Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 11577,
    "url": "http://patchwork.dpdk.org/api/1.0/patches/11577/?format=api",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<1458255427-12371-2-git-send-email-johndale@cisco.com>",
    "date": "2016-03-17T22:57:05",
    "name": "[dpdk-dev,1/3] enic: mbuf->ol_flags could be set incorrectly",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "1f61d81aaa1a4e6bf44c7efbaa6573f60cae340d",
    "submitter": {
        "id": 359,
        "url": "http://patchwork.dpdk.org/api/1.0/people/359/?format=api",
        "name": "John Daley (johndale)",
        "email": "johndale@cisco.com"
    },
    "delegate": {
        "id": 10,
        "url": "http://patchwork.dpdk.org/api/1.0/users/10/?format=api",
        "username": "bruce",
        "first_name": "Bruce",
        "last_name": "Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1458255427-12371-2-git-send-email-johndale@cisco.com/mbox/",
    "series": [],
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/11577/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 26ACD58CF;\n\tThu, 17 Mar 2016 23:57:19 +0100 (CET)",
            "from rcdn-iport-4.cisco.com (rcdn-iport-4.cisco.com [173.37.86.75])\n\tby dpdk.org (Postfix) with ESMTP id 502A35323\n\tfor <dev@dpdk.org>; Thu, 17 Mar 2016 23:57:16 +0100 (CET)",
            "from alln-core-5.cisco.com ([173.36.13.138])\n\tby rcdn-iport-4.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t17 Mar 2016 22:57:15 +0000",
            "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-5.cisco.com (8.14.5/8.14.5) with ESMTP id u2HMvFZo006548;\n\tThu, 17 Mar 2016 22:57:15 GMT",
            "by cisco.com (Postfix, from userid 392789)\n\tid 3C2293FAAD5C; Thu, 17 Mar 2016 15:57:15 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=1302; q=dns/txt; s=iport;\n\tt=1458255436; x=1459465036;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=l+ScfhXSI/O8WzkuEMnj6NCVbSfFrv548s11DBuo4J8=;\n\tb=A1Y8VKrR+guizR7VOa3sSexpGahuZZvReERe4nLDuOMcg/Ub8FhNHdUZ\n\tsujve7Rp7Iipz1HIS2PkfqiOb2HypIagarAnPykW2cqlm3s8t174U0edM\n\tVrrZ0HmdSqfyhE4BJRmcfgZTyyd2hMOGXNuCsvDXvLRpWBpNQ7koZh4fD k=;",
        "X-IronPort-AV": "E=Sophos;i=\"5.24,351,1454976000\"; d=\"scan'208\";a=\"83997614\"",
        "From": "John Daley <johndale@cisco.com>",
        "To": "dev@dpdk.org",
        "Cc": "John Daley <johndale@cisco.com>",
        "Date": "Thu, 17 Mar 2016 15:57:05 -0700",
        "Message-Id": "<1458255427-12371-2-git-send-email-johndale@cisco.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "In-Reply-To": "<1458255427-12371-1-git-send-email-johndale@cisco.com>",
        "References": "<1458255427-12371-1-git-send-email-johndale@cisco.com>",
        "Subject": "[dpdk-dev] [PATCH 1/3] enic: mbuf->ol_flags could be set incorrectly",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "In the receive path, the function to set mbuf ol_flags used the\nmbuf packet_type before it was set.\n\nFixes: 947d860c821f (\"enic: improve Rx performance\")\n\nSigned-off-by: John Daley <johndale@cisco.com>\n---\n drivers/net/enic/enic_rx.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/net/enic/enic_rx.c b/drivers/net/enic/enic_rx.c\nindex 945a60f..59ebaa4 100644\n--- a/drivers/net/enic/enic_rx.c\n+++ b/drivers/net/enic/enic_rx.c\n@@ -210,7 +210,7 @@ enic_cq_rx_to_pkt_flags(struct cq_desc *cqd, struct rte_mbuf *mbuf)\n \tciflags = enic_cq_rx_desc_ciflags(cqrd);\n \tbwflags = enic_cq_rx_desc_bwflags(cqrd);\n \n-\tASSERT(mbuf->ol_flags == 0);\n+\tmbuf->ol_flags = 0;\n \n \t/* flags are meaningless if !EOP */\n \tif (unlikely(!enic_cq_rx_desc_eop(ciflags)))\n@@ -340,10 +340,10 @@ enic_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts,\n \t\trxmb->pkt_len = rx_pkt_len;\n \t\trxmb->data_len = rx_pkt_len;\n \t\trxmb->port = enic->port_id;\n+\t\trxmb->packet_type = enic_cq_rx_flags_to_pkt_type(&cqd);\n \t\trxmb->ol_flags = ol_err_flags;\n \t\tif (!ol_err_flags)\n \t\t\tenic_cq_rx_to_pkt_flags(&cqd, rxmb);\n-\t\trxmb->packet_type = enic_cq_rx_flags_to_pkt_type(&cqd);\n \n \t\t/* prefetch mbuf data for caller */\n \t\trte_packet_prefetch(RTE_PTR_ADD(rxmb->buf_addr,\n",
    "prefixes": [
        "dpdk-dev",
        "1/3"
    ]
}