Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/140106/?format=api
{ "id": 140106, "url": "http://patchwork.dpdk.org/api/1.0/patches/140106/?format=api", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk" }, "msgid": "<1715704559-15839-34-git-send-email-roretzla@linux.microsoft.com>", "date": "2024-05-14T16:35:47", "name": "[v6,33/45] net/null: use rte stdatomic API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "07f2999e4b7dad1aabe57e9eb9b6e63c664235eb", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/1.0/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/1.0/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1715704559-15839-34-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 31927, "url": "http://patchwork.dpdk.org/api/1.0/series/31927/?format=api", "date": "2024-05-14T16:35:14", "name": "use stdatomic API", "version": 6, "mbox": "http://patchwork.dpdk.org/series/31927/mbox/" } ], "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/140106/checks/", "tags": {}, "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DE8A444024;\n\tTue, 14 May 2024 18:39:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 948AF427E5;\n\tTue, 14 May 2024 18:36:48 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id CF1C840685\n for <dev@dpdk.org>; Tue, 14 May 2024 18:36:08 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id 56A6F20B2CAD; Tue, 14 May 2024 09:36:00 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com 56A6F20B2CAD", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1715704562;\n bh=yNPjl519j/hJk+X5Ac1gav4MladHrulwcxSneiQAwAo=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=OZiyrqm61zXqzboV+cixR68DCQCnFFxXQpSBQrVc4jEU+o3y2QwYTzNHkyPyZjQBz\n wLGvJEB9pFJa4cKEVGc7mhODixperMSOYQ4t8h4IASptT6khBsphuxkhXXfcWebqha\n mADmiAJYL8dy4EiDhMCk2LRIJ1pDCUr891K7WpiU=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n\t=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Abdullah Sevincer <abdullah.sevincer@intel.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>, Alok Prasad <palok@marvell.com>,\n Anatoly Burakov <anatoly.burakov@intel.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,\n Anoob Joseph <anoobj@marvell.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Byron Marohn <byron.marohn@intel.com>, Chenbo Xia <chenbox@nvidia.com>,\n Chengwen Feng <fengchengwen@huawei.com>,\n Ciara Loftus <ciara.loftus@intel.com>, Ciara Power <ciara.power@intel.com>,\n Dariusz Sosnowski <dsosnowski@nvidia.com>, David Hunt <david.hunt@intel.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Guoyang Zhou <zhouguoyang@huawei.com>, Harman Kalra <hkalra@marvell.com>,\n Harry van Haaren <harry.van.haaren@intel.com>,\n Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,\n Jakub Grajciar <jgrajcia@cisco.com>, Jerin Jacob <jerinj@marvell.com>,\n Jeroen de Borst <jeroendb@google.com>, Jian Wang <jianwang@trustnetic.com>,\n Jiawen Wu <jiawenwu@trustnetic.com>, Jie Hai <haijie1@huawei.com>,\n Jingjing Wu <jingjing.wu@intel.com>, Joshua Washington <joshwash@google.com>,\n Joyce Kong <joyce.kong@arm.com>, Junfeng Guo <junfeng.guo@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Liang Ma <liangma@liangbit.com>, Long Li <longli@microsoft.com>,\n Maciej Czekaj <mczekaj@marvell.com>, Matan Azrad <matan@nvidia.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Nicolas Chautru <nicolas.chautru@intel.com>, Ori Kam <orika@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Peter Mccarthy <peter.mccarthy@intel.com>,\n Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,\n Reshma Pattan <reshma.pattan@intel.com>, Rosen Xu <rosen.xu@intel.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Rushil Gupta <rushilg@google.com>,\n Sameh Gobriel <sameh.gobriel@intel.com>,\n Sivaprasad Tummala <sivaprasad.tummala@amd.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n Stephen Hemminger <stephen@networkplumber.org>,\n Suanming Mou <suanmingm@nvidia.com>, Sunil Kumar Kori <skori@marvell.com>,\n Sunil Uttarwar <sunilprakashrao.uttarwar@amd.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Vamsi Attunuru <vattunuru@marvell.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,\n Yipeng Wang <yipeng1.wang@intel.com>, Yisen Zhuang <yisen.zhuang@huawei.com>,\n Ziyang Xuan <xuanziyang2@huawei.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v6 33/45] net/null: use rte stdatomic API", "Date": "Tue, 14 May 2024 09:35:47 -0700", "Message-Id": "<1715704559-15839-34-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1715704559-15839-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com>\n <1715704559-15839-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of gcc builtin __atomic_xxx intrinsics with\ncorresponding rte_atomic_xxx optional rte stdatomic API.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/null/rte_eth_null.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 7c46004..f4ed3b8 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -37,8 +37,8 @@ struct null_queue {\n \tstruct rte_mempool *mb_pool;\n \tstruct rte_mbuf *dummy_packet;\n \n-\tuint64_t rx_pkts;\n-\tuint64_t tx_pkts;\n+\tRTE_ATOMIC(uint64_t) rx_pkts;\n+\tRTE_ATOMIC(uint64_t) tx_pkts;\n };\n \n struct pmd_options {\n@@ -102,7 +102,7 @@ struct pmd_internals {\n \t}\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n+\trte_atomic_fetch_add_explicit(&h->rx_pkts, i, rte_memory_order_seq_cst);\n \n \treturn i;\n }\n@@ -130,7 +130,7 @@ struct pmd_internals {\n \t}\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n+\trte_atomic_fetch_add_explicit(&h->rx_pkts, i, rte_memory_order_seq_cst);\n \n \treturn i;\n }\n@@ -155,7 +155,7 @@ struct pmd_internals {\n \t\trte_pktmbuf_free(bufs[i]);\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n+\trte_atomic_fetch_add_explicit(&h->tx_pkts, i, rte_memory_order_seq_cst);\n \n \treturn i;\n }\n@@ -178,7 +178,7 @@ struct pmd_internals {\n \t}\n \n \t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n+\trte_atomic_fetch_add_explicit(&h->tx_pkts, i, rte_memory_order_seq_cst);\n \n \treturn i;\n }\n", "prefixes": [ "v6", "33/45" ] }