Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 140148,
    "url": "http://patchwork.dpdk.org/api/1.0/patches/140148/?format=api",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<20240516154327.64104-10-stephen@networkplumber.org>",
    "date": "2024-05-16T15:40:45",
    "name": "[v5,9/9] net/null: use generic SW stats",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "b33a1bb0f88ad49439abe2aabf07058a1659e5b6",
    "submitter": {
        "id": 27,
        "url": "http://patchwork.dpdk.org/api/1.0/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/1.0/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240516154327.64104-10-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 31939,
            "url": "http://patchwork.dpdk.org/api/1.0/series/31939/?format=api",
            "date": "2024-05-16T15:40:36",
            "name": "Generic 64 bit counters",
            "version": 5,
            "mbox": "http://patchwork.dpdk.org/series/31939/mbox/"
        }
    ],
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/140148/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08B4543F81;\n\tThu, 16 May 2024 17:44:54 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E9E4406FF;\n\tThu, 16 May 2024 17:43:53 +0200 (CEST)",
            "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 93609406B6\n for <dev@dpdk.org>; Thu, 16 May 2024 17:43:47 +0200 (CEST)",
            "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6f44b296e02so252058b3a.2\n for <dev@dpdk.org>; Thu, 16 May 2024 08:43:47 -0700 (PDT)",
            "from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])\n by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-6f67b526b44sm2457430b3a.149.2024.05.16.08.43.46\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 16 May 2024 08:43:46 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715874227;\n x=1716479027; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=F1v3feu5BR4POSxHAthIeXNE69YI+TXuZU380J4Tk78=;\n b=laMx8Ra3Munq5cXhQgBM2kecFIT33VyIMXpxZ2q0PdlpK+liWS1M5PvEDlUGHRGWZz\n RrOoBVNK6ZnchgjTZRphUXfG7Vtk4vjg5VJqOs8/2I3dRieblRg3A//yNuMeIr1Co3I1\n KaNTQfnOwu3lwaVjTrLEAuYAAQLztiGisO9tTufUFd+LKhQyUEBsqcL84TBua6GwNR8I\n lbByvsWEwEDdIKwR4gtij3YvmGEY1BDH5TgKn1aJOKEk6IsoRrswhN67qvUAkEHxayTs\n 7s3W6zSx1vqqw1p0BB/pUiM7I8JFQQ1MknD0GALMK80fcB77FzXAG7VEp5ugclvkxv0M\n TDpg==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715874227; x=1716479027;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=F1v3feu5BR4POSxHAthIeXNE69YI+TXuZU380J4Tk78=;\n b=c/RQs8qmwdAyNSc8nhO045MoF7lbZKKMBZgu5OaByiP/4u7VlL0rK1RS7XRwjwEX1E\n Sgeqt0UESUVdPzxatSvuYMaxk7lO/D9OfhXx8HXhMkefhZRymZ0hob27EUF7tc8XBQuc\n 7/17m+Su64Tpiki2SVorSdMVJH6Yp5AGwHceVcMxyQHf100ZgXLMSOqj/5No6MdlZWrY\n hm+y3cCuN8mmuH9sKhMvJpeR6Pf9vAobR5ED65f865rnV5eZMdSSKHCjvHifYK/y/88o\n U/rveKbFp9DQkT1tuvUaR0GAMGOhUMDBR7b32X47Z7t3inblIzLiCrpKoT5uFqUGhPTK\n EEbw==",
        "X-Gm-Message-State": "AOJu0YxVuxMbs9G5rFSnHiUXBsbHNbqh4MzYqbUkWIPwWa4/U529J7yX\n DPlxeroxgRbuA1mnAU4/6Brn7HOc04H/zUzmBWPF0Eole9wKDoCfcmfIYPE6xDrJ7BOnpfqdfBZ\n 8pmU=",
        "X-Google-Smtp-Source": "\n AGHT+IGhOXOxpQbvd1yu50mnb6sqwgWVA0EpWZOnDW6G1anR1XqSvXNjvCXWndEyOde+a1IV2kyy0g==",
        "X-Received": "by 2002:a05:6a00:845:b0:6f4:4723:98b3 with SMTP id\n d2e1a72fcca58-6f4e02ada39mr21461285b3a.13.1715874226830;\n Thu, 16 May 2024 08:43:46 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>",
        "Subject": "[PATCH v5 9/9] net/null: use generic SW stats",
        "Date": "Thu, 16 May 2024 08:40:45 -0700",
        "Message-ID": "<20240516154327.64104-10-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.43.0",
        "In-Reply-To": "<20240516154327.64104-1-stephen@networkplumber.org>",
        "References": "<20240510050507.14381-1-stephen@networkplumber.org>\n <20240516154327.64104-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Use the new common code for statistics.\nThis also fixes the bug that this driver was not accounting\nfor bytes.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/null/rte_eth_null.c | 80 +++++++--------------------------\n 1 file changed, 17 insertions(+), 63 deletions(-)",
    "diff": "diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c\nindex 7c46004f1e..7786982732 100644\n--- a/drivers/net/null/rte_eth_null.c\n+++ b/drivers/net/null/rte_eth_null.c\n@@ -8,6 +8,7 @@\n #include <rte_mbuf.h>\n #include <ethdev_driver.h>\n #include <ethdev_vdev.h>\n+#include <ethdev_swstats.h>\n #include <rte_malloc.h>\n #include <rte_memcpy.h>\n #include <bus_vdev_driver.h>\n@@ -37,8 +38,8 @@ struct null_queue {\n \tstruct rte_mempool *mb_pool;\n \tstruct rte_mbuf *dummy_packet;\n \n-\tuint64_t rx_pkts;\n-\tuint64_t tx_pkts;\n+\tstruct rte_eth_counters tx_stats;\n+\tstruct rte_eth_counters rx_stats;\n };\n \n struct pmd_options {\n@@ -99,11 +100,9 @@ eth_null_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -127,11 +126,9 @@ eth_null_copy_rx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \t\tbufs[i]->data_len = (uint16_t)packet_size;\n \t\tbufs[i]->pkt_len = packet_size;\n \t\tbufs[i]->port = h->internals->port_id;\n+\t\trte_eth_count_mbuf(&h->rx_stats, bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->rx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -151,11 +148,10 @@ eth_null_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tif ((q == NULL) || (bufs == NULL))\n \t\treturn 0;\n \n-\tfor (i = 0; i < nb_bufs; i++)\n+\tfor (i = 0; i < nb_bufs; i++) {\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n-\n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n+\t}\n \n \treturn i;\n }\n@@ -174,12 +170,10 @@ eth_null_copy_tx(void *q, struct rte_mbuf **bufs, uint16_t nb_bufs)\n \tfor (i = 0; i < nb_bufs; i++) {\n \t\trte_memcpy(h->dummy_packet, rte_pktmbuf_mtod(bufs[i], void *),\n \t\t\t\t\tpacket_size);\n+\t\trte_eth_count_mbuf(&h->tx_stats, bufs[i]);\n \t\trte_pktmbuf_free(bufs[i]);\n \t}\n \n-\t/* NOTE: review for potential ordering optimization */\n-\t__atomic_fetch_add(&h->tx_pkts, i, __ATOMIC_SEQ_CST);\n-\n \treturn i;\n }\n \n@@ -322,60 +316,20 @@ eth_dev_info(struct rte_eth_dev *dev,\n }\n \n static int\n-eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)\n+eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned int i, num_stats;\n-\tunsigned long rx_total = 0, tx_total = 0;\n-\tconst struct pmd_internals *internal;\n-\n-\tif ((dev == NULL) || (igb_stats == NULL))\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_rx_queues,\n-\t\t\t\tRTE_DIM(internal->rx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_ipackets[i] =\n-\t\t\tinternal->rx_null_queues[i].rx_pkts;\n-\t\trx_total += igb_stats->q_ipackets[i];\n-\t}\n-\n-\tnum_stats = RTE_MIN((unsigned int)RTE_ETHDEV_QUEUE_STAT_CNTRS,\n-\t\t\tRTE_MIN(dev->data->nb_tx_queues,\n-\t\t\t\tRTE_DIM(internal->tx_null_queues)));\n-\tfor (i = 0; i < num_stats; i++) {\n-\t\t/* NOTE: review for atomic access */\n-\t\tigb_stats->q_opackets[i] =\n-\t\t\tinternal->tx_null_queues[i].tx_pkts;\n-\t\ttx_total += igb_stats->q_opackets[i];\n-\t}\n-\n-\tigb_stats->ipackets = rx_total;\n-\tigb_stats->opackets = tx_total;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_stats_get(dev,\n+\t\t\t\t\t  offsetof(struct null_queue, tx_stats),\n+\t\t\t\t\t  offsetof(struct null_queue, rx_stats),\n+\t\t\t\t\t  stats);\n }\n \n static int\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned int i;\n-\tstruct pmd_internals *internal;\n-\n-\tif (dev == NULL)\n-\t\treturn -EINVAL;\n-\n-\tinternal = dev->data->dev_private;\n-\tfor (i = 0; i < RTE_DIM(internal->rx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->rx_null_queues[i].rx_pkts = 0;\n-\tfor (i = 0; i < RTE_DIM(internal->tx_null_queues); i++)\n-\t\t/* NOTE: review for atomic access */\n-\t\tinternal->tx_null_queues[i].tx_pkts = 0;\n-\n-\treturn 0;\n+\treturn rte_eth_counters_reset(dev,\n+\t\t\t\t      offsetof(struct null_queue, tx_stats),\n+\t\t\t\t      offsetof(struct null_queue, rx_stats));\n }\n \n static void\n",
    "prefixes": [
        "v5",
        "9/9"
    ]
}