Cover Detail
Show a cover letter.
GET /api/covers/121945/?format=api
{ "id": 121945, "url": "http://patchwork.dpdk.org/api/covers/121945/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20230112174116.2105237-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230112174116.2105237-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230112174116.2105237-1-bruce.richardson@intel.com", "date": "2023-01-12T17:41:07", "name": "[v3,0/9] Standardize telemetry int types", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20230112174116.2105237-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26512, "url": "http://patchwork.dpdk.org/api/series/26512/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26512", "date": "2023-01-12T17:41:07", "name": "Standardize telemetry int types", "version": 3, "mbox": "http://patchwork.dpdk.org/series/26512/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/121945/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B26FB423B9;\n\tThu, 12 Jan 2023 18:41:55 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5372442D55;\n\tThu, 12 Jan 2023 18:41:55 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 5BD9342D4F\n for <dev@dpdk.org>; Thu, 12 Jan 2023 18:41:53 +0100 (CET)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2023 09:41:51 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.166])\n by fmsmga005.fm.intel.com with ESMTP; 12 Jan 2023 09:41:50 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673545313; x=1705081313;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=1EKJ65NiaNlKg1fBIUvZ8y94rtKRaR2PMOJKhm2FWJk=;\n b=QvC7H3+c4mz2NT16Y+V9E6wDYa3kghMg7C3VXbShPSTCXcK/oqBV+kS1\n k6w15HNTyw+mk4R567nlb6dFJebJMF81kTLgBz01qI+caH0hmEWFnYxpl\n m2BE2WceP5PSl9yh5+/S08FC+iKkTxnJNt3TBHuH9CmN7zHvwEnmBjdV/\n AV1PN7gYVBrf9pEzj9FE7p8gocmYHEMoCe0DQvSWDf7pn0H+6iyyVvZWC\n HvUIdFTIWbIQFYi+EmGyNVt3h0YcNsUWQDWHk/xSYcbv0plHbdUjJHjoH\n kISKGkIChdZkffZJFTe6n3NPBm8L91+UnA4/4smtvVQXbkxoeePn5rb0w w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10588\"; a=\"388264769\"", "E=Sophos;i=\"5.97,211,1669104000\"; d=\"scan'208\";a=\"388264769\"", "E=McAfee;i=\"6500,9779,10588\"; a=\"986677991\"", "E=Sophos;i=\"5.97,211,1669104000\"; d=\"scan'208\";a=\"986677991\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 0/9] Standardize telemetry int types", "Date": "Thu, 12 Jan 2023 17:41:07 +0000", "Message-Id": "<20230112174116.2105237-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20221213182730.97065-1-bruce.richardson@intel.com>", "References": "<20221213182730.97065-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rather than having 64-bit unsigned types and 32-bit signed types\nsupported by the telemetry lib, we should support 64-bit values\nfor both types. On the naming side, since both are 64-bit, we\nshould no longer call the unsigned value u64 - \"uint\" is better.\n\nThis patchset implements these changes as far as is possible while\nstill keeping API and ABI compatibility.\n\n* Internal structures and functions are updated to use 64-bit ints\n* Internal functions are renamed from u64 to uint\n* Public enum values are renamed from u64 to uint, and a macro is\n added to ensure that older code still compiles\n* The public add_*_int functions are changed to take a 64-bit value\n rather than a 32-bit one. Since this would be an ABI break, we\n use function versioning to ensure older code still calls into\n a wrapper function which takes a 32-bit value.\n\nThe patchset also contains a couple of other small cleanups to the\ntelemetry code that were seen in passing when making these changes -\nremoving RTE_ prefix on internal enums, and simplifying the init of the\nthe array of data types.\n\nNOTE: the renaming of the u64 functions to uint is split across 3\npatches in this set - patches 4,5 and 6. This is to make it easier to\nreview and to avoid warnings about new functions not being marked\ninitially as experimental. Some/all of these 3 can be combined on merge\nif so desired.\n\nV3:\n- fix build issues due to missing a driver code change\n- fix spelling issue flagged by checkpatch\n\nV2:\n- added additional patches to replace the old function calls within DPDK\n code, something missed in RFC version\n- added new patch to make the renamed/new functions immediately public\n allowing us to mark the original named versions as deprecated\n- re-ordered patches within the sit, so the extra cleanup changes come\n first\n\nBruce Richardson (9):\n telemetry: remove RTE prefix from internal enum values\n telemetry: make array initialization more robust\n telemetry: rename unsigned 64-bit enum value to uint\n telemetry: add uint type as alias for u64\n global: rename telemetry functions to newer versions\n telemetry: mark old names of renamed fns as deprecated\n telemetry: update json functions to use int/uint in names\n telemetry: make internal int representation 64-bits\n telemetry: change public API to use 64-bit signed values\n\n app/test/test_telemetry_data.c | 22 ++---\n app/test/test_telemetry_json.c | 9 +-\n doc/guides/rel_notes/deprecation.rst | 5 ++\n drivers/common/cnxk/roc_platform.h | 4 +-\n drivers/net/cnxk/cnxk_ethdev_sec_telemetry.c | 24 ++---\n drivers/net/cnxk/cnxk_ethdev_telemetry.c | 6 +-\n examples/ipsec-secgw/ipsec-secgw.c | 72 +++++++--------\n examples/l3fwd-power/main.c | 4 +-\n lib/cryptodev/rte_cryptodev.c | 6 +-\n lib/dmadev/rte_dmadev.c | 2 +-\n lib/eal/common/eal_common_memory.c | 19 ++--\n lib/ethdev/rte_ethdev.c | 12 +--\n lib/ethdev/sff_telemetry.c | 2 +-\n lib/eventdev/rte_event_eth_rx_adapter.c | 22 ++---\n lib/eventdev/rte_event_timer_adapter.c | 38 ++++----\n lib/eventdev/rte_eventdev.c | 5 +-\n lib/ipsec/ipsec_telemetry.c | 33 +++----\n lib/rawdev/rte_rawdev.c | 4 +-\n lib/security/rte_security.c | 8 +-\n lib/telemetry/meson.build | 1 +\n lib/telemetry/rte_telemetry.h | 51 +++++++++--\n lib/telemetry/telemetry.c | 56 ++++++------\n lib/telemetry/telemetry_data.c | 95 ++++++++++++++------\n lib/telemetry/telemetry_data.h | 24 +++--\n lib/telemetry/telemetry_json.h | 16 ++--\n lib/telemetry/version.map | 9 ++\n 26 files changed, 325 insertions(+), 224 deletions(-)\n\n--\n2.37.2" }