Cover Detail
Show a cover letter.
GET /api/covers/122048/?format=api
{ "id": 122048, "url": "http://patchwork.dpdk.org/api/covers/122048/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20230113203656.1864072-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230113203656.1864072-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230113203656.1864072-1-bruce.richardson@intel.com", "date": "2023-01-13T20:36:53", "name": "[v3,0/3] Split logging functionality out of EAL", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20230113203656.1864072-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26543, "url": "http://patchwork.dpdk.org/api/series/26543/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26543", "date": "2023-01-13T20:36:53", "name": "Split logging functionality out of EAL", "version": 3, "mbox": "http://patchwork.dpdk.org/series/26543/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/122048/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1E221423C7;\n\tFri, 13 Jan 2023 21:37:05 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0836B40E0F;\n\tFri, 13 Jan 2023 21:37:05 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 0482C40042\n for <dev@dpdk.org>; Fri, 13 Jan 2023 21:37:03 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 13 Jan 2023 12:37:03 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.166])\n by orsmga002.jf.intel.com with ESMTP; 13 Jan 2023 12:37:01 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1673642224; x=1705178224;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=opwXz4Z2Arvxb3UUJkF8hTnKHouQTxg/kl5npQx10FQ=;\n b=NjwKuAjqsIbDbztY6ZJIjXx22dDu6Z43MQ2bSzQuE8e1+aZvWlXGEmzf\n TecSstGHkHyZgH2ZGBcZE02ggkyVtLfiRF5QqZH2ch8w3X2Ja82p5oo5J\n dWvK4NY3o/FGDjxpHwz4NP2TM4gI3Db8Y5ldiiWRx7KWeULmTPuIIlNYB\n xsOJa0cp3cRU1mAEp9LKUMlAakszT9uEElOqckeB5dglPRkEPkdoWhZiY\n gdCSghcp4W+3PygAetpgPaoWwwDEJIp9sJoZzNSQ5OaNLqHOp2jh/x+fj\n woJ9RejdlxtmTzb7hOdHzEFebRuuZ/a6JMkpFrccQo8UZQsXSCqc1yn56 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10589\"; a=\"388592340\"", "E=Sophos;i=\"5.97,214,1669104000\"; d=\"scan'208\";a=\"388592340\"", "E=McAfee;i=\"6500,9779,10589\"; a=\"658334355\"", "E=Sophos;i=\"5.97,214,1669104000\"; d=\"scan'208\";a=\"658334355\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3 0/3] Split logging functionality out of EAL", "Date": "Fri, 13 Jan 2023 20:36:53 +0000", "Message-Id": "<20230113203656.1864072-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20220829151901.376754-1-bruce.richardson@intel.com>", "References": "<20220829151901.376754-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is a general desire to reduce the size and scope of EAL. To this\nend, this patchset makes a (very) small step in that direction by taking\nthe logging functionality out of EAL and putting it into its own library\nthat can be built and maintained separately.\n\nAs with the v1 RFC for this, the main obstacle is the \"fnmatch\" function\nwhich is needed by both EAL and the new log function when building on\nwindows. While the function cannot stay in EAL - or we would have a\ncircular dependency, moving it to a new library or just putting it in\nthe log library have the disadvantages that it then \"leaks\" into the\npublic namespace without an rte_prefix, which could cause issues. Since\nonly a single function is involved, this v2 RFC takes a different\napproach to v1, and just moves the offending function to be a static\nfunction in a header file. This allows use by multiple libs without\nconflicting names or making it public.\n\nThe other complication, as explained in v1 RFC was that of multiple\nimplementations for different OS's. This is solved here in the same\nway as v1, by including the OS in the name and having meson pick the\ncorrect file for each build. Since only one file is involved, there\nseemed little need for replicating EAL's separate subdirectories\nper-OS.\n\nNOTE: documentation updates are still missing in v3, will come in v4.\nSubmitting v3 to allow CI testing and check that v2 broken builds are\nnow working\n\nv3:\n* Fixed missing log file for BSD\n* Removed \"eal\" from the filenames of files in the log directory\n* added prefixes to elements in the fnmatch header to avoid conflicts\n* fixed space indentation in new lines in telemetry.c (checkpatch)\n* removed \"extern int logtype\" definition in telemetry.c (checkpatch)\n* added log directory to list for doxygen scanning\n\nBruce Richardson (3):\n eal/windows: move fnmatch function to header file\n log: separate logging functions out of EAL\n telemetry: use standard logging\n\n doc/api/doxy-api.conf.in | 1 +\n lib/eal/common/eal_common_options.c | 2 +-\n lib/eal/common/eal_private.h | 7 -\n lib/eal/common/meson.build | 1 -\n lib/eal/freebsd/eal.c | 6 +-\n lib/eal/include/meson.build | 1 -\n lib/eal/linux/eal.c | 8 +-\n lib/eal/linux/meson.build | 1 -\n lib/eal/meson.build | 2 +-\n lib/eal/version.map | 17 --\n lib/eal/windows/eal.c | 2 +-\n lib/eal/windows/fnmatch.c | 172 -----------------\n lib/eal/windows/include/fnmatch.h | 175 ++++++++++++++++--\n lib/eal/windows/meson.build | 2 -\n lib/kvargs/meson.build | 3 +-\n .../common/eal_common_log.c => log/log.c} | 3 +-\n lib/log/log_freebsd.c | 12 ++\n .../common/eal_log.h => log/log_internal.h} | 18 +-\n lib/{eal/linux/eal_log.c => log/log_linux.c} | 2 +-\n .../windows/eal_log.c => log/log_windows.c} | 2 +-\n lib/log/meson.build | 9 +\n lib/{eal/include => log}/rte_log.h | 0\n lib/log/version.map | 34 ++++\n lib/meson.build | 1 +\n lib/telemetry/meson.build | 3 +-\n lib/telemetry/telemetry.c | 11 +-\n lib/telemetry/telemetry_internal.h | 3 +-\n 27 files changed, 249 insertions(+), 249 deletions(-)\n delete mode 100644 lib/eal/windows/fnmatch.c\n rename lib/{eal/common/eal_common_log.c => log/log.c} (99%)\n create mode 100644 lib/log/log_freebsd.c\n rename lib/{eal/common/eal_log.h => log/log_internal.h} (69%)\n rename lib/{eal/linux/eal_log.c => log/log_linux.c} (97%)\n rename lib/{eal/windows/eal_log.c => log/log_windows.c} (93%)\n create mode 100644 lib/log/meson.build\n rename lib/{eal/include => log}/rte_log.h (100%)\n create mode 100644 lib/log/version.map\n\n--\n2.37.2" }