Cover Detail
Show a cover letter.
GET /api/covers/122428/?format=api
{ "id": 122428, "url": "http://patchwork.dpdk.org/api/covers/122428/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20230120182154.481039-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230120182154.481039-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230120182154.481039-1-bruce.richardson@intel.com", "date": "2023-01-20T18:21:51", "name": "[v4,0/3] Split logging functionality out of EAL", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20230120182154.481039-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 26625, "url": "http://patchwork.dpdk.org/api/series/26625/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=26625", "date": "2023-01-20T18:21:51", "name": "Split logging functionality out of EAL", "version": 4, "mbox": "http://patchwork.dpdk.org/series/26625/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/122428/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8FBC42439;\n\tFri, 20 Jan 2023 19:22:16 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 862C242D14;\n\tFri, 20 Jan 2023 19:22:16 +0100 (CET)", "from mga06.intel.com (mga06b.intel.com [134.134.136.31])\n by mails.dpdk.org (Postfix) with ESMTP id 2EC8A4067E\n for <dev@dpdk.org>; Fri, 20 Jan 2023 19:22:14 +0100 (CET)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 20 Jan 2023 10:22:04 -0800", "from silpixa00401385.ir.intel.com ([10.237.214.55])\n by orsmga008.jf.intel.com with ESMTP; 20 Jan 2023 10:22:03 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1674238935; x=1705774935;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=X1JUB5/HJPshrjPh94H4qKiYVd18+5dn590aVNt771I=;\n b=c/i/hcyM5Zbc2MeCSaGDXlR1MW4QL2ee8HbV24UElln5Oj1eIVuj5c8G\n Rb5/hEi+s0GMNXARYoKA/oeIomSZN5dHKCxTLjlZyz2p8urqSzF04GgTY\n VT07qy8xNeUA6U0lRn3Ue3hdn7CcefX7eK6YLTe3dHYzoDb7GAl6T1viN\n Jy2e13cyTv4fre70PwLFnllRinXLjGEjM7wEyrTpLzIlMT8z5aOSx/DGl\n cXvTzjCgzPQ2/fpqVLfaKEp3g1Qj6RBYp1TMVThugJyyCnTOAzpTkDI75\n YPyfD1A/aEkZad0cW0v0VhZKP3rEqJGlvOf04ghCK0pSBBP/Q8VGClP/I w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10596\"; a=\"388012436\"", "E=Sophos;i=\"5.97,233,1669104000\"; d=\"scan'208\";a=\"388012436\"", "E=McAfee;i=\"6500,9779,10596\"; a=\"691143400\"", "E=Sophos;i=\"5.97,233,1669104000\"; d=\"scan'208\";a=\"691143400\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v4 0/3] Split logging functionality out of EAL", "Date": "Fri, 20 Jan 2023 18:21:51 +0000", "Message-Id": "<20230120182154.481039-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.37.2", "In-Reply-To": "<20220829151901.376754-1-bruce.richardson@intel.com>", "References": "<20220829151901.376754-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There is a general desire to reduce the size and scope of EAL. To this\nend, this patchset makes a (very) small step in that direction by taking\nthe logging functionality out of EAL and putting it into its own library\nthat can be built and maintained separately.\n\nAs with the first RFC for this, the main obstacle is the \"fnmatch\"\nfunction which is needed by both EAL and the new log function when\nbuilding on windows. While the function cannot stay in EAL - or we would\nhave a circular dependency, moving it to a new library or just putting\nit in the log library have the disadvantages that it then \"leaks\" into\nthe public namespace without an rte_prefix, which could cause issues.\nSince only a single function is involved, subsequent versions take a\ndifferent approach to v1, and just moves the offending function to be a\nstatic function in a header file. This allows use by multiple libs\nwithout conflicting names or making it public.\n\nThe other complication, as explained in v1 RFC was that of multiple\nimplementations for different OS's. This is solved here in the same\nway as v1, by including the OS in the name and having meson pick the\ncorrect file for each build. Since only one file is involved, there\nseemed little need for replicating EAL's separate subdirectories\nper-OS.\n\nv4:\n* Fixed windows build error, due to missing strdup (_strdup on windows)\n* Added doc updates to programmers guide.\n\nv3:\n* Fixed missing log file for BSD\n* Removed \"eal\" from the filenames of files in the log directory\n* added prefixes to elements in the fnmatch header to avoid conflicts\n* fixed space indentation in new lines in telemetry.c (checkpatch)\n* removed \"extern int logtype\" definition in telemetry.c (checkpatch)\n* added log directory to list for doxygen scanning\n\nBruce Richardson (3):\n eal/windows: move fnmatch function to header file\n log: separate logging functions out of EAL\n telemetry: use standard logging\n\n doc/api/doxy-api.conf.in | 1 +\n .../prog_guide/env_abstraction_layer.rst | 4 +-\n doc/guides/prog_guide/index.rst | 1 +\n doc/guides/prog_guide/log_lib.rst | 115 ++++++++++++\n lib/eal/common/eal_common_options.c | 2 +-\n lib/eal/common/eal_private.h | 7 -\n lib/eal/common/meson.build | 1 -\n lib/eal/freebsd/eal.c | 6 +-\n lib/eal/include/meson.build | 1 -\n lib/eal/linux/eal.c | 8 +-\n lib/eal/linux/meson.build | 1 -\n lib/eal/meson.build | 2 +-\n lib/eal/version.map | 17 --\n lib/eal/windows/eal.c | 2 +-\n lib/eal/windows/fnmatch.c | 172 -----------------\n lib/eal/windows/include/fnmatch.h | 175 ++++++++++++++++--\n lib/eal/windows/meson.build | 2 -\n lib/kvargs/meson.build | 3 +-\n .../common/eal_common_log.c => log/log.c} | 7 +-\n lib/log/log_freebsd.c | 12 ++\n .../common/eal_log.h => log/log_internal.h} | 18 +-\n lib/{eal/linux/eal_log.c => log/log_linux.c} | 2 +-\n .../windows/eal_log.c => log/log_windows.c} | 2 +-\n lib/log/meson.build | 9 +\n lib/{eal/include => log}/rte_log.h | 0\n lib/log/version.map | 34 ++++\n lib/meson.build | 1 +\n lib/telemetry/meson.build | 3 +-\n lib/telemetry/telemetry.c | 11 +-\n lib/telemetry/telemetry_internal.h | 3 +-\n 30 files changed, 370 insertions(+), 252 deletions(-)\n create mode 100644 doc/guides/prog_guide/log_lib.rst\n delete mode 100644 lib/eal/windows/fnmatch.c\n rename lib/{eal/common/eal_common_log.c => log/log.c} (99%)\n create mode 100644 lib/log/log_freebsd.c\n rename lib/{eal/common/eal_log.h => log/log_internal.h} (69%)\n rename lib/{eal/linux/eal_log.c => log/log_linux.c} (97%)\n rename lib/{eal/windows/eal_log.c => log/log_windows.c} (93%)\n create mode 100644 lib/log/meson.build\n rename lib/{eal/include => log}/rte_log.h (100%)\n create mode 100644 lib/log/version.map\n\n--\n2.37.2" }