Cover Detail
Show a cover letter.
GET /api/covers/126763/?format=api
{ "id": 126763, "url": "http://patchwork.dpdk.org/api/covers/126763/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20230508114707.89629-1-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230508114707.89629-1-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230508114707.89629-1-denis.pryazhennikov@arknetworks.am", "date": "2023-05-08T11:47:04", "name": "[RFC,v2,0/3] improve FEC API usage", "submitter": { "id": 3057, "url": "http://patchwork.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20230508114707.89629-1-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 27955, "url": "http://patchwork.dpdk.org/api/series/27955/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=27955", "date": "2023-05-08T11:47:04", "name": "improve FEC API usage", "version": 2, "mbox": "http://patchwork.dpdk.org/series/27955/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/126763/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 239D042A94;\n\tMon, 8 May 2023 13:47:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id ADD9F410ED;\n\tMon, 8 May 2023 13:47:12 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 2397540685\n for <dev@dpdk.org>; Mon, 8 May 2023 13:47:11 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.88.48])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 394ECE1218;\n Mon, 8 May 2023 15:47:10 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ivan Malov <ivan.malov@arknetworks.am>,\n Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[RFC PATCH v2 0/3] improve FEC API usage", "Date": "Mon, 8 May 2023 15:47:04 +0400", "Message-Id": "<20230508114707.89629-1-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "In-Reply-To": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The documentation for the FEC API is currently incomplete and contains\ninaccuracies in its descriptions of function parameters. \nSpecifically, the semantics of the fec_capa parameter in rte_eth_fec_set()\nis not well-defined. It does not provide information on what should\nbe done if only AUTO bit is set or one of the specified FEC modes is \nnot supported. Additionally, the fec_capa parameter in rte_eth_fec_get()\nimplies that more than one FEC mode can be obtained, but it is \nwrong. Furthermore, the behaviour is undefined in \nrte_eth_fec_set() when the fec_capa parameter is zero.\n\nTo address these issues, a patch series has been created that updates\nthe FEC API documentation, renames one of the parameters to improve \nits clarity and adds a check for zero fec_capability.\n\nv2:\n* Update documentation for rte_eth_fec_set() to fix review comments.\n* Don't rename the fec_capa parameter of rte_eth_fec_get() but\n add a proper description instead.\n\nDenis Pryazhennikov (3):\n ethdev: update documentation for API to set FEC\n ethdev: check that at least one FEC mode is specified\n ethdev: update documentation for API to get FEC\n\n lib/ethdev/rte_ethdev.c | 5 +++++\n lib/ethdev/rte_ethdev.h | 16 ++++++++--------\n 2 files changed, 13 insertions(+), 8 deletions(-)" }