Cover Detail
Show a cover letter.
GET /api/covers/128230/?format=api
{ "id": 128230, "url": "http://patchwork.dpdk.org/api/covers/128230/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com", "date": "2023-06-06T21:45:41", "name": "[v5,0/6] replace rte atomics with GCC builtin atomics", "submitter": { "id": 2077, "url": "http://patchwork.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 28379, "url": "http://patchwork.dpdk.org/api/series/28379/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=28379", "date": "2023-06-06T21:45:42", "name": "replace rte atomics with GCC builtin atomics", "version": 5, "mbox": "http://patchwork.dpdk.org/series/28379/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/128230/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA77C42C44;\n\tTue, 6 Jun 2023 23:46:01 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CD90C42D0B;\n\tTue, 6 Jun 2023 23:45:53 +0200 (CEST)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id B8FB440223\n for <dev@dpdk.org>; Tue, 6 Jun 2023 23:45:49 +0200 (CEST)", "by linux.microsoft.com (Postfix, from userid 1086)\n id CDDAF20BE494; Tue, 6 Jun 2023 14:45:48 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com CDDAF20BE494", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1686087948;\n bh=kjJ5Vj4vPD4vNYDe8JMq/EwhPf1kHSAAUSkKLp+NO3k=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=C1wHhsRt1W3/Pv+lwNm/DraSpqnKxFSYcrKpFZKAyS1g9X8fu8i64lAQy6a58Ahws\n I3f2Gsc2WaV9qsB/OyfeAOmkwNVBKrUkNT3GsbuN2QE0TwbnA29OW7kC2quEDlmc+F\n mIf/Gs65j+CoX2E4Wo+8yxL/5osgQi9Fh6Ar2TrQ=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org,\n\tdavid.marchand@redhat.com", "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Kevin Laatz <kevin.laatz@intel.com>, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Tetsuya Mukawa <mtetsuyah@gmail.com>, Honnappa.Nagarahalli@arm.com,\n thomas@monjalon.net, Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v5 0/6] replace rte atomics with GCC builtin atomics", "Date": "Tue, 6 Jun 2023 14:45:41 -0700", "Message-Id": "<1686087947-15471-1-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of rte_atomic.h types and functions, instead use GCC\nsupplied C++11 memory model builtins.\n\nThis series covers the libraries and drivers that are built on Windows.\n\nThe code has be converted to use the __atomic builtins but there are\nadditional during conversion I notice that there may be some issues\nthat need to be addressed.\n\nI'll comment in the patches where my concerns are so the maintainers\nmay comment.\n\nv5:\n * use relaxed ordering for counter increments in net/ring patch\n * remove note comments from net/ring patch\n\nv4:\n\n * drop patch for lib/ring it will be provided by ARM / Honnappa\n * rebase for changes in dma/idxd merge\n * adapt __atomic_fetch_sub(...) - 1 == 0 to be (__atomic_fetch_sub(...) == 1)\n as per feedback.\n * drop one /* NOTE: review for potential ordering optimization */ since\n the note reference non-critical to perf control path.\n\n note:\n\n Remainder of the NOTE comments have been retained since there\n seems to be no consensus but stronger opinion/argument to keep\n expressed. while I generally agree that changes should not\n include ``TODO'' style comments I also agree that without these\n comments in your face people are very unlikely to feel compelled\n to make the review they are trying to solicit without them. if\n it is absolute that the series won't be merged with them then I\n will remove them, but please be explicit soon.\n\nv3:\n * style, don't use c99 comments\n\nv2:\n * comment code where optimizations may be possible now that memory\n order can be specified.\n * comment code where operations should potentially be atomic so that\n maintainers can review.\n * change a couple of variables labeled as counters to be unsigned.\n\nTyler Retzlaff (6):\n stack: replace rte atomics with GCC builtin atomics\n dma/idxd: replace rte atomics with GCC builtin atomics\n net/ice: replace rte atomics with GCC builtin atomics\n net/ixgbe: replace rte atomics with GCC builtin atomics\n net/null: replace rte atomics with GCC builtin atomics\n net/ring: replace rte atomics with GCC builtin atomics\n\n drivers/dma/idxd/idxd_internal.h | 3 +--\n drivers/dma/idxd/idxd_pci.c | 11 ++++++-----\n drivers/net/ice/ice_dcf.c | 1 -\n drivers/net/ice/ice_dcf_ethdev.c | 1 -\n drivers/net/ice/ice_ethdev.c | 12 ++++++++----\n drivers/net/ixgbe/ixgbe_bypass.c | 1 -\n drivers/net/ixgbe/ixgbe_ethdev.c | 18 ++++++++++++------\n drivers/net/ixgbe/ixgbe_ethdev.h | 3 ++-\n drivers/net/ixgbe/ixgbe_flow.c | 1 -\n drivers/net/ixgbe/ixgbe_rxtx.c | 1 -\n drivers/net/null/rte_eth_null.c | 28 ++++++++++++++++++----------\n drivers/net/ring/rte_eth_ring.c | 20 ++++++++++----------\n lib/stack/rte_stack_lf_generic.h | 16 +++++++++-------\n 13 files changed, 66 insertions(+), 50 deletions(-)" }