Cover Detail
Show a cover letter.
GET /api/covers/41557/?format=api
{ "id": 41557, "url": "http://patchwork.dpdk.org/api/covers/41557/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/cover.1530009564.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cover.1530009564.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cover.1530009564.git.anatoly.burakov@intel.com", "date": "2018-06-26T10:53:11", "name": "[v2,0/7] Remove asynchronous IPC thread", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/cover.1530009564.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 238, "url": "http://patchwork.dpdk.org/api/series/238/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=238", "date": "2018-06-26T10:53:12", "name": "Remove asynchronous IPC thread", "version": 2, "mbox": "http://patchwork.dpdk.org/series/238/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/41557/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7835F1B546;\n\tTue, 26 Jun 2018 12:53:33 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id DAE251B45C\n\tfor <dev@dpdk.org>; Tue, 26 Jun 2018 12:53:23 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Jun 2018 03:53:23 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga001.fm.intel.com with ESMTP; 26 Jun 2018 03:53:19 -0700", "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tw5QArJXO026432; Tue, 26 Jun 2018 11:53:19 +0100", "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id w5QArIqV021174;\n\tTue, 26 Jun 2018 11:53:18 +0100", "(from aburakov@localhost)\n\tby sivswdev01.ir.intel.com with LOCAL id w5QArIWY021170;\n\tTue, 26 Jun 2018 11:53:18 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.51,274,1526367600\"; d=\"scan'208\";a=\"67358854\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "konstantin.ananyev@intel.com, thomas@monjalon.net,\n\tbruce.richardson@intel.com, qi.z.zhang@intel.com", "Date": "Tue, 26 Jun 2018 11:53:11 +0100", "Message-Id": "<cover.1530009564.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "In-Reply-To": "<cover.1529071026.git.anatoly.burakov@intel.com>", "References": "<cover.1529071026.git.anatoly.burakov@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 0/7] Remove asynchronous IPC thread", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As previously discussed [1], IPC threads need to be removed and their\nworkload moved to interrupt thread. However, due to upcoming changes\nfor multiprocess hotplug, it was decided to leave one IPC thread in\nplace for now to avoid deadlocks on memory allocation attempts [2].\n\nFreeBSD did not have an interrupt thread, nor did it support alarm\nAPI. This patchset adds support for both on FreeBSD. FreeBSD interrupt\nthread is based on kevent, FreeBSD's native event multiplexing\nmechanism similar to Linux's epoll.\n\nThe patchset makes FreeBSD's interrupts and alarm work just enough to\nsuffice for purposes of IPC, however there are really weird problems\nobserved. Specifically, FreeBSD's kevent timers are really slow to\ntrigger for some reason, sleeping on a 10ms timer as much as 200ms\nbefore waking up. Interrupt handling on fd's is also a bit flaky.\n\nIt has also been observed that both problems go away if we do not\naffinitize master lcore (by commenting relevant code out [3]). It is\nnot known why these problems are observed, nor it is clear what a\nsolution might entail.\n\nFor the purposes of making IPC work and having rudimentary support\nfor alarm and interrupt API's, this patchset works fine. However,\nbecause of the above described issues, documentation will not be\nupdated to indicate support for interrupts on FreeBSD at this time.\n\nv1->v2:\n- Leave IPC thread in place and only remove asynchronous IPC thread\n\nRFC->v1:\n- FreeBSD support\n\n[1] https://patches.dpdk.org/patch/36579/\n[2] https://patches.dpdk.org/patch/41512/\n[3] https://git.dpdk.org/dpdk/tree/lib/librte_eal/bsdapp/eal/eal.c#n729\n\nAnatoly Burakov (4):\n eal/bsdapp: add interrupt thread\n eal/bsdapp: add alarm support\n ipc: remove IPC thread for async requests\n doc: document IPC callback limitations\n\nJianfeng Tan (3):\n eal/linux: use glibc malloc in alarm\n eal/linux: use glibc malloc in interrupt handling\n eal: bring forward init of interrupt handling\n\n doc/guides/prog_guide/multi_proc_support.rst | 17 +-\n lib/librte_eal/bsdapp/eal/eal.c | 10 +-\n lib/librte_eal/bsdapp/eal/eal_alarm.c | 299 +++++++++++-\n lib/librte_eal/bsdapp/eal/eal_alarm_private.h | 19 +\n lib/librte_eal/bsdapp/eal/eal_interrupts.c | 455 +++++++++++++++++-\n lib/librte_eal/common/eal_common_proc.c | 201 +++-----\n lib/librte_eal/linuxapp/eal/eal.c | 10 +-\n lib/librte_eal/linuxapp/eal/eal_alarm.c | 9 +-\n lib/librte_eal/linuxapp/eal/eal_interrupts.c | 14 +-\n 9 files changed, 852 insertions(+), 182 deletions(-)\n create mode 100644 lib/librte_eal/bsdapp/eal/eal_alarm_private.h" }