Cover Detail
Show a cover letter.
GET /api/covers/47376/?format=api
{ "id": 47376, "url": "http://patchwork.dpdk.org/api/covers/47376/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20181024202719.24902-1-dg@adax.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20181024202719.24902-1-dg@adax.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20181024202719.24902-1-dg@adax.com", "date": "2018-10-24T20:27:14", "name": "[v6,0/5] kni: add API to set link status on kernel interface", "submitter": { "id": 1040, "url": "http://patchwork.dpdk.org/api/people/1040/?format=api", "name": "Dan Gora", "email": "dg@adax.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20181024202719.24902-1-dg@adax.com/mbox/", "series": [ { "id": 2076, "url": "http://patchwork.dpdk.org/api/series/2076/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=2076", "date": "2018-10-24T20:27:14", "name": "kni: add API to set link status on kernel interface", "version": 6, "mbox": "http://patchwork.dpdk.org/series/2076/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/47376/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 562494C95;\n\tWed, 24 Oct 2018 22:27:34 +0200 (CEST)", "from mail-qk1-f193.google.com (mail-qk1-f193.google.com\n\t[209.85.222.193]) by dpdk.org (Postfix) with ESMTP id 4213444BE\n\tfor <dev@dpdk.org>; Wed, 24 Oct 2018 22:27:33 +0200 (CEST)", "by mail-qk1-f193.google.com with SMTP id r71so11495qkr.10\n\tfor <dev@dpdk.org>; Wed, 24 Oct 2018 13:27:33 -0700 (PDT)", "from snappy.local.lan ([179.228.213.114])\n\tby smtp.gmail.com with ESMTPSA id\n\tp64-v6sm3509117qkc.96.2018.10.24.13.27.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tWed, 24 Oct 2018 13:27:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=AdYJeZmpldsSBeOmpoATKBbEqmIhIfvsS/ikpHI6hN0=;\n\tb=IV80PXfWfaNP/v+kSKSTS2AM8HoGZEblvB3n0iUnbryur0+a28+Zw21RU1ywl+hIne\n\ts5b6nqDIRlbe3uE9FjEH9E0rzTNuntRrw/2HdDJjGEOxdOOqF0CMwcDLFgvczV4FmNKg\n\t9vcwqWEKFXPl/gU7I+BfvYbE2GmwhKBpHHhVGfp1v6DLZSpQSAPfUp8tPgeeKZoEk8Rk\n\tdscWV458/s1XYAKGOt3UuSU+fTB5XQnUwkMFyF8JaJIMxeTcuzugma/SzitLVECbI0+X\n\tI1trXdmIILBNuZ1CT/GNmrcqBfhbod4vxuBPZRgX5zD5cP3GJt9sIFgmT3jl55dV4fQX\n\ty1jA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=AdYJeZmpldsSBeOmpoATKBbEqmIhIfvsS/ikpHI6hN0=;\n\tb=MI+EHTrwTFAW+NAlSoo6arRAkkZ4HXGP3nISQ3L8k7KtE2MzSCpZe4M6T62KClNUhx\n\tqq/vfZJfFcMWlke6A5PMwN/tcXFEDpJJFnpAv6oseoBzyJOTBrGWjXU3IlrbcRz3EtIv\n\tZesGMudhIPCBSBtd1DaVZBYNzG2DgCInFkEtzacs2Lq+mbd9hLwdBwZOy99Uevzny/mI\n\tpSEC5gFamhGQoh6GoePgYiHcNcUOifOgJfpXl7CgOdMXAiWQ9KCiz3oHpYHS9F7LCXgR\n\t+pSwz5LgQ03yW4dOYNCna24oMyVGPDS08vWHCd8InPtK81Z9efuvb+qOxmx9R1amj7LY\n\ti/9g==", "X-Gm-Message-State": "AGRZ1gJFBOVM361SnE83u1oBpK/1DLO927HPP/6Djz/dN6aHfaEorGIQ\n\tPKV2YFKuahj0VvbLm5ObtQpkbPsd", "X-Google-Smtp-Source": "AJdET5e+Jo4Y0JKGXKBH+j1FlW1UnutCZwLKNrUHxYGMSJARPHDX0j0/bF6CGIBBYJjCgXQgay8tTQ==", "X-Received": "by 2002:a37:b9c6:: with SMTP id\n\tj189-v6mr3790665qkf.203.1540412852079; \n\tWed, 24 Oct 2018 13:27:32 -0700 (PDT)", "From": "Dan Gora <dg@adax.com>", "To": "dev@dpdk.org", "Cc": "Igor Ryzhov <iryzhov@nfware.com>,\n\tStephen Hemminger <stephen@networkplumber.org>,\n\tFerruh Yigit <ferruh.yigit@intel.com>, Dan Gora <dg@adax.com>", "Date": "Wed, 24 Oct 2018 17:27:14 -0300", "Message-Id": "<20181024202719.24902-1-dg@adax.com>", "X-Mailer": "git-send-email 2.19.0", "In-Reply-To": "<20180911232906.18352-1-dg@adax.com>", "References": "<20180911232906.18352-1-dg@adax.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v6 0/5] kni: add API to set link status on kernel\n\tinterface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Hi All,\n\nAttached is version 6 of a patchset to add a new API function to\nset the link status on kernel interfaces created with the KNI kernel\nmodule.\n\nv6\n====\n* Update info about callback functions in KNI library documentation.\n\n* Minor fixup to module parameter formatting in KNI kernel module. (align\n the \"charp\" text...)\n\n* Add '-m' flag to KNI sample app command line in KNI sample app\n documentation.\n\n* Add references to KNI library documentation from KNI sample app\n documentation (yay Sphinx!)\n\n> v5\n> ====\n> * Update Kernel NIC Interface document with new rte_kni option, move\n> kernel module parameter description here from KNI sample app\n> document, general cleanup.\n> \n> * Update Kernel NIC Interface sample application (kni) document\n> with new command line parameter, remove documentation for rte_kni\n> kernel module but add reference to it, general cleanup.\n> \n> * Change link status change sample rate for KNI example app to 500ms\n> from 100ms.\n> \n> * Fix bug in parameter parsing in v4 in rte_kni kernel module.\n> \n> * Fix output formatting of optional parameters for rte_kni with\n> modinfo.\n> \n> * Fix permissions of optional parameters for rte_kni.\n> \n> * Squash patch to add test for rte_kni_update_link into patch\n> introducing the API function.\n> \n> v4\n> ====\n> * Rework rte_kni_update_link to only take linkup/linkdown as parameter,\n> return previous link state, and remove log messages.\n> \n> * Update patch to set default carrier state to make default carrier\n> state configurable by passing the 'carrier=[on|off]' option to\n> the rte_kni kernel module. This is necessary in order to allow\n> applications which use KNI as pure virtual interfaces without\n> corresponding physical ethernet port to use the interfaces without\n> having to set the carrier state to 'on' via rte_kni_update_link()\n> or by writing to /sys/devices/virtual/net/<ifaceX>/carrier.\n> Note that the default is 'off'.\n> \n> * Add command line flag '-m' to examples/kni to continuously monitor\n> and update the KNI interface link status according to the link\n> status of the corresponding physical ethernet port.\n> \n> \n> v3\n> ====\n> * Use separate function to test rte_kni_update_link() in 'test' app.\n> \n> * Separate changes to 'test' app into separate patch to facilitate\n> possible merge with https://patches.dpdk.org/patch/44730/\n> \n> * Remove changes to set KNI interfaces to 'up' in example/kni\n> \n> v2\n> ====\n> \n> * Fix bug where \"Fixed\" and \"AutoNeg\" were transposed in the link\n> status log message.\n> \n> * Add rte_kni_update_link() to rte_kni_version.map\n> \n> * Add rte_kni_update_link() tests to kni_autotest\n> \n> * Update examples/kni to continuously monitor link status and\n> update the corresponding kernel interface with\n> rte_kni_update_link().\n> \n> * Minor improvements to examples/kni: Add log message showing how\n> to show/zero stats. Improve zeroing statistics.\n> \n> Note that checkpatches.sh compains about patch 1/5, but this appears\n> to be a bug with check-symbol-change or something. If I move the\n> fragment of the patch modifying rte_kni_version.map to the bottom of\n> the patch file, it doesn't complain any more... I just don't really\n> have time to investigate this right now.\n \nthanks\ndan\n\nDan Gora (5):\n kni: add API to set link status on kernel interface\n kni: set default carrier state of interface\n examples/kni: monitor and update link status continually\n examples/kni: add log msgs to show and clear stats\n examples/kni: improve zeroing statistics\n\n .../prog_guide/kernel_nic_interface.rst | 239 ++++++++++++++---\n .../sample_app_ug/kernel_nic_interface.rst | 251 +++++++++++-------\n examples/kni/Makefile | 2 +\n examples/kni/main.c | 92 ++++++-\n kernel/linux/kni/kni_dev.h | 3 +\n kernel/linux/kni/kni_misc.c | 60 ++++-\n kernel/linux/kni/kni_net.c | 5 +\n lib/librte_kni/rte_kni.c | 41 +++\n lib/librte_kni/rte_kni.h | 20 ++\n lib/librte_kni/rte_kni_version.map | 6 +\n test/test/test_kni.c | 77 ++++++\n 11 files changed, 641 insertions(+), 155 deletions(-)" }