get:
Show a patch.

patch:
Update a patch.

put:
Update a patch.

GET /api/patches/100029/?format=api
HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 100029,
    "url": "http://patchwork.dpdk.org/api/patches/100029/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210929205730.775-10-ivan.malov@oktetlabs.ru/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20210929205730.775-10-ivan.malov@oktetlabs.ru>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20210929205730.775-10-ivan.malov@oktetlabs.ru",
    "date": "2021-09-29T20:57:29",
    "name": "[09/10] net/sfc: support counters in tunnel offload JUMP rules",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "b62c384578b20dacf891ee52b32340e04939c86b",
    "submitter": {
        "id": 869,
        "url": "http://patchwork.dpdk.org/api/people/869/?format=api",
        "name": "Ivan Malov",
        "email": "Ivan.Malov@oktetlabs.ru"
    },
    "delegate": {
        "id": 319,
        "url": "http://patchwork.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210929205730.775-10-ivan.malov@oktetlabs.ru/mbox/",
    "series": [
        {
            "id": 19272,
            "url": "http://patchwork.dpdk.org/api/series/19272/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19272",
            "date": "2021-09-29T20:57:20",
            "name": "net/sfc: add support for tunnel offload",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/19272/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/100029/comments/",
    "check": "success",
    "checks": "http://patchwork.dpdk.org/api/patches/100029/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 27CA7A0032;\n\tWed, 29 Sep 2021 22:58:42 +0200 (CEST)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0F8CA41151;\n\tWed, 29 Sep 2021 22:57:57 +0200 (CEST)",
            "from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])\n by mails.dpdk.org (Postfix) with ESMTP id A2D96410F5\n for <dev@dpdk.org>; Wed, 29 Sep 2021 22:57:46 +0200 (CEST)",
            "from localhost.localdomain (unknown [5.144.122.192])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA256)\n (No client certificate requested)\n by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 581E47F6D7;\n Wed, 29 Sep 2021 23:57:46 +0300 (MSK)"
        ],
        "DKIM-Filter": "OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 581E47F6D7",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;\n s=default; t=1632949066;\n bh=VrxkcJZKRZXciLG0/tBGp/x07mNHL0iiF5ROBOdjbrg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References;\n b=MhJwpR1gXKG61UNgSGQErZjFQtg+Mes63ok1O0fc7XA2cr1Kmiz551voLqzjSEjrO\n 6hOYzKt6ivmJjXVUOXMSkRjxCwMAzYkTR51WiKQlivJGtX0HwH9PL0704K2kpxfers\n cVTab3IbGEqOPY/bmb6TPMC9K7q/wlPh+HVclpss=",
        "From": "Ivan Malov <ivan.malov@oktetlabs.ru>",
        "To": "dev@dpdk.org",
        "Cc": "Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "Date": "Wed, 29 Sep 2021 23:57:29 +0300",
        "Message-Id": "<20210929205730.775-10-ivan.malov@oktetlabs.ru>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20210929205730.775-1-ivan.malov@oktetlabs.ru>",
        "References": "<20210929205730.775-1-ivan.malov@oktetlabs.ru>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 09/10] net/sfc: support counters in tunnel\n offload JUMP rules",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Such a counter will only report the number of hits, which is actually\na sum of two contributions (the JUMP rule's own counter + indirect\nincrements issued by counters of the associated GROUP rules.\n\nSigned-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>\nReviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>\n---\n drivers/net/sfc/sfc_flow.c        |  2 ++\n drivers/net/sfc/sfc_flow_tunnel.c | 18 ++++++++++\n drivers/net/sfc/sfc_flow_tunnel.h |  5 +++\n drivers/net/sfc/sfc_mae.c         | 58 +++++++++++++++++++++++++++----\n drivers/net/sfc/sfc_mae.h         |  9 +++++\n drivers/net/sfc/sfc_mae_counter.c | 41 +++++++++++++++++++---\n drivers/net/sfc/sfc_mae_counter.h |  3 ++\n 7 files changed, 125 insertions(+), 11 deletions(-)",
    "diff": "diff --git a/drivers/net/sfc/sfc_flow.c b/drivers/net/sfc/sfc_flow.c\nindex b0dd7d7b6c..689b479d87 100644\n--- a/drivers/net/sfc/sfc_flow.c\n+++ b/drivers/net/sfc/sfc_flow.c\n@@ -2991,6 +2991,8 @@ sfc_flow_start(struct sfc_adapter *sa)\n \n \tSFC_ASSERT(sfc_adapter_is_locked(sa));\n \n+\tsfc_flow_tunnel_reset_hit_counters(sa);\n+\n \tTAILQ_FOREACH(flow, &sa->flow_list, entries) {\n \t\trc = sfc_flow_insert(sa, flow, NULL);\n \t\tif (rc != 0)\ndiff --git a/drivers/net/sfc/sfc_flow_tunnel.c b/drivers/net/sfc/sfc_flow_tunnel.c\nindex 2de401148e..399ce55cd1 100644\n--- a/drivers/net/sfc/sfc_flow_tunnel.c\n+++ b/drivers/net/sfc/sfc_flow_tunnel.c\n@@ -87,6 +87,8 @@ sfc_flow_tunnel_detect_jump_rule(struct sfc_adapter *sa,\n \t\t}\n \n \t\tswitch (actions->type) {\n+\t\tcase RTE_FLOW_ACTION_TYPE_COUNT:\n+\t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_MARK:\n \t\t\tif (action_mark == NULL) {\n \t\t\t\taction_mark = actions->conf;\n@@ -459,3 +461,19 @@ sfc_flow_tunnel_get_restore_info(struct rte_eth_dev *dev,\n \t\t\t\t  RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL,\n \t\t\t\t  \"tunnel offload: get_restore_info failed\");\n }\n+\n+void\n+sfc_flow_tunnel_reset_hit_counters(struct sfc_adapter *sa)\n+{\n+\tunsigned int i;\n+\n+\tSFC_ASSERT(sfc_adapter_is_locked(sa));\n+\tSFC_ASSERT(sa->state != SFC_ETHDEV_STARTED);\n+\n+\tfor (i = 0; i < RTE_DIM(sa->flow_tunnels); ++i) {\n+\t\tstruct sfc_flow_tunnel *ft = &sa->flow_tunnels[i];\n+\n+\t\tft->reset_jump_hit_counter = 0;\n+\t\tft->group_hit_counter = 0;\n+\t}\n+}\ndiff --git a/drivers/net/sfc/sfc_flow_tunnel.h b/drivers/net/sfc/sfc_flow_tunnel.h\nindex 573585ca80..997811809a 100644\n--- a/drivers/net/sfc/sfc_flow_tunnel.h\n+++ b/drivers/net/sfc/sfc_flow_tunnel.h\n@@ -63,6 +63,9 @@ struct sfc_flow_tunnel {\n \tstruct rte_flow_item_mark\titem_mark_v;\n \tstruct rte_flow_item_mark\titem_mark_m;\n \tstruct rte_flow_item\t\titem;\n+\n+\tuint64_t\t\t\treset_jump_hit_counter;\n+\tuint64_t\t\t\tgroup_hit_counter;\n };\n \n struct sfc_adapter;\n@@ -106,6 +109,8 @@ int sfc_flow_tunnel_get_restore_info(struct rte_eth_dev *dev,\n \t\t\t\t     struct rte_flow_restore_info *info,\n \t\t\t\t     struct rte_flow_error *err);\n \n+void sfc_flow_tunnel_reset_hit_counters(struct sfc_adapter *sa);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/net/sfc/sfc_mae.c b/drivers/net/sfc/sfc_mae.c\nindex faf3be522d..73fb40a02d 100644\n--- a/drivers/net/sfc/sfc_mae.c\n+++ b/drivers/net/sfc/sfc_mae.c\n@@ -607,6 +607,8 @@ sfc_mae_action_set_add(struct sfc_adapter *sa,\n \t\t       const struct rte_flow_action actions[],\n \t\t       efx_mae_actions_t *spec,\n \t\t       struct sfc_mae_encap_header *encap_header,\n+\t\t       uint64_t *ft_group_hit_counter,\n+\t\t       struct sfc_flow_tunnel *ft,\n \t\t       unsigned int n_counters,\n \t\t       struct sfc_mae_action_set **action_setp)\n {\n@@ -633,6 +635,16 @@ sfc_mae_action_set_add(struct sfc_adapter *sa,\n \t\t\treturn ENOMEM;\n \t\t}\n \n+\t\tfor (i = 0; i < n_counters; ++i) {\n+\t\t\taction_set->counters[i].rte_id_valid = B_FALSE;\n+\t\t\taction_set->counters[i].mae_id.id =\n+\t\t\t\tEFX_MAE_RSRC_ID_INVALID;\n+\n+\t\t\taction_set->counters[i].ft_group_hit_counter =\n+\t\t\t\tft_group_hit_counter;\n+\t\t\taction_set->counters[i].ft = ft;\n+\t\t}\n+\n \t\tfor (action = actions, i = 0;\n \t\t     action->type != RTE_FLOW_ACTION_TYPE_END && i < n_counters;\n \t\t     ++action) {\n@@ -643,8 +655,7 @@ sfc_mae_action_set_add(struct sfc_adapter *sa,\n \n \t\t\tconf = action->conf;\n \n-\t\t\taction_set->counters[i].mae_id.id =\n-\t\t\t\tEFX_MAE_RSRC_ID_INVALID;\n+\t\t\taction_set->counters[i].rte_id_valid = B_TRUE;\n \t\t\taction_set->counters[i].rte_id = conf->id;\n \t\t\ti++;\n \t\t}\n@@ -3373,10 +3384,12 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n {\n \tstruct sfc_mae_encap_header *encap_header = NULL;\n \tstruct sfc_mae_actions_bundle bundle = {0};\n+\tstruct sfc_flow_tunnel *counter_ft = NULL;\n+\tuint64_t *ft_group_hit_counter = NULL;\n \tconst struct rte_flow_action *action;\n \tstruct sfc_mae *mae = &sa->mae;\n+\tunsigned int n_count = 0;\n \tefx_mae_actions_t *spec;\n-\tunsigned int n_count;\n \tint rc;\n \n \trte_errno = 0;\n@@ -3391,11 +3404,31 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\tgoto fail_action_set_spec_init;\n \n+\tfor (action = actions;\n+\t     action->type != RTE_FLOW_ACTION_TYPE_END; ++action) {\n+\t\tif (action->type == RTE_FLOW_ACTION_TYPE_COUNT)\n+\t\t\t++n_count;\n+\t}\n+\n \tif (spec_mae->ft_rule_type == SFC_FT_RULE_GROUP) {\n \t\t/* JUMP rules don't decapsulate packets. GROUP rules do. */\n \t\trc = efx_mae_action_set_populate_decap(spec);\n \t\tif (rc != 0)\n \t\t\tgoto fail_enforce_ft_decap;\n+\n+\t\tif (n_count == 0 && sfc_mae_counter_stream_enabled(sa)) {\n+\t\t\t/*\n+\t\t\t * The user opted not to use action COUNT in this rule,\n+\t\t\t * but the counter should be enabled implicitly because\n+\t\t\t * packets hitting this rule contribute to the tunnel's\n+\t\t\t * total number of hits. See sfc_mae_counter_get().\n+\t\t\t */\n+\t\t\trc = efx_mae_action_set_populate_count(spec);\n+\t\t\tif (rc != 0)\n+\t\t\t\tgoto fail_enforce_ft_count;\n+\n+\t\t\tn_count = 1;\n+\t\t}\n \t}\n \n \t/* Cleanup after previous encap. header bounce buffer usage. */\n@@ -3421,7 +3454,6 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \tif (rc != 0)\n \t\tgoto fail_process_encap_header;\n \n-\tn_count = efx_mae_action_set_get_nb_count(spec);\n \tif (n_count > 1) {\n \t\trc = ENOTSUP;\n \t\tsfc_err(sa, \"too many count actions requested: %u\", n_count);\n@@ -3436,6 +3468,8 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \t\trc = sfc_mae_rule_parse_action_pf_vf(sa, NULL, spec);\n \t\tif (rc != 0)\n \t\t\tgoto fail_workaround_jump_delivery;\n+\n+\t\tcounter_ft = spec_mae->ft;\n \t\tbreak;\n \tcase SFC_FT_RULE_GROUP:\n \t\t/*\n@@ -3445,6 +3479,8 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \t\t * MARK above, so don't check the return value here.\n \t\t */\n \t\t(void)efx_mae_action_set_populate_mark(spec, 0);\n+\n+\t\tft_group_hit_counter = &spec_mae->ft->group_hit_counter;\n \t\tbreak;\n \tdefault:\n \t\tSFC_ASSERT(B_FALSE);\n@@ -3458,7 +3494,8 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n \t\treturn 0;\n \t}\n \n-\trc = sfc_mae_action_set_add(sa, actions, spec, encap_header, n_count,\n+\trc = sfc_mae_action_set_add(sa, actions, spec, encap_header,\n+\t\t\t\t    ft_group_hit_counter, counter_ft, n_count,\n \t\t\t\t    &spec_mae->action_set);\n \tif (rc != 0)\n \t\tgoto fail_action_set_add;\n@@ -3474,6 +3511,7 @@ sfc_mae_rule_parse_actions(struct sfc_adapter *sa,\n fail_rule_parse_action:\n \tefx_mae_action_set_spec_fini(sa->nic, spec);\n \n+fail_enforce_ft_count:\n fail_enforce_ft_decap:\n fail_action_set_spec_init:\n \tif (rc > 0 && rte_errno == 0) {\n@@ -3621,6 +3659,11 @@ sfc_mae_flow_insert(struct sfc_adapter *sa,\n \t\t\tgoto fail_outer_rule_enable;\n \t}\n \n+\tif (spec_mae->ft_rule_type == SFC_FT_RULE_JUMP) {\n+\t\tspec_mae->ft->reset_jump_hit_counter =\n+\t\t\tspec_mae->ft->group_hit_counter;\n+\t}\n+\n \tif (action_set == NULL) {\n \t\tsfc_dbg(sa, \"enabled flow=%p (no AR)\", flow);\n \t\treturn 0;\n@@ -3720,7 +3763,8 @@ sfc_mae_query_counter(struct sfc_adapter *sa,\n \tfor (i = 0; i < action_set->n_counters; i++) {\n \t\t/*\n \t\t * Get the first available counter of the flow rule if\n-\t\t * counter ID is not specified.\n+\t\t * counter ID is not specified, provided that this\n+\t\t * counter is not an automatic (implicit) one.\n \t\t */\n \t\tif (conf != NULL && action_set->counters[i].rte_id != conf->id)\n \t\t\tcontinue;\n@@ -3738,7 +3782,7 @@ sfc_mae_query_counter(struct sfc_adapter *sa,\n \n \treturn rte_flow_error_set(error, ENOENT,\n \t\t\t\t  RTE_FLOW_ERROR_TYPE_ACTION, action,\n-\t\t\t\t  \"No such flow rule action count ID\");\n+\t\t\t\t  \"no such flow rule action or such count ID\");\n }\n \n int\ndiff --git a/drivers/net/sfc/sfc_mae.h b/drivers/net/sfc/sfc_mae.h\nindex 907e292dd1..b2a62fc10b 100644\n--- a/drivers/net/sfc/sfc_mae.h\n+++ b/drivers/net/sfc/sfc_mae.h\n@@ -62,6 +62,13 @@ struct sfc_mae_counter_id {\n \tefx_counter_t\t\t\tmae_id;\n \t/* ID of a counter in RTE */\n \tuint32_t\t\t\trte_id;\n+\t/* RTE counter ID validity status */\n+\tbool\t\t\t\trte_id_valid;\n+\n+\t/* Flow Tunnel (FT) GROUP hit counter (or NULL) */\n+\tuint64_t\t\t\t*ft_group_hit_counter;\n+\t/* Flow Tunnel (FT) context (for JUMP rules; otherwise, NULL) */\n+\tstruct sfc_flow_tunnel\t\t*ft;\n };\n \n /** Action set registry entry */\n@@ -101,6 +108,8 @@ struct sfc_mae_counter {\n \tuint32_t\t\t\tgeneration_count;\n \tunion sfc_pkts_bytes\t\tvalue;\n \tunion sfc_pkts_bytes\t\treset;\n+\n+\tuint64_t\t\t\t*ft_group_hit_counter;\n };\n \n struct sfc_mae_counters_xstats {\ndiff --git a/drivers/net/sfc/sfc_mae_counter.c b/drivers/net/sfc/sfc_mae_counter.c\nindex 5afd450a11..418caffe59 100644\n--- a/drivers/net/sfc/sfc_mae_counter.c\n+++ b/drivers/net/sfc/sfc_mae_counter.c\n@@ -99,6 +99,8 @@ sfc_mae_counter_enable(struct sfc_adapter *sa,\n \t\t       &p->value.pkts_bytes.int128, __ATOMIC_RELAXED);\n \tp->generation_count = generation_count;\n \n+\tp->ft_group_hit_counter = counterp->ft_group_hit_counter;\n+\n \t/*\n \t * The flag is set at the very end of add operation and reset\n \t * at the beginning of delete operation. Release ordering is\n@@ -210,6 +212,14 @@ sfc_mae_counter_increment(struct sfc_adapter *sa,\n \t__atomic_store(&p->value.pkts_bytes,\n \t\t       &cnt_val.pkts_bytes, __ATOMIC_RELAXED);\n \n+\tif (p->ft_group_hit_counter != NULL) {\n+\t\tuint64_t ft_group_hit_counter;\n+\n+\t\tft_group_hit_counter = *p->ft_group_hit_counter + pkts;\n+\t\t__atomic_store_n(p->ft_group_hit_counter, ft_group_hit_counter,\n+\t\t\t\t __ATOMIC_RELAXED);\n+\t}\n+\n \tsfc_info(sa, \"update MAE counter #%u: pkts+%\" PRIu64 \"=%\" PRIu64\n \t\t \", bytes+%\" PRIu64 \"=%\" PRIu64, mae_counter_id,\n \t\t pkts, cnt_val.pkts, bytes, cnt_val.bytes);\n@@ -799,6 +809,8 @@ sfc_mae_counter_get(struct sfc_mae_counters *counters,\n \t\t    const struct sfc_mae_counter_id *counter,\n \t\t    struct rte_flow_query_count *data)\n {\n+\tstruct sfc_flow_tunnel *ft = counter->ft;\n+\tuint64_t non_reset_jump_hit_counter;\n \tstruct sfc_mae_counter *p;\n \tunion sfc_pkts_bytes value;\n \n@@ -814,14 +826,35 @@ sfc_mae_counter_get(struct sfc_mae_counters *counters,\n \t\t\t\t\t\t  __ATOMIC_RELAXED);\n \n \tdata->hits_set = 1;\n-\tdata->bytes_set = 1;\n \tdata->hits = value.pkts - p->reset.pkts;\n-\tdata->bytes = value.bytes - p->reset.bytes;\n+\n+\tif (ft != NULL) {\n+\t\tdata->hits += ft->group_hit_counter;\n+\t\tnon_reset_jump_hit_counter = data->hits;\n+\t\tdata->hits -= ft->reset_jump_hit_counter;\n+\t} else {\n+\t\tdata->bytes_set = 1;\n+\t\tdata->bytes = value.bytes - p->reset.bytes;\n+\t}\n \n \tif (data->reset != 0) {\n-\t\tp->reset.pkts = value.pkts;\n-\t\tp->reset.bytes = value.bytes;\n+\t\tif (ft != NULL) {\n+\t\t\tft->reset_jump_hit_counter = non_reset_jump_hit_counter;\n+\t\t} else {\n+\t\t\tp->reset.pkts = value.pkts;\n+\t\t\tp->reset.bytes = value.bytes;\n+\t\t}\n \t}\n \n \treturn 0;\n }\n+\n+bool\n+sfc_mae_counter_stream_enabled(struct sfc_adapter *sa)\n+{\n+\tif ((sa->counter_rxq.state & SFC_COUNTER_RXQ_INITIALIZED) == 0 ||\n+\t    sfc_get_service_lcore(SOCKET_ID_ANY) == RTE_MAX_LCORE)\n+\t\treturn B_FALSE;\n+\telse\n+\t\treturn B_TRUE;\n+}\ndiff --git a/drivers/net/sfc/sfc_mae_counter.h b/drivers/net/sfc/sfc_mae_counter.h\nindex 2c953c2968..28d70f7d69 100644\n--- a/drivers/net/sfc/sfc_mae_counter.h\n+++ b/drivers/net/sfc/sfc_mae_counter.h\n@@ -52,6 +52,9 @@ int sfc_mae_counter_get(struct sfc_mae_counters *counters,\n int sfc_mae_counter_start(struct sfc_adapter *sa);\n void sfc_mae_counter_stop(struct sfc_adapter *sa);\n \n+/* Check whether MAE Counter-on-Queue (CoQ) prerequisites are satisfied */\n+bool sfc_mae_counter_stream_enabled(struct sfc_adapter *sa);\n+\n #ifdef __cplusplus\n }\n #endif\n",
    "prefixes": [
        "09/10"
    ]
}