Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100035/?format=api
{ "id": 100035, "url": "http://patchwork.dpdk.org/api/patches/100035/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210929213943.17817-4-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210929213943.17817-4-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210929213943.17817-4-olivier.matz@6wind.com", "date": "2021-09-29T21:39:41", "name": "[v2,3/5] kvargs: new function to get from key and value", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4fc00283cd352c281c0d0f83c9d1d161b9a84115", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210929213943.17817-4-olivier.matz@6wind.com/mbox/", "series": [ { "id": 19274, "url": "http://patchwork.dpdk.org/api/series/19274/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19274", "date": "2021-09-29T21:39:38", "name": "kvargs: promote or remove experimental api", "version": 2, "mbox": "http://patchwork.dpdk.org/series/19274/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/100035/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/100035/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9A854A0032;\n\tWed, 29 Sep 2021 23:40:22 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 51EDD410F0;\n\tWed, 29 Sep 2021 23:40:11 +0200 (CEST)", "from mail-wm1-f41.google.com (mail-wm1-f41.google.com\n [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id 12021410F2\n for <dev@dpdk.org>; Wed, 29 Sep 2021 23:40:06 +0200 (CEST)", "by mail-wm1-f41.google.com with SMTP id j27so2966627wms.0\n for <dev@dpdk.org>; Wed, 29 Sep 2021 14:40:06 -0700 (PDT)", "from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id o19sm1079743wrg.60.2021.09.29.14.40.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Sep 2021 14:40:05 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=qXKA7hBgJPdrYfOCcAdOOtanDoOf3WmmEVZubd/adjY=;\n b=G2olN1tIGofVXNBs9A5spKEmj0BD/HWI9aesJhhe8KesxiHm6SCXppriIQuYfWSd1x\n mGWjMYUIYuPvP31pkUmHXIPuIMqZlyaHmSzh63uOIobUDe2rfZ5lr4hCuQiUdilkLh0j\n 9OF0vpBKfEo+Qjza+ZyNQGdoZtr8N4MKsG2whFtFpOG48miRiOaGNNDPzpHEGy1Z1xEe\n OSBQ44O66gWmtXpiMaMlFSe0SURkMxB5sJMjSg1boW/fE1nveUM6Qls+5VQTB0Z5JqSf\n e0Tgr1J52v9twR43eVTrWSAwEwbdfc57JJ9QYs3RjQCk86nxfQHVdkoAFJA46xXFthMP\n xLjg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=qXKA7hBgJPdrYfOCcAdOOtanDoOf3WmmEVZubd/adjY=;\n b=q0yZCO+zGQBF4F2fUZkZmLF3vSBWFVxKZOAt8+aglKOGTASNYYDC0Z4glFbJLwrvrL\n B3KK7aCDvdQxDnUdi85Gedk3I2YHClKFHBVuYkFp9/Z3aE8Qicvqn+aMD1RacFPg2HE2\n 0dqFYkv0Hdj4KUGgR9XKVCcWRmhFw7tbm+dA7QjZklcH/oGNlQzZg5be+xCWaxLGoE7u\n Yw9R4tmxOdzWvtR64N1FXB73f2iC5JQqa6A0f4BRx7YUwVWUhANH9zVUAh7y8/pgIIFO\n 4yiDm4uy//izWCC7/zauLeSiEoZg7NKcgTkkNwCB46qe7eqE+SonWvcVQC5Xn/Ov/aYv\n adxw==", "X-Gm-Message-State": "AOAM530WczJNdyjdVyrfcDPPu2E26w58XEQftB70DDRkX9xQefmU/++z\n 8lauCccyCg4OCz6eEPQK/bHUMSeSdAuSEQ==", "X-Google-Smtp-Source": "\n ABdhPJzcEIpVOyzt2Qo/MUiEK44oLnmly2DVfSIhLESwcmzoE6zqSGGPdNJR8WvWqigm04DNlmGR4A==", "X-Received": "by 2002:a05:600c:4fc7:: with SMTP id\n o7mr12839356wmq.91.1632951605793;\n Wed, 29 Sep 2021 14:40:05 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Xueming Li <xuemingl@nvidia.com>, Gaetan Rivet <grive@u256.net>,\n Ray Kinsella <mdr@ashroe.eu>", "Date": "Wed, 29 Sep 2021 23:39:41 +0200", "Message-Id": "<20210929213943.17817-4-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210929213943.17817-1-olivier.matz@6wind.com>", "References": "<20210924155740.20510-1-olivier.matz@6wind.com>\n <20210929213943.17817-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/5] kvargs: new function to get from key and\n value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "A quite common scenario with kvargs is to lookup for a <key>=<value> in\na kvlist. For instance, check if name=foo is present in\nname=toto,name=foo,name=bar. This is currently done in drivers/bus with\nrte_kvargs_process() + the rte_kvargs_strcmp() handler.\n\nThis approach is not straightforward, and can be replaced by this new\nfunction.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nReviewed-by: Xueming Li <xuemingl@nvidia.com>\n---\n drivers/bus/auxiliary/auxiliary_params.c | 9 ++++----\n drivers/bus/vdev/vdev_params.c | 13 ++---------\n lib/kvargs/rte_kvargs.c | 23 +++++++++++++++----\n lib/kvargs/rte_kvargs.h | 29 +++++++++++++++++++++++-\n lib/kvargs/version.map | 2 ++\n 5 files changed, 54 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/bus/auxiliary/auxiliary_params.c b/drivers/bus/auxiliary/auxiliary_params.c\nindex cd3fa56cb4..a9c7853ed1 100644\n--- a/drivers/bus/auxiliary/auxiliary_params.c\n+++ b/drivers/bus/auxiliary/auxiliary_params.c\n@@ -25,13 +25,12 @@ auxiliary_dev_match(const struct rte_device *dev,\n \t const void *_kvlist)\n {\n \tconst struct rte_kvargs *kvlist = _kvlist;\n-\tint ret;\n+\tconst char *key = auxiliary_params_keys[RTE_AUXILIARY_PARAM_NAME];\n \n-\tret = rte_kvargs_process(kvlist,\n-\t\t\tauxiliary_params_keys[RTE_AUXILIARY_PARAM_NAME],\n-\t\t\trte_kvargs_strcmp, (void *)(uintptr_t)dev->name);\n+\tif (rte_kvargs_get_with_value(kvlist, key, dev->name) == NULL)\n+\t\treturn -1;\n \n-\treturn ret != 0 ? -1 : 0;\n+\treturn 0;\n }\n \n void *\ndiff --git a/drivers/bus/vdev/vdev_params.c b/drivers/bus/vdev/vdev_params.c\nindex 6f74704d1c..37d95395e7 100644\n--- a/drivers/bus/vdev/vdev_params.c\n+++ b/drivers/bus/vdev/vdev_params.c\n@@ -26,19 +26,10 @@ static int\n vdev_dev_match(const struct rte_device *dev,\n \t const void *_kvlist)\n {\n-\tint ret;\n \tconst struct rte_kvargs *kvlist = _kvlist;\n-\tchar *name;\n+\tconst char *key = vdev_params_keys[RTE_VDEV_PARAM_NAME];\n \n-\t/* cannot pass const dev->name to rte_kvargs_process() */\n-\tname = strdup(dev->name);\n-\tif (name == NULL)\n-\t\treturn -1;\n-\tret = rte_kvargs_process(kvlist,\n-\t\tvdev_params_keys[RTE_VDEV_PARAM_NAME],\n-\t\trte_kvargs_strcmp, name);\n-\tfree(name);\n-\tif (ret != 0)\n+\tif (rte_kvargs_get_with_value(kvlist, key, dev->name) == NULL)\n \t\treturn -1;\n \n \treturn 0;\ndiff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c\nindex 38e9d5c1ca..20abb23183 100644\n--- a/lib/kvargs/rte_kvargs.c\n+++ b/lib/kvargs/rte_kvargs.c\n@@ -204,21 +204,34 @@ rte_kvargs_free(struct rte_kvargs *kvlist)\n \tfree(kvlist);\n }\n \n-/* Lookup a value in an rte_kvargs list by its key. */\n+/* Lookup a value in an rte_kvargs list by its key and value. */\n const char *\n-rte_kvargs_get(const struct rte_kvargs *kvlist, const char *key)\n+rte_kvargs_get_with_value(const struct rte_kvargs *kvlist, const char *key,\n+\t\t\t const char *value)\n {\n \tunsigned int i;\n \n-\tif (kvlist == NULL || key == NULL)\n+\tif (kvlist == NULL)\n \t\treturn NULL;\n \tfor (i = 0; i < kvlist->count; ++i) {\n-\t\tif (strcmp(kvlist->pairs[i].key, key) == 0)\n-\t\t\treturn kvlist->pairs[i].value;\n+\t\tif (key != NULL && strcmp(kvlist->pairs[i].key, key) != 0)\n+\t\t\tcontinue;\n+\t\tif (value != NULL && strcmp(kvlist->pairs[i].value, value) != 0)\n+\t\t\tcontinue;\n+\t\treturn kvlist->pairs[i].value;\n \t}\n \treturn NULL;\n }\n \n+/* Lookup a value in an rte_kvargs list by its key. */\n+const char *\n+rte_kvargs_get(const struct rte_kvargs *kvlist, const char *key)\n+{\n+\tif (kvlist == NULL || key == NULL)\n+\t\treturn NULL;\n+\treturn rte_kvargs_get_with_value(kvlist, key, NULL);\n+}\n+\n /*\n * Parse the arguments \"key=value,key=value,...\" string and return\n * an allocated structure that contains a key/value list. Also\ndiff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h\nindex 328f0d3cc6..e40df1bd2a 100644\n--- a/lib/kvargs/rte_kvargs.h\n+++ b/lib/kvargs/rte_kvargs.h\n@@ -116,7 +116,7 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);\n /**\n * Get the value associated with a given key.\n *\n- * If multiple key matches, the value of the first one is returned.\n+ * If multiple keys match, the value of the first one is returned.\n *\n * The memory returned is allocated as part of the rte_kvargs structure,\n * it must never be modified.\n@@ -132,6 +132,33 @@ void rte_kvargs_free(struct rte_kvargs *kvlist);\n */\n const char *rte_kvargs_get(const struct rte_kvargs *kvlist, const char *key);\n \n+/**\n+ * @warning\n+ * @b EXPERIMENTAL: this API may change without prior notice\n+ *\n+ * Get the value associated with a given key and value.\n+ *\n+ * Find the first entry in the kvlist whose key and value match the\n+ * ones passed as argument.\n+ *\n+ * The memory returned is allocated as part of the rte_kvargs structure,\n+ * it must never be modified.\n+ *\n+ * @param kvlist\n+ * A list of rte_kvargs pair of 'key=value'.\n+ * @param key\n+ * The matching key. If NULL, any key will match.\n+ * @param value\n+ * The matching value. If NULL, any value will match.\n+ *\n+ * @return\n+ * NULL if no key matches the input,\n+ * a value associated with a matching key otherwise.\n+ */\n+__rte_experimental\n+const char *rte_kvargs_get_with_value(const struct rte_kvargs *kvlist,\n+\t\t\t\t const char *key, const char *value);\n+\n /**\n * Call a handler function for each key/value matching the key\n *\ndiff --git a/lib/kvargs/version.map b/lib/kvargs/version.map\nindex 236f35c02b..82879b7140 100644\n--- a/lib/kvargs/version.map\n+++ b/lib/kvargs/version.map\n@@ -16,4 +16,6 @@ EXPERIMENTAL {\n \n \trte_kvargs_strcmp;\n \n+\t# added in 21.11\n+\trte_kvargs_get_with_value;\n };\n", "prefixes": [ "v2", "3/5" ] }