Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/100036/?format=api
{ "id": 100036, "url": "http://patchwork.dpdk.org/api/patches/100036/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20210929213943.17817-5-olivier.matz@6wind.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20210929213943.17817-5-olivier.matz@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20210929213943.17817-5-olivier.matz@6wind.com", "date": "2021-09-29T21:39:42", "name": "[v2,4/5] kvargs: remove experimental function to compare string", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a68f72f4a5e6bf7f5c281ae1e7f4f99367024068", "submitter": { "id": 8, "url": "http://patchwork.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20210929213943.17817-5-olivier.matz@6wind.com/mbox/", "series": [ { "id": 19274, "url": "http://patchwork.dpdk.org/api/series/19274/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=19274", "date": "2021-09-29T21:39:38", "name": "kvargs: promote or remove experimental api", "version": 2, "mbox": "http://patchwork.dpdk.org/series/19274/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/100036/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/100036/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 37DD7A0032;\n\tWed, 29 Sep 2021 23:40:27 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 533804111F;\n\tWed, 29 Sep 2021 23:40:12 +0200 (CEST)", "from mail-wr1-f51.google.com (mail-wr1-f51.google.com\n [209.85.221.51]) by mails.dpdk.org (Postfix) with ESMTP id AFACC410F2\n for <dev@dpdk.org>; Wed, 29 Sep 2021 23:40:06 +0200 (CEST)", "by mail-wr1-f51.google.com with SMTP id d6so6509189wrc.11\n for <dev@dpdk.org>; Wed, 29 Sep 2021 14:40:06 -0700 (PDT)", "from gojira.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com.\n [62.23.145.78])\n by smtp.gmail.com with ESMTPSA id o19sm1079743wrg.60.2021.09.29.14.40.05\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Sep 2021 14:40:06 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google;\n h=from:to:cc:subject:date:message-id:in-reply-to:references\n :mime-version:content-transfer-encoding;\n bh=yh0oVJn13XE2wUoqp8T0trW+xdSBLudc5er4oxGWPjc=;\n b=G3jHG5Ukqm7JN6JomANp6DcIWN6Ka8KX2G7bVNwl7sxv4Lz11lHUFo4Ya4zchHRID2\n 5qd75HtrLurrnq7TeX6XjjSngWt1yi9M+FRTT3qYqwkcpPXYOR//34KbF1AS+YuU1fqQ\n 1/9ZLNgl7Ohskb71ZcbeAoiIusU0s/wqg1jcnChNnKUPEKZj/rWSVwyuztj0yWO7zZMR\n OTei8qcCVjflEzHG2QmZmJIiKlOzkaUfp9n/VqigVz8lyNffGafC242UG3dkbbY80Ev5\n B6udnSUyQpmHPDVh4e8vnF2m/Zg3xzLF4g9UZvr+h17Gw/1iPvt2maSv+kuBwVzFLAhN\n n2IA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n :references:mime-version:content-transfer-encoding;\n bh=yh0oVJn13XE2wUoqp8T0trW+xdSBLudc5er4oxGWPjc=;\n b=mMBAgSaRW7Vu98tLkkrWGNfQMP953uY5kscy2E8qckk5iG/volJjoC/AyGUATOy9sB\n g2zozlX4D4L0+ZxrAHJq8JAHk5aoisBbgNCiCv8QCQ5U9hJx9I1I4iwHOR3Ab8h4PqRe\n lhkbf7wn4eYFaGIeiHv0Q0zc701mk+z2blqPXhrSLMlugtsPN+y+DlcLFlda+jAbpSng\n hhiAtJaKjPbuJBYnvst65C+/TuBlncmUFgWx8YAND2S3f9j2b8ggCa8XHEdoC0sT/06k\n vuS3QVgCzC1H6QtI4jzCwHWeD6d1pmnYFcDuys2qaNrkcdtnuL/BgfDI0V+qxUHV9G+U\n 6fwg==", "X-Gm-Message-State": "AOAM531FG0zeR9p3Pt1HYXE6MHlsOAli3FZUi3UciHU7KYl2LU8rrp0J\n eO9j9nPye7jsnNhK+FtcvXJkOLe8w6w0Uw==", "X-Google-Smtp-Source": "\n ABdhPJyLMUgXjjxs9eFjVbqJ+jXKyjSOeIOL3utf71ORfuNW05kgZrmdMzBebpP2QJdvrclVxZzqvQ==", "X-Received": "by 2002:a05:6000:2c6:: with SMTP id\n o6mr2504655wry.292.1632951606494;\n Wed, 29 Sep 2021 14:40:06 -0700 (PDT)", "From": "Olivier Matz <olivier.matz@6wind.com>", "To": "dev@dpdk.org", "Cc": "Olivier Matz <olivier.matz@6wind.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Xueming Li <xuemingl@nvidia.com>, Gaetan Rivet <grive@u256.net>,\n Ray Kinsella <mdr@ashroe.eu>", "Date": "Wed, 29 Sep 2021 23:39:42 +0200", "Message-Id": "<20210929213943.17817-5-olivier.matz@6wind.com>", "X-Mailer": "git-send-email 2.30.2", "In-Reply-To": "<20210929213943.17817-1-olivier.matz@6wind.com>", "References": "<20210924155740.20510-1-olivier.matz@6wind.com>\n <20210929213943.17817-1-olivier.matz@6wind.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to\n compare string", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The function was designed to be used as a handler for\nrte_kvargs_process() to compare the value string in a kvlist. For\nreadability, its usages in DPDK have been replaced by\nrte_kvargs_get_with_value() in previous commit.\n\nRemove this function, as it is not used anymore.\n\nSigned-off-by: Olivier Matz <olivier.matz@6wind.com>\nReviewed-by: Xueming Li <xuemingl@nvidia.com>\n---\n lib/kvargs/rte_kvargs.c | 9 ---------\n lib/kvargs/rte_kvargs.h | 26 --------------------------\n lib/kvargs/version.map | 2 --\n 3 files changed, 37 deletions(-)", "diff": "diff --git a/lib/kvargs/rte_kvargs.c b/lib/kvargs/rte_kvargs.c\nindex 20abb23183..11f624ef14 100644\n--- a/lib/kvargs/rte_kvargs.c\n+++ b/lib/kvargs/rte_kvargs.c\n@@ -283,12 +283,3 @@ rte_kvargs_parse_delim(const char *args, const char * const valid_keys[],\n \tfree(copy);\n \treturn kvlist;\n }\n-\n-int\n-rte_kvargs_strcmp(const char *key __rte_unused,\n-\t\t const char *value, void *opaque)\n-{\n-\tconst char *str = opaque;\n-\n-\treturn -abs(strcmp(str, value));\n-}\ndiff --git a/lib/kvargs/rte_kvargs.h b/lib/kvargs/rte_kvargs.h\nindex e40df1bd2a..3c1754c3d9 100644\n--- a/lib/kvargs/rte_kvargs.h\n+++ b/lib/kvargs/rte_kvargs.h\n@@ -197,32 +197,6 @@ int rte_kvargs_process(const struct rte_kvargs *kvlist,\n unsigned rte_kvargs_count(const struct rte_kvargs *kvlist,\n \tconst char *key_match);\n \n-/**\n- * Generic kvarg handler for string comparison.\n- *\n- * This function can be used for a generic string comparison processing\n- * on a list of kvargs.\n- *\n- * @param key\n- * kvarg pair key.\n- *\n- * @param value\n- * kvarg pair value.\n- *\n- * @param opaque\n- * Opaque pointer to a string.\n- *\n- * @return\n- * 0 if the strings match.\n- * !0 otherwise or on error.\n- *\n- * Unlike strcmp, comparison ordering is not kept.\n- * In order for rte_kvargs_process to stop processing on match error,\n- * a negative value is returned even if strcmp had returned a positive one.\n- */\n-__rte_experimental\n-int rte_kvargs_strcmp(const char *key, const char *value, void *opaque);\n-\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/lib/kvargs/version.map b/lib/kvargs/version.map\nindex 82879b7140..0d42cd58a8 100644\n--- a/lib/kvargs/version.map\n+++ b/lib/kvargs/version.map\n@@ -14,8 +14,6 @@ DPDK_22 {\n EXPERIMENTAL {\n \tglobal:\n \n-\trte_kvargs_strcmp;\n-\n \t# added in 21.11\n \trte_kvargs_get_with_value;\n };\n", "prefixes": [ "v2", "4/5" ] }