Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103162/?format=api
{ "id": 103162, "url": "http://patchwork.dpdk.org/api/patches/103162/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com", "date": "2021-10-28T13:49:27", "name": "[v2,1/4] vfio: drop fallback Linux implementation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4902f18865d3ea7f097210ecee0cde996d21f2e4", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 20100, "url": "http://patchwork.dpdk.org/api/series/20100/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20100", "date": "2021-10-28T13:49:27", "name": "[v2,1/4] vfio: drop fallback Linux implementation", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20100/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/103162/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/103162/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0AD05A0547;\n\tThu, 28 Oct 2021 15:49:34 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CDDC141147;\n\tThu, 28 Oct 2021 15:49:33 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 8F6084111A\n for <dev@dpdk.org>; Thu, 28 Oct 2021 15:49:32 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Oct 2021 06:49:31 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by orsmga007.jf.intel.com with ESMTP; 28 Oct 2021 06:49:31 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10150\"; a=\"230261420\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"230261420\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"487136649\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Thu, 28 Oct 2021 13:49:27 +0000", "Message-Id": "\n <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "References": "\n <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/4] vfio: drop fallback Linux implementation", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, VFIO support for Linux is compiled unconditionally, and\nsupported kernel versions start with 4.4, so VFIO is assumed to always\nbe enabled. There is no way of disabling VFIO support at compile time\nanyway, so just drop the \"VFIO not available\" fallback code altogether.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n Current minimum support Linux kernel is 4.4, and Meson build file sets the\n RTE_EAL_VFIO config option to `true` simply because we are compiling for Linux.\n So, it looks like VFIO support is pretty much assumed on Linux, so i think we\n can safely drop the fallback dummy implementation from Linux altogether?\n\n lib/eal/linux/eal_vfio.c | 110 ---------------------------------------\n 1 file changed, 110 deletions(-)", "diff": "diff --git a/lib/eal/linux/eal_vfio.c b/lib/eal/linux/eal_vfio.c\nindex aa2087a2da..549b86ae1d 100644\n--- a/lib/eal/linux/eal_vfio.c\n+++ b/lib/eal/linux/eal_vfio.c\n@@ -20,8 +20,6 @@\n #include \"eal_private.h\"\n #include \"eal_internal_cfg.h\"\n \n-#ifdef VFIO_PRESENT\n-\n #define VFIO_MEM_EVENT_CLB_NAME \"vfio_mem_event_clb\"\n \n /* hot plug/unplug of VFIO groups may cause all DMA maps to be dropped. we can\n@@ -2201,111 +2199,3 @@ rte_vfio_container_dma_unmap(int container_fd, uint64_t vaddr, uint64_t iova,\n \n \treturn container_dma_unmap(vfio_cfg, vaddr, iova, len);\n }\n-\n-#else\n-\n-int\n-rte_vfio_setup_device(__rte_unused const char *sysfs_base,\n-\t\t__rte_unused const char *dev_addr,\n-\t\t__rte_unused int *vfio_dev_fd,\n-\t\t__rte_unused struct vfio_device_info *device_info)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_release_device(__rte_unused const char *sysfs_base,\n-\t\t__rte_unused const char *dev_addr, __rte_unused int fd)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_enable(__rte_unused const char *modname)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_is_enabled(__rte_unused const char *modname)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_noiommu_is_enabled(void)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_clear_group(__rte_unused int vfio_group_fd)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_get_group_num(__rte_unused const char *sysfs_base,\n-\t\t__rte_unused const char *dev_addr,\n-\t\t__rte_unused int *iommu_group_num)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_get_container_fd(void)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_get_group_fd(__rte_unused int iommu_group_num)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_create(void)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_destroy(__rte_unused int container_fd)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_group_bind(__rte_unused int container_fd,\n-\t\t__rte_unused int iommu_group_num)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_group_unbind(__rte_unused int container_fd,\n-\t\t__rte_unused int iommu_group_num)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_dma_map(__rte_unused int container_fd,\n-\t\t__rte_unused uint64_t vaddr,\n-\t\t__rte_unused uint64_t iova,\n-\t\t__rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n-int\n-rte_vfio_container_dma_unmap(__rte_unused int container_fd,\n-\t\t__rte_unused uint64_t vaddr,\n-\t\t__rte_unused uint64_t iova,\n-\t\t__rte_unused uint64_t len)\n-{\n-\treturn -1;\n-}\n-\n-#endif /* VFIO_PRESENT */\n", "prefixes": [ "v2", "1/4" ] }