Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/103173/?format=api
{ "id": 103173, "url": "http://patchwork.dpdk.org/api/patches/103173/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/dd34410c291af04f929df2a63240793ef8c345a1.1635430513.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<dd34410c291af04f929df2a63240793ef8c345a1.1635430513.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/dd34410c291af04f929df2a63240793ef8c345a1.1635430513.git.anatoly.burakov@intel.com", "date": "2021-10-28T14:15:19", "name": "[v3,4/4] vfio: add errno on unsupported platforms", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0654664c47544af60eddf1c05def6c8667bd2ba0", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/dd34410c291af04f929df2a63240793ef8c345a1.1635430513.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 20103, "url": "http://patchwork.dpdk.org/api/series/20103/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20103", "date": "2021-10-28T14:15:16", "name": "[v3,1/4] vfio: drop fallback Linux implementation", "version": 3, "mbox": "http://patchwork.dpdk.org/series/20103/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/103173/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/103173/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 07A0BA0547;\n\tThu, 28 Oct 2021 16:15:42 +0200 (CEST)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A5A1C426DC;\n\tThu, 28 Oct 2021 16:15:30 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 8990741C27;\n Thu, 28 Oct 2021 16:15:26 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 28 Oct 2021 07:15:25 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by orsmga008.jf.intel.com with ESMTP; 28 Oct 2021 07:15:23 -0700" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10151\"; a=\"253986082\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"253986082\"", "E=Sophos;i=\"5.87,190,1631602800\"; d=\"scan'208\";a=\"498417219\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,\n Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,\n Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,\n Dmitry Malloy <dmitrym@microsoft.com>,\n Pallavi Kadam <pallavi.kadam@intel.com>", "Cc": "stable@dpdk.org,\n\tChenbo Xia <chenbo.xia@intel.com>", "Date": "Thu, 28 Oct 2021 14:15:19 +0000", "Message-Id": "\n <dd34410c291af04f929df2a63240793ef8c345a1.1635430513.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "\n <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635430513.git.anatoly.burakov@intel.com>", "References": "\n <b2382197250fe4a359a7eb2e7e4c1d12cd959500.1635428963.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 4/4] vfio: add errno on unsupported platforms", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, when code is running on FreeBSD or Windows,, there is no way\nto distinguish between a geniune error and a \"VFIO is unsupported\"\nerror. Fix the dummy implementations to also set the rte_errno flag.\n\nCc: stable@dpdk.org\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\nAcked-by: Chenbo Xia <chenbo.xia@intel.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eal/freebsd/eal.c | 13 +++++++++++++\n lib/eal/windows/eal.c | 2 ++\n 2 files changed, 15 insertions(+)", "diff": "diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c\nindex dada210b19..fce13accc8 100644\n--- a/lib/eal/freebsd/eal.c\n+++ b/lib/eal/freebsd/eal.c\n@@ -1005,6 +1005,7 @@ int rte_vfio_setup_device(__rte_unused const char *sysfs_base,\n \t\t __rte_unused int *vfio_dev_fd,\n \t\t __rte_unused struct vfio_device_info *device_info)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1012,11 +1013,13 @@ int rte_vfio_release_device(__rte_unused const char *sysfs_base,\n \t\t\t__rte_unused const char *dev_addr,\n \t\t\t__rte_unused int fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int rte_vfio_enable(__rte_unused const char *modname)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1032,6 +1035,7 @@ int rte_vfio_noiommu_is_enabled(void)\n \n int rte_vfio_clear_group(__rte_unused int vfio_group_fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1040,30 +1044,35 @@ rte_vfio_get_group_num(__rte_unused const char *sysfs_base,\n \t\t __rte_unused const char *dev_addr,\n \t\t __rte_unused int *iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_container_fd(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_get_group_fd(__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_create(void)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n int\n rte_vfio_container_destroy(__rte_unused int container_fd)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1071,6 +1080,7 @@ int\n rte_vfio_container_group_bind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1078,6 +1088,7 @@ int\n rte_vfio_container_group_unbind(__rte_unused int container_fd,\n \t\t__rte_unused int iommu_group_num)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1087,6 +1098,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -1096,5 +1108,6 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\ndiff --git a/lib/eal/windows/eal.c b/lib/eal/windows/eal.c\nindex f7ce1b6671..67db7f099a 100644\n--- a/lib/eal/windows/eal.c\n+++ b/lib/eal/windows/eal.c\n@@ -481,6 +481,7 @@ rte_vfio_container_dma_map(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n@@ -490,6 +491,7 @@ rte_vfio_container_dma_unmap(__rte_unused int container_fd,\n \t\t\t__rte_unused uint64_t iova,\n \t\t\t__rte_unused uint64_t len)\n {\n+\trte_errno = ENOTSUP;\n \treturn -1;\n }\n \n", "prefixes": [ "v3", "4/4" ] }