Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104476/?format=api
{ "id": 104476, "url": "http://patchwork.dpdk.org/api/patches/104476/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211117204453.27337-1-eagostini@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211117204453.27337-1-eagostini@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211117204453.27337-1-eagostini@nvidia.com", "date": "2021-11-17T20:44:53", "name": "[v1] app/test-gpudev: remove memory leaks in case of errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7e32eb8184900d240d9ae1a19c9fa126ec9269ba", "submitter": { "id": 1571, "url": "http://patchwork.dpdk.org/api/people/1571/?format=api", "name": "Elena Agostini", "email": "eagostini@nvidia.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211117204453.27337-1-eagostini@nvidia.com/mbox/", "series": [ { "id": 20621, "url": "http://patchwork.dpdk.org/api/series/20621/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20621", "date": "2021-11-17T20:44:53", "name": "[v1] app/test-gpudev: remove memory leaks in case of errors", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20621/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104476/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104476/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 199A6A0C41;\n\tWed, 17 Nov 2021 13:34:36 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 0061341104;\n\tWed, 17 Nov 2021 13:34:35 +0100 (CET)", "from NAM11-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam11on2053.outbound.protection.outlook.com [40.107.223.53])\n by mails.dpdk.org (Postfix) with ESMTP id 510B9407FF\n for <dev@dpdk.org>; Wed, 17 Nov 2021 13:34:35 +0100 (CET)", "from CO2PR06CA0059.namprd06.prod.outlook.com (2603:10b6:104:3::17)\n by CY4PR12MB1861.namprd12.prod.outlook.com (2603:10b6:903:11e::23) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27; Wed, 17 Nov\n 2021 12:34:33 +0000", "from CO1NAM11FT048.eop-nam11.prod.protection.outlook.com\n (2603:10b6:104:3:cafe::e8) by CO2PR06CA0059.outlook.office365.com\n (2603:10b6:104:3::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.18 via Frontend\n Transport; Wed, 17 Nov 2021 12:34:33 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT048.mail.protection.outlook.com (10.13.175.148) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4690.15 via Frontend Transport; Wed, 17 Nov 2021 12:34:32 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 17 Nov\n 2021 12:34:31 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FUsyOwobnH1V+i4bi2VMNUtCCFDx1ObtRdy0Ade/xe6RNfVqGYXflK2CluHv9BKglpKqMTrUbxxohGdKsfsR7CC5FBdSbMBYOewxAm8LyWzZi96d7vETUPTb8TYEla93nRHfrRqkPtQjpAYB72OmZZEkSTCJET1CyDOCOvsFSQ1k5K1lwn6m5/gB4zgCR5edGqjbTZbnAC8LNMDwOGLtAfUQYnNfySJmy3GJx2gm2iCZIrNy+Wda1H+KtqXTpZig7R1aDs32JByv4oJwExtT4JW2NQZ7JUrLLOmPx4gmY+FZ5SnBrm2eOIDv2R8jx/u+selC9BbWhtXbMuWHOa8omg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=GdF36s9BTU7h9lqSx/HdyCBZdJlNR2jPzLvVy1RLFnM=;\n b=Li+lDRd3BsBEYBUWHF0VL5bmQR8S0dYw/CSwhbIKbaJSUotrCicHQbcEVqIDJYobBRCS2rysOgKC8sYsdZLI17s9BDTPZ30Eb4wrXdhv5ZCTVqcDFY7rsbrByTnNoC8H7wt96HAmkt0CWGeEwNS23e68Fiwo+ynbr5Do32GqK139RfzLZdlL4UM3MubV+Kb0QodAXpve0+3Zrit7Ne4eYcJX6GGxAiVngihHe3R+yISSR3U/wRwxAjF+FeuIOHfks1bdF+Q900fuOs4RaSp4NpTlSiFNF+owLboVK8DJlcKteO+x2+ztOrRWPLaed7VK0V52BpdFQatvKMsIGdr7fg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=GdF36s9BTU7h9lqSx/HdyCBZdJlNR2jPzLvVy1RLFnM=;\n b=j0VB5KIuA+pyz7MZgBv4bHmiE9GXbsk8Pl5SDngr7CLcm5ama/Ruyz/+27cYPFUGPPLMJKrn4Jizg3AAxaNz74gOX1+TN+MJmay/D0Y2028hVdBbCPljkFX175Qd6K6WyjWJYwPZvt+0nqO+g4+AEgOiNwuIxCxBwm0AOIs59fx/IemaouxODvcU98Js7M+wRDKnAwZp7pH5rz1v4dcqCTh3PZNvuIt8fHN5BkEwFcDv+KPNj/tPW1+HtUJUGDfekepMLcEAbv4XqsTnXWYLLFhC31oyMTMtBx8uAYEebJk1F7BMF+yeQMxUMnsQTqJ68WkMNj7rY5UqrFIQSLKKsA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "<eagostini@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Elena Agostini <eagostini@nvidia.com>", "Subject": "[PATCH v1] app/test-gpudev: remove memory leaks in case of errors", "Date": "Wed, 17 Nov 2021 20:44:53 +0000", "Message-ID": "<20211117204453.27337-1-eagostini@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "daba7f77-34fc-4d64-85d0-08d9a9c69b6b", "X-MS-TrafficTypeDiagnostic": "CY4PR12MB1861:", "X-Microsoft-Antispam-PRVS": "\n <CY4PR12MB186197CAE85F9B629F4C1473CD9A9@CY4PR12MB1861.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:82;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n NL3kcFHGNnpFwg/StxjlZYAgY36AbnLcBhfNb10VBkGi6zbt2wYdkmY1HRNetPogVTdZ4jRUVl8/5tLUClTGNraO4XvWdRUKiOrtDf3+PNZZNhrWwGp4jz4xil221U9meTjlrG5HLeaFNhhZT3RgYNdSI0mY7ldd3OW3zuED1hkO7YM3C4maY99yhD9+rjX942QT8t8q34pn+pF8YqoEhfdGZPpdoY/6hYh1X4KAZIiA3TJtYyYKt+wf47W1mIaH7i/FFrMy4pDWYTeK2rmwNyF0HYPFMjeTXFcMN5BzNO4FrdArk+1+R7QSbnILy8/X3GM5IiosD5kFnKsQRapkcHPCLCgtNm2WMt2tnfahiVFxO/74NTJ3dg02Bcl2YkR3bSx/yTFPCxMvRZiQiyKkHvqa081bUJsuUU8uEahIr/cAUNVT2hGF1IAlte805YC6BDjCLoVGhaU88DfgITD8x/VM1Oi0cKBtnBoccjtjRtj+S/lI1VwIg8C6C34qesQym+Ni9HKkp3dUm0+PL293cCuSfyEhJCjT7vvd7hP4TO4rNW9VZXILJFaPdF6KsjUQfpaouNCS/qZsVb+DvF/qrljLFZz7kEcqvs08IFDlVElLUSEu5EN/5kWNZ/NblQ0YkJYy2fl2mSIR11+mnA+iTTs2iqchsg5fh1ayPFLzmP3gQzLMMxlqjDZaWtX7keuRVIEZYCAqn5y51fkt4Vs5+w==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(356005)(26005)(6916009)(2906002)(83380400001)(6666004)(4326008)(7636003)(47076005)(86362001)(2876002)(1076003)(8936002)(8676002)(508600001)(82310400003)(2616005)(5660300002)(70586007)(426003)(36906005)(7696005)(186003)(107886003)(55016002)(70206006)(336012)(16526019)(6286002)(316002)(36860700001)(36756003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Nov 2021 12:34:32.4600 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n daba7f77-34fc-4d64-85d0-08d9a9c69b6b", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT048.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR12MB1861", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Elena Agostini <eagostini@nvidia.com>\n\nSigned-off-by: Elena Agostini <eagostini@nvidia.com>\n---\n app/test-gpudev/main.c | 41 ++++++++++++++++++++++++++++-------------\n 1 file changed, 28 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c\nindex c647e30de4..fe5c1e5b15 100644\n--- a/app/test-gpudev/main.c\n+++ b/app/test-gpudev/main.c\n@@ -70,7 +70,7 @@ alloc_gpu_memory(uint16_t gpu_id)\n \tsize_t buf_bytes = 1024;\n \tint ret;\n \n-\tprintf(\"\\n=======> TEST: Allocate GPU memory\\n\\n\");\n+\tprintf(\"\\nTEST: Allocate GPU memory\\n\\n\");\n \n \t/* Alloc memory on GPU 0 */\n \tptr_1 = rte_gpu_mem_alloc(gpu_id, buf_bytes);\n@@ -113,11 +113,18 @@ alloc_gpu_memory(uint16_t gpu_id)\n \t}\n \tprintf(\"GPU memory 0x%p freed\\n\", ptr_1);\n \n-\tprintf(\"\\n=======> TEST: PASSED\\n\");\n+\tprintf(\"\\nTEST: PASSED\\n\");\n \treturn 0;\n \n error:\n-\tprintf(\"\\n=======> TEST: FAILED\\n\");\n+\n+\tif (ptr_1 != NULL)\n+\t\trte_gpu_mem_free(gpu_id, ptr_1);\n+\n+\tif (ptr_2 != NULL)\n+\t\trte_gpu_mem_free(gpu_id, ptr_2);\n+\n+\tprintf(\"\\nTEST: FAILED\\n\");\n \treturn -1;\n }\n \n@@ -128,7 +135,7 @@ register_cpu_memory(uint16_t gpu_id)\n \tsize_t buf_bytes = 1024;\n \tint ret;\n \n-\tprintf(\"\\n=======> TEST: Register CPU memory\\n\\n\");\n+\tprintf(\"\\nTEST: Register CPU memory\\n\\n\");\n \n \t/* Alloc memory on CPU visible from GPU 0 */\n \tptr = rte_zmalloc(NULL, buf_bytes, 0);\n@@ -161,11 +168,15 @@ register_cpu_memory(uint16_t gpu_id)\n \t}\n \tprintf(\"CPU memory 0x%p unregistered\\n\", ptr);\n \n-\tprintf(\"\\n=======> TEST: PASSED\\n\");\n+\tprintf(\"\\nTEST: PASSED\\n\");\n \treturn 0;\n \n error:\n-\tprintf(\"\\n=======> TEST: FAILED\\n\");\n+\n+\tif (ptr != NULL)\n+\t\trte_gpu_mem_unregister(gpu_id, ptr);\n+\n+\tprintf(\"\\nTEST: FAILED\\n\");\n \treturn -1;\n }\n \n@@ -177,7 +188,7 @@ create_update_comm_flag(uint16_t gpu_id)\n \tuint32_t set_val;\n \tuint32_t get_val;\n \n-\tprintf(\"\\n=======> TEST: Communication flag\\n\\n\");\n+\tprintf(\"\\nTEST: Communication flag\\n\\n\");\n \n \tret = rte_gpu_comm_create_flag(gpu_id, &devflag, RTE_GPU_COMM_FLAG_CPU);\n \tif (ret < 0) {\n@@ -223,11 +234,13 @@ create_update_comm_flag(uint16_t gpu_id)\n \t\tgoto error;\n \t}\n \n-\tprintf(\"\\n=======> TEST: PASSED\\n\");\n+\tprintf(\"\\nTEST: PASSED\\n\");\n \treturn 0;\n \n error:\n-\tprintf(\"\\n=======> TEST: FAILED\\n\");\n+\n+\trte_gpu_comm_destroy_flag(&devflag);\n+\tprintf(\"\\nTEST: FAILED\\n\");\n \treturn -1;\n }\n \n@@ -254,11 +267,11 @@ create_update_comm_list(uint16_t gpu_id)\n {\n \tint ret = 0;\n \tint i = 0;\n-\tstruct rte_gpu_comm_list *comm_list;\n+\tstruct rte_gpu_comm_list *comm_list = NULL;\n \tuint32_t num_comm_items = 1024;\n \tstruct rte_mbuf *mbufs[10];\n \n-\tprintf(\"\\n=======> TEST: Communication list\\n\\n\");\n+\tprintf(\"\\nTEST: Communication list\\n\\n\");\n \n \tcomm_list = rte_gpu_comm_create_list(gpu_id, num_comm_items);\n \tif (comm_list == NULL) {\n@@ -323,11 +336,13 @@ create_update_comm_list(uint16_t gpu_id)\n \tfor (i = 0; i < 10; i++)\n \t\trte_free(mbufs[i]);\n \n-\tprintf(\"\\n=======> TEST: PASSED\\n\");\n+\tprintf(\"\\nTEST: PASSED\\n\");\n \treturn 0;\n \n error:\n-\tprintf(\"\\n=======> TEST: FAILED\\n\");\n+\n+\trte_gpu_comm_destroy_list(comm_list, num_comm_items);\n+\tprintf(\"\\nTEST: FAILED\\n\");\n \treturn -1;\n }\n \n", "prefixes": [ "v1" ] }