Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104481/?format=api
{ "id": 104481, "url": "http://patchwork.dpdk.org/api/patches/104481/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211117154605.112390-1-dsosnowski@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211117154605.112390-1-dsosnowski@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211117154605.112390-1-dsosnowski@nvidia.com", "date": "2021-11-17T15:46:05", "name": "net/mlx5: fix refcount on detached indirect action", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ae8bc512f846a970cf4fccb41873d5aea8b17332", "submitter": { "id": 2386, "url": "http://patchwork.dpdk.org/api/people/2386/?format=api", "name": "Dariusz Sosnowski", "email": "dsosnowski@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211117154605.112390-1-dsosnowski@nvidia.com/mbox/", "series": [ { "id": 20625, "url": "http://patchwork.dpdk.org/api/series/20625/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20625", "date": "2021-11-17T15:46:05", "name": "net/mlx5: fix refcount on detached indirect action", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20625/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104481/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104481/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 48E5DA0C41;\n\tWed, 17 Nov 2021 16:48:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 44F8040687;\n\tWed, 17 Nov 2021 16:48:24 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2056.outbound.protection.outlook.com [40.107.92.56])\n by mails.dpdk.org (Postfix) with ESMTP id 6CBF340040\n for <dev@dpdk.org>; Wed, 17 Nov 2021 16:48:22 +0100 (CET)", "from BN9PR03CA0343.namprd03.prod.outlook.com (2603:10b6:408:f6::18)\n by DM6PR12MB3289.namprd12.prod.outlook.com (2603:10b6:5:15d::31) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19; Wed, 17 Nov\n 2021 15:48:20 +0000", "from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com\n (2603:10b6:408:f6:cafe::b6) by BN9PR03CA0343.outlook.office365.com\n (2603:10b6:408:f6::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.27 via Frontend\n Transport; Wed, 17 Nov 2021 15:48:20 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4690.15 via Frontend Transport; Wed, 17 Nov 2021 15:48:19 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 17 Nov\n 2021 15:48:14 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=AUuP8JcoX2b1Dw2HFSzD8D78PuMsf71/lSA2UbAOgFcj1n0pNX39UBXDRCD8jcgK6496tYYLWpEehbbkHow43B5LmLL5n9meJ6+gJvz3b4uCReBlPoNzJ8fwFKQRbvwxxVLRK94Kg+bU/OVlu9SU13AfrudfoyhoIsmzPKcN1sBwxzSD8FTaKXiKmp8D07UcLOTQWtqOXhfCFXbfJT70k/I3caVSoFsalPn2r0s60FDhVlJEXFoKapi0ZGx2J/uBGRCeRfCI8ePU6xjAAHgBg2UH5TJukQo+RSnshI11mbsDsFmosmxAjFhyTDcw3DuJtL9syonwbLc9GgAGR9H0eg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=vKBN2oiyf9+jon4jf+4M+USTxuVQVFdElCHp4d2t3AU=;\n b=gCKpIVuFmsi1414ng4yvMI/yrrzicGgZpYcRRrmGtGwLHOJXmMRob0dQjAIEteTdQyzuhfvGrTjUoEF8Ifpfq0FeudWAML4N+mnlv+EXcmhSzF6uCYlC1F5x5VbdwgIpD87GZHD1YtW1lHaW/RWyhFRf6M2/jNT/JWxRPZJxZlwNabCY6OFOKWBZP6VtVr2dtGU2+xX2HUgDK5yb+DIOVYWj5YD8Zf2GOYdVy4USG887Vmhxwrm7q7SwBjxduc5GKOPdfvxergLwbT8l03II1b105GqeZtMZMTBCFaobzpZYjgbhY1C+sQej3drMv32p7g/Jlhz5FEl7eOtQo3jfKA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=vKBN2oiyf9+jon4jf+4M+USTxuVQVFdElCHp4d2t3AU=;\n b=OmIV0D4bMCfYigT1nXcR84PnvgLFM+9pI9HCOT3Ujz14TkB0shnxPfpR1ziMtFO7p4Ia4zZARfMv4PZkM+fIafyr8YLxZA24RylAVhIGTXMqrY8NoNi7y2pQOUaYRpX/ZaopWlVDYiEqvQ9W6eGi/rTQ9/DB1XNO7Fmny11REpK/51s1qRV0x8vq506bZX9L2K5VevoD18n6E4VjYTOov1KC/LtKAWvhXOp33dNbVlvnftRgQXh9VBX+AzS9fWHHsRClzbg58VGI+f6bcdfXj9SlzxJ9l2JVnAKVQlsDkpLx9huDJbHtt5rvedRGVMGgs20O2mXkcArvtOP4NmxR0A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Dariusz Sosnowski <dsosnowski@nvidia.com>", "To": "Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Dmitry Kozlyuk <dkozlyuk@nvidia.com>", "CC": "<dev@dpdk.org>", "Subject": "[PATCH] net/mlx5: fix refcount on detached indirect action", "Date": "Wed, 17 Nov 2021 17:46:05 +0200", "Message-ID": "<20211117154605.112390-1-dsosnowski@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "c8d86d98-b1d7-4f06-371b-08d9a9e1ada8", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3289:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB3289455DB060B96FBBAE6DEDA49A9@DM6PR12MB3289.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1079;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n G/8Ufnw1oD+dVtxP05w7I7a5NgbfkvdyjupChyEp07fre/LGwVTZUEtgkDRsc9fAnmVDdpyDn3HfrLprwtm3DKUl/Ti+Ddnb6Rd/7c0Vy9sCy+uOTgjRgEuCfODNn13/+wkPnaIlYBtbzyiSv9ALYDRKc/vaYpYmY+spnelDgIN4JX1kOrKxHHgp5k63zRXiwNgoUwUX0e3gc43C+LY0tbSNRBhwZvcYruHeP8LqikPYGJa4o8rQFddWWOiP4lB42Zm4KNIF4Qt99yR/iWJxH8JAC8LgJgU8EoBt1k1g4yEjdSFgmgpxwFyb1WVsbpca2wr9QI2m3f3U4caTpr5JIRV6k0tJnyUfTjqCJuJqaS9NIW6OG1fCEibcEICH3BkcaaUBzDXVFLcHrTHEtEROnRty/7Jfgpl9MboftMtDQDXaIWHyT2gFU6NPS2sZLltnUAxlJvaWb4Nj7WDYXC90GL1q5PVGYOIJKpAbohh9Nmkn2Dz+5vQPjvv3FUiOaRYdm+HRbRY0yWDVIevs9/E2ktaFXishaai7HrLCOfhoiQ1IRltG8105onNuhQ7mzm32dV72b2+zlne+Kl54uRDtJz3WjNDgfA8MHPphZKVvS9FWQ4b3uuGuREfXBys6btV8ww2yzDVX6LB9ASYmRNS5tmls9dqHcw8FJZXnJr927lZfdZmNKCvfjuNUj6E9iquCDbiRAjC5JaMPGvks1gq4NQ==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(186003)(16526019)(70586007)(36860700001)(426003)(7696005)(1076003)(2906002)(82310400003)(26005)(110136005)(7636003)(508600001)(6286002)(55016002)(83380400001)(47076005)(356005)(86362001)(5660300002)(336012)(8676002)(8936002)(6636002)(70206006)(316002)(2616005)(36756003)(6666004)(4326008);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "17 Nov 2021 15:48:19.4175 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n c8d86d98-b1d7-4f06-371b-08d9a9e1ada8", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT031.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3289", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch fixes segfault which was triggered when port, with indirect\nactions created, was closed. Segfault was occurring only when\nRTE_LIBRTE_MLX5_DEBUG was defined. It was caused by redundant decrement\nof RX queues refcount:\n\n- refcount was decremented when port was stopped and indirect actions\nwere detached from RX queues (port stop),\n- refcount was decremented when indirect actions objects were destroyed\n(port close or destroying of indirect action).\n\nWith this patch RX queues refcounts are decremented if and only if\nindirect actions object is detached or indirect actions object is\ndestroyed.\n\nFixes: ec4e11d41d12 (\"net/mlx5: preserve indirect actions on restart\")\nCc: dkozlyuk@nvidia.com\n\nSigned-off-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\nAcked-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 11 +++++++++--\n 1 file changed, 9 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 52b95d7070..b7af60df38 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -2214,8 +2214,15 @@ mlx5_ind_table_obj_release(struct rte_eth_dev *dev,\n \tif (ret)\n \t\treturn 1;\n \tpriv->obj_ops.ind_table_destroy(ind_tbl);\n-\tfor (i = 0; i != ind_tbl->queues_n; ++i)\n-\t\tclaim_nonzero(mlx5_rxq_deref(dev, ind_tbl->queues[i]));\n+\t/*\n+\t * Refcounts on RX queues are decremented if and only if indirection\n+\t * table was attached to RX queues. It will not be the case after\n+\t * calling mlx5_dev_stop.\n+\t */\n+\tif (priv->dev_data->dev_started) {\n+\t\tfor (i = 0; i != ind_tbl->queues_n; ++i)\n+\t\t\tclaim_nonzero(mlx5_rxq_deref(dev, ind_tbl->queues[i]));\n+\t}\n \tmlx5_free(ind_tbl);\n \treturn 0;\n }\n", "prefixes": [] }