Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104482/?format=api
{ "id": 104482, "url": "http://patchwork.dpdk.org/api/patches/104482/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/20211117162330.25896-1-ohilyard@iol.unh.edu/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20211117162330.25896-1-ohilyard@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dts/20211117162330.25896-1-ohilyard@iol.unh.edu", "date": "2021-11-17T16:23:30", "name": "framework: Advise against using root passwords", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "51492a6d65bfd9ca2491960332a86e196826053b", "submitter": { "id": 1829, "url": "http://patchwork.dpdk.org/api/people/1829/?format=api", "name": "Owen Hilyard", "email": "ohilyard@iol.unh.edu" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/20211117162330.25896-1-ohilyard@iol.unh.edu/mbox/", "series": [ { "id": 20626, "url": "http://patchwork.dpdk.org/api/series/20626/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=20626", "date": "2021-11-17T16:23:30", "name": "framework: Advise against using root passwords", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20626/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104482/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/104482/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7745BA0C41;\n\tWed, 17 Nov 2021 17:23:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 467C940687;\n\tWed, 17 Nov 2021 17:23:42 +0100 (CET)", "from mail-vk1-f226.google.com (mail-vk1-f226.google.com\n [209.85.221.226])\n by mails.dpdk.org (Postfix) with ESMTP id 42C6D40040\n for <dts@dpdk.org>; Wed, 17 Nov 2021 17:23:41 +0100 (CET)", "by mail-vk1-f226.google.com with SMTP id b192so1995161vkf.3\n for <dts@dpdk.org>; Wed, 17 Nov 2021 08:23:41 -0800 (PST)", "from postal.iol.unh.edu (postal.iol.unh.edu. [132.177.123.84])\n by smtp-relay.gmail.com with ESMTPS id az39sm164666uab.1.2021.11.17.08.23.40\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Wed, 17 Nov 2021 08:23:40 -0800 (PST)", "from iol.unh.edu (unknown [IPv6:2606:4100:3880:1257::105d])\n by postal.iol.unh.edu (Postfix) with ESMTP id 2D55C605247D;\n Wed, 17 Nov 2021 11:23:40 -0500 (EST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu;\n s=unh-iol;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=FrBYaoELqU07SCmfAN86cOZFBUa46XMKq/BcFeHl5Cc=;\n b=FG8Nmfv0CDWRQ3f2X0G89bdOL8GZuEowevGL+EINl+niYxQ53Qxu1aXe702o7IYQ6t\n wzPCVfAxim5heRTJHs1TaxQgwKT2rbUXwRoMObhPW8JxCSI7WJhFNEgXGtDP1l5YURdF\n a4uFZDlxGA21VZ8F9LKJj8RYr7mjzUFFk1Vck=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=FrBYaoELqU07SCmfAN86cOZFBUa46XMKq/BcFeHl5Cc=;\n b=GOIx3Q8Qekhkvhz+GUCKXmhEFGTSj+OgcBk3GgvsR1D2wafzhTf0NqjCALm+9iXCRT\n PJO3aGhSAufOo3hdBbUqJLgQBu8XV4CZYvq+CdqLQjzcA8g1t3QTH6TfOz7vPaupC3+B\n tBULLuNR17xHpGsNE1l3L0XAX1yCYC0EzimSw6cuZgmuKSj7/ye6jYxyn65UaPSHiPlr\n CCxVZfT6MSvsKbcrGEDiEuT45h37hYQumPQO+DoDsoXP1YPZZMDgjiMpHefNPXaENoQ+\n 0tsu8TLl7veWup9rCnwUa8+cw2ES58rCD/QZxpoVOL1hWecGHKxLtTE2yLZUxjs1sB0C\n Dvtg==", "X-Gm-Message-State": "AOAM532cu36eD2XaMqCyigo2VcqOCtP4e3rVi/13VEO82i+uamPQQJrN\n obv7gzSXHOsD5rGptfAaGDKzqc+vZQzctjf+D0QmRWYQP1RMNcI+z8OvTe7alWn911AIyViwbQH\n fH9uP9jzKF4rnOXXP7CWWWc1++CxhUzSQd72v+Cf/j7KpZ2VVZ+1SOsKUchY2oSzQKqqrXn6oRg\n ==", "X-Google-Smtp-Source": "\n ABdhPJwU4DREISqJPOeN5K6wctTc/lmFLz9H64hw9DC17yFAFdQcmSKhADaBysghT1b9WBnTKGOimElLtau3", "X-Received": "by 2002:a05:6122:2090:: with SMTP id\n i16mr91446940vkd.18.1637166220630;\n Wed, 17 Nov 2021 08:23:40 -0800 (PST)", "X-Relaying-Domain": "iol.unh.edu", "From": "ohilyard@iol.unh.edu", "To": "dts@dpdk.org", "Cc": "lijuan.tu@intel.com,\n\tOwen Hilyard <ohilyard@iol.unh.edu>", "Subject": "[PATCH] framework: Advise against using root passwords", "Date": "Wed, 17 Nov 2021 11:23:30 -0500", "Message-Id": "<20211117162330.25896-1-ohilyard@iol.unh.edu>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "From: Owen Hilyard <ohilyard@iol.unh.edu>\n\nAdded messages to notify the user that a blank password field will use\nssh keys, and that using root passwords is insecure.\n---\n conf/crbs.cfg | 4 ++--\n tools/setup.py | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/conf/crbs.cfg b/conf/crbs.cfg\nindex b6c0a9af..a12e60a4 100644\n--- a/conf/crbs.cfg\n+++ b/conf/crbs.cfg\n@@ -2,10 +2,10 @@\n #[DUT IP]\n # dut_ip: DUT ip address\n # dut_user: Login DUT username\n-# dut_passwd: Login DUT password\n+# dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys\n # os: operation system type linux or freebsd\n # tester_ip: Tester ip address\n-# tester_passwd: Tester password\n+# tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys\n # pktgen_group: packet generator group name: ixia/trex/ixia_network\n # channels: Board channel number\n # bypass_core0: Whether by pass core0\ndiff --git a/tools/setup.py b/tools/setup.py\nindex 3873a884..c70730c7 100755\n--- a/tools/setup.py\n+++ b/tools/setup.py\n@@ -105,7 +105,7 @@ def config_crbs():\n \n passwd_option = {'prompt': 'DUT root password',\n 'type': 'string',\n- 'help': 'Please input password of DUT crb',\n+ 'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',\n 'default': ''}\n opt = Option(**passwd_option)\n dut_pass = opt.parse_input()\n@@ -120,7 +120,7 @@ def config_crbs():\n \n passwd_option = {'prompt': 'Tester root password',\n 'type': 'string',\n- 'help': 'Please input password of Tester crb',\n+ 'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',\n 'default': ''}\n opt = Option(**passwd_option)\n tester_pass = opt.parse_input()\n", "prefixes": [] }