Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104524/?format=api
{ "id": 104524, "url": "http://patchwork.dpdk.org/api/patches/104524/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211119035041.4493-1-somnath.kotur@broadcom.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211119035041.4493-1-somnath.kotur@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211119035041.4493-1-somnath.kotur@broadcom.com", "date": "2021-11-19T03:50:41", "name": "net/bnxt: fix crash caused by error recovery", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3edb89caba94e1cd5fe50fec5a4bf672f2c684f8", "submitter": { "id": 908, "url": "http://patchwork.dpdk.org/api/people/908/?format=api", "name": "Somnath Kotur", "email": "somnath.kotur@broadcom.com" }, "delegate": { "id": 1766, "url": "http://patchwork.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211119035041.4493-1-somnath.kotur@broadcom.com/mbox/", "series": [ { "id": 20653, "url": "http://patchwork.dpdk.org/api/series/20653/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20653", "date": "2021-11-19T03:50:41", "name": "net/bnxt: fix crash caused by error recovery", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20653/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104524/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104524/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6EB79A0C47;\n\tFri, 19 Nov 2021 04:57:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB67B40143;\n\tFri, 19 Nov 2021 04:57:11 +0100 (CET)", "from relay.smtp-ext.broadcom.com (relay.smtp-ext.broadcom.com\n [192.19.166.231])\n by mails.dpdk.org (Postfix) with ESMTP id 828D040140\n for <dev@dpdk.org>; Fri, 19 Nov 2021 04:57:10 +0100 (CET)", "from dhcp-10-123-153-55.dhcp.broadcom.net\n (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55])\n (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by relay.smtp-ext.broadcom.com (Postfix) with ESMTPS id 932D7A2;\n Thu, 18 Nov 2021 19:57:08 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 relay.smtp-ext.broadcom.com 932D7A2", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com;\n s=dkimrelay; t=1637294229;\n bh=WcS2/Imq+/zKaSEvL/KH9/U4SmLEZ2HCzIlKVdtybMI=;\n h=From:To:Cc:Subject:Date:From;\n b=GDKFnUw3gnlK3kY2r01rrx840Kt6OMhb/IWKmnFTJeCK2SoLeDYqt2y7pn9AYwL+g\n CNv2tWADdtEGyJ0BRi8Nglkg2hissFsA1L/mJeE4d0C16WLPHfHsoP3ij3lUtZzlx7\n zdeT6m0hvvRccM13+ARqqWBzQfMI9jvyVR/0mp70=", "From": "Somnath Kotur <somnath.kotur@broadcom.com>", "To": "dev@dpdk.org", "Cc": "ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>", "Subject": "[PATCH] net/bnxt: fix crash caused by error recovery", "Date": "Fri, 19 Nov 2021 09:20:41 +0530", "Message-Id": "<20211119035041.4493-1-somnath.kotur@broadcom.com>", "X-Mailer": "git-send-email 2.28.0.450.g3a238e5", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "bnxt_stop_rxtx() does not stop data path processing as intended\nas it does not update the recently introduced fast-path pointers\n'(struct rte_eth_fp_ops)->rx_pkt_burst'. Since both the burst routines\nonly use the fast-path pointer, the real burst routines get invoked\ninstead of the dummy ones set by bnxt_stop_rxtx() leading to crashes\nin the data path (e.g. dereferencing freed structures)\n\nFix the segfault by updating the fast-path pointer as well\n\nFixes: c87d435a4d79 (\"ethdev: copy fast-path API into separate structure\")\n\nSigned-off-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\n---\n drivers/net/bnxt/bnxt_cpr.c | 9 +++++++++\n drivers/net/bnxt/bnxt_ethdev.c | 7 ++++++-\n 2 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt_cpr.c b/drivers/net/bnxt/bnxt_cpr.c\nindex 6bb70d516e..a43b22a8f8 100644\n--- a/drivers/net/bnxt/bnxt_cpr.c\n+++ b/drivers/net/bnxt/bnxt_cpr.c\n@@ -387,4 +387,13 @@ void bnxt_stop_rxtx(struct bnxt *bp)\n {\n \tbp->eth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts;\n \tbp->eth_dev->tx_pkt_burst = &bnxt_dummy_xmit_pkts;\n+\n+\trte_eth_fp_ops[bp->eth_dev->data->port_id].rx_pkt_burst =\n+\t\tbp->eth_dev->rx_pkt_burst;\n+\trte_eth_fp_ops[bp->eth_dev->data->port_id].tx_pkt_burst =\n+\t\tbp->eth_dev->tx_pkt_burst;\n+\trte_mb();\n+\n+\t/* Allow time for threads to exit the real burst functions. */\n+\trte_delay_ms(100);\n }\ndiff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c\nindex 4413b5d72e..c1bdf9a921 100644\n--- a/drivers/net/bnxt/bnxt_ethdev.c\n+++ b/drivers/net/bnxt/bnxt_ethdev.c\n@@ -4323,6 +4323,8 @@ static void bnxt_dev_recover(void *arg)\n \n \t/* Clear Error flag so that device re-init should happen */\n \tbp->flags &= ~BNXT_FLAG_FATAL_ERROR;\n+\tPMD_DRV_LOG(INFO, \"Port: %u Starting recovery...\\n\",\n+\t\t bp->eth_dev->data->port_id);\n \n \trc = bnxt_check_fw_ready(bp);\n \tif (rc)\n@@ -4347,7 +4349,8 @@ static void bnxt_dev_recover(void *arg)\n \tif (rc)\n \t\tgoto err_start;\n \n-\tPMD_DRV_LOG(INFO, \"Recovered from FW reset\\n\");\n+\tPMD_DRV_LOG(INFO, \"Port: %u Recovered from FW reset\\n\",\n+\t\t bp->eth_dev->data->port_id);\n \tpthread_mutex_unlock(&bp->err_recovery_lock);\n \n \treturn;\n@@ -4372,6 +4375,8 @@ void bnxt_dev_reset_and_resume(void *arg)\n \tint rc;\n \n \tbnxt_dev_cleanup(bp);\n+\tPMD_DRV_LOG(INFO, \"Port: %u Finished bnxt_dev_cleanup\\n\",\n+\t\t bp->eth_dev->data->port_id);\n \n \tbnxt_wait_for_device_shutdown(bp);\n \n", "prefixes": [] }