Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104548/?format=api
{ "id": 104548, "url": "http://patchwork.dpdk.org/api/patches/104548/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/1637562295-14806-1-git-send-email-yux.jiang@intel.com/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1637562295-14806-1-git-send-email-yux.jiang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dts/1637562295-14806-1-git-send-email-yux.jiang@intel.com", "date": "2021-11-22T06:24:55", "name": "[V1] Optimize script: wait_link_status_up after start testpmd", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "f66dced52059f8580213865f414f194120a6463a", "submitter": { "id": 1709, "url": "http://patchwork.dpdk.org/api/people/1709/?format=api", "name": "Yu Jiang", "email": "yux.jiang@intel.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/1637562295-14806-1-git-send-email-yux.jiang@intel.com/mbox/", "series": [ { "id": 20674, "url": "http://patchwork.dpdk.org/api/series/20674/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=20674", "date": "2021-11-22T06:24:55", "name": "[V1] Optimize script: wait_link_status_up after start testpmd", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20674/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104548/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104548/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B8375A0C45;\n\tMon, 22 Nov 2021 07:25:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7ADB34014E;\n\tMon, 22 Nov 2021 07:25:20 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 722844003C\n for <dts@dpdk.org>; Mon, 22 Nov 2021 07:25:18 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Nov 2021 22:25:17 -0800", "from unknown (HELO localhost.localdomain) ([10.240.183.163])\n by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-SHA;\n 21 Nov 2021 22:25:15 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10175\"; a=\"298143258\"", "E=Sophos;i=\"5.87,254,1631602800\"; d=\"scan'208\";a=\"298143258\"", "E=Sophos;i=\"5.87,254,1631602800\"; d=\"scan'208\";a=\"456529932\"" ], "From": "Yu Jiang <yux.jiang@intel.com>", "To": "xueqin.lin@intel.com,\n\tdts@dpdk.org", "Cc": "Yu Jiang <yux.jiang@intel.com>", "Subject": "[dts][PATCH V1] Optimize script: wait_link_status_up after start\n testpmd", "Date": "Mon, 22 Nov 2021 14:24:55 +0800", "Message-Id": "<1637562295-14806-1-git-send-email-yux.jiang@intel.com>", "X-Mailer": "git-send-email 2.7.4", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "optimize script: ddp_gtp_qregion&dual_vlan&external_memory&link_flowctrl&mtu_update&qos_api&scatter\nwait_link_status_up after start testpmd or before send_packets to enhance script robustness\n\nSigned-off-by: Yu Jiang <yux.jiang@intel.com>\n---\n tests/TestSuite_ddp_gtp_qregion.py | 2 ++\n tests/TestSuite_dual_vlan.py | 31 ++++++-------------------------\n tests/TestSuite_external_memory.py | 4 +++-\n tests/TestSuite_link_flowctrl.py | 5 ++++-\n tests/TestSuite_mtu_update.py | 1 +\n tests/TestSuite_qos_api.py | 3 ++-\n tests/TestSuite_scatter.py | 1 +\n 7 files changed, 19 insertions(+), 28 deletions(-)", "diff": "diff --git a/tests/TestSuite_ddp_gtp_qregion.py b/tests/TestSuite_ddp_gtp_qregion.py\nindex e870db3..1fbb05c 100644\n--- a/tests/TestSuite_ddp_gtp_qregion.py\n+++ b/tests/TestSuite_ddp_gtp_qregion.py\n@@ -322,6 +322,7 @@ class TestDdpGtpQregion(TestCase):\n self.dut_testpmd.execute_cmd('set fwd rxonly')\n self.dut_testpmd.execute_cmd('set verbose 1')\n self.dut_testpmd.execute_cmd('start')\n+ self.dut_testpmd.wait_link_status_up(self.dut_ports[0])\n qnum = self.send_verify_fd(flowtype, keywords, 'word_opt')\n self.verify(qnum == 0, \"Receive packet from wrong queue!!!\")\n self.raw_packet_generate(flowtype)\n@@ -385,6 +386,7 @@ class TestDdpGtpQregion(TestCase):\n self.dut_testpmd.execute_cmd('set fwd rxonly')\n self.dut_testpmd.execute_cmd('set verbose 1')\n self.dut_testpmd.execute_cmd('start')\n+ self.dut_testpmd.wait_link_status_up(self.dut_ports[0])\n self.send_and_verify(flowtype, qmin, qmax, keyword)\n \n def test_outer_dst_contrl_gtpcq(self):\ndiff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py\nindex 0f9247f..f7dbcf6 100644\n--- a/tests/TestSuite_dual_vlan.py\n+++ b/tests/TestSuite_dual_vlan.py\n@@ -87,18 +87,14 @@ class TestDualVlan(TestCase):\n global dutTxPortId\n \n # Based on h/w type, choose how many ports to use\n- ports = self.dut.get_ports(self.nic)\n- self.verify(len(ports) >= 2, \"Insufficient ports\")\n- self.ports_socket = self.dut.get_numa_id(ports[0])\n+ self.dut_ports = self.dut.get_ports(self.nic)\n+ self.verify(len(self.dut_ports) >= 2, \"Insufficient ports\")\n+ self.ports_socket = self.dut.get_numa_id(self.dut_ports[0])\n \n cores = self.dut.get_core_list('1S/2C/2T')\n coreMask = utils.create_mask(cores)\n-\n- ports = self.dut.get_ports(self.nic)\n- valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]\n-\n+ valports = [_ for _ in self.dut_ports if self.tester.get_local_port(_) != -1]\n portMask = utils.create_mask(valports[:2])\n-\n dutRxPortId = valports[0]\n dutTxPortId = valports[1]\n \n@@ -141,7 +137,8 @@ class TestDualVlan(TestCase):\n vlanString += 'IP(len=46)],iface=\"%s\", count=4)' % txItf\n \n self.tester.scapy_append(vlanString)\n-\n+ # check link status before send pkg\n+ self.pmdout.wait_link_status_up(self.dut_ports[0])\n self.tester.scapy_execute()\n \n def mode_config(self, **modeName):\n@@ -185,17 +182,6 @@ class TestDualVlan(TestCase):\n else:\n self.verify(\"%s %s\" % (mode, modeName[mode]) in out, \"%s setting error\" % mode)\n \n- def verify_link_up(self):\n- ports = self.dut.get_ports(self.nic)\n- for port_id in range(len(ports)):\n- out = self.dut.send_expect(\"show port info %s\" % port_id, \"testpmd> \")\n- port_time_up = 0\n- while (port_time_up <= 10) and (\"Link status: down\" in out):\n- time.sleep(1)\n- out = self.dut.send_expect(\"show port info %s\" % port_id, \"testpmd> \")\n- port_time_up += 1\n- self.verify(\"Link status: down\" not in out, \"Port %s Link down, please check your link\" % port_id)\n-\n def multimode_test(self, caseIndex):\n \"\"\"\n Setup Strip/Filter/Extend/Insert enable/disable for synthetic test.\n@@ -217,7 +203,6 @@ class TestDualVlan(TestCase):\n self.dut.send_expect('tx_vlan set %s %s' % (dutTxPortId, txvlan), \"testpmd> \")\n self.dut.send_expect('port start all', \"testpmd> \")\n self.dut.send_expect('start', \"testpmd> \")\n- self.verify_link_up()\n \n configMode = \"Strip %s, filter %s 0x1, extend %s, insert %s\" % (temp[0], temp[1], temp[2], \"on\" if (caseDef & txCase) != 0 else \"off\")\n \n@@ -236,7 +221,6 @@ class TestDualVlan(TestCase):\n self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, \"testpmd> \")\n self.dut.send_expect('port start all', \"testpmd> \")\n self.dut.send_expect('start', \"testpmd> \")\n- self.verify_link_up()\n \n else:\n self.dut.send_expect('rx_vlan add %s %s' % (invlan, dutRxPortId), \"testpmd> \")\n@@ -249,7 +233,6 @@ class TestDualVlan(TestCase):\n self.dut.send_expect('tx_vlan reset %s' % dutTxPortId, \"testpmd> \")\n self.dut.send_expect('port start all', \"testpmd> \")\n self.dut.send_expect('start', \"testpmd> \")\n- self.verify_link_up()\n self.dut.send_expect('rx_vlan rm %s %s' % (invlan, dutRxPortId), \"testpmd> \")\n self.dut.send_expect('rx_vlan rm %s %s' % (outvlan, dutRxPortId), \"testpmd> \")\n \n@@ -378,7 +361,6 @@ class TestDualVlan(TestCase):\n self.dut.send_expect(\"tx_vlan set %s %s\" % (dutTxPortId, txvlan), \"testpmd> \")\n self.dut.send_expect(\"port start all\", \"testpmd> \")\n self.dut.send_expect(\"start\", \"testpmd> \")\n- self.verify_link_up()\n \n self.vlan_send_packet()\n out = self.get_tcpdump_package()\n@@ -389,7 +371,6 @@ class TestDualVlan(TestCase):\n self.dut.send_expect(\"tx_vlan reset %s\" % dutTxPortId, \"testpmd> \")\n self.dut.send_expect(\"port start all\", \"testpmd> \")\n self.dut.send_expect(\"start\", \"testpmd> \")\n- self.verify_link_up()\n \n self.vlan_send_packet()\n out = self.get_tcpdump_package()\ndiff --git a/tests/TestSuite_external_memory.py b/tests/TestSuite_external_memory.py\nindex f68a9a6..2f862fa 100644\n--- a/tests/TestSuite_external_memory.py\n+++ b/tests/TestSuite_external_memory.py\n@@ -40,6 +40,7 @@ import time\n \n import framework.utils as utils\n from framework.test_case import TestCase\n+from framework.pmd_output import PmdOutput\n \n \n class TestExternalMemory(TestCase):\n@@ -49,7 +50,7 @@ class TestExternalMemory(TestCase):\n \"\"\"\n self.dut_ports = self.dut.get_ports(self.nic)\n self.verify(len(self.dut_ports) >= 2, \"Insufficient ports\")\n-\n+ self.pmdout = PmdOutput(self.dut)\n self.app_testpmd_path = self.dut.apps_name['test-pmd']\n \n def set_up(self):\n@@ -134,6 +135,7 @@ class TestExternalMemory(TestCase):\n \n def verifier_result(self):\n self.dut.send_expect(\"start\", \"testpmd>\",10)\n+ self.pmdout.wait_link_status_up(self.dut_ports[0])\n self.scapy_send_packet(20)\n out = self.dut.send_expect(\"stop\", \"testpmd>\", 10)\n \ndiff --git a/tests/TestSuite_link_flowctrl.py b/tests/TestSuite_link_flowctrl.py\nindex a102288..96ba231 100644\n--- a/tests/TestSuite_link_flowctrl.py\n+++ b/tests/TestSuite_link_flowctrl.py\n@@ -134,6 +134,7 @@ class TestLinkFlowctrl(TestCase):\n \n self.dut.send_expect(\"set fwd csum\", \"testpmd> \")\n self.dut.send_expect(\"start\", \"testpmd> \", 60)\n+ self.pmdout.wait_link_status_up(self.dutPorts[0])\n \n def pause_frame_loss_test(self, rx_flow_control='off',\n tx_flow_control='off',\n@@ -171,6 +172,7 @@ class TestLinkFlowctrl(TestCase):\n return port_stats\n \n def send_packets(self, frame):\n+ self.pmdout.wait_link_status_up(self.dutPorts[0])\n tester_tx_port = self.tester.get_local_port(self.rx_port)\n tx_interface = self.tester.get_interface(tester_tx_port)\n tester_rx_port = self.tester.get_local_port(self.tx_port)\n@@ -530,7 +532,7 @@ class TestLinkFlowctrl(TestCase):\n self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n self.dut.send_expect(\"port start 0\", \"testpmd> \", 60)\n self.dut.send_expect(\"start\", \"testpmd> \", 60)\n-\n+ self.pmdout.wait_link_status_up(self.dutPorts[0])\n tgenInput = self.get_tgen_input()\n result = self.start_traffic(tgenInput)\n self.logger.info(\"Packet loss: %.3f\" % result)\n@@ -555,6 +557,7 @@ class TestLinkFlowctrl(TestCase):\n self.dut.send_expect(\"port stop 0\", \"testpmd> \")\n self.dut.send_expect(\"port start 0\", \"testpmd> \", 60)\n self.dut.send_expect(\"start\", \"testpmd> \", 60)\n+ self.pmdout.wait_link_status_up(self.dutPorts[0])\n result = self.start_traffic(tgenInput)\n self.logger.info(\"Packet loss: %.3f\" % result)\n if self.nic == \"niantic\":\ndiff --git a/tests/TestSuite_mtu_update.py b/tests/TestSuite_mtu_update.py\nindex ad13a8a..f16eb8e 100644\n--- a/tests/TestSuite_mtu_update.py\n+++ b/tests/TestSuite_mtu_update.py\n@@ -235,6 +235,7 @@ class TestMtuUpdate(TestCase):\n self.exec(\"port start all\")\n self.exec(\"set fwd mac\")\n self.exec(\"start\")\n+ self.pmdout.wait_link_status_up(self.dut_ports[0])\n \"\"\"\n On 1G NICs, when the jubmo frame MTU set > 1500, the software adjust it to MTU+4.\n \"\"\"\ndiff --git a/tests/TestSuite_qos_api.py b/tests/TestSuite_qos_api.py\nindex 70b3d0d..82c4d0e 100644\n--- a/tests/TestSuite_qos_api.py\n+++ b/tests/TestSuite_qos_api.py\n@@ -120,6 +120,7 @@ class TestQosApi(TestCase):\n self.dut.send_expect('port start all', 'testpmd> ')\n \n def scapy_send_packet_verify(self, n):\n+ self.host_testpmd.wait_link_status_up(self.dut_ports[0])\n self.tester.scapy_foreground()\n dmac = self.dut.get_mac_address(P0)\n queues_4tc = [0, 32, 64, 96]\n@@ -220,7 +221,7 @@ class TestQosApi(TestCase):\n self.perf_test(n)\n \n def perf_test(self, n):\n-\n+ self.host_testpmd.wait_link_status_up(self.dut_ports[0])\n dmac = self.dut.get_mac_address(self.dut_ports[0])\n pkts = []\n for i in range(n):\ndiff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py\nindex 85312c5..499c0ab 100644\n--- a/tests/TestSuite_scatter.py\n+++ b/tests/TestSuite_scatter.py\n@@ -110,6 +110,7 @@ class TestScatter(TestCase):\n \n self.dut.send_expect(\"set fwd mac\", \"testpmd> \", 120)\n self.dut.send_expect(\"start\", \"testpmd> \")\n+ self.pmdout.wait_link_status_up(self.port)\n \n for offset in [-1, 0, 1, 4, 5]:\n ret = self.scatter_pktgen_send_packet(self.mbsize + offset)\n", "prefixes": [ "V1" ] }