Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104549/?format=api
{ "id": 104549, "url": "http://patchwork.dpdk.org/api/patches/104549/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211122073122.10052-1-vanshika.shukla@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211122073122.10052-1-vanshika.shukla@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211122073122.10052-1-vanshika.shukla@nxp.com", "date": "2021-11-22T07:31:22", "name": "[v2] examples/ptpclient: fix delay request message", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "71c8d103218208eb26e4125fefbd118c2dd14db7", "submitter": { "id": 2422, "url": "http://patchwork.dpdk.org/api/people/2422/?format=api", "name": null, "email": "vanshika.shukla@nxp.com" }, "delegate": { "id": 24651, "url": "http://patchwork.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211122073122.10052-1-vanshika.shukla@nxp.com/mbox/", "series": [ { "id": 20675, "url": "http://patchwork.dpdk.org/api/series/20675/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20675", "date": "2021-11-22T07:31:22", "name": "[v2] examples/ptpclient: fix delay request message", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20675/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104549/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/104549/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E0F02A0C45;\n\tMon, 22 Nov 2021 08:31:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5F0BA4014E;\n\tMon, 22 Nov 2021 08:31:25 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by mails.dpdk.org (Postfix) with ESMTP id E8D584003C;\n Mon, 22 Nov 2021 08:31:24 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id BC226203D17;\n Mon, 22 Nov 2021 08:31:24 +0100 (CET)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8441B200256;\n Mon, 22 Nov 2021 08:31:24 +0100 (CET)", "from lsv03379.swis.in-blr01.nxp.com (lsv03379.swis.in-blr01.nxp.com\n [92.120.147.188])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 8A372183AC4E;\n Mon, 22 Nov 2021 15:31:23 +0800 (+08)" ], "From": "vanshika.shukla@nxp.com", "To": "dev@dpdk.org,\n\tthomas@monjalon.net", "Cc": "nipun.gupta@nxp.com, david.marchand@redhat.com, stable@dpdk.org,\n Vanshika Shukla <vanshika.shukla@nxp.com>", "Subject": "[PATCH v2] examples/ptpclient: fix delay request message", "Date": "Mon, 22 Nov 2021 13:01:22 +0530", "Message-Id": "<20211122073122.10052-1-vanshika.shukla@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211117061853.20979-1-vanshika.shukla@nxp.com>", "References": "<20211117061853.20979-1-vanshika.shukla@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Vanshika Shukla <vanshika.shukla@nxp.com>\n\nThe size of delay request message sent out by the DPDK\nptpclient application was observed to have extra length\nthan expected. Due to this, bad messages were observed\non the master side and delay response was not received.\nThis patch fixes this bug.\n\nFixes: ab129e9065a5 (\"examples/ptpclient: add minimal PTP client\")\nCc: stable@dpdk.org\n\nSigned-off-by: Vanshika Shukla <vanshika.shukla@nxp.com>\n---\nChanges in v2:\n - Added a check on available size in allocated buffer\n - Created the right type of pointer when sending DELAY_REQ packet\n\n examples/ptpclient/ptpclient.c | 32 +++++++++++++++++++-------------\n 1 file changed, 19 insertions(+), 13 deletions(-)", "diff": "diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c\nindex 354c7b2c90..de799f698b 100644\n--- a/examples/ptpclient/ptpclient.c\n+++ b/examples/ptpclient/ptpclient.c\n@@ -386,6 +386,7 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \tstruct ptp_header *ptp_hdr;\n \tstruct clock_id *client_clkid;\n \tstruct ptp_message *ptp_msg;\n+\tstruct delay_req_msg *req_msg;\n \tstruct rte_mbuf *created_pkt;\n \tstruct tstamp *origin_tstamp;\n \tstruct rte_ether_addr eth_multicast = ether_multicast;\n@@ -423,7 +424,12 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \n \t\tcreated_pkt = rte_pktmbuf_alloc(mbuf_pool);\n \t\tpkt_size = sizeof(struct rte_ether_hdr) +\n-\t\t\tsizeof(struct ptp_message);\n+\t\t\tsizeof(struct delay_req_msg);\n+\n+\t\tif (rte_pktmbuf_append(created_pkt, pkt_size) == NULL) {\n+\t\t\trte_pktmbuf_free(created_pkt);\n+\t\t\treturn;\n+\t\t}\n \t\tcreated_pkt->data_len = pkt_size;\n \t\tcreated_pkt->pkt_len = pkt_size;\n \t\teth_hdr = rte_pktmbuf_mtod(created_pkt, struct rte_ether_hdr *);\n@@ -433,22 +439,22 @@ parse_fup(struct ptpv2_data_slave_ordinary *ptp_data)\n \t\trte_ether_addr_copy(ð_multicast, ð_hdr->dst_addr);\n \n \t\teth_hdr->ether_type = htons(PTP_PROTOCOL);\n-\t\tptp_msg = (struct ptp_message *)\n-\t\t\t(rte_pktmbuf_mtod(created_pkt, char *) +\n-\t\t\tsizeof(struct rte_ether_hdr));\n-\n-\t\tptp_msg->delay_req.hdr.seq_id = htons(ptp_data->seqID_SYNC);\n-\t\tptp_msg->delay_req.hdr.msg_type = DELAY_REQ;\n-\t\tptp_msg->delay_req.hdr.ver = 2;\n-\t\tptp_msg->delay_req.hdr.control = 1;\n-\t\tptp_msg->delay_req.hdr.log_message_interval = 127;\n-\t\tptp_msg->delay_req.hdr.message_length =\n+\t\treq_msg = rte_pktmbuf_mtod_offset(created_pkt,\n+\t\t\tstruct delay_req_msg *, sizeof(struct\n+\t\t\trte_ether_hdr));\n+\n+\t\treq_msg->hdr.seq_id = htons(ptp_data->seqID_SYNC);\n+\t\treq_msg->hdr.msg_type = DELAY_REQ;\n+\t\treq_msg->hdr.ver = 2;\n+\t\treq_msg->hdr.control = 1;\n+\t\treq_msg->hdr.log_message_interval = 127;\n+\t\treq_msg->hdr.message_length =\n \t\t\thtons(sizeof(struct delay_req_msg));\n-\t\tptp_msg->delay_req.hdr.domain_number = ptp_hdr->domain_number;\n+\t\treq_msg->hdr.domain_number = ptp_hdr->domain_number;\n \n \t\t/* Set up clock id. */\n \t\tclient_clkid =\n-\t\t\t&ptp_msg->delay_req.hdr.source_port_id.clock_id;\n+\t\t\t&req_msg->hdr.source_port_id.clock_id;\n \n \t\tclient_clkid->id[0] = eth_hdr->src_addr.addr_bytes[0];\n \t\tclient_clkid->id[1] = eth_hdr->src_addr.addr_bytes[1];\n", "prefixes": [ "v2" ] }