Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104570/?format=api
{ "id": 104570, "url": "http://patchwork.dpdk.org/api/patches/104570/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com", "date": "2021-11-22T13:53:29", "name": "net/mlx4: fix empty ETH spec with VLAN support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "eddb60edb7eb75888f593d7d520c7f323025faf8", "submitter": { "id": 1971, "url": "http://patchwork.dpdk.org/api/people/1971/?format=api", "name": "Jack Min", "email": "jackmin@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com/mbox/", "series": [ { "id": 20683, "url": "http://patchwork.dpdk.org/api/series/20683/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20683", "date": "2021-11-22T13:53:29", "name": "net/mlx4: fix empty ETH spec with VLAN support", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20683/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104570/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104570/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B416AA0032;\n\tMon, 22 Nov 2021 14:53:51 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8264A4014E;\n\tMon, 22 Nov 2021 14:53:51 +0100 (CET)", "from NAM04-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam08on2076.outbound.protection.outlook.com [40.107.102.76])\n by mails.dpdk.org (Postfix) with ESMTP id 723F94003C;\n Mon, 22 Nov 2021 14:53:50 +0100 (CET)", "from MW4PR03CA0282.namprd03.prod.outlook.com (2603:10b6:303:b5::17)\n by BYAPR12MB4774.namprd12.prod.outlook.com (2603:10b6:a03:10b::33)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Mon, 22 Nov\n 2021 13:53:47 +0000", "from CO1NAM11FT038.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b5:cafe::74) by MW4PR03CA0282.outlook.office365.com\n (2603:10b6:303:b5::17) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.19 via Frontend\n Transport; Mon, 22 Nov 2021 13:53:47 +0000", "from mail.nvidia.com (216.228.112.34) by\n CO1NAM11FT038.mail.protection.outlook.com (10.13.174.231) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Mon, 22 Nov 2021 13:53:47 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 22 Nov\n 2021 13:53:45 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=EcKa0XtiNWnVW7FKafNY+us7jBrE/QFZFmCWgLpiyHPY5ZVwjfeivS6NKqDC1X+S+hM+MImaMOEalxQC206OrQt9zqB78r1l9RTUQgPxdUQ0T1mTAHoT/VBuVekKfhKzUJYmXLcvsWojuavxRdkebVeM1SDyGNb2NbTOmfExpq4ILd/BmnAifC5gJpKO6P9QdfyYW9KzmuiFBmHIGW6toQ5vfWBIqYz8zdprduU17gvGiCZQhMWI2y6bgJMpnLrF747iQuufOaRTStP1uacCu7UbXVjQ3McDJa9WIo7mdiWRlQmze0m34LddQCZLyxNH5Y57gvFDhb1nSnZYEqLKGg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=Ec94YAWGlXiiedEnHcJp8AqoQASJrRr9hm9usSNXMfE=;\n b=Ij8rITVH8S6iCoOHaT0DNt2Pcru4F2xpd2Z2eAnPLewJDccym4C0djjmlgmcTLy0cJdX9pdqfIf6fq7lR7pbRvArTpWiRSoaJoG+IDsnkbnpMtKnN2UKijPe+lzSvUf6zx5KXLFaczXKo21lqegtGGCAY9do6GJSMAFJ2MQzfS0OZkIbERcBnL9dYDVGsi1vrybDdssjDBrC4KnYtwKkYRnogoJ1fUfbIxxYd/7/4x0Z6xAEhHQxSoqnH8wTJa566BGjJ/2ewxtoqgxS0tsiZazPsmSo2naZ629GA6UOu1NR3yBNTbkaZLOTFNnpVRH8QqVIqueK/x2s93Y0LgCWww==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=Ec94YAWGlXiiedEnHcJp8AqoQASJrRr9hm9usSNXMfE=;\n b=dEDarRCYdMzAaYYsLezTJ/X3UxcgPX7fJakW9LvzqePIJbn+bvTH7yhSa/1C4pLpDr/cxJsTRAUQkVAAKkj/h3u9ZpRyLiA1DD0oiIYjK5zTO3OsewF5Q1Hcihf9xmO6kndyCA+R7ph7alSTtn97Wy0lewtalZoTMW+OsDPDF1SRgix5nxE0AxGGU7OQblA0cqN8Ttq/1oOWSv7nlEM3imkYcoJwMFxSMN9dcjeMQ3N7MJU4d0B/iHExn/ATg2UTxp0oSFi0Ky57SmhAcNAiXqd/i9cppauqmISrof2UBsL3nDA2DMBSdpnMW5gzv1MAczLeFvskTTxs+tNMPJYJcQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Xiaoyu Min <jackmin@nvidia.com>", "To": "Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Dekel Peled <dekelp@mellanox.com>", "CC": "<dev@dpdk.org>, <stable@dpdk.org>", "Subject": "[PATCH] net/mlx4: fix empty ETH spec with VLAN support", "Date": "Mon, 22 Nov 2021 21:53:29 +0800", "Message-ID": "\n <3672e46dd1181429c73952a93cc211ad11769b99.1637589050.git.jackmin@nvidia.com>", "X-Mailer": "git-send-email 2.34.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "adfbbb15-8f53-4eb7-2580-08d9adbf81a7", "X-MS-TrafficTypeDiagnostic": "BYAPR12MB4774:", "X-Microsoft-Antispam-PRVS": "\n <BYAPR12MB4774E541872D998F367A8D95C19F9@BYAPR12MB4774.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:298;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n Q87PjQX5Jb4xo7uhmKkiXNOqNlMZ536IrOHF2gHCleTrptPVp+3uss4CNeQ0M88Srnwin6kjgh5svlUNevF7lJrf91K/F/PBAQwRXXFjZUNeAPkmA+RT0RJmxmdjzA34z1zqJl9s0p0m61rkxgarfRivZte//YtZyE8vRg6Umcrvwj/sma8Lq6cUdsMQLXPIC+8t0e7ByIWRgTmWw+a+d2pzdwWmu4LKdikfxMR/ikuzu688rQ0TD/KepUsaSBhDuz9bFpTt+QHMQYOsVr6PtXXiJGwhh21RrJBVT9kQtVF9pDsTI1LYYA4wo+qnt59JkX6jg+GCHetGG6Io4vEhBYk4Y+GBeOPifz86CpSkho/Z+4vMVf0dZgY6oMGdvqD4opZ9hYOkhTBtsjYbdTBALc80ER6v5AO2xQNbApsOqGgEkhlA3PhCRPte454WWhJ8pzPY7OUhY3ogD8YDxIIH/GZN1weh/wvTwQtcFVGpSawhkfNGvaWpAX4AIk09UzBkNV6cnZTehYUuEzaq7grGQbWS5VwgCrganHRo59BKK4lR1Njc5kxZD2CRaIU6Ma2k+KGC/YVor0JQVJ1PoJL/HYObA96QFNJuI+jCUb3V0jIUkjmEpMpM9w+FWPaPDSrPoAtzwMQQsMoS3O6QvjsclhDCkmzU89wap3epQcwlvSZ56Tc+EvEsm7CLb5Krpp2hsvQD2Hw0/d3aCylspcj3cg==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(82310400003)(36860700001)(356005)(70206006)(55016002)(426003)(2616005)(4326008)(186003)(26005)(36756003)(508600001)(16526019)(47076005)(54906003)(8676002)(336012)(8936002)(70586007)(6666004)(86362001)(7636003)(316002)(2906002)(36906005)(6286002)(450100002)(5660300002)(83380400001)(7696005)(110136005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Nov 2021 13:53:47.4100 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n adfbbb15-8f53-4eb7-2580-08d9adbf81a7", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT038.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BYAPR12MB4774", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When the ETH spec is empty MLX4 PMD doesn't allow match other criteria,\nwhich means the flow should be promisc one.\n\nCurrently, PMD validates this by setting flow->promisc bit when ETH spec\nis empty and checking whether there is other rte_flow_item followed\nwhen flow->promisc is on.\n\nHowever, commit [1] adds support to match traffic only on VLAN id, the\nabove validation logic should be changed accordingly.\n\nThis patch changes the above validate logic by skipping flow->promisc\ncheck if this item is VLAN.\n\nFixes: c0d239263156 (\"net/mlx4: support flow w/o ETH spec and with VLAN\")\nCc: stable@dpdk.org\n\n[1]:\ncommit c0d239263156 (\"net/mlx4: support flow w/o ETH spec and with VLAN\")\n\nSigned-off-by: Xiaoyu Min <jackmin@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\n drivers/net/mlx4/mlx4_flow.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c\nindex 2e1b6c87e9..9d7247cf81 100644\n--- a/drivers/net/mlx4/mlx4_flow.c\n+++ b/drivers/net/mlx4/mlx4_flow.c\n@@ -713,7 +713,8 @@ mlx4_flow_prepare(struct mlx4_priv *priv,\n \t\t\tflow->internal = 1;\n \t\t\tcontinue;\n \t\t}\n-\t\tif (flow->promisc || flow->allmulti) {\n+\t\tif ((item->type != RTE_FLOW_ITEM_TYPE_VLAN && flow->promisc) ||\n+\t\t flow->allmulti) {\n \t\t\tmsg = \"mlx4 does not support additional matching\"\n \t\t\t\t\" criteria combined with indiscriminate\"\n \t\t\t\t\" matching on Ethernet headers\";\n", "prefixes": [] }