Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104573/?format=api
{ "id": 104573, "url": "http://patchwork.dpdk.org/api/patches/104573/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211122235229.22019-1-eagostini@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211122235229.22019-1-eagostini@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211122235229.22019-1-eagostini@nvidia.com", "date": "2021-11-22T23:52:29", "name": "[v4] gpudev: manage NULL pointer", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "85915f10e899fb3746ec4f2a330dbf9adb73e1d7", "submitter": { "id": 1571, "url": "http://patchwork.dpdk.org/api/people/1571/?format=api", "name": "Elena Agostini", "email": "eagostini@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211122235229.22019-1-eagostini@nvidia.com/mbox/", "series": [ { "id": 20686, "url": "http://patchwork.dpdk.org/api/series/20686/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20686", "date": "2021-11-22T23:52:29", "name": "[v4] gpudev: manage NULL pointer", "version": 4, "mbox": "http://patchwork.dpdk.org/series/20686/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104573/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/104573/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5C00CA0C4B;\n\tMon, 22 Nov 2021 16:42:06 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CF7E14014E;\n\tMon, 22 Nov 2021 16:42:05 +0100 (CET)", "from NAM04-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam08on2049.outbound.protection.outlook.com [40.107.100.49])\n by mails.dpdk.org (Postfix) with ESMTP id 28A794003C\n for <dev@dpdk.org>; Mon, 22 Nov 2021 16:42:05 +0100 (CET)", "from DS7PR03CA0306.namprd03.prod.outlook.com (2603:10b6:8:2b::14) by\n BN9PR12MB5113.namprd12.prod.outlook.com (2603:10b6:408:136::17) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Mon, 22 Nov\n 2021 15:42:03 +0000", "from DM6NAM11FT012.eop-nam11.prod.protection.outlook.com\n (2603:10b6:8:2b:cafe::cf) by DS7PR03CA0306.outlook.office365.com\n (2603:10b6:8:2b::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.20 via Frontend\n Transport; Mon, 22 Nov 2021 15:42:03 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT012.mail.protection.outlook.com (10.13.173.109) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Mon, 22 Nov 2021 15:42:03 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Mon, 22 Nov\n 2021 15:42:02 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=YE1o7N0PSIUmIQtXBD8xPTaQaTeX6A5e3fxdcL7Z0C61HpgmZIyls68K6/JDLBE63Td5RZX7yvNQ9w9M+szHiRipK76HZgEIIuE0CjzgrN8wCI6QOviAMe5bKGFTWJKvEZsPu/WsPBOY3+9RcMOZk+S+p44CQKpE43o6G02/AAO+GntMTh1xpTMMSIN0zQlsdL0JRD+OZKO2SuoWUnWq6NQcK0Iz2LpuLFI70v7tZ3V+7eM7/p5wwYoevTbUAANxF5WyGDdVhfCGBWJoO74CnjP+DSMdDQ/lFdGz3W3OlUxgA8UHU5g9JnYTRTq52VmEnJzwmuPcIQI6nUFpZOHEjQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=t8Z4eRgcS76xuBcSLZM+uKSVH01ODnTgz47ekJRwETY=;\n b=NVuayBI/rEjfGNjWzmAG25z4Xjgv8NZenYFna4XF5+PHj3Rt6ATAb1zxWBOD1j2RVr5XyoSfSRcnjSxNKppsNQ6ZS2/9qrsuPetCcYChMyVTwKt1XbDRJvU+XZRn9AriHQAKq2krGDDges0rt3L3w0JMVWqCNjm5+xKYeUE4IKWnvH0Hxow6xntcqNlDaf8iqtAJG3XApo6emxtOlWKelZOTX8erJnkdNssdveu90+VqhLyD3pvRrPHcUvaHKyeCbNyEvBX4sbrkZ91g2abg0MGvNW1iNDkDqc7V9z5VZMOHBxetQUSgbHgMPLs2s6yE/t+wHdebTtomnyl5H58C3g==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=t8Z4eRgcS76xuBcSLZM+uKSVH01ODnTgz47ekJRwETY=;\n b=ir+PeKQuPH2ImokauTFF5Za8usrMukG8l67+frn1mSvO2xVap2mvJLAA+ij8z9eei62E3aBra6i4YmPuj70Hzo4VZ+xmW+led+zuK8coHhM1qLFowMSuDiWDTrC0IWHntvx1V1TMvwGVW+a0H1F8eipdQlsKXWoLNH6ng/PvyluFQ/b3oSjQkENdcKbtG3cv3WikQEJSMrDYdUV0CXffi9GUtEb3CWpbrx+N5U6MVOKTxre3hVnHGrGijCbWKkC27K8Oc7kggWH7MsT6UZJ+xCZ1iaZL8re50g7gImKrRcBy5PrKDaSyJ+RT09uVnH/K6xUDZLC+S08TgO+o6QLKaA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "<eagostini@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Elena Agostini <eagostini@nvidia.com>", "Subject": "[PATCH v4] gpudev: manage NULL pointer", "Date": "Mon, 22 Nov 2021 23:52:29 +0000", "Message-ID": "<20211122235229.22019-1-eagostini@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211118192802.23955-1-eagostini@nvidia.com>", "References": "<20211118192802.23955-1-eagostini@nvidia.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "18595ea9-d7d6-46f9-5feb-08d9adcea167", "X-MS-TrafficTypeDiagnostic": "BN9PR12MB5113:", "X-Microsoft-Antispam-PRVS": "\n <BN9PR12MB511364CC7BE26754E2E8A09ACD9F9@BN9PR12MB5113.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:3383;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n wEkmGKCQcoKuHGc8i1t4vUSLiHOObWuqxNdMyb9vZhxxK0ubF9B3gz6rhGoRCVvsIlwr3ZKN4r5m768pohKuSHPs1agfZhw6Z2TO3CiEzrP3ogdAAxIOybXpG5qvpr8/GB2F+4+PBN36Xad0LgnuiCErBvfcSrQCzeE1EjaxoaqhmZT+4SEU931/YtL3HVnjtRLiMQdW3GZgls4jxIFoU1uuKC2WcxovfUCYSoSjV4ie1Suqzl5w/d3qB6DMusdh30NYjjdGSp6XpYV8EtCFic0dCzsPCkUqQ83S5+UYk8cLVuXBQ12s+kMr7GnRvaZRU+holJ65S9OeXWgZAaFyR2vaHBK82NhdgdtcAmjaePTK7/nSUfxiNlrjYJDYrHdPHqnO7K5XKId4r4SleD/D5eLYxpD98RWJC+S0IJxqmA5JoiPJn+unV3wn1AIoeQmdg41ixnXaz88k8ftqAP5723NmWsRS2pOdcyTEL9KJ4GbIsR9Um/gMm7CfPo+N1wqtL4gpgT1u/dkh3ksh3zCX9khr8gl5sjWi06aWqunB96BKq2KAzzY3RaHelHKMIklbVAJPgqdZkLP+lpNNdOuA4Vdpr1URsJugSTegbAw4mblftD3sf2sOGOt0ybBvPKnexJJd5xw2HGd2WPCLKC71/yT9QbV8VfKfWEmn/xDNBl0IlJp7fbtm4jk8W0+R+GZtY/DGAuitYKDYpq20t748Og==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(1076003)(82310400003)(426003)(2906002)(6286002)(336012)(70206006)(47076005)(70586007)(7636003)(186003)(36756003)(8936002)(107886003)(36906005)(7696005)(4326008)(16526019)(83380400001)(356005)(508600001)(36860700001)(8676002)(6666004)(26005)(2876002)(2616005)(5660300002)(316002)(55016002)(86362001)(6916009);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "22 Nov 2021 15:42:03.1341 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 18595ea9-d7d6-46f9-5feb-08d9adcea167", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT012.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN9PR12MB5113", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Elena Agostini <eagostini@nvidia.com>\n\ngpudev free and unregister functions return\ngracefully if input pointer is NULL because\nAPI doc was indicating NULL as a no-op\naccepted value.\n\ncuda driver checks are removed because\nredundant with the checks added\nin gpudev library.\n\nFixes: e818c4e2bf50 (\"gpudev: add memory API\")\n\nSigned-off-by: Elena Agostini <eagostini@nvidia.com>\n---\n drivers/gpu/cuda/cuda.c | 6 ------\n lib/gpudev/gpudev.c | 9 +++++++++\n 2 files changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/gpu/cuda/cuda.c b/drivers/gpu/cuda/cuda.c\nindex 24ae630d04..47a3bbf256 100644\n--- a/drivers/gpu/cuda/cuda.c\n+++ b/drivers/gpu/cuda/cuda.c\n@@ -764,9 +764,6 @@ cuda_mem_free(struct rte_gpu *dev, void *ptr)\n \tif (dev == NULL)\n \t\treturn -ENODEV;\n \n-\tif (ptr == NULL)\n-\t\treturn -EINVAL;\n-\n \thk = get_hash_from_ptr((void *)ptr);\n \n \tmem_item = mem_list_find_item(hk);\n@@ -803,9 +800,6 @@ cuda_mem_unregister(struct rte_gpu *dev, void *ptr)\n \tif (dev == NULL)\n \t\treturn -ENODEV;\n \n-\tif (ptr == NULL)\n-\t\treturn -EINVAL;\n-\n \thk = get_hash_from_ptr((void *)ptr);\n \n \tmem_item = mem_list_find_item(hk);\ndiff --git a/lib/gpudev/gpudev.c b/lib/gpudev/gpudev.c\nindex 2b174d8bd5..d6224a3828 100644\n--- a/lib/gpudev/gpudev.c\n+++ b/lib/gpudev/gpudev.c\n@@ -576,6 +576,9 @@ rte_gpu_mem_free(int16_t dev_id, void *ptr)\n \t\treturn -rte_errno;\n \t}\n \n+\tif (ptr == NULL)\n+\t\treturn 0;\n+\n \tif (dev->ops.mem_free == NULL) {\n \t\trte_errno = ENOTSUP;\n \t\treturn -rte_errno;\n@@ -595,6 +598,9 @@ rte_gpu_mem_register(int16_t dev_id, size_t size, void *ptr)\n \t\treturn -rte_errno;\n \t}\n \n+\tif (ptr == NULL)\n+\t\treturn 0;\n+\n \tif (dev->ops.mem_register == NULL) {\n \t\tGPU_LOG(ERR, \"mem registration not supported\");\n \t\trte_errno = ENOTSUP;\n@@ -619,6 +625,9 @@ rte_gpu_mem_unregister(int16_t dev_id, void *ptr)\n \t\treturn -rte_errno;\n \t}\n \n+\tif( ptr == NULL)\n+\t\treturn 0;\n+\n \tif (dev->ops.mem_unregister == NULL) {\n \t\trte_errno = ENOTSUP;\n \t\treturn -rte_errno;\n", "prefixes": [ "v4" ] }