Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104609/?format=api
{ "id": 104609, "url": "http://patchwork.dpdk.org/api/patches/104609/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211123115751.29038-1-getelson@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211123115751.29038-1-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211123115751.29038-1-getelson@nvidia.com", "date": "2021-11-23T11:57:51", "name": "[v2] app/testpmd: fix hex string parser input length", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3db94b7186e2fd552fe4fc31791ce72a08b4817d", "submitter": { "id": 1882, "url": "http://patchwork.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211123115751.29038-1-getelson@nvidia.com/mbox/", "series": [ { "id": 20707, "url": "http://patchwork.dpdk.org/api/series/20707/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20707", "date": "2021-11-23T11:57:51", "name": "[v2] app/testpmd: fix hex string parser input length", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20707/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104609/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104609/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9F670A0C4C;\n\tTue, 23 Nov 2021 12:58:12 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 67BC940040;\n\tTue, 23 Nov 2021 12:58:12 +0100 (CET)", "from NAM02-DM3-obe.outbound.protection.outlook.com\n (mail-dm3nam07on2049.outbound.protection.outlook.com [40.107.95.49])\n by mails.dpdk.org (Postfix) with ESMTP id 5341A4003C;\n Tue, 23 Nov 2021 12:58:11 +0100 (CET)", "from DM6PR07CA0098.namprd07.prod.outlook.com (2603:10b6:5:337::31)\n by BN8PR12MB3570.namprd12.prod.outlook.com (2603:10b6:408:4a::31) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22; Tue, 23 Nov\n 2021 11:58:07 +0000", "from DM6NAM11FT017.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:337:cafe::e4) by DM6PR07CA0098.outlook.office365.com\n (2603:10b6:5:337::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.22 via Frontend\n Transport; Tue, 23 Nov 2021 11:58:07 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT017.mail.protection.outlook.com (10.13.172.145) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 11:58:06 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov\n 2021 11:58:03 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=cZXNmpbR/eS4rpPjt30Llm8KK6LDY+WcbjUDtHtsCoKNfUrZ1x5jPjJQ0RfSNRPwDeDAPcdjio9M9T7yqmQr8qgiCz7z3jaw6V2amI12qUxQPMYM4KkLm9wltk7VlDn3JJ/8pVTR9jtGu64ZYDAf17JkYeINZ58EykwR2K8HX8E1CCfcW8toUdWORkHp0hwLS8165Y53ByOGRt87V8NNgt6rGPkc51nUvdNd4mYCOEJVa0KfiH9R8ZJf54umEzrNwN9gnvx4zQ9BEnmBlsT28HaY91C3QAxlTCr46YB2hHx3AD83yN5HxTxNDmeNDPloIV1+vF7L3OA80dki9NOeww==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=AeIql2Z/5dPbYGNzx9FQUslVcOdfPN8NvQjgNda/BKg=;\n b=KoFqO5ViVUfDKLOp4BWAkZhjuCje5ImcEIoKs67VhHobzCxEhAxj2yc6FE5tT7JYnSFjrwQWC8o5gVdZJ8NdSXzV+jnMuOxo/q6gHowT8y7JjNKCqdXuoXGB6ON8bCcLfN4k+A8V3aSvpazlW6S7lIc5aRrBjrCQzLnK6oMU2lNJsDmk8cvjiJc0sjWMUz/T1MK4DV/HeuhtDja16dRsLvXD6H9LkJPmD62SHU6IgoAD4NYAobpVsNRvxX78miTJvSoO5fp+NkF/oBG8aQA/HrphrjG5T+eGWQSGYqeSHzPSIPyOPRctBt9ORDe3kpY9tumDDw9mfC2sIB1s7Vw3nQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=AeIql2Z/5dPbYGNzx9FQUslVcOdfPN8NvQjgNda/BKg=;\n b=EOYiCigxVkbApdJ3Nkq/NTT4pk5tFBpfGIrfJpEhcoCw+Rqr0f0lCd7mcLO1WfR8roALcdq9ImnZ/KJnZw6YFcbVZ9Kc6V751KRSF/UscouFOhM06T/8jasEtNPoUtYFtwVn6nrBp4+D6AfXrRqEWuLM7MEJytAmiHSPXOzn/meUlnd0J8+wtYzKgC9X0VyXlTcSiE8vXvn99uSZLUiHjnNLWPwM0E+LjoOS/0mzZ4ic6GoNWcpxmBkfW/pl/ljYw6oL5WoiKa1f+SaJHlrHyf6ts1Kpn7eiX7wo44PB0Zjh1BTdDxDiXUFLdz0C/bcfd0+tUBDKpj9JhQ/cwufe3A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>, <getelson@nvidia.com>", "CC": "Ferruh Yigit <ferruh.yigit@intel.com>, <stable@dpdk.org>, Ori Kam\n <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>, Wei Zhao\n <wei.zhao1@intel.com>", "Subject": "[PATCH v2] app/testpmd: fix hex string parser input length", "Date": "Tue, 23 Nov 2021 13:57:51 +0200", "Message-ID": "<20211123115751.29038-1-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.34.0", "In-Reply-To": "<20211123090005.24707-1-getelson@nvidia.com>", "References": "<20211123090005.24707-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "611c939f-fcce-46f7-0dcc-08d9ae788323", "X-MS-TrafficTypeDiagnostic": "BN8PR12MB3570:", "X-Microsoft-Antispam-PRVS": "\n <BN8PR12MB35709D30BFBB41BF8248058DA5609@BN8PR12MB3570.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:197;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n U8TxWYkx8HtnQeW249jim2MhIxWFaRhsppvcrTav9JGqSYCcAuwnsqu+cabpxo+CIr58HYIwuZnaSw1QhwqLuVMQnHJONr0GL19HNXidYjEYP0p5XNaQJurIsTZlbjqZLNfeCDERVKzPFBr0dOs/uwr4esG0GmH6oFHhuOVEj7WfydnMO5UnwkXpZMAh9bR5D4Y5G9N4uTxaCPkaSxSXks5Z0OM6U3o7Cq6C1SLFvHb074Tov2SGYXdqJ53rpSBa+QbOs2GoaXSDZWQORc4q7US4hlzT2TK6XlkdyoqE2LNvR8Ql2o97Ya7RSQB3fdOdkku/bnz2BGnN554WoTS6dXlflwBsYCtTROi/n5mot1JbIfdz0sMJG3KfwAcA78UanWj6MQO0FyzxHr/4R5G2nsDBcizr5i109jyD2MSEjFe4tLb+mNJ7tN4YS7X7JkCCeSdio9aoQPQVHM+T0wV7f8zBLDpiV3OOO3BxvwYZ/xp5eysyLZF7yVjGvnIuVYe3GnGtvS3f7ZoWgjefMqxK2Fv/yrdp2praulXX+BORf4wUh6c5R76SFKiDPBHdkcwNp7zhpAkaw4Rw+/CRONW6D6aLbWj/nkqeYF7w9ooZWISog2/0xLDIaV8GFR5kS8PZXk+xQVgUFYK5NMOn9tha2Za0dhz4RrHTDY+IjQEGVaMa+X0mzB186D6wcsxCfO4YCofAKJpKFq6yUbEMNIvNFA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(70586007)(8676002)(8936002)(4326008)(70206006)(186003)(6286002)(6666004)(508600001)(16526019)(2616005)(336012)(7049001)(55016003)(82310400004)(426003)(36756003)(5660300002)(26005)(36860700001)(7696005)(54906003)(110136005)(1076003)(86362001)(356005)(7636003)(316002)(47076005)(83380400001)(2906002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Nov 2021 11:58:06.7937 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 611c939f-fcce-46f7-0dcc-08d9ae788323", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT017.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR12MB3570", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Current hex string parser assumes input has even characters number.\nThe parser fails input string with odd length.\n\nThe patch parses hex stringhs with even and odd length.\n\nCc: stable@dpdk.org\n\nFixes: 169a9fed1f4c (\"app/testpmd: fix hex string parser support for flow API\")\nSigned-off-by: Gregory Etelson <getelson@nvidia.com>\n---\nv2: return error after snprintf failure.\n---\n app/test-pmd/cmdline_flow.c | 27 ++++++++++++++-------------\n 1 file changed, 14 insertions(+), 13 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 1b00ae507b..dcf8ebec45 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -7702,9 +7702,7 @@ parse_string(struct context *ctx, const struct token *token,\n static int\n parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)\n {\n-\tchar *c = NULL;\n-\tuint32_t i, len;\n-\tchar tmp[3];\n+\tuint32_t left = *size;\n \n \t/* Check input parameters */\n \tif ((src == NULL) ||\n@@ -7714,19 +7712,22 @@ parse_hex_string(const char *src, uint8_t *dst, uint32_t *size)\n \t\treturn -1;\n \n \t/* Convert chars to bytes */\n-\tfor (i = 0, len = 0; i < *size; i += 2) {\n-\t\tsnprintf(tmp, 3, \"%s\", src + i);\n-\t\tdst[len++] = strtoul(tmp, &c, 16);\n-\t\tif (*c != 0) {\n-\t\t\tlen--;\n-\t\t\tdst[len] = 0;\n-\t\t\t*size = len;\n+\twhile (left) {\n+\t\tchar tmp[3], *end = tmp;\n+\t\tuint32_t read_lim = left & 1 ? 1 : 2;\n+\n+\t\tsnprintf(tmp, read_lim + 1, \"%s\", src);\n+\t\t*dst = strtoul(tmp, &end, 16);\n+\t\tif (*end) {\n+\t\t\t*dst = 0;\n+\t\t\t*size = *size - left;\n \t\t\treturn -1;\n \t\t}\n+\t\tleft -= read_lim;\n+\t\tsrc += read_lim;\n+\t\tdst++;\n \t}\n-\tdst[len] = 0;\n-\t*size = len;\n-\n+\t*dst = 0;\n \treturn 0;\n }\n \n", "prefixes": [ "v2" ] }