Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104618/?format=api
{ "id": 104618, "url": "http://patchwork.dpdk.org/api/patches/104618/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211123160519.79511-1-bingz@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211123160519.79511-1-bingz@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211123160519.79511-1-bingz@nvidia.com", "date": "2021-11-23T16:05:19", "name": "[v2] net/mlx5: fix RSS validation for meter hierarchy", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "310c545bb056403e98f29cd96943fdce0fc644d1", "submitter": { "id": 1976, "url": "http://patchwork.dpdk.org/api/people/1976/?format=api", "name": "Bing Zhao", "email": "bingz@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211123160519.79511-1-bingz@nvidia.com/mbox/", "series": [ { "id": 20715, "url": "http://patchwork.dpdk.org/api/series/20715/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20715", "date": "2021-11-23T16:05:19", "name": "[v2] net/mlx5: fix RSS validation for meter hierarchy", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20715/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104618/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104618/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3C2E0A0C4C;\n\tTue, 23 Nov 2021 17:05:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C188E40040;\n\tTue, 23 Nov 2021 17:05:41 +0100 (CET)", "from NAM11-CO1-obe.outbound.protection.outlook.com\n (mail-co1nam11on2056.outbound.protection.outlook.com [40.107.220.56])\n by mails.dpdk.org (Postfix) with ESMTP id E26634003C;\n Tue, 23 Nov 2021 17:05:39 +0100 (CET)", "from BN6PR13CA0053.namprd13.prod.outlook.com (2603:10b6:404:11::15)\n by CH0PR12MB5313.namprd12.prod.outlook.com (2603:10b6:610:d4::18)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Tue, 23 Nov\n 2021 16:05:37 +0000", "from BN8NAM11FT044.eop-nam11.prod.protection.outlook.com\n (2603:10b6:404:11:cafe::f3) by BN6PR13CA0053.outlook.office365.com\n (2603:10b6:404:11::15) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.13 via Frontend\n Transport; Tue, 23 Nov 2021 16:05:37 +0000", "from mail.nvidia.com (216.228.112.34) by\n BN8NAM11FT044.mail.protection.outlook.com (10.13.177.219) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 16:05:36 +0000", "from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov\n 2021 16:05:32 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ZeM/dLHwfo0jgiNoulmOf6yB4gxpVhbVlGq4XZSWxqOGEUhrZZblf2IYaGdanGtChosLuXHGoiM0PYCnRsArXqa8ZVBqEewv9lcl/bXcZAX/cLPqOeAJBThYObsVs9eerm1a3HUQpK+DO9Js5RQHRhfOnVbpXXlSJynt0Finz0Lps6PGDdUkZuxObWR7ZP+7kVgcdf8pzVHh5Qx3NM7JMZgPoCf4bu/k8wPfFeXCWlkO+QN4nMsb+DqCRrDobKGJ9HO40kifJO6974NCPjRvdSOkwslHCT5lFn0KG4fZCcokEIfFbkhO/7MsTLwiXBhXJavym+C3D3k34KXEUe4m0g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=x+2OcFHW7eH9sJVVxeL+IoJpBpAe7XuXz4LeGnuRsL8=;\n b=Pt1v8PVK+4cpAtShfsHyW8l46FFbTDHp8ZqDGEQi7eKYv739Sue4jrk0pN3N5QKcoUP0ygUdZ1QvudUV0j/3UoGA74q9sBsBrbzWMh7y5VAhs2qP35ozL0WwsVbJCmmg9zFcb5emSWFVsCUNF/k/0QvesRdRu+y9pzr6uA0HP0+Tmq2qSnO/HUME7xpr6t/123FbazJ5qP/ags8qro7ya5l1MXHY/fBUzZJokYH2jyAtyTZZYJQgpB/aQvx3cmv11EWtoC3b+RTWRtt2x3DEuDYGczvDK8+y87OOZrNCgtBmtprHR9V+vZjri96z6OxowayQZqMKVYf/HYQmt/pk4w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=x+2OcFHW7eH9sJVVxeL+IoJpBpAe7XuXz4LeGnuRsL8=;\n b=XSn3tor2Zdevgf33+363Ft6BluHNZPQu0e2HOAOrutvb9au7o0SBPTxSJTGsGcQPO7GD6ekKyRs1wydp6Tl052qaFh+weFbwBvRZj4mYUZL1fIHuRbjkmi+8iFd0RkZctgpniocy4ig79FZtesaxr75hoA1dis7Fu2Zgvg9QZhpKlKaZnFP9Tk49cnCzd+pKMTa3dYKp/L4ACg+mXYPDMuEt6I1RvGGt7cCUC6BRaafCeMJ5SRpJAmIF/kKn+74ZC6sdRrqapLUfSNjrLTvU/MzhWwGqSJFvBGWbyBlUq8Vj+9BUxOMSOWmkBEbewOtW+hCzqrpTUSscCiUUH71uVQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Bing Zhao <bingz@nvidia.com>", "To": "<viacheslavo@nvidia.com>, <matan@nvidia.com>", "CC": "<dev@dpdk.org>, <rasland@nvidia.com>, <stable@dpdk.org>, Li Zhang\n <lizh@nvidia.com>, Shun Hao <shunh@nvidia.com>", "Subject": "[PATCH v2] net/mlx5: fix RSS validation for meter hierarchy", "Date": "Tue, 23 Nov 2021 18:05:19 +0200", "Message-ID": "<20211123160519.79511-1-bingz@nvidia.com>", "X-Mailer": "git-send-email 2.26.3", "In-Reply-To": "<20211123160011.79219-1-bingz@nvidia.com>", "References": "<20211123160011.79219-1-bingz@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.6]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "0a6a970f-17b5-421c-1754-08d9ae9b1645", "X-MS-TrafficTypeDiagnostic": "CH0PR12MB5313:", "X-Microsoft-Antispam-PRVS": "\n <CH0PR12MB5313BA94FEF33A3F59792B8ED0609@CH0PR12MB5313.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:1824;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n VVsNplKA5cGIxYhbQYYAIg9VEL0nuxJpshvB/ZH2YJx+64sQ6auk5LLAJCMsu9scDWNISzIIAmSMj3QzW1QZFc/jBOm3dPCOMn7BcSdZq6OewZo7AyUKnBkr5g7tu83jlNbf7EqqYkrkt/gTf0ZSStkKJRBngOZw1Tt0CwHMyEMykat42MEeRcuS86AOTPcU3fL2/c2wu9VetvPMXIvgkBrAeJLKK/89qlinpsH/vyNFPKHr4OniOrB3fy+6Tx2xzFOMqA5AecqLO46IA6ZBeGm4PIp/TFOb4LjOssEaxRrkWAqY0N9fHl/FYymCjK1JZh5P4hpaXUyhynzaBKWmFhZLC1bLY0vfd8c0npbp6j7++D/RIkCwrtx8tPTO/SRDNBWY7BbzrZtDNUymKwHN1cIk2s1DgRLWk9uCNrXA5QyBFg7/HILd79QAdrktVNaieYlnlwDLFpznfC6WIChlt8+p1XtQA2kqunim4LmYbPfhwQgyWBdKeYkuRlrNQ8bVjlxD9cs62FxPUcqypEMxCSnejQiITFUmtn13PS1iEPhmBeLQmOUXe1v5w+579gzMdLWQdn4ABR8NNC78YEgDbYRUcef+zj+TEho/1oloHGUUub6Sbvxb9ACdct0rZd4VEweH6cHoF3/6uwuZrkKx1wBj23W2+phwiwn/ehFze9CrZf6UilA22i5mb4IeaAV8", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(508600001)(2906002)(110136005)(36906005)(356005)(54906003)(36860700001)(336012)(2616005)(83380400001)(1076003)(7636003)(4326008)(70206006)(426003)(5660300002)(16526019)(26005)(107886003)(36756003)(47076005)(8676002)(7696005)(186003)(8936002)(86362001)(450100002)(6636002)(55016003)(82310400004)(6286002)(316002)(70586007)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Nov 2021 16:05:36.4717 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 0a6a970f-17b5-421c-1754-08d9ae9b1645", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT044.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH0PR12MB5313", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In a meter hierarchy, all the meters are marked with having RSS if\nthe final meter's termination action is RSS.\n\nWhen validating a flow rule with meter hierarchy, the RSS action\nshould not be fetched from the current meter if it is not the final\none.\n\nThe fate action union is next meter ID instead of the pointer to the\nRSS action. By using the final meter in the hierarchy, the flow rule\nvalidation will succeed without any crash caused by the invalid RSS\naction pointer access.\n\nFixes: 1ce19ab1f43b (\"net/mlx5: fix RSS validation with meter policy\")\nCc: stable@dpdk.org\n\nSigned-off-by: Bing Zhao <bingz@nvidia.com>\nReviewed-by: Li Zhang <lizh@nvidia.com>\nReviewed-by: Shun Hao <shunh@nvidia.com>\nAcked-by: Matan Azrad <matan@nvidia.com>\n---\nv2: fix typo in the commit message\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 16 ++++++++++++----\n 1 file changed, 12 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 2f03e59f9c..f5356418fa 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -5254,13 +5254,21 @@ mlx5_flow_validate_action_meter(struct rte_eth_dev *dev,\n \t\t\t\t\t\t\"Flow and meter policy \"\n \t\t\t\t\t\t\"have different src port.\");\n \t\t} else if (mtr_policy->is_rss) {\n-\t\t\tstruct mlx5_meter_policy_action_container *acg =\n-\t\t\t\t&mtr_policy->act_cnt[RTE_COLOR_GREEN];\n-\t\t\tstruct mlx5_meter_policy_action_container *acy =\n-\t\t\t\t&mtr_policy->act_cnt[RTE_COLOR_YELLOW];\n+\t\t\tstruct mlx5_flow_meter_policy *fp;\n+\t\t\tstruct mlx5_meter_policy_action_container *acg;\n+\t\t\tstruct mlx5_meter_policy_action_container *acy;\n \t\t\tconst struct rte_flow_action *rss_act;\n \t\t\tint ret;\n \n+\t\t\tfp = mlx5_flow_meter_hierarchy_get_final_policy(dev,\n+\t\t\t\t\t\t\t\tmtr_policy);\n+\t\t\tif (fp == NULL)\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, NULL,\n+\t\t\t\t\t\t \"Unable to get the final \"\n+\t\t\t\t\t\t \"policy in the hierarchy\");\n+\t\t\tacg = &fp->act_cnt[RTE_COLOR_GREEN];\n+\t\t\tacy = &fp->act_cnt[RTE_COLOR_YELLOW];\n \t\t\tMLX5_ASSERT(acg->fate_action ==\n \t\t\t\t MLX5_FLOW_FATE_SHARED_RSS ||\n \t\t\t\t acy->fate_action ==\n", "prefixes": [ "v2" ] }