Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104634/?format=api
{ "id": 104634, "url": "http://patchwork.dpdk.org/api/patches/104634/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211123223159.3324247-2-dkozlyuk@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211123223159.3324247-2-dkozlyuk@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211123223159.3324247-2-dkozlyuk@nvidia.com", "date": "2021-11-23T22:31:58", "name": "[1/2] net/mlx5: fix indirect RSS creation when port is stopped", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0fed404ecf99309ac1faa92e64bfd30d039480c6", "submitter": { "id": 2248, "url": "http://patchwork.dpdk.org/api/people/2248/?format=api", "name": "Dmitry Kozlyuk", "email": "dkozlyuk@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211123223159.3324247-2-dkozlyuk@nvidia.com/mbox/", "series": [ { "id": 20722, "url": "http://patchwork.dpdk.org/api/series/20722/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20722", "date": "2021-11-23T22:31:57", "name": "next/mlx5: fix indirect RSS reference counting", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20722/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104634/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104634/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 15C94A0C4C;\n\tTue, 23 Nov 2021 23:32:24 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 25DF941152;\n\tTue, 23 Nov 2021 23:32:20 +0100 (CET)", "from NAM04-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam08on2063.outbound.protection.outlook.com [40.107.101.63])\n by mails.dpdk.org (Postfix) with ESMTP id B994640040\n for <dev@dpdk.org>; Tue, 23 Nov 2021 23:32:17 +0100 (CET)", "from DM6PR10CA0011.namprd10.prod.outlook.com (2603:10b6:5:60::24) by\n CH2PR12MB4117.namprd12.prod.outlook.com (2603:10b6:610:ae::13) with\n Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4713.21; Tue, 23 Nov 2021 22:32:16 +0000", "from DM6NAM11FT003.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:60:cafe::c6) by DM6PR10CA0011.outlook.office365.com\n (2603:10b6:5:60::24) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend\n Transport; Tue, 23 Nov 2021 22:32:16 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT003.mail.protection.outlook.com (10.13.173.162) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Tue, 23 Nov 2021 22:32:15 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Tue, 23 Nov\n 2021 22:32:13 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=JNNYLCiev2u0oC99ElwvA+eBJn4/NzCQk6Cltm4YHH/rzzXZEJFQvSgBg2ti8GUGMQVXf5IxaF/LUx7x32bfoG+c43IaugG/E+c2eCP80zp1SoYci11DRzn1i59bpdPHYoh21i/t0THGvKGlXvYpeJ47EGBdOdn+PUFXbxX1GgsK0XhWTlrf/dtVzaZsTHY9bEhr8Z3SDWsZH80fzOItBavFtC4zh55QMXnEWxqFvcB9qg8bVRRUvaRsHWiMxwdEvCKgzHkjdq8nxoHFoFiakmwd3HO1F0rYMGFU980x7Wx/GM/k4deE/a4ejiK4hgiJAga0CUnCdBHTcofbihshvg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=;\n b=N7a/rX9piqeU8avMUmjNjdQHpO7ntpc/Csys1BkAg6oEIyGEzes8ngTUa86l7ys+F2L3K+TTadia6LAFUK2V91i0lmp4Vat8z5qS2v35USZ9ginkU4gVVWdcygri1Ww5h3msm2QFdQQnUKpf0/N6xc6KNvUNe0SgsL6CuYEGXDKV7QGS5DA+SrS2pkPwGy6HWxhlU4IIxUSod6py4/dAL6GkpFzA55aVCzcgeRLILIR7frYP2vgXGXkZEtJbzTkec0trb3pq55E9Dmo6JH6PGLR7QJwzAdEedFPNyanLLKuSggxhh+Kz+JTFueA5sAfvVzWpCsWT1jAlT8y6v2/RNg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=;\n b=mzvNShZ/XhEKhKOWU90mqGQV0NAsPTkQuqyVWYcMvLkhU4RASbDCtd/NQgY78d+/Fmrcju70aGko5JwV0cBx4AIcS/1/zoPGrSAaOS0rpIEdhuaPjwQcd2NP41nmu4h7tj5IIZrYL/jy1p7pTgmp/5UPdQe/+bR4ZmIleHKvuOoAc1boAPSHOQZgtpT9TPhlQfe+tZeFcL6J5phdLAquXz6jcCdnAUGtXLyZ3xZxFSn7E6oK0JInoG4tlqFmxnI3l8BCMd0IjEM1UThlTQPPYDXb+knO6YKjp49W/TEQnVvh8v01TmepfPeby6h9cw4CX0d1frgXOh2RoaqEEJAzzQ==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Dmitry Kozlyuk <dkozlyuk@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Raslan Darawsheh <rasland@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH 1/2] net/mlx5: fix indirect RSS creation when port is stopped", "Date": "Wed, 24 Nov 2021 00:31:58 +0200", "Message-ID": "<20211123223159.3324247-2-dkozlyuk@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211123223159.3324247-1-dkozlyuk@nvidia.com>", "References": "<20211123223159.3324247-1-dkozlyuk@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "ae2834dd-eea0-407a-00a4-08d9aed119fa", "X-MS-TrafficTypeDiagnostic": "CH2PR12MB4117:", "X-Microsoft-Antispam-PRVS": "\n <CH2PR12MB4117E2B9035827807AACD5C1B9609@CH2PR12MB4117.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2000;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xgEqTM5sC/qHp1s7m2XV22vSFzb9G54Vij/jY8fOSZ8SHqnmI4bhB4aKFOz95KYRWbK7XA8PNLXZUxKc3YRYnV0z07tqtYYt5NgF0rU9LjekmdvqTGsTW3xBh6aUlI1qZX425vAdyMIUSaFWCXScMETjb4ZK1gKgLZR/FqjM+AiApyy9CYv3CoP/nsZ4Zyl9VKwtm15l58JGKrdbrc1pTIh3CL7jc4hhvI+041qvb3Uj+34afDaBcMU9n6xZ290dphUqQvH0Y5d5MLNY23omZFjbC26jT3lkia83Cgxj2JQ1Kp+JbfAs9BFlilo3tz5Jz4555aZaMlx1dD7W9ZGj5QDIdEUhhng9/OXVOyht3PrWD1fVnjMPL6cHaHjr2QP8n0jmkKK2Hhd/574+x9INu6tsjQ6PYT/nT/IpwCxB94vN4G4qERYPCWqcW2ImWxBSZsSSloylgV3VO6mIxM96b6UyWgg5Q9aixnb98MhqMxtF6fApliuQIAFFfJmGH+CVxXxyhcCbpFzgXX8JNePpdRb5kIhxfDtk0NHjUhQREUQXJVU5BYr2MC1dYSIy4yumBV+5LoI/yXHCjmwiOnWBfgTtO1MMknluAg7ZBIxKVFvlPp639hHRTT7iW4p7+oJr/T0iOLVLSdUJte6hvvNSaJfAxC+v1IWNz5hMiv8vmR12eH4mh73WmUCgTVrX0UZySpPZng8C4GNT9yGhT/tndA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(6666004)(426003)(7696005)(70206006)(1076003)(2616005)(6916009)(8676002)(86362001)(508600001)(356005)(6286002)(316002)(83380400001)(5660300002)(7636003)(26005)(54906003)(36756003)(186003)(2906002)(16526019)(4326008)(82310400004)(336012)(55016003)(47076005)(8936002)(107886003)(70586007)(36860700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "23 Nov 2021 22:32:15.5049 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ae2834dd-eea0-407a-00a4-08d9aed119fa", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT003.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH2PR12MB4117", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "mlx5_ind_table_obj_setup() was incrementing RxQ reference counters\neven when the port was stopped, which prevented RxQ release\nand triggered an internal assertion.\nOnly increment reference counter when the port is started.\n\nFixes: ec4e11d41d12 (\"net/mlx5: preserve indirect actions on restart\")\n\nSigned-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 22 +++++++++++++---------\n 1 file changed, 13 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 47dc24793b..8f9a94572f 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -2270,6 +2270,7 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_ind_table_obj *ind_tbl)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tbool dev_started = priv->dev_data->dev_started;\n \tuint32_t queues_n = ind_tbl->queues_n;\n \tuint16_t *queues = ind_tbl->queues;\n \tunsigned int i, j;\n@@ -2278,22 +2279,25 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev,\n \t\t\t log2above(queues_n) :\n \t\t\t log2above(priv->config.ind_table_max_size);\n \n-\tfor (i = 0; i != queues_n; ++i) {\n-\t\tif (mlx5_rxq_ref(dev, queues[i]) == NULL) {\n-\t\t\tret = -rte_errno;\n-\t\t\tgoto error;\n+\tif (dev_started)\n+\t\tfor (i = 0; i != queues_n; ++i) {\n+\t\t\tif (mlx5_rxq_ref(dev, queues[i]) == NULL) {\n+\t\t\t\tret = -rte_errno;\n+\t\t\t\tgoto error;\n+\t\t\t}\n \t\t}\n-\t}\n \tret = priv->obj_ops.ind_table_new(dev, n, ind_tbl);\n \tif (ret)\n \t\tgoto error;\n \t__atomic_fetch_add(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED);\n \treturn 0;\n error:\n-\terr = rte_errno;\n-\tfor (j = 0; j < i; j++)\n-\t\tmlx5_rxq_deref(dev, ind_tbl->queues[j]);\n-\trte_errno = err;\n+\tif (dev_started) {\n+\t\terr = rte_errno;\n+\t\tfor (j = 0; j < i; j++)\n+\t\t\tmlx5_rxq_deref(dev, queues[j]);\n+\t\trte_errno = err;\n+\t}\n \tDRV_LOG(DEBUG, \"Port %u cannot setup indirection table.\",\n \t\tdev->data->port_id);\n \treturn ret;\n", "prefixes": [ "1/2" ] }