Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104641/?format=api
{ "id": 104641, "url": "http://patchwork.dpdk.org/api/patches/104641/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211124043234.3287245-1-akozyrev@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211124043234.3287245-1-akozyrev@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211124043234.3287245-1-akozyrev@nvidia.com", "date": "2021-11-24T04:32:34", "name": "net/mlx5: fix GRE item matching", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0661934a86462fdc5c610af94032515ba2b6dccd", "submitter": { "id": 1873, "url": "http://patchwork.dpdk.org/api/people/1873/?format=api", "name": "Alexander Kozyrev", "email": "akozyrev@nvidia.com" }, "delegate": { "id": 3268, "url": "http://patchwork.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211124043234.3287245-1-akozyrev@nvidia.com/mbox/", "series": [ { "id": 20725, "url": "http://patchwork.dpdk.org/api/series/20725/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20725", "date": "2021-11-24T04:32:34", "name": "net/mlx5: fix GRE item matching", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20725/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104641/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104641/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 99E52A0C52;\n\tWed, 24 Nov 2021 05:32:57 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 006A940696;\n\tWed, 24 Nov 2021 05:32:57 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2047.outbound.protection.outlook.com [40.107.92.47])\n by mails.dpdk.org (Postfix) with ESMTP id 0C7D540040;\n Wed, 24 Nov 2021 05:32:56 +0100 (CET)", "from DM6PR04CA0023.namprd04.prod.outlook.com (2603:10b6:5:334::28)\n by DM6PR12MB3403.namprd12.prod.outlook.com (2603:10b6:5:11d::27) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.19; Wed, 24 Nov\n 2021 04:32:53 +0000", "from DM6NAM11FT066.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:334:cafe::21) by DM6PR04CA0023.outlook.office365.com\n (2603:10b6:5:334::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.21 via Frontend\n Transport; Wed, 24 Nov 2021 04:32:53 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT066.mail.protection.outlook.com (10.13.173.179) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Wed, 24 Nov 2021 04:32:53 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 24 Nov\n 2021 04:32:48 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=ReJ0SBXsLOdQctqepXDKOBWA/6uBIOIQXuaKcFugkWXRBrpOkYTLKE0OkhaWcwN83LtNU9IbxTR0fCJevu2yaBYaYOEua8Zdb35Q50s6VLC6c4sliu2w/ZESzH7v89vg1j3t/J1pK+BJ9cSN/MHc7wGIHKihzAFJ/U3+Q3yGwcLdREpAK89ij0cmlMJwhsvWsEDPVnIYQu3f9HYDaLCh8gjXtq7JZe6nlXRA9sqcXfjTxDPomnDKqlAFDf0jnPq4DqM8ofywoz9Swg7IrofLYTFD+ty0k0NG6/1qvYRRlYVJLkPxxifanQaxjhMtJt3f87cR0VPTuKaeJ6NHVt9KJQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=RvhCK560Y3+/jn2+5lmIGG8btBmw4ycViZ4LSMxjtfM=;\n b=ZP+0hUZObW20qlTXg89wZIJiugtVG/PnKldNFnYUC6Y90pyarH28TCGpILO4lXd6riNKpawdDY2tr+Jms1RoOSqt3f+eA74wZ63yNZAwnAkLZOS8eRzWrKy2BBMrAi2bixhmk7J+oCQ0S/8rdfzM0q93CbfvTUQvS9p9yNAMoRPz4hDDjWmsKEEU1uuSrkXwYE4+7h2W5NwUxXeOI3ZXypPlJ5o0KeSlqknJDNaDirGN9hAGTC6b/G3xDx3GqWF6GvUObuUz8NBGtrj+Nt2V0hHPzqD9M1JTFrfjCtjnCJ/SwS8SObP5lcxxz4ZvSaAYu1Z/Zp5IRABm7+tXYmic0w==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=RvhCK560Y3+/jn2+5lmIGG8btBmw4ycViZ4LSMxjtfM=;\n b=eQq8WPqjD0H0q1nF1AjULIYIm1hfKN2ByI/MbqBMcFLZV6wgNB87w+j1ed3bc1oPoOJK/5d/eX1seyiaVpGf/6dXzMa/R6nhIwKYI9NUZ2/Y8KPwWpxL3b/QDCSyqtmJTHFvTKwleH5afcogCf5Clbu96/TzXlFJ1o767PGi3tAMrTqPsfFOZj3zm4rCrUWqQ8rylbWMuFgpquZOkrBNfmMrO0Hcywmg3fNUnKJ1NQj+VCMzG6aZilMSJnf6noEGUugz15Y4JHtepbTOb2L0tjgsY8128yt51Lqg1nLkYQWqCvVpZRGiU2gJ+MsuBMqwi4yojy9raqv57NR7vspC2A==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Alexander Kozyrev <akozyrev@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<stable@dpdk.org>, <rasland@nvidia.com>, <viacheslavo@nvidia.com>,\n <matan@nvidia.com>, <getelson@nvidia.com>", "Subject": "[PATCH] net/mlx5: fix GRE item matching", "Date": "Wed, 24 Nov 2021 06:32:34 +0200", "Message-ID": "<20211124043234.3287245-1-akozyrev@nvidia.com>", "X-Mailer": "git-send-email 2.18.2", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL101.nvidia.com (172.20.187.10) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "e24cff82-24bd-46eb-3eae-08d9af037b22", "X-MS-TrafficTypeDiagnostic": "DM6PR12MB3403:", "X-Microsoft-Antispam-PRVS": "\n <DM6PR12MB3403D9B5DB05A76A77E39382AF619@DM6PR12MB3403.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:9508;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n DsLXBxLkNVukABep1E4V5ywGoYLl003t+XPWEVxF7iN52Dp052pLTZKlOQ4EVCH4inJ30mkDAsXg4Xh8tUzm2QhT6Jk9jlWkOxnZgSj4gzPXSdUHWUt1afzPewa8SSCAktS77ns3Y9axqgpbuxntgUJRXR3sqHg5m/4toeocVQR+OxDEmf/PF5UeFjFNbIwoYOI2XQmJVCQUjjrnwkppFmTHGxwEvVqWv/TgDEN+oNhFcBmbJKdoXR9Jw5somKeOa1J/x6sm58XjAc/Q64VY1nSB1c3l/rvYn1+vITSguyPnSZwMa+DuFLj6dYYqtxtyrIQq5s+ZsLFwNptgoG0GuUCV+HT7qrboTmpNWa/0EfogdZAU4aBxLIqUBEyw+Rbst8bIzm3iaV1x2gLceB8cJkdAanU+S3shzKHQGCuz8yUcm/Ek1DqFh9qKw3Cz2YZYEHgb1AbgfyAAmtCKw/dQ+LS/lGCKGjyXddoMgOs1S2I10ZlGAELSZzMMeE0Ghr2UvW/pvsmlMl8HZU8OuBGK5FMygkYXJLK1BDseXx5aaawUJFA5O/O24x4nPJ+UZvGpLVnprd/rb1gc6WfgrC2bVG3qOHKx79GSGqHTIJpvy4hpqHS2UrOxi2S+duXnnos7vXfgI1Np/dLBw5eVfyB74FV9P6mzXRmcs986mcCJyAIVV1E5ItTDcl1DTUN4w/5885RlzllS0AfOwyJkT4ynKw==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(46966006)(36840700001)(6286002)(450100002)(26005)(316002)(6666004)(1076003)(16526019)(4326008)(8936002)(36756003)(2906002)(82310400004)(55016003)(2616005)(7696005)(6916009)(186003)(508600001)(83380400001)(36860700001)(86362001)(54906003)(70206006)(47076005)(107886003)(336012)(5660300002)(426003)(356005)(7636003)(8676002)(70586007);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Nov 2021 04:32:53.4210 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e24cff82-24bd-46eb-3eae-08d9af037b22", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT066.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR12MB3403", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "GRE protocol type is implicitly set in the matching translation in case\nan application doesn't specify any type explicitly in a flow rule.\nIt is extracted from the inner header type, but this type may be absent.\nIn this case, GRE item matching is broken. Check if we have the inner\nheader type before setting it to allow matching on all GRE packets.\n\nFixes: be26e81bfc1c (\"net/mlx5: fix GRE protocol type translation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Alexander Kozyrev <akozyrev@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_dv.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 9d4bd0560c..7bb092ea9f 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -8823,8 +8823,9 @@ flow_dv_translate_item_gre(void *matcher, void *key,\n \tprotocol_v = rte_be_to_cpu_16(gre_v->protocol);\n \tif (!protocol_m) {\n \t\t/* Force next protocol to prevent matchers duplication */\n-\t\tprotocol_m = 0xFFFF;\n \t\tprotocol_v = mlx5_translate_tunnel_etypes(pattern_flags);\n+\t\tif (protocol_v)\n+\t\t\tprotocol_m = 0xFFFF;\n \t}\n \tMLX5_SET(fte_match_set_misc, misc_m, gre_protocol, protocol_m);\n \tMLX5_SET(fte_match_set_misc, misc_v, gre_protocol,\n", "prefixes": [] }