Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104654/?format=api
{ "id": 104654, "url": "http://patchwork.dpdk.org/api/patches/104654/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211124093556.3358394-2-dkozlyuk@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211124093556.3358394-2-dkozlyuk@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211124093556.3358394-2-dkozlyuk@nvidia.com", "date": "2021-11-24T09:35:52", "name": "[1/2] net/mlx5: fix indirect RSS creation when port is stopped", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0fed404ecf99309ac1faa92e64bfd30d039480c6", "submitter": { "id": 2248, "url": "http://patchwork.dpdk.org/api/people/2248/?format=api", "name": "Dmitry Kozlyuk", "email": "dkozlyuk@nvidia.com" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211124093556.3358394-2-dkozlyuk@nvidia.com/mbox/", "series": [ { "id": 20738, "url": "http://patchwork.dpdk.org/api/series/20738/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20738", "date": "2021-11-24T09:35:52", "name": "[1/2] net/mlx5: fix indirect RSS creation when port is stopped", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20738/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104654/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104654/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35113A0C52;\n\tWed, 24 Nov 2021 10:36:23 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D9B3441143;\n\tWed, 24 Nov 2021 10:36:20 +0100 (CET)", "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2045.outbound.protection.outlook.com [40.107.243.45])\n by mails.dpdk.org (Postfix) with ESMTP id A44474003C\n for <dev@dpdk.org>; Wed, 24 Nov 2021 10:36:17 +0100 (CET)", "from DM6PR03CA0042.namprd03.prod.outlook.com (2603:10b6:5:100::19)\n by CY4PR12MB1798.namprd12.prod.outlook.com (2603:10b6:903:11a::9) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4713.24; Wed, 24 Nov\n 2021 09:36:16 +0000", "from DM6NAM11FT026.eop-nam11.prod.protection.outlook.com\n (2603:10b6:5:100:cafe::d3) by DM6PR03CA0042.outlook.office365.com\n (2603:10b6:5:100::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.20 via Frontend\n Transport; Wed, 24 Nov 2021 09:36:15 +0000", "from mail.nvidia.com (216.228.112.34) by\n DM6NAM11FT026.mail.protection.outlook.com (10.13.172.161) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4713.20 via Frontend Transport; Wed, 24 Nov 2021 09:36:15 +0000", "from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com\n (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Wed, 24 Nov\n 2021 09:36:11 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UQB9pmOx6GoX+CWnMcPTxYPFsPwYX0F5YQtt5TWfNrkmxSJU9RHfD2v3AH0UbBHufNbJrFqdfJ7J7r0nN8cgcbovhI9KTMQftupw44TcD+ChlSVrj9uiRD+dPcTD+Zj7vQhiqTJSk1boUdrgaRpgLbKpY77yOT0Z1L1mdxOyE255M9FiH++MB1rVqeUiFUrXjA1wu8vA2f6DtRlnO9uNRb9uSl8MS26HWPcr1wZNm5MQSWEcQJ4g6EOUl3hsmpcAKeZPSXdwsFuDWcDKjW+hqeHpvgFp9LJaQKp+dovDn2PKJ5lHF1UaEn27xzqMiQ32qZfH9zu7wqNf3Cjaa3SONQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=;\n b=TXLywhW2YzhwPkAkxTtjbEOA7NYHEIeDzQPUHAEyot1gaCFQt98MuQeCHYjdHKBGOpmROiX5zSa7F2gVMlhm0WvhH1AiT/S1XaRTN3eOc4h4JWl7g2DLM/JZBvSkOtjmmTyMqvWB1L7/evAMSwhQFH4AJQVh0kQlivitDDkYKi95jWzbAP1JORmR0T/ecHTRFp/0gzFebpPMp7q4preOk/fh6mtlF/SHwesNsZSZmtTw9taFVQKxBzMC9ucJHs/DZIIFjrFQX3Oip6QUJtTZatBuscxJSL4fZwiuEUOvvf0TAdtIqptO2lJPvzkXeaapo3SZUWH7OAcxaDCySywESg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=+ptZHFWO6YTp0clNQoAGZT9zrgFvgfi35RSo365NPXY=;\n b=llsnAnybCX+iY6mXT5ZcKxNSeARueWvatolCyRtoxWD69Ojvfxvwi/6YETEdgUmpmtCakmn3R9UUWBbUAVyutlwZH3YDlTaT9m3iz+lOCu3c1tFjLnCW6f7AIHWxHJbqjqbc1HQIlmJdpXpj5RCt1kMqRKJIibE/DvOGs4Tg/2lWROWWWY4g0D7WaMcR9ZqDECa/CXXuiStABryejagLmzJ/lR+oTKdQfX9qY80pt1ogSRE2x4Ks+J/QfMx/AoCyULrpQ3KvkvTy2CKStGBQvDUeZ3uJTbdvRmcgdB2km7o7ZjSavy0zLpCJb+vxGoygar8wAYr74k8LvnDXtBXuVg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.34)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.34 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.34; helo=mail.nvidia.com;", "From": "Dmitry Kozlyuk <dkozlyuk@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Raslan Darawsheh <rasland@nvidia.com>, Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>", "Subject": "[PATCH 1/2] net/mlx5: fix indirect RSS creation when port is stopped", "Date": "Wed, 24 Nov 2021 11:35:52 +0200", "Message-ID": "<20211124093556.3358394-2-dkozlyuk@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20211124093556.3358394-1-dkozlyuk@nvidia.com>", "References": "<20211123223159.3324247-1-dkozlyuk@nvidia.com>\n <20211124093556.3358394-1-dkozlyuk@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL105.nvidia.com (172.20.187.12) To\n HQMAIL107.nvidia.com (172.20.187.13)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "5415f257-1588-4f40-9e80-08d9af2ddc64", "X-MS-TrafficTypeDiagnostic": "CY4PR12MB1798:", "X-Microsoft-Antispam-PRVS": "\n <CY4PR12MB1798AA3CD3B8B173B65DB1C4B9619@CY4PR12MB1798.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2000;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n V315Wj427hFz8lJDfx+F3tckHWQlDyG6i+R9YHtJU8GSLfRRWTKThzkb49ia/k4/J0qbK4yMS20utmKFfMfcKsqjsWe/KMXHZJ/mN2YJjT7s/762PjaN/L6hSdVBlfpSKsCO2O2F5HbteITx4MbpEXdpbgsBlknDv0Us2LBK2uEz3l98XmBGPsYgdf49AJDOOFIMX9oRken+wWwA1s2lOjO7b/mnrWPD0nxf7eFky6vbKYtPtDurxV0iTMIVW95tR1DNk2dPDWFimc0YTmG+blj0cfar7IN12qiSH1e8/NwunRnHkYa4evfWApiZF9oAktxensjMS2ez2p21HxRVQwC5rnSL8yGgtJUL+3jhaxh65gBVX/NE+KiUFbtHYOjCEjWQUSCCaMYc6WhAhhUCsRcI9yf4tDhSHSDEjO2EUTohkANsMnd5pZ43LcJFefYlzwEqcyO1AXLyqsdds3UoXJBoHF0Ud1TyNn2FqvAqprb8+C++PlfhRJ3hRUk+Fk/qzTiiHyLLfe+EyHy8GH75DBKOdzdSKpDD3PaA+cegoKFQaDBDfvP4dOkm12VMVsdQ0PkvOgriqGlibedgqtA8Mnpmd91WCGpr93zMdgmVE4pJTL4ub3kg289OJcnC8bQJ3rRXK3XRnFfQ8G5Eu7JIS9lsuy8oHFdC5nCXjNLuUc7WPd8C9gvi0eTT4NfPkcIqiwUmr3h7O1VmHujyRlVX5w==", "X-Forefront-Antispam-Report": "CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(4326008)(8936002)(2906002)(6286002)(47076005)(5660300002)(107886003)(16526019)(83380400001)(7696005)(26005)(6666004)(86362001)(36860700001)(82310400004)(6916009)(186003)(508600001)(316002)(336012)(7636003)(70586007)(426003)(70206006)(1076003)(356005)(8676002)(55016003)(36756003)(54906003)(2616005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "24 Nov 2021 09:36:15.4357 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 5415f257-1588-4f40-9e80-08d9af2ddc64", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DM6NAM11FT026.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY4PR12MB1798", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "mlx5_ind_table_obj_setup() was incrementing RxQ reference counters\neven when the port was stopped, which prevented RxQ release\nand triggered an internal assertion.\nOnly increment reference counter when the port is started.\n\nFixes: ec4e11d41d12 (\"net/mlx5: preserve indirect actions on restart\")\n\nSigned-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 22 +++++++++++++---------\n 1 file changed, 13 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex 47dc24793b..8f9a94572f 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -2270,6 +2270,7 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_ind_table_obj *ind_tbl)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n+\tbool dev_started = priv->dev_data->dev_started;\n \tuint32_t queues_n = ind_tbl->queues_n;\n \tuint16_t *queues = ind_tbl->queues;\n \tunsigned int i, j;\n@@ -2278,22 +2279,25 @@ mlx5_ind_table_obj_setup(struct rte_eth_dev *dev,\n \t\t\t log2above(queues_n) :\n \t\t\t log2above(priv->config.ind_table_max_size);\n \n-\tfor (i = 0; i != queues_n; ++i) {\n-\t\tif (mlx5_rxq_ref(dev, queues[i]) == NULL) {\n-\t\t\tret = -rte_errno;\n-\t\t\tgoto error;\n+\tif (dev_started)\n+\t\tfor (i = 0; i != queues_n; ++i) {\n+\t\t\tif (mlx5_rxq_ref(dev, queues[i]) == NULL) {\n+\t\t\t\tret = -rte_errno;\n+\t\t\t\tgoto error;\n+\t\t\t}\n \t\t}\n-\t}\n \tret = priv->obj_ops.ind_table_new(dev, n, ind_tbl);\n \tif (ret)\n \t\tgoto error;\n \t__atomic_fetch_add(&ind_tbl->refcnt, 1, __ATOMIC_RELAXED);\n \treturn 0;\n error:\n-\terr = rte_errno;\n-\tfor (j = 0; j < i; j++)\n-\t\tmlx5_rxq_deref(dev, ind_tbl->queues[j]);\n-\trte_errno = err;\n+\tif (dev_started) {\n+\t\terr = rte_errno;\n+\t\tfor (j = 0; j < i; j++)\n+\t\t\tmlx5_rxq_deref(dev, queues[j]);\n+\t\trte_errno = err;\n+\t}\n \tDRV_LOG(DEBUG, \"Port %u cannot setup indirection table.\",\n \t\tdev->data->port_id);\n \treturn ret;\n", "prefixes": [ "1/2" ] }