Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104741/?format=api
{ "id": 104741, "url": "http://patchwork.dpdk.org/api/patches/104741/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-3-rbalu@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211129095159.16376-3-rbalu@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211129095159.16376-3-rbalu@marvell.com", "date": "2021-11-29T09:51:56", "name": "[2/5] crypto/openssl: fix output of RSA verify op", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "c0d418e079da0c4d7eb67a85fbe92f02dce7a241", "submitter": { "id": 2428, "url": "http://patchwork.dpdk.org/api/people/2428/?format=api", "name": "Ramkumar Balu", "email": "rbalu@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-3-rbalu@marvell.com/mbox/", "series": [ { "id": 20798, "url": "http://patchwork.dpdk.org/api/series/20798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20798", "date": "2021-11-29T09:51:54", "name": "cryptodev: fix inconsistency in RSA op usage", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20798/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104741/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104741/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 60C7DA0C5A;\n\tMon, 29 Nov 2021 11:41:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 10AFB41147;\n\tMon, 29 Nov 2021 11:41:11 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id EAAB540689;\n Mon, 29 Nov 2021 10:53:18 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1ASLrU0T017558;\n Mon, 29 Nov 2021 01:53:18 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cmgkpsuht-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 29 Nov 2021 01:53:17 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 29 Nov 2021 01:53:16 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 29 Nov 2021 01:53:16 -0800", "from rbalu.marvell.com (unknown [10.29.53.29])\n by maili.marvell.com (Postfix) with ESMTP id DC42C3F7079;\n Mon, 29 Nov 2021 01:53:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=gfmG/K17S1B8BgwswZveGnpZ8uta98xGz6hunFg/hbo=;\n b=UN5mOJZHmDvXVphFfaFfLVHjDyFCyohNeNT+9ktzhEM0g0Wb52KShlVEEUM9gE/iA5Gc\n YWWLwdwHEJRi1IVlqqPC3XU4ZFAfJnTAUTZf2QpE3gAVoT2SZT5DSpL+zR2kV/ho5ZvG\n Q0RjjjKTmvJFiBjJN+kzCmECZ41nwbArP2I18if2KjsFspkC5U8yqwPbvtL2Oyw/cpnf\n zLHJZ30EPxAWKNDumjURXkFBu6roCJj7BEpDLXWmhiJqKXUUEBePuZ3QSM+U+Gbt1rie\n 9b/YNsOSSmsBdVuaGx2cUovHJU8yyejtFqHWBEMEBpHmPL9yf2nQioXUgGTmL0YAQEL9 AQ==", "From": "Ramkumar Balu <rbalu@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Declan Doherty <declan.doherty@intel.com>, Fan Zhang\n <roy.fan.zhang@intel.com>, Ankur Dwivedi <adwivedi@marvell.com>, \"Tejasree\n Kondoj\" <ktejasree@marvell.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Ramkumar <rbalu@marvell.com>", "Subject": "[PATCH 2/5] crypto/openssl: fix output of RSA verify op", "Date": "Mon, 29 Nov 2021 09:51:56 +0000", "Message-ID": "<20211129095159.16376-3-rbalu@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211129095159.16376-1-rbalu@marvell.com>", "References": "<20211129095159.16376-1-rbalu@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "r2s8pKg1049fSOrbP6KjbPPatOebb0DK", "X-Proofpoint-GUID": "r2s8pKg1049fSOrbP6KjbPPatOebb0DK", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01", "X-Mailman-Approved-At": "Mon, 29 Nov 2021 11:41:08 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ramkumar <rbalu@marvell.com>\n\nDuring RSA verify, the OpenSSL PMD fails to return the plaintext after\npublic key decryption.\nThis patch fixes the OpenSSL PMD to return the decrypted plaintext in\ncipher.data / cipher.length fields\n\nFixes: 3e9d6bd447fb (\"crypto/openssl: add RSA and mod asym operations\")\nFixes: fe1606e0138c (\"crypto/openssl: fix RSA verify operation\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ramkumar <rbalu@marvell.com>\n---\n drivers/crypto/openssl/rte_openssl_pmd.c | 16 +++++++++++-----\n 1 file changed, 11 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c\nindex 5794ed8159..3ab2c3b5c1 100644\n--- a/drivers/crypto/openssl/rte_openssl_pmd.c\n+++ b/drivers/crypto/openssl/rte_openssl_pmd.c\n@@ -1953,12 +1953,16 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,\n \t\tbreak;\n \n \tcase RTE_CRYPTO_ASYM_OP_VERIFY:\n-\t\ttmp = rte_malloc(NULL, op->rsa.sign.length, 0);\n+\t\ttmp = op->rsa.cipher.data;\n \t\tif (tmp == NULL) {\n-\t\t\tOPENSSL_LOG(ERR, \"Memory allocation failed\");\n-\t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n-\t\t\tbreak;\n+\t\t\ttmp = rte_malloc(NULL, op->rsa.sign.length, 0);\n+\t\t\tif (tmp == NULL) {\n+\t\t\t\tOPENSSL_LOG(ERR, \"Memory allocation failed\");\n+\t\t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n+\t\t\t\tbreak;\n+\t\t\t}\n \t\t}\n+\n \t\tret = RSA_public_decrypt(op->rsa.sign.length,\n \t\t\t\top->rsa.sign.data,\n \t\t\t\ttmp,\n@@ -1974,7 +1978,9 @@ process_openssl_rsa_op(struct rte_crypto_op *cop,\n \t\t\tOPENSSL_LOG(ERR, \"RSA sign Verification failed\");\n \t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t}\n-\t\trte_free(tmp);\n+\t\top->rsa.cipher.length = ret;\n+\t\tif (tmp != op->rsa.cipher.data)\n+\t\t\trte_free(tmp);\n \t\tbreak;\n \n \tdefault:\n", "prefixes": [ "2/5" ] }