Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104743/?format=api
{ "id": 104743, "url": "http://patchwork.dpdk.org/api/patches/104743/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-5-rbalu@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211129095159.16376-5-rbalu@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211129095159.16376-5-rbalu@marvell.com", "date": "2021-11-29T09:51:58", "name": "[4/5] crypto/octeontx2: fix output field for RSA verify", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "914918d907785c23cd776397115851e547fb3175", "submitter": { "id": 2428, "url": "http://patchwork.dpdk.org/api/people/2428/?format=api", "name": "Ramkumar Balu", "email": "rbalu@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-5-rbalu@marvell.com/mbox/", "series": [ { "id": 20798, "url": "http://patchwork.dpdk.org/api/series/20798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20798", "date": "2021-11-29T09:51:54", "name": "cryptodev: fix inconsistency in RSA op usage", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20798/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104743/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104743/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F1EB2A0C5A;\n\tMon, 29 Nov 2021 11:41:30 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 10F1642765;\n\tMon, 29 Nov 2021 11:41:13 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 2E10040689;\n Mon, 29 Nov 2021 10:53:46 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1AT7ZQbC009078;\n Mon, 29 Nov 2021 01:53:45 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cmtkpgdcx-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 29 Nov 2021 01:53:45 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 29 Nov 2021 01:53:43 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 29 Nov 2021 01:53:43 -0800", "from rbalu.marvell.com (unknown [10.29.53.29])\n by maili.marvell.com (Postfix) with ESMTP id 96E163F7090;\n Mon, 29 Nov 2021 01:53:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=owL+yEvx51IDYyVIvVBL3b77DK9AOZ8ahfxiHWcTZpU=;\n b=L2XsoQZcmAv5h2MjgoPXYmsLGtUybdQS2/cAgbmCow3tiRd0U1d59fHKyK8Z5uooLpoa\n ET+otuAbgATLBnslKA10kn3GB3OhiduXVcdjtndrXPnOoS9a3dck1T77D4QDz1mqnZ/E\n KrtVYxEIDTQbBT6dZ78ATVpSdnrZGBrvNPUJj7f3zDcOHtXaDX1GfyClIKUC1oAFNNfC\n oEWTWc2d6yzcL5/d0PV5sHQm5w+ELSCD/nDAbC3ohjGDKsLRO3rnIvAApFjhCpvdfGy/\n mQVqB8S46dKEQrBOOtlkmibQtkKed/ndFWTdo6nYE45+w7dEXgXRWfbWzuzxs3peH0O2 nQ==", "From": "Ramkumar Balu <rbalu@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Declan Doherty <declan.doherty@intel.com>, Fan Zhang\n <roy.fan.zhang@intel.com>, Ankur Dwivedi <adwivedi@marvell.com>, \"Tejasree\n Kondoj\" <ktejasree@marvell.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Ramkumar <rbalu@marvell.com>", "Subject": "[PATCH 4/5] crypto/octeontx2: fix output field for RSA verify", "Date": "Mon, 29 Nov 2021 09:51:58 +0000", "Message-ID": "<20211129095159.16376-5-rbalu@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211129095159.16376-1-rbalu@marvell.com>", "References": "<20211129095159.16376-1-rbalu@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "3eyfa1uWCsgCQNHauh7yVSnzb7T61Nj0", "X-Proofpoint-ORIG-GUID": "3eyfa1uWCsgCQNHauh7yVSnzb7T61Nj0", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01", "X-Mailman-Approved-At": "Mon, 29 Nov 2021 11:41:08 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ramkumar <rbalu@marvell.com>\n\nDuring RSA sign verification, the OCTEONTX2 PMD returns the decrypted\nplaintext in 'sign' field of rte_crypto_rsa_op_param. The 'sign'\nfield is actually used to pass input to the operation. This PMD\noverwrites the 'sign' field buffer. This is non-compliance to lib\ncryptodev.\n\nThis patch fixes the PMD to use 'cipher' field to return the decrypted\nplaintext during RSA verify operation.\n\nFixes: 04227377c81b (\"crypto/octeontx2: support asymmetric in enqueue/dequeue\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ramkumar <rbalu@marvell.com>\n---\n drivers/crypto/octeontx2/otx2_cryptodev_ops.c | 16 +++++++++-------\n 1 file changed, 9 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\nindex 339b82f33e..fb38e309aa 100644\n--- a/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n+++ b/drivers/crypto/octeontx2/otx2_cryptodev_ops.c\n@@ -876,20 +876,22 @@ otx2_cpt_asym_rsa_op(struct rte_crypto_op *cop, struct cpt_request_info *req,\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_VERIFY:\n \t\tif (rsa->pad == RTE_CRYPTO_RSA_PADDING_NONE) {\n-\t\t\trsa->sign.length = rsa_ctx->n.length;\n-\t\t\tmemcpy(rsa->sign.data, req->rptr, rsa->sign.length);\n+\t\t\trsa->cipher.length = rsa_ctx->n.length;\n \t\t} else {\n \t\t\t/* Get length of signed output */\n-\t\t\trsa->sign.length = rte_cpu_to_be_16\n+\t\t\trsa->cipher.length = rte_cpu_to_be_16\n \t\t\t\t\t (*((uint16_t *)req->rptr));\n \t\t\t/*\n \t\t\t * Offset output data pointer by length field\n-\t\t\t * (2 bytes) and copy signed data.\n+\t\t\t * (2 bytes).\n \t\t\t */\n-\t\t\tmemcpy(rsa->sign.data, req->rptr + 2,\n-\t\t\t rsa->sign.length);\n+\t\t\treq->rptr += 2;\n \t\t}\n-\t\tif (memcmp(rsa->sign.data, rsa->message.data,\n+\n+\t\tif (rsa->cipher.data != NULL)\n+\t\t\tmemcpy(rsa->cipher.data, req->rptr, rsa->cipher.length);\n+\n+\t\tif (memcmp(req->rptr, rsa->message.data,\n \t\t\t rsa->message.length)) {\n \t\t\tCPT_LOG_DP_ERR(\"RSA verification failed\");\n \t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n", "prefixes": [ "4/5" ] }