Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104744/?format=api
{ "id": 104744, "url": "http://patchwork.dpdk.org/api/patches/104744/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-6-rbalu@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211129095159.16376-6-rbalu@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211129095159.16376-6-rbalu@marvell.com", "date": "2021-11-29T09:51:59", "name": "[5/5] crypto/cnxk: fix output field for RSA verify", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "0b4163063306dc06b9093ebb909c1ba26da78d33", "submitter": { "id": 2428, "url": "http://patchwork.dpdk.org/api/people/2428/?format=api", "name": "Ramkumar Balu", "email": "rbalu@marvell.com" }, "delegate": { "id": 6690, "url": "http://patchwork.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211129095159.16376-6-rbalu@marvell.com/mbox/", "series": [ { "id": 20798, "url": "http://patchwork.dpdk.org/api/series/20798/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20798", "date": "2021-11-29T09:51:54", "name": "cryptodev: fix inconsistency in RSA op usage", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20798/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104744/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104744/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1D570A0C5A;\n\tMon, 29 Nov 2021 11:41:36 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1885A4276F;\n\tMon, 29 Nov 2021 11:41:14 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id EAF7E40689;\n Mon, 29 Nov 2021 10:53:54 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1ASNMELR003048;\n Mon, 29 Nov 2021 01:53:54 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cmgkpsukv-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 29 Nov 2021 01:53:53 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 29 Nov 2021 01:53:52 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 29 Nov 2021 01:53:52 -0800", "from rbalu.marvell.com (unknown [10.29.53.29])\n by maili.marvell.com (Postfix) with ESMTP id D41E63F7079;\n Mon, 29 Nov 2021 01:53:46 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=StPUS0yw/3b3gzBjvTh64tEZYrUs4sHF+7m0mhXxD68=;\n b=X+EJAtFPE0B8U+AAExMcS9fPCb0NmdYr4eJn1pTX2p3eOSMZ6+J1xKLvowkuXdeXcLQG\n t0T/ge60c/2F4/hPU46sVbpxlGpCPAn4cP6WK3mTxrsmqFvrw827cfiqvoBCYhwRa4oX\n jRiePlwxoItd+hQ+TyUWbD369qTGhgONeA4as+uJQKLBQ0HPLBgT8LIRiiLA0LjbvUEo\n SizZ/DGV1T3/CktSHtnOAAxq3FXP5aTfrxWC2ghxwnH3XU9uAkNoQM598Fp/n6Zigc+H\n X6BV+2hOnq/7D5DA8ask3vyZt4DKqmFeeE3xm8MeALw0Mi20YLr4EaGcRfHzPObl5Q7r bw==", "From": "Ramkumar Balu <rbalu@marvell.com>", "To": "Akhil Goyal <gakhil@marvell.com>, Anoob Joseph <anoobj@marvell.com>,\n Declan Doherty <declan.doherty@intel.com>, Fan Zhang\n <roy.fan.zhang@intel.com>, Ankur Dwivedi <adwivedi@marvell.com>, \"Tejasree\n Kondoj\" <ktejasree@marvell.com>", "CC": "<stable@dpdk.org>, <dev@dpdk.org>, Ramkumar <rbalu@marvell.com>", "Subject": "[PATCH 5/5] crypto/cnxk: fix output field for RSA verify", "Date": "Mon, 29 Nov 2021 09:51:59 +0000", "Message-ID": "<20211129095159.16376-6-rbalu@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211129095159.16376-1-rbalu@marvell.com>", "References": "<20211129095159.16376-1-rbalu@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "Vmx8QBnoUD8gMCzJVuGaAE-p6JO6e0o4", "X-Proofpoint-GUID": "Vmx8QBnoUD8gMCzJVuGaAE-p6JO6e0o4", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-29_07,2021-11-28_01,2020-04-07_01", "X-Mailman-Approved-At": "Mon, 29 Nov 2021 11:41:08 +0100", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ramkumar <rbalu@marvell.com>\n\nDuring RSA sign verification, this PMD returns the decrypted plaintext\nin 'sign' field of rte_crypto_rsa_op_param. The 'sign' field is\nactually used to pass input to the operation. This PMD overwrites the\n'sign' field buffer. This is non-compliance to lib cryptodev.\n\nThis patch fixes the PMD to use 'cipher' field to return the decrypted\nplaintext during RSA verify operation.\n\nFixes: 6661bedf1605 (\"crypto/cnxk: add asymmetric datapath\")\nCc: stable@dpdk.org\n\nSigned-off-by: Ramkumar <rbalu@marvell.com>\n---\n drivers/crypto/cnxk/cnxk_ae.h | 15 +++++++++------\n 1 file changed, 9 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/crypto/cnxk/cnxk_ae.h b/drivers/crypto/cnxk/cnxk_ae.h\nindex 6222171fe6..f4c6c92880 100644\n--- a/drivers/crypto/cnxk/cnxk_ae.h\n+++ b/drivers/crypto/cnxk/cnxk_ae.h\n@@ -696,19 +696,22 @@ cnxk_ae_dequeue_rsa_op(struct rte_crypto_op *cop, uint8_t *rptr,\n \t\tbreak;\n \tcase RTE_CRYPTO_ASYM_OP_VERIFY:\n \t\tif (rsa->pad == RTE_CRYPTO_RSA_PADDING_NONE) {\n-\t\t\trsa->sign.length = rsa_ctx->n.length;\n-\t\t\tmemcpy(rsa->sign.data, rptr, rsa->sign.length);\n+\t\t\trsa->cipher.length = rsa_ctx->n.length;\n \t\t} else {\n \t\t\t/* Get length of signed output */\n-\t\t\trsa->sign.length =\n+\t\t\trsa->cipher.length =\n \t\t\t\trte_cpu_to_be_16(*((uint16_t *)rptr));\n \t\t\t/*\n \t\t\t * Offset output data pointer by length field\n-\t\t\t * (2 bytes) and copy signed data.\n+\t\t\t * (2 bytes).\n \t\t\t */\n-\t\t\tmemcpy(rsa->sign.data, rptr + 2, rsa->sign.length);\n+\t\t\trptr += 2;\n \t\t}\n-\t\tif (memcmp(rsa->sign.data, rsa->message.data,\n+\n+\t\tif (rsa->cipher.data != NULL)\n+\t\t\tmemcpy(rsa->cipher.data, rptr, rsa->cipher.length);\n+\n+\t\tif (memcmp(rptr, rsa->message.data,\n \t\t\t rsa->message.length)) {\n \t\t\tcop->status = RTE_CRYPTO_OP_STATUS_ERROR;\n \t\t}\n", "prefixes": [ "5/5" ] }