Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104768/?format=api
{ "id": 104768, "url": "http://patchwork.dpdk.org/api/patches/104768/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211130054527.2696881-1-asekhar@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211130054527.2696881-1-asekhar@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211130054527.2696881-1-asekhar@marvell.com", "date": "2021-11-30T05:45:27", "name": "common/cnxk: use cas with release semantics for batch alloc", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c80035e1733cdaa4d775aff1a049bd207732519b", "submitter": { "id": 2125, "url": "http://patchwork.dpdk.org/api/people/2125/?format=api", "name": "Ashwin Sekhar T K", "email": "asekhar@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211130054527.2696881-1-asekhar@marvell.com/mbox/", "series": [ { "id": 20810, "url": "http://patchwork.dpdk.org/api/series/20810/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20810", "date": "2021-11-30T05:45:27", "name": "common/cnxk: use cas with release semantics for batch alloc", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20810/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104768/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/104768/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D102A0C58;\n\tTue, 30 Nov 2021 06:47:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1F2BC4068F;\n\tTue, 30 Nov 2021 06:47:25 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 0C0264068B\n for <dev@dpdk.org>; Tue, 30 Nov 2021 06:47:23 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1AU07O55026005\n for <dev@dpdk.org>; Mon, 29 Nov 2021 21:47:22 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cn23wu1r2-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 29 Nov 2021 21:47:21 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Mon, 29 Nov 2021 21:47:20 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Mon, 29 Nov 2021 21:47:20 -0800", "from lab-ci-142.marvell.com (unknown [10.28.36.142])\n by maili.marvell.com (Postfix) with ESMTP id 528C85C68F2;\n Mon, 29 Nov 2021 21:47:17 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=V/hznvf9wZLBH8f5HYbeRffraOTO9hI2orgyxT4LRhg=;\n b=Ot3fg/YArJwDBqKy6x03Nu88V3Hu50235jd6o8+xxx44zfIWBMh8Pa2sU5ME6Olziss8\n pqVV954lUgfaSgpRy/xFCHhHLbVwDWot7hAd1d11+7OP3icLkM/WDbHJUTXnUGC86QS5\n jKJWnHPECTQNws37s8bF1dh78hHwhFicuCH1CUkKwvn8QMg/W0tGMmdrk7JTBwim0bJs\n Y0sEZ5j/BQ+0dBXL7nK/7l4+R6x/PyYkQrqfcLV0FR/ur9q2FHYuKiY/w4Ryk1AAKSQX\n bqHdJebzMi0cOuIUfjeaGLDK+ANhdINx9iVmo9IDVyUxCmg8h21YCeWqJ0W5U/i9fuMP 0Q==", "From": "Ashwin Sekhar T K <asekhar@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<ndabilpuram@marvell.com>, <jerinj@marvell.com>, <skori@marvell.com>,\n <skoteshwar@marvell.com>, <pbhagavatula@marvell.com>,\n <kirankumark@marvell.com>, <psatheesh@marvell.com>,\n <asekhar@marvell.com>, <anoobj@marvell.com>, <gakhil@marvell.com>", "Subject": "[PATCH] common/cnxk: use cas with release semantics for batch alloc", "Date": "Tue, 30 Nov 2021 11:15:27 +0530", "Message-ID": "<20211130054527.2696881-1-asekhar@marvell.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "8c5j_OIByBDwPlL6kCIPo-rFUq58ztFI", "X-Proofpoint-GUID": "8c5j_OIByBDwPlL6kCIPo-rFUq58ztFI", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-30_04,2021-11-28_01,2020-04-07_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Before issuing the batch alloc, we clear the first word of\ncache lines so that NPA can update the status. Make sure that\nthis line clear is flushed before the batch alloc is issued.\n\nSigned-off-by: Ashwin Sekhar T K <asekhar@marvell.com>\n---\n drivers/common/cnxk/roc_io.h | 12 ++++++++++++\n drivers/common/cnxk/roc_io_generic.h | 9 +++++++++\n drivers/common/cnxk/roc_npa.h | 2 +-\n 3 files changed, 22 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/common/cnxk/roc_io.h b/drivers/common/cnxk/roc_io.h\nindex fe5f7f46d0..4f15503c29 100644\n--- a/drivers/common/cnxk/roc_io.h\n+++ b/drivers/common/cnxk/roc_io.h\n@@ -78,6 +78,18 @@ roc_atomic64_cas(uint64_t compare, uint64_t swap, int64_t *ptr)\n \treturn compare;\n }\n \n+static __plt_always_inline uint64_t\n+roc_atomic64_casl(uint64_t compare, uint64_t swap, int64_t *ptr)\n+{\n+\tasm volatile(PLT_CPU_FEATURE_PREAMBLE\n+\t\t \"casl %[compare], %[swap], [%[ptr]]\\n\"\n+\t\t : [compare] \"+r\"(compare)\n+\t\t : [swap] \"r\"(swap), [ptr] \"r\"(ptr)\n+\t\t : \"memory\");\n+\n+\treturn compare;\n+}\n+\n static __plt_always_inline uint64_t\n roc_atomic64_add_nosync(int64_t incr, int64_t *ptr)\n {\ndiff --git a/drivers/common/cnxk/roc_io_generic.h b/drivers/common/cnxk/roc_io_generic.h\nindex ceaa3a38d8..5f90835c09 100644\n--- a/drivers/common/cnxk/roc_io_generic.h\n+++ b/drivers/common/cnxk/roc_io_generic.h\n@@ -41,6 +41,15 @@ roc_atomic64_cas(uint64_t compare, uint64_t swap, int64_t *ptr)\n \treturn compare;\n }\n \n+static __plt_always_inline uint64_t\n+roc_atomic64_casl(uint64_t compare, uint64_t swap, int64_t *ptr)\n+{\n+\tPLT_SET_USED(swap);\n+\tPLT_SET_USED(ptr);\n+\n+\treturn compare;\n+}\n+\n static inline uint64_t\n roc_atomic64_add_nosync(int64_t incr, int64_t *ptr)\n {\ndiff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h\nindex 46350fdb48..19b9a9352c 100644\n--- a/drivers/common/cnxk/roc_npa.h\n+++ b/drivers/common/cnxk/roc_npa.h\n@@ -218,7 +218,7 @@ roc_npa_aura_batch_alloc_issue(uint64_t aura_handle, uint64_t *buf,\n \tcmp.compare_s.dis_wait = dis_wait;\n \tcmp.compare_s.count = num;\n \n-\tres = roc_atomic64_cas(cmp.u, (uint64_t)buf, addr);\n+\tres = roc_atomic64_casl(cmp.u, (uint64_t)buf, addr);\n \tif (res != ALLOC_RESULT_ACCEPTED && res != ALLOC_RESULT_NOCORE)\n \t\treturn -1;\n \n", "prefixes": [] }