Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104774/?format=api
{ "id": 104774, "url": "http://patchwork.dpdk.org/api/patches/104774/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211130064147.1023321-1-rkudurumalla@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211130064147.1023321-1-rkudurumalla@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211130064147.1023321-1-rkudurumalla@marvell.com", "date": "2021-11-30T06:41:46", "name": "[1/2] net/cnxk: update meter bpf ID in rq", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "671dce9639ded3b1f1333ecab2f82d497e779816", "submitter": { "id": 2289, "url": "http://patchwork.dpdk.org/api/people/2289/?format=api", "name": "Rakesh Kudurumalla", "email": "rkudurumalla@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211130064147.1023321-1-rkudurumalla@marvell.com/mbox/", "series": [ { "id": 20813, "url": "http://patchwork.dpdk.org/api/series/20813/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20813", "date": "2021-11-30T06:41:46", "name": "[1/2] net/cnxk: update meter bpf ID in rq", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20813/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104774/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104774/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96206A0C58;\n\tTue, 30 Nov 2021 07:42:22 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 5EFB54068F;\n\tTue, 30 Nov 2021 07:42:22 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id B37124068B\n for <dev@dpdk.org>; Tue, 30 Nov 2021 07:42:20 +0100 (CET)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1AU3f6E7017637\n for <dev@dpdk.org>; Mon, 29 Nov 2021 22:42:20 -0800", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3cmtkpmw4x-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Mon, 29 Nov 2021 22:42:19 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.18;\n Mon, 29 Nov 2021 22:42:18 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Mon, 29 Nov 2021 22:42:18 -0800", "from localhost.localdomain (unknown [10.28.48.103])\n by maili.marvell.com (Postfix) with ESMTP id 4C6D05C68E3;\n Mon, 29 Nov 2021 22:42:16 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=DBqbBbcREN3EVvwl/qFlAscd3xJcMMUlfPxDd1vpPS0=;\n b=LqVj1EdvLkJRjmS2DPAhhmmncBzG1Fbnz6FlIFOAgQ5K7+gMvGwbLZ9LDoN97umcOAFg\n n1DYElD9S3SW8gPXAIIT2X2VkNoX/onNYW0/ZLwBYRJ2SQwBrybzzYUoewk3muj81brx\n WdYcaa2jeadOTLpcmp1H9J8sRFaGzUf3ySjwg2RzoiXwRM873rwX8kEUo5ZFWgcNLqwp\n 4dAKFGjcdpgQluCCEsZktq2gZtQb9gXNc/WZRkxyiyUz2CQD5ugFzyT/OwBCFsqESopX\n nY42WTWKfg2i90LU7f/AoFM4vUkXs2EUAnwNtzCPFW9fiRhmzE4T9CKKlxq37QHk48ay Rw==", "From": "Rakesh Kudurumalla <rkudurumalla@marvell.com>", "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Rakesh Kudurumalla <rkudurumalla@marvell.com>", "Subject": "[PATCH 1/2] net/cnxk: update meter bpf ID in rq", "Date": "Tue, 30 Nov 2021 12:11:46 +0530", "Message-ID": "<20211130064147.1023321-1-rkudurumalla@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "7VP_n09GgvjTlzh17cFy5sEz1R53txJe", "X-Proofpoint-ORIG-GUID": "7VP_n09GgvjTlzh17cFy5sEz1R53txJe", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-30_05,2021-11-28_01,2020-04-07_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Patch updates configured meter bpf is in rq context\nduring meter creation\n\nSigned-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com>\n---\n drivers/net/cnxk/cn10k_rte_flow.c | 9 ++++-----\n drivers/net/cnxk/cnxk_ethdev_mtr.c | 25 ++++++++++++++++++-------\n 2 files changed, 22 insertions(+), 12 deletions(-)", "diff": "diff --git a/drivers/net/cnxk/cn10k_rte_flow.c b/drivers/net/cnxk/cn10k_rte_flow.c\nindex b830abe63e..402bb1c72f 100644\n--- a/drivers/net/cnxk/cn10k_rte_flow.c\n+++ b/drivers/net/cnxk/cn10k_rte_flow.c\n@@ -36,20 +36,20 @@ cn10k_mtr_configure(struct rte_eth_dev *eth_dev,\n \tfor (i = 0; actions[i].type != RTE_FLOW_ACTION_TYPE_END; i++) {\n \t\tif (actions[i].type == RTE_FLOW_ACTION_TYPE_METER) {\n \t\t\tmtr_conf = (const struct rte_flow_action_meter\n-\t\t\t\t\t *)(actions->conf);\n+\t\t\t\t\t *)(actions[i].conf);\n \t\t\tmtr_id = mtr_conf->mtr_id;\n \t\t\tis_mtr_act = true;\n \t\t}\n \t\tif (actions[i].type == RTE_FLOW_ACTION_TYPE_QUEUE) {\n \t\t\tq_conf = (const struct rte_flow_action_queue\n-\t\t\t\t\t *)(actions->conf);\n+\t\t\t\t\t *)(actions[i].conf);\n \t\t\tif (is_mtr_act)\n \t\t\t\tnix_mtr_rq_update(eth_dev, mtr_id, 1,\n \t\t\t\t\t\t &q_conf->index);\n \t\t}\n \t\tif (actions[i].type == RTE_FLOW_ACTION_TYPE_RSS) {\n \t\t\trss_conf = (const struct rte_flow_action_rss\n-\t\t\t\t\t *)(actions->conf);\n+\t\t\t\t\t *)(actions[i].conf);\n \t\t\tif (is_mtr_act)\n \t\t\t\tnix_mtr_rq_update(eth_dev, mtr_id,\n \t\t\t\t\t\t rss_conf->queue_num,\n@@ -98,7 +98,7 @@ cn10k_rss_action_validate(struct rte_eth_dev *eth_dev,\n \t\treturn -EINVAL;\n \t}\n \n-\tif (eth_dev->data->dev_conf.rxmode.mq_mode != RTE_ETH_MQ_RX_RSS) {\n+\tif (eth_dev->data->dev_conf.rxmode.mq_mode != ETH_MQ_RX_RSS) {\n \t\tplt_err(\"multi-queue mode is disabled\");\n \t\treturn -ENOTSUP;\n \t}\n@@ -171,7 +171,6 @@ cn10k_flow_create(struct rte_eth_dev *eth_dev, const struct rte_flow_attr *attr,\n \t\t\treturn NULL;\n \t\t}\n \t}\n-\n \tfor (i = 0; actions[i].type != RTE_FLOW_ACTION_TYPE_END; i++) {\n \t\tif (actions[i].type == RTE_FLOW_ACTION_TYPE_METER) {\n \t\t\tmtr = (const struct rte_flow_action_meter *)actions[i]\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_mtr.c b/drivers/net/cnxk/cnxk_ethdev_mtr.c\nindex 39d8563826..a36fcb8aaf 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_mtr.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_mtr.c\n@@ -35,7 +35,6 @@ static struct rte_mtr_capabilities mtr_capa = {\n \t.chaining_n_mtrs_per_flow_max = NIX_MTR_COUNT_PER_FLOW,\n \t.chaining_use_prev_mtr_color_supported = true,\n \t.chaining_use_prev_mtr_color_enforced = true,\n-\t.meter_rate_max = NIX_BPF_RATE_MAX / 8, /* Bytes per second */\n \t.color_aware_srtcm_rfc2697_supported = true,\n \t.color_aware_trtcm_rfc2698_supported = true,\n \t.color_aware_trtcm_rfc4115_supported = true,\n@@ -180,20 +179,20 @@ cnxk_nix_mtr_capabilities_get(struct rte_eth_dev *dev,\n \t\t\t struct rte_mtr_capabilities *capa,\n \t\t\t struct rte_mtr_error *error)\n {\n-\tstruct cnxk_eth_dev *eth_dev = cnxk_eth_pmd_priv(dev);\n-\tuint16_t count[ROC_NIX_BPF_LEVEL_MAX] = {0};\n \tuint8_t lvl_mask = ROC_NIX_BPF_LEVEL_F_LEAF | ROC_NIX_BPF_LEVEL_F_MID |\n \t\t\t ROC_NIX_BPF_LEVEL_F_TOP;\n+\tstruct cnxk_eth_dev *eth_dev = cnxk_eth_pmd_priv(dev);\n+\tuint16_t count[ROC_NIX_BPF_LEVEL_MAX] = {0};\n \tstruct roc_nix *nix = ð_dev->nix;\n-\tint rc;\n-\tint i;\n+\tuint32_t time_unit;\n+\tint rc, i;\n \n \tRTE_SET_USED(dev);\n \n \tif (!capa)\n \t\treturn -rte_mtr_error_set(error, EINVAL,\n-\t\t\t\tRTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n-\t\t\t\t\"NULL input parameter\");\n+\t\t\t\t\t RTE_MTR_ERROR_TYPE_MTR_PARAMS, NULL,\n+\t\t\t\t\t \"NULL input parameter\");\n \n \trc = roc_nix_bpf_count_get(nix, lvl_mask, count);\n \tif (rc)\n@@ -207,6 +206,15 @@ cnxk_nix_mtr_capabilities_get(struct rte_eth_dev *dev,\n \tmtr_capa.meter_trtcm_rfc4115_n_max = mtr_capa.n_max;\n \tmtr_capa.meter_policy_n_max = mtr_capa.n_max;\n \n+\trc = roc_nix_bpf_timeunit_get(nix, &time_unit);\n+\tif (rc)\n+\t\treturn rc;\n+\n+\tmtr_capa.meter_rate_max =\n+\t\tNIX_BPF_RATE(time_unit, NIX_BPF_MAX_RATE_EXPONENT,\n+\t\t\t NIX_BPF_MAX_RATE_MANTISSA, 0) /\n+\t\t8;\n+\n \t*capa = mtr_capa;\n \treturn 0;\n }\n@@ -304,6 +312,9 @@ cnxk_nix_mtr_policy_validate(struct rte_eth_dev *dev,\n \t\t\t\tif (action->type == RTE_FLOW_ACTION_TYPE_DROP)\n \t\t\t\t\tsupported[i] = true;\n \n+\t\t\t\tif (action->type == RTE_FLOW_ACTION_TYPE_VOID)\n+\t\t\t\t\tsupported[i] = true;\n+\n \t\t\t\tif (!supported[i]) {\n \t\t\t\t\tsprintf(message,\n \t\t\t\t\t\t\"%s action is not valid\",\n", "prefixes": [ "1/2" ] }