Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104781/?format=api
{ "id": 104781, "url": "http://patchwork.dpdk.org/api/patches/104781/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com", "date": "2021-11-30T16:59:13", "name": "[v1,1/1] net/qede: fix redundant condition in debug code", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0d915c68eb30d9e9720a21ccfedc1df2bc216e34", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 20818, "url": "http://patchwork.dpdk.org/api/series/20818/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20818", "date": "2021-11-30T16:59:13", "name": "[v1,1/1] net/qede: fix redundant condition in debug code", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20818/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104781/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104781/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D7C9A0C45;\n\tTue, 30 Nov 2021 17:59:46 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C60F941142;\n\tTue, 30 Nov 2021 17:59:45 +0100 (CET)", "from mga07.intel.com (mga07.intel.com [134.134.136.100])\n by mails.dpdk.org (Postfix) with ESMTP id 89E78410F7;\n Tue, 30 Nov 2021 17:59:44 +0100 (CET)", "from orsmga006.jf.intel.com ([10.7.209.51])\n by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Nov 2021 08:59:15 -0800", "from silpixa00401191.ir.intel.com ([10.55.128.95])\n by orsmga006.jf.intel.com with ESMTP; 30 Nov 2021 08:59:14 -0800" ], "X-IronPort-AV": [ "E=McAfee;i=\"6200,9189,10184\"; a=\"299652887\"", "E=Sophos;i=\"5.87,276,1631602800\"; d=\"scan'208\";a=\"299652887\"", "E=Sophos;i=\"5.87,276,1631602800\"; d=\"scan'208\";a=\"459672397\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org, Rasesh Mody <rmody@marvell.com>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Igor Russkikh <irusskikh@marvell.com>", "Cc": "stable@dpdk.org", "Subject": "[PATCH v1 1/1] net/qede: fix redundant condition in debug code", "Date": "Tue, 30 Nov 2021 16:59:13 +0000", "Message-Id": "\n <7105742b042a813a391466d6706bb809c1bd9569.1638291548.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Expression \"a && 1\" is equivalent to just \"a\", so fix the accidental\ninclusion of a literal in code.\n\nCc: stable@dpdk.org\n\nFixes: ec55c118792b (\"net/qede: add infrastructure for debug data collection\")\nCc: rmody@marvell.com\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n\nNotes:\n This isn't a bug, this is just a syntactic anomaly, likely a remnant of some\n kind of debugging code.\n \n This issue was found with Control Flag [1], which i ran on DPDK codebase just\n out of curiosity. This was the only issue worth addressing that the tool\n produced output for.\n \n [1] https://github.com/IntelLabs/control-flag\n\n drivers/net/qede/qede_debug.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/qede/qede_debug.c b/drivers/net/qede/qede_debug.c\nindex 2297d245c4..ba807ea680 100644\n--- a/drivers/net/qede/qede_debug.c\n+++ b/drivers/net/qede/qede_debug.c\n@@ -3522,7 +3522,7 @@ static enum dbg_status qed_grc_dump(struct ecore_hwfn *p_hwfn,\n \n \t/* Dump MCP HW Dump */\n \tif (qed_grc_is_included(p_hwfn, DBG_GRC_PARAM_DUMP_MCP_HW_DUMP) &&\n-\t !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP) && 1)\n+\t !qed_grc_get_param(p_hwfn, DBG_GRC_PARAM_NO_MCP))\n \t\toffset += qed_grc_dump_mcp_hw_dump(p_hwfn,\n \t\t\t\t\t\t p_ptt,\n \t\t\t\t\t\t dump_buf + offset, dump);\n", "prefixes": [ "v1", "1/1" ] }