Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 104790,
    "url": "http://patchwork.dpdk.org/api/patches/104790/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211201102954.2453386-1-skori@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211201102954.2453386-1-skori@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211201102954.2453386-1-skori@marvell.com",
    "date": "2021-12-01T10:29:53",
    "name": "net/cnxk: fix promiscuous mode in multicast enable flow",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "a0aad1e9a14a780b926831aa8be8a97a07c79252",
    "submitter": {
        "id": 1318,
        "url": "http://patchwork.dpdk.org/api/people/1318/?format=api",
        "name": "Sunil Kumar Kori",
        "email": "skori@marvell.com"
    },
    "delegate": {
        "id": 310,
        "url": "http://patchwork.dpdk.org/api/users/310/?format=api",
        "username": "jerin",
        "first_name": "Jerin",
        "last_name": "Jacob",
        "email": "jerinj@marvell.com"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211201102954.2453386-1-skori@marvell.com/mbox/",
    "series": [
        {
            "id": 20823,
            "url": "http://patchwork.dpdk.org/api/series/20823/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20823",
            "date": "2021-12-01T10:29:53",
            "name": "net/cnxk: fix promiscuous mode in multicast enable flow",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/20823/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/104790/comments/",
    "check": "fail",
    "checks": "http://patchwork.dpdk.org/api/patches/104790/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B9CECA0C4C;\n\tWed,  1 Dec 2021 11:30:01 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 461B84067B;\n\tWed,  1 Dec 2021 11:30:01 +0100 (CET)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 174FC40140\n for <dev@dpdk.org>; Wed,  1 Dec 2021 11:29:59 +0100 (CET)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B191A0X020504\n for <dev@dpdk.org>; Wed, 1 Dec 2021 02:29:58 -0800",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cp624rakp-2\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 01 Dec 2021 02:29:58 -0800",
            "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Wed, 1 Dec 2021 02:29:57 -0800",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.2 via Frontend\n Transport; Wed, 1 Dec 2021 02:29:57 -0800",
            "from localhost.localdomain (unknown [10.28.34.25])\n by maili.marvell.com (Postfix) with ESMTP id B2D7E5B6932;\n Wed,  1 Dec 2021 02:29:55 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=MLuOFDJNMWdm6lYrHuYhiso+CKaXmNjpfksmy2qoxQM=;\n b=cH7I6IW652nG2fpv2nwOWDbWHDDV3GBDaappmxasWhIoedH47VremhHsyuZY4I2LWhth\n NWebLOmqshGIF7BGyYdqQYI4QypqSLZpub1HxXBbGHteNHpaJJVs3cJu76lsxWCRk2kD\n mf5AhMkr3oC+mmSy0iSXRlsp80cIVLw6ciKAqEoc5XmHKWsb9iblWtbKzuF4nqDhHIXU\n rtgOiDXM49m3ZdwMZ3+wNvknkR9zvU9iSHtxAYm1ZRqlIOOfiWGOVX5HkgxWYN3g2nRG\n UAEQQHGeNvzFb+VaoYffuSPikfbmDbWAWeePvrPVDrLJc7AUvwF1vAtwVAvokGTs8lwp ug==",
        "From": "<skori@marvell.com>",
        "To": "Nithin Dabilpuram <ndabilpuram@marvell.com>, Kiran Kumar K\n <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>, Satha Rao\n <skoteshwar@marvell.com>",
        "CC": "<dev@dpdk.org>, Asaf Ravid <aravid@marvell.com>",
        "Subject": "[PATCH] net/cnxk: fix promiscuous mode in multicast enable flow",
        "Date": "Wed, 1 Dec 2021 15:59:53 +0530",
        "Message-ID": "<20211201102954.2453386-1-skori@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-GUID": "xYeeEJfHLSKCkw6WBmVqMdYa4W-TmCpw",
        "X-Proofpoint-ORIG-GUID": "xYeeEJfHLSKCkw6WBmVqMdYa4W-TmCpw",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.0.607.475\n definitions=2021-11-30_10,2021-12-01_01,2020-04-07_01",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Asaf Ravid <aravid@marvell.com>\n\nWhen multicast promisc was being enabled it caused the unicast promisc\nto be disabled. This fix resolves this by setting NIX_RX_MODE_PROMISC\nwhen eth_dev->data->promiscuous is set, regardless.\n\nci: skip_checkpatch skip_roc_check\n\nFixes: 325d79c00a5a (\"net/cnxk: support all multicast\")\n\nSigned-off-by: Asaf Ravid <aravid@marvell.com>\n---\n drivers/common/cnxk/roc_nix_npc.c  | 2 +-\n drivers/net/cnxk/cnxk_ethdev_ops.c | 3 ++-\n 2 files changed, 3 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/drivers/common/cnxk/roc_nix_npc.c b/drivers/common/cnxk/roc_nix_npc.c\nindex c0666c87d5..ad8839dde8 100644\n--- a/drivers/common/cnxk/roc_nix_npc.c\n+++ b/drivers/common/cnxk/roc_nix_npc.c\n@@ -96,7 +96,7 @@ roc_nix_npc_mcast_config(struct roc_nix *roc_nix, bool mcast_enable,\n \n \tif (mcast_enable)\n \t\treq->mode = NIX_RX_MODE_ALLMULTI;\n-\telse if (prom_enable)\n+\tif (prom_enable)\n \t\treq->mode = NIX_RX_MODE_PROMISC;\n \n \treturn mbox_process(mbox);\ndiff --git a/drivers/net/cnxk/cnxk_ethdev_ops.c b/drivers/net/cnxk/cnxk_ethdev_ops.c\nindex ce5f1f7240..34e4809650 100644\n--- a/drivers/net/cnxk/cnxk_ethdev_ops.c\n+++ b/drivers/net/cnxk/cnxk_ethdev_ops.c\n@@ -517,7 +517,8 @@ cnxk_nix_allmulticast_enable(struct rte_eth_dev *eth_dev)\n {\n \tstruct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev);\n \n-\treturn roc_nix_npc_mcast_config(&dev->nix, true, false);\n+\treturn roc_nix_npc_mcast_config(&dev->nix, true,\n+\t\t\t\t\teth_dev->data->promiscuous);\n }\n \n int\n",
    "prefixes": []
}