Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104812/?format=api
{ "id": 104812, "url": "http://patchwork.dpdk.org/api/patches/104812/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/1638384245-12587-7-git-send-email-jizh@linux.microsoft.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1638384245-12587-7-git-send-email-jizh@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1638384245-12587-7-git-send-email-jizh@linux.microsoft.com", "date": "2021-12-01T18:44:02", "name": "[v10,6/9] app/test: differentiate a strerror on different OS", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "86bd1b3fa51ae60c570dd01d1e44087030184114", "submitter": { "id": 1934, "url": "http://patchwork.dpdk.org/api/people/1934/?format=api", "name": "Jie Zhou", "email": "jizh@linux.microsoft.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/1638384245-12587-7-git-send-email-jizh@linux.microsoft.com/mbox/", "series": [ { "id": 20828, "url": "http://patchwork.dpdk.org/api/series/20828/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20828", "date": "2021-12-01T18:43:57", "name": "app/test: enable subset of tests on Windows", "version": 10, "mbox": "http://patchwork.dpdk.org/series/20828/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104812/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104812/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B2EBA0C41;\n\tWed, 1 Dec 2021 19:45:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E775E42707;\n\tWed, 1 Dec 2021 19:44:18 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id E3CB940140\n for <dev@dpdk.org>; Wed, 1 Dec 2021 19:44:10 +0100 (CET)", "from\n linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net\n (linux.microsoft.com [13.77.154.182])\n by linux.microsoft.com (Postfix) with ESMTPSA id A99BB20E581E;\n Wed, 1 Dec 2021 10:44:09 -0800 (PST)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com A99BB20E581E", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1638384249;\n bh=21CgDt/WmaQZSTbJ2JL9cXzuZWlWx3jRTGxq27mxIS4=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=YO2o57xUKbA9k8ASiFcZ57GqH1tQX2FRoSq1i3TOoF23bAE1szTs/2bIJwLhFYoh0\n u9iQZjCdev5L5sK3KY78XSvKwC+eTK3E+98HH7WMRjDs0oscKD2VvvqRKbuK6Lj++D\n 2pZtO6LAyZMtGT9oQrH4S5EqoBwwar7newtUzTAs=", "From": "Jie Zhou <jizh@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "dmitry.kozliuk@gmail.com, roretzla@microsoft.com,\n navasile@linux.microsoft.com, dmitrym@microsoft.com,\n pallavi.kadam@intel.com, talshn@nvidia.com, thomas@monjalon.net,\n aconole@redhat.com", "Subject": "[PATCH v10 6/9] app/test: differentiate a strerror on different OS", "Date": "Wed, 1 Dec 2021 10:44:02 -0800", "Message-Id": "<1638384245-12587-7-git-send-email-jizh@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1638384245-12587-1-git-send-email-jizh@linux.microsoft.com>", "References": "<1638381938-6113-1-git-send-email-jizh@linux.microsoft.com>\n <1638384245-12587-1-git-send-email-jizh@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "On Windows, strerror returns just \"Unknown error\" for errnum greater\nthan MAX_ERRNO, while linux and freebsd returns \"Unknown error <num>\",\nwhich is the current expectation for errno_autotest. Differentiate\nthe error string on Windows to remove a \"duplicate error code\" failure.\n\nSigned-off-by: Jie Zhou <jizh@linux.microsoft.com>\n\n---\n app/test/test_errno.c | 12 +++++++++++-\n lib/eal/common/eal_common_errno.c | 4 ++++\n 2 files changed, 15 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test/test_errno.c b/app/test/test_errno.c\nindex 3ff0456a58..0db4fbc8b3 100644\n--- a/app/test/test_errno.c\n+++ b/app/test/test_errno.c\n@@ -18,13 +18,19 @@ test_errno(void)\n {\n \tconst char *rte_retval;\n \tconst char *libc_retval;\n+\n+#ifndef RTE_EXEC_ENV_WINDOWS\n #ifdef RTE_EXEC_ENV_FREEBSD\n \t/* BSD has a colon in the string, unlike linux */\n \tconst char unknown_code_result[] = \"Unknown error: %d\";\n #else\n \tconst char unknown_code_result[] = \"Unknown error %d\";\n #endif\n-\tchar expected_libc_retval[sizeof(unknown_code_result)+3];\n+\tchar expected_libc_retval[sizeof(unknown_code_result) + 3];\n+#else\n+\t/* Windows doesn't return error number for error greater than MAX_errno*/\n+\tstatic const char expected_libc_retval[] = \"Unknown error\";\n+#endif\n \n \t/* use a small selection of standard errors for testing */\n \tint std_errs[] = {EAGAIN, EBADF, EACCES, EINTR, EINVAL};\n@@ -54,11 +60,13 @@ test_errno(void)\n \t\t\t\trte_retval, libc_retval);\n \t\tif (strcmp(rte_retval, libc_retval) == 0)\n \t\t\treturn -1;\n+#ifndef RTE_EXEC_ENV_WINDOWS\n \t\t/* generate appropriate error string for unknown error number\n \t\t * and then check that this is what we got back. If not, we have\n \t\t * a duplicate error number that conflicts with errno.h */\n \t\tsnprintf(expected_libc_retval, sizeof(expected_libc_retval),\n \t\t\t\tunknown_code_result, rte_errs[i]);\n+#endif\n \t\tif ((strcmp(expected_libc_retval, libc_retval) != 0) &&\n \t\t\t\t(strcmp(\"\", libc_retval) != 0)){\n \t\t\tprintf(\"Error, duplicate error code %d\\n\", rte_errs[i]);\n@@ -69,8 +77,10 @@ test_errno(void)\n \t/* ensure that beyond RTE_MAX_ERRNO, we always get an unknown code */\n \trte_retval = rte_strerror(RTE_MAX_ERRNO + 1);\n \tlibc_retval = strerror(RTE_MAX_ERRNO + 1);\n+#ifndef RTE_EXEC_ENV_WINDOWS\n \tsnprintf(expected_libc_retval, sizeof(expected_libc_retval),\n \t\t\tunknown_code_result, RTE_MAX_ERRNO + 1);\n+#endif\n \tprintf(\"rte_strerror: '%s', strerror: '%s'\\n\",\n \t\t\trte_retval, libc_retval);\n \tif ((strcmp(rte_retval, libc_retval) != 0) ||\ndiff --git a/lib/eal/common/eal_common_errno.c b/lib/eal/common/eal_common_errno.c\nindex f86802705a..4c4abb802e 100644\n--- a/lib/eal/common/eal_common_errno.c\n+++ b/lib/eal/common/eal_common_errno.c\n@@ -37,7 +37,11 @@ rte_strerror(int errnum)\n \t/* since some implementations of strerror_r throw an error\n \t * themselves if errnum is too big, we handle that case here */\n \tif (errnum >= RTE_MAX_ERRNO)\n+#ifdef RTE_EXEC_ENV_WINDOWS\n+\t\tsnprintf(ret, RETVAL_SZ, \"Unknown error%s\", sep);\n+#else\n \t\tsnprintf(ret, RETVAL_SZ, \"Unknown error%s %d\", sep, errnum);\n+#endif\n \telse\n \t\tswitch (errnum){\n \t\tcase E_RTE_SECONDARY:\n", "prefixes": [ "v10", "6/9" ] }