Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104820/?format=api
{ "id": 104820, "url": "http://patchwork.dpdk.org/api/patches/104820/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211202092001.1830481-1-zhengbin.89740@bytedance.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211202092001.1830481-1-zhengbin.89740@bytedance.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211202092001.1830481-1-zhengbin.89740@bytedance.com", "date": "2021-12-02T09:20:00", "name": "[v2,1/2] net/ixgbe: add vector Rx parameter check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ef9806462c763e2425eadd0e9733303921be4809", "submitter": { "id": 2415, "url": "http://patchwork.dpdk.org/api/people/2415/?format=api", "name": "Bin Zheng", "email": "zhengbin.89740@bytedance.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211202092001.1830481-1-zhengbin.89740@bytedance.com/mbox/", "series": [ { "id": 20833, "url": "http://patchwork.dpdk.org/api/series/20833/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20833", "date": "2021-12-02T09:20:00", "name": "[v2,1/2] net/ixgbe: add vector Rx parameter check", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20833/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104820/comments/", "check": "warning", "checks": "http://patchwork.dpdk.org/api/patches/104820/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9E915A0C41;\n\tThu, 2 Dec 2021 10:20:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 64869426D7;\n\tThu, 2 Dec 2021 10:20:15 +0100 (CET)", "from mail-pf1-f181.google.com (mail-pf1-f181.google.com\n [209.85.210.181])\n by mails.dpdk.org (Postfix) with ESMTP id DC62940692\n for <dev@dpdk.org>; Thu, 2 Dec 2021 10:20:13 +0100 (CET)", "by mail-pf1-f181.google.com with SMTP id n26so27349322pff.3\n for <dev@dpdk.org>; Thu, 02 Dec 2021 01:20:13 -0800 (PST)", "from workstation-Precision-3640-Tower.bytedance.net\n ([61.120.150.75])\n by smtp.gmail.com with ESMTPSA id w142sm2545761pfc.115.2021.12.02.01.20.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 02 Dec 2021 01:20:12 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=bytedance-com.20210112.gappssmtp.com; s=20210112;\n h=from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=k4ko+OiEH0B52VbGQ6UTI6RMsiTAr398IgSg6Xt5tws=;\n b=fWrDjo0W601cSvN1zWntKKOdKmmghxU09OmYU+K/MDbCGQ0ev2i/APwappn+kKdcEj\n GDyub/n4mFbrr4NNIaG9H2r/K4TGAUmq1GlNzH7Ti8CjJfPf7E2tTFh6gkkGo9/WyMmA\n qkEUzMYMiI14dJhMBk1RGADSApmTkeniLMse7flxiWdmz812UyKO5jfxhnHRAqyzYNDs\n kdHFTcLUbH1hG45y+sxGUb4V2C4kbQkToXXpu2zb+cgXOXuGaVucz55a0uHd2Wq2/+w7\n vY9GeY0FWNWQLPOi+le4zAxyov4N+Fl7KeuIhTB6lwsuXbOD7kQ8MQtgCBZUVwTxyq53\n WdyA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=k4ko+OiEH0B52VbGQ6UTI6RMsiTAr398IgSg6Xt5tws=;\n b=76i3vMb/s7fTR1rZM+rPhiTXRw/4mmqReqOq2eBq3Q+tvYqRX0eyIcf/0XFymOkxj7\n JdmeIDQmYwxE/L3rml4ftnE2MrazTDp1KhFgLUpKRVLJQjJiuw0nBYBzus3NXvfsYmfU\n 2YJpfvWdwHdziE/Psyxa3mWxPjZvKbYk3ogze7sRzfrosR+qe/4Xui4ui9pa/h+Onnku\n sdbpJ3PInTiK6TAJOaHEjzFppQ3gVg3ERvKLmRGXeEVsbxP64DDvjxYZ6garySYyUTCJ\n Sxf40l2O24O+OdRHjX+vXP7uyttk8pPOXMIz9tD3U0nshZc+rpfNPk3wDmOFaBTUtGTo\n Kceg==", "X-Gm-Message-State": "AOAM532vIYI1mzIb6n0gjSnDzTDjtkAue6QB2LYWIWOJt4ittaOeSUee\n J0iZTAN18yC4z2coOgNbSZlxD9WLs4mSgw==", "X-Google-Smtp-Source": "\n ABdhPJxsw0EO4J0WJviaPgKAse+9vVsS6W7itCqsUIG7Dy1p9/xhOVJP7EJM/QwiOW4W2SZGpcpN5g==", "X-Received": "by 2002:a05:6a00:1816:b0:49f:cd0d:b51b with SMTP id\n y22-20020a056a00181600b0049fcd0db51bmr11173494pfa.6.1638436812523;\n Thu, 02 Dec 2021 01:20:12 -0800 (PST)", "From": "Bin Zheng <zhengbin.89740@bytedance.com>", "To": "dev@dpdk.org", "Cc": "haiyue.wang@intel.com, liangma@liangbit.com,\n Bin Zheng <zhengbin.89740@bytedance.com>, jia.guo@intel.com,\n stable@dpdk.org", "Subject": "[PATCH v2 1/2] net/ixgbe: add vector Rx parameter check", "Date": "Thu, 2 Dec 2021 17:20:00 +0800", "Message-Id": "<20211202092001.1830481-1-zhengbin.89740@bytedance.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Under the circumstance that `rx_tail` wrap back to zero\nand the advance speed of `rx_tail` is greater than `rxrearm_start`,\n`rx_tail` will catch up with `rxrearm_start` and surpass it.\nThis may cause some mbufs be reused by application.\n\nSo we need to make some restrictions to ensure that\n `rx_tail` will not exceed `rxrearm_start`.\n\ne.g.\n\nRDH: 972 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959\nRDH: 1004 RDT: 1023 rxrearm_nb: 991 rxrearm_start: 0 rx_tail: 991\nRDH: 12 RDT: 31 rxrearm_nb: 991 rxrearm_start: 32 rx_tail: 1023\nRDH: 31 RDT: 63 rxrearm_nb: 960 rxrearm_start: 64 rx_tail: 0\nRDH: 95 RDT: 95 rxrearm_nb: 1016 rxrearm_start: 96 rx_tail: 88\nRDH: 95 RDT: 127 rxrearm_nb: 991 rxrearm_start: 128 rx_tail: 95\n...\nRDH: 908 RDT: 927 rxrearm_nb: 991 rxrearm_start: 928 rx_tail: 895\nRDH: 940 RDT: 959 rxrearm_nb: 991 rxrearm_start: 960 rx_tail: 927\nRDH: 980 RDT: 991 rxrearm_nb: 991 rxrearm_start: 992 rx_tail: 959\nRDH: 991 RDT: 991 rxrearm_nb: 1026 rxrearm_start: 992 rx_tail: 994\n\nwhen `rx_tail` catches up with `rxrearm_start`,\n2(994 - 992) mbufs be reused by application !\n\nBugzilla ID: 882\nFixes: 5a3cca342417 (\"net/ixgbe: fix vector Rx\")\nCc: jia.guo@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Bin Zheng <zhengbin.89740@bytedance.com>\n---\n drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\nindex 1eed949495..5811749b95 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_sse.c\n@@ -364,6 +364,17 @@ _recv_raw_pkts_vec(struct ixgbe_rx_queue *rxq, struct rte_mbuf **rx_pkts,\n \tuint8_t vlan_flags;\n \tuint16_t udp_p_flag = 0; /* Rx Descriptor UDP header present */\n \n+\t/*\n+\t * Under the circumstance that `rx_tail` wrap back to zero\n+\t * and the advance speed of `rx_tail` is greater than `rxrearm_start`,\n+\t * `rx_tail` will catch up with `rxrearm_start` and surpass it.\n+\t * This may cause some mbufs be reused by applicaion.\n+\t *\n+\t * So we need to make some restrictions to ensure that\n+\t * `rx_tail` will not exceed `rxrearm_start`.\n+\t */\n+\tnb_pkts = RTE_MIN(nb_pkts, RTE_IXGBE_RXQ_REARM_THRESH);\n+\n \t/* nb_pkts has to be floor-aligned to RTE_IXGBE_DESCS_PER_LOOP */\n \tnb_pkts = RTE_ALIGN_FLOOR(nb_pkts, RTE_IXGBE_DESCS_PER_LOOP);\n \n", "prefixes": [ "v2", "1/2" ] }