Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 104846,
    "url": "http://patchwork.dpdk.org/api/patches/104846/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/CAHJXk3bKEZr5oDPP6WCWWAr=j9urWQU030aMr4g3BFn0_Ar2Hw@mail.gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<CAHJXk3bKEZr5oDPP6WCWWAr=j9urWQU030aMr4g3BFn0_Ar2Hw@mail.gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/CAHJXk3bKEZr5oDPP6WCWWAr=j9urWQU030aMr4g3BFn0_Ar2Hw@mail.gmail.com",
    "date": "2021-12-03T07:24:29",
    "name": "net/kni: reset rte_kni_conf struct before initialization",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fd60ea2d678001f932fd37c76a28a0439289abef",
    "submitter": {
        "id": 2435,
        "url": "http://patchwork.dpdk.org/api/people/2435/?format=api",
        "name": "Harold Huang",
        "email": "baymaxhuang@gmail.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/CAHJXk3bKEZr5oDPP6WCWWAr=j9urWQU030aMr4g3BFn0_Ar2Hw@mail.gmail.com/mbox/",
    "series": [
        {
            "id": 20845,
            "url": "http://patchwork.dpdk.org/api/series/20845/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20845",
            "date": "2021-12-03T07:24:29",
            "name": "net/kni: reset rte_kni_conf struct before initialization",
            "version": 1,
            "mbox": "http://patchwork.dpdk.org/series/20845/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/104846/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/104846/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E5B65A0548;\n\tFri,  3 Dec 2021 08:24:42 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 78C334014F;\n\tFri,  3 Dec 2021 08:24:42 +0100 (CET)",
            "from mail-pj1-f46.google.com (mail-pj1-f46.google.com\n [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 1A98B40041\n for <dev@dpdk.org>; Fri,  3 Dec 2021 08:24:41 +0100 (CET)",
            "by mail-pj1-f46.google.com with SMTP id\n cq22-20020a17090af99600b001a9550a17a5so4476586pjb.2\n for <dev@dpdk.org>; Thu, 02 Dec 2021 23:24:41 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=mime-version:from:date:message-id:subject:to:cc;\n bh=KuqVvhXWYJA5xFib/b6iGyZNeyVBu2kZ1q8D/bPSUOg=;\n b=qQvyEdQPYGxsQhcz5YEqtX6/2M8kiKBdQHQ6Ydncq71ZBpHBwq6kR8KZSGMNr4Md4X\n GWRpaCJPd+q+BL3MD6yOyTmYeLygW+G4vgcD78ixELAhRyr3N7zntN9uSut1e256Z6gY\n BbjOdAZLtLPf1+74M4VvyIcHrHoOhSSEPlgaaXiwdavn8ALNyYe5nFCjwvD7TVZK2GJP\n Xa7cPWDic5+o39/adhtO17cBMDmhnQlRhYC8ms9Z9S8oMta3zF88ZPGSqSB3N21ds8ge\n EqoltQbbnDBBuELApol+H3G6Cj0lboBXrgLAso2NtWaakBW+R2TA/vXd7NXtL9bRoS2+\n 2uSQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc;\n bh=KuqVvhXWYJA5xFib/b6iGyZNeyVBu2kZ1q8D/bPSUOg=;\n b=SjvTT86LXaySi9FPd0I9oaRgoyThMPnDMQUq3hYx0wCfotP0Bu6BRghU+4emkuzc+K\n vi8GbuqLiPSEIQGfdmTryzSD4Zzng4tQZLT/+bKCgNoi1n6O3xk04UZ0YFIrA5qQoT17\n cpoIXew4PULNnAoUZ14BULRmYfp3Lu4ygca6P5rtw/l9Mz1uSTkXp17+wvSddaAWEs5Q\n lQ7CsFda07FCHRKIghUE32H/gcjVcX9aKuQ1462hGUmLFgG4AOglpHJ7hhbpzDcsuuUZ\n eL4a6yxhQe4/L8DsIu/T5dqTFw+mtu/0kSKXaLTYmpXDb4fVkwCzJ1HBhhmvR+MsmlMe\n ehDw==",
        "X-Gm-Message-State": "AOAM530KLDvSzMwrL6LR+ymVL/n7ln2CbHycPlmoC0LeC+PlZnI1spXA\n Y6FpGDgiCMzjsjRHjtUbE7I6q1wyId05zOWcNcNRHxyvkUs=",
        "X-Google-Smtp-Source": "\n ABdhPJwc2dz6iBZ1Y1BN2KqQXiY50ttkWgaVEbrIePHJfnCoN4r3Htp0T/ouL9XFoG8+8h5tSbtiS+vlRju0ogr2oDg=",
        "X-Received": "by 2002:a17:902:d4c2:b0:142:2039:e8e5 with SMTP id\n o2-20020a170902d4c200b001422039e8e5mr21135741plg.18.1638516280038; Thu, 02\n Dec 2021 23:24:40 -0800 (PST)",
        "MIME-Version": "1.0",
        "From": "Harold Huang <baymaxhuang@gmail.com>",
        "Date": "Fri, 3 Dec 2021 15:24:29 +0800",
        "Message-ID": "\n <CAHJXk3bKEZr5oDPP6WCWWAr=j9urWQU030aMr4g3BFn0_Ar2Hw@mail.gmail.com>",
        "Subject": "[PATCH] net/kni: reset rte_kni_conf struct before initialization",
        "To": "dev@dpdk.org",
        "Cc": "ferruh.yigit@intel.com, lironh@marvell.com",
        "Content-Type": "text/plain; charset=\"UTF-8\"",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When kni driver calls eth_kni_start to start device, some fields such\nas min_mtu and max_mtu of rte_kni_conf are not initialized. It will\ncause kni_ioctl_create create a kni netdevice with a random min_mtu\nand max_mtu value. This is unexpected and in some time we could not\nchange the kni device mtu with ip link command.\n\nFixes: ff1e35fb5f8 (\"kni: calculate MTU from mbuf size\")\nSigned-off-by: Harold Huang <baymaxhuang@gmail.com>\n---\n drivers/net/kni/rte_eth_kni.c | 1 +\n 1 file changed, 1 insertion(+)\n\n--\n2.18.2",
    "diff": "diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex c428caf441..23b15edfac 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -128,6 +128,7 @@ eth_kni_start(struct rte_eth_dev *dev)\n  const char *name = dev->device->name + 4; /* remove net_ */\n\n  mb_pool = internals->rx_queues[0].mb_pool;\n+ memset(&conf, 0, sizeof(conf));\n  strlcpy(conf.name, name, RTE_KNI_NAMESIZE);\n  conf.force_bind = 0;\n  conf.group_id = port_id;\n",
    "prefixes": []
}