Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104860/?format=api
{ "id": 104860, "url": "http://patchwork.dpdk.org/api/patches/104860/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-3-stephend@silicom-usa.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211203225516.571368-3-stephend@silicom-usa.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211203225516.571368-3-stephend@silicom-usa.com", "date": "2021-12-03T22:55:11", "name": "[2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state of PRSNT# signal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "1376471e1d9b9b0b7380dcdd57c75acacc86a27f", "submitter": { "id": 2437, "url": "http://patchwork.dpdk.org/api/people/2437/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-3-stephend@silicom-usa.com/mbox/", "series": [ { "id": 20852, "url": "http://patchwork.dpdk.org/api/series/20852/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20852", "date": "2021-12-03T22:55:09", "name": "ixgbe SFP handling fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20852/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104860/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 53B31A0C41;\n\tFri, 3 Dec 2021 23:56:15 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 081194272D;\n\tFri, 3 Dec 2021 23:56:03 +0100 (CET)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2111.outbound.protection.outlook.com [40.107.21.111])\n by mails.dpdk.org (Postfix) with ESMTP id 44D9340041;\n Fri, 3 Dec 2021 23:55:59 +0100 (CET)", "from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29)\n by AM0PR04MB6404.eurprd04.prod.outlook.com (2603:10a6:208:178::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec\n 2021 22:55:55 +0000", "from AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.019; Fri, 3 Dec 2021\n 22:55:54 +0000", "from lappy.adi.eng (173.14.114.227) by\n BL1PR13CA0431.namprd13.prod.outlook.com (2603:10b6:208:2c3::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.10 via Frontend\n Transport; Fri, 3 Dec 2021 22:55:53 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=G0Yd4dW6IBNC16p83Qvy8FF7sjoQDIwKWR01dCAcBMghSGSbwqfa8nFJSszixClKcRmA/GLUgn3ZpottBtkS4f+XTdRJud0VYqld4DaWQwuoJ9Ju5H1dmunCEHQyVlUjoVjvSpLc3WBDkgAhTfA+fHC9TDuiJaAUnpAgLq8s5RYkFP8+xkH7hfUtgPaYgYqS0SUS+IjioxKom+iT0l6x/h0hB+ZweZwU+IBcUZUDQUy6t842wP+zQZDsdkfCUCB89d7hvAkC3tuix/hdHiJ0iWGk6U0vIfQbSnNYZTV4VqbZUZfaiQQ1yNoVE62FL/LrE9LYfvEkXOUE5f0nD83Jjg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=U1ToY7tooyrlQKzotnHseoh8V/mRmx0gxOiB9eHyvhc=;\n b=eXONhwBGcvP0aDX1Pb4ZD8D6hr83d0E1a2wGOetjWGZwK5wa031GN6so3YPcvBGR/vaoqTb+QM70w9GGHw2g+2xf9LcVrK+mXs6KKNahOljP/8z9yYTgN4s2/wUUD6zkmtn77iM06/HWU9cO1BisVpVJmNGu6ylLpezKjO0DL7K2UeyM6bCyX2OPaTOrqCv2QpsEHVoQ5rhDpoP7LnmVVkxsqulyDZV6kP+cyruisbvl4v3n7AkYsG4EBG4dAU+GZGYgXGqILcjUnOjFLjgyQDtaaBlc+JZPNf8Z8R4/qQveJXuH7EMjyR+CHH/GAKZSxw6lZqTIf9SjMqMhdPPneA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom-usa.com; dmarc=pass action=none\n header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=U1ToY7tooyrlQKzotnHseoh8V/mRmx0gxOiB9eHyvhc=;\n b=ZzPjSvhobI8ex/yu1PQspUwjsJugNWGiVhxDYetXhViU5BrQBNfzc01vhiUkn021CtfdLTdpKNQXuZvI6aI2KXQQqzdP196nPWVnDNs1MHxwkFnBj1AuH7489iwdDBjEnpZ+54ZtcwPBrX9cXKCQsfEv7Ya5cgWTTiC5l+CriUE=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=silicom-usa.com;", "From": "Stephen Douthit <stephend@silicom-usa.com>", "To": "dev@dpdk.org", "Cc": "wenw@silicom-usa.com, Stephen Douthit <stephend@silicom-usa.com>,\n stable@dpdk.org, Haiyue Wang <haiyue.wang@intel.com>,\n Xiao Wang <xiao.w.wang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>", "Subject": "[PATCH 2/7] net/ixgbe: Add ixgbe_check_sfp_cage() for testing state\n of PRSNT# signal", "Date": "Fri, 3 Dec 2021 17:55:11 -0500", "Message-Id": "<20211203225516.571368-3-stephend@silicom-usa.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211203225516.571368-1-stephend@silicom-usa.com>", "References": "<20211203225516.571368-1-stephend@silicom-usa.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BL1PR13CA0431.namprd13.prod.outlook.com\n (2603:10b6:208:2c3::16) To AM0PR04MB4083.eurprd04.prod.outlook.com\n (2603:10a6:208:64::29)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "ab76d97d-1c3a-400e-e994-08d9b6b00ff7", "X-MS-TrafficTypeDiagnostic": "AM0PR04MB6404:", "X-Microsoft-Antispam-PRVS": "\n <AM0PR04MB6404F42ABA471AA54F419DD9946A9@AM0PR04MB6404.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n H//7NEXNaOmWRAT1TFd9s4l7pSRcr5EKYW97lZiFweGeYUHFG0vIwKrS8AKQjeycTiZWOX8/yebduFfFuZavE/C+vzg4PpL9bIWkG9H6oIkImLlfW6NAyjD+WrvIvbMV+acm6CuUlx32EyJpMEyoiRPIO9EJZEs6nKAQefKo6aFLAmgE22sXnPxFHMqGk9LjFQ1JXKMi1iKAXbeL+Dvfe9l/FiiUjOGKPQsrGp5r7u9ojisbQ5rCSuIq62VSkI8YkUgPJblBSGbJOaXwcl2enoEvGMmUeW0oIsGT1lu85zxhespO+PDBSq5gLPwiaA7cOddZjgLavnYP2igKV6P5nzNMUFfgnMEUcOf1Mkp1bGh1rigQ8wOw0QVZWTg7AVNEhR5n3UL8zO2+/JfyeD+aO9/50sqeU7+n43uad0hoCMiNHlE92UoFlPHhIzs1qfpfJPmncIv7bhLz5l0wx30SaE9hF200JbSZNho4+3vPnGctqcV9jrhkFSCpjfH3xkDw4n70m11+vIX5/TxiZTWhMERGtJwTgulKylFNM1GhkYvcmf6afeN/9pOhUZ8vVxAKvLRXmQXuwiw3DMGaFxYW94zTdJV/SE3pqDlRvVZtsGb/oXHOmo0Qsgn+FlD86jK/hskkaB/BxQ3VbNQVkCDD3gmc3EDbWqmDo9DXAhO9F1FomyiPgeEmbNQYnZoUtfmFlO5UNqCFw2xt0OIWszy2bg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(8936002)(2906002)(508600001)(6916009)(8676002)(6486002)(26005)(956004)(83380400001)(316002)(1076003)(36756003)(5660300002)(86362001)(186003)(4326008)(66946007)(2616005)(38100700002)(38350700002)(6506007)(66556008)(52116002)(66476007)(6666004)(6512007)(54906003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n R9nyEuVNxb0HRIY9Yv5jDbOdSxcqsnPsGoUw6TRopJxQwhPhkt0NwElK77tsZkBofisCch06FCTxG99VYDRJP1rVCGVz1UbDn3bilDU8MrPur9bRAX542eYvV2IQ3wGJYOSOaulVWHU0fjK3COgKH8bU3t2ir5hkfsrPOEKOl6stJkBrUBR8G9LxqxPoaMhdkJRrY8KVoX2NayW3Dttro/Dz4xXwDnTcV6e/JlPpqu9LbIXSvx+0724Lp9irsOYEQn6AJgIo/lIXiDwgvM90BIP4V0b9CBAKLXtTqOr9FAI2L6BemzCN3uVgXExS4D6rjU5oXu8Dn6m06fT66cjDbgZTcEAEUe6+LO63613qkhT4LFRmpNR6UL+VB679xilAReTi98z5HT25uiQuwY0Yh2ulnv/rPnPG9gI1SKjZ5fS3axYNBg3x5rTYveZ9xW3dFD3W7T57yxDRtpSggeh/tV7knu+HmJVdegl6O+boU65ba+Jhn4/kTk8BS3uF9uKq/L+DLIx9vhPrkD1hagGKaGQwYGF+hTEddO+kC8DQXikk3LkKvv1sL/pKeZBGDAnmIZFo0kz2PasrFFWotu3ZdZ7wxda5OLsadRrLEnosInip6XYEssc9KJQ58AAd9mkVx4VAyFiUpseJSz04pZm0VsKK/66LsaP9eJxEhxNf2BHIahyIZ4hlqP9orToScN7GAePs9QKRyMdDMDmOROTONfqcmf+OcErN8wqZ49Qgt7VUrSCzAZBIsRNhcYsOhNmPSnmO78Gdjg+tyEs6LWbFf/wgsh445qdaihiavuzNawKQZ2l9qzTLVoRycDTNKI5rBWAfKvollNiMsTARC02fU8LT9vpW0FAnG/3x1/8xj8wvmh14fP8ctzfhKiAqpeWNkUNGtS/HLc2hfuEoo9wi3m9bQ4EvyqHlz/OQPOEs9NFH16Kb+ClaXDzQFbWiIb1NEvwS+HC9hyaw6QgQHjEht5Hb94c68yYhjgOiKr2WEBDSaKiVVV7GBWqGQ8nA0dWMHr5LvCCY68PfNGIGyf4b/mfvAl/JGaihP2HwH9tbgJ1oKo8sQPqwn+TrM2Av59dUScgOQEWrvbX9SFVkRaS0wzw8qFoRsLGdKRZ57zWXpDCTUi/5tPImDDIwCAUL1eB+SS+eOcYKNGiVb9qqLIDX5MbhMOdhJHzE0dos/V/KPB43zbBxsTifCgwpLIhQcgH+6MAJONpWY62SVFaUVjY7h24yisrZRWTFad0Mr/sW1csL/yc8Dg1aGX76RQPuV8nZuzDlF8dAz/uNVFxIWwx2hp66tBMxJ4ZXSupjpN4F+aH0oDREEhLpcXhyAOjOspmKstaDlUizLVkDLMpfL5khyguFAQYfcL2KxLkkbdvq49NQ9054GhnILqyhF0fkyhYx5DG1axGcmZCW7UhGSGDnbifxHn1NGqfgxtkCb0ViGeidRvge9Mocp5cj9r71eA+DbJykKdABDkpNREcmQ6LuzjpccHWoJbReGn64rUzmy/0PeHBAZRNYJeil5D1Urhl3M4YZskCn2Ie64TxzC/3mRxPCUtPqSKEle4EjHyyjBySqt9yRZJ8TpHrZvSonPOG7SUDP34x1+ZqyFs5TDeSQlc0fCiRFZImeatgcAT0oOBA17g2Lr7kcq/eoc6ddDbrXteTSdrT0dc7CN3ZtZSMKyqQ4a81BJmh4ccEGFRm9gLw=", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ab76d97d-1c3a-400e-e994-08d9b6b00ff7", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR04MB4083.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Dec 2021 22:55:54.8780 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n kisPSQ8YzQgyhQ70SWv+yG9rbzvSdqKXQRDBZN1YffhgKKg1FRKZRaZQcel4XC6ZnU2jwk1pKBGC1W1NVNzQZ/LgwXjh+PjOQUtOMJG3fqM=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6404", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Refactor the SFP check code from ixgbe_check_mac_link_generic into its own\nfunction.\n\nNote that the SFP present status was inverted for the X550EM family of\ndevices, where SDP0 represents the active low PRSNT# signal from the cage.\n\nCall the new function in ixgbe_identify_module_generic() to short circuit\nthe I2C polling and greatly speed things up for devices we know are\nabsent.\n\nFixes: dd3a93cf5a2 (\"net/ixgbe/base: bypass checking link for crosstalk\")\nCc: stable@dpdk.org\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 60 +++++++++++++++++++--------\n drivers/net/ixgbe/base/ixgbe_common.h | 8 ++++\n drivers/net/ixgbe/base/ixgbe_phy.c | 8 ++++\n 3 files changed, 58 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex aa843bd5c4..2764cf7cf1 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -4124,6 +4124,45 @@ static bool ixgbe_need_crosstalk_fix(struct ixgbe_hw *hw)\n \treturn true;\n }\n \n+/**\n+ * ixgbe_check_sfp_cage - Find present status of SFP module\n+ * @hw: pointer to hardware structure\n+ *\n+ * Find if a SFP module is present and if this device supports SFPs\n+ **/\n+enum ixgbe_sfp_cage_status ixgbe_check_sfp_cage(struct ixgbe_hw *hw)\n+{\n+\tenum ixgbe_sfp_cage_status status;\n+\n+\t/* If we're not a fiber/fiber_qsfp, no cage to check */\n+\tswitch (hw->mac.ops.get_media_type(hw)) {\n+\tcase ixgbe_media_type_fiber:\n+\tcase ixgbe_media_type_fiber_qsfp:\n+\t\tbreak;\n+\tdefault:\n+\t\treturn IXGBE_SFP_CAGE_NOCAGE;\n+\t}\n+\n+\tswitch (hw->mac.type) {\n+\tcase ixgbe_mac_82599EB:\n+\t\tstatus = !!(IXGBE_READ_REG(hw, IXGBE_ESDP) &\n+\t\t\t IXGBE_ESDP_SDP2);\n+\t\tbreak;\n+\tcase ixgbe_mac_X550EM_x:\n+\tcase ixgbe_mac_X550EM_a:\n+\t\t/* SDP0 is the active low signal PRSNT#, so invert this */\n+\t\tstatus = !(IXGBE_READ_REG(hw, IXGBE_ESDP) &\n+\t\t\t\t IXGBE_ESDP_SDP0);\n+\t\tbreak;\n+\tdefault:\n+\t\t/* Don't know how to check this device type yet */\n+\t\tstatus = IXGBE_SFP_CAGE_UNKNOWN;\n+\t\tbreak;\n+\t}\n+\n+\treturn status;\n+}\n+\n /**\n * ixgbe_check_mac_link_generic - Determine link and speed status\n * @hw: pointer to hardware structure\n@@ -4145,25 +4184,10 @@ s32 ixgbe_check_mac_link_generic(struct ixgbe_hw *hw, ixgbe_link_speed *speed,\n \t * the SFP+ cage is full.\n \t */\n \tif (ixgbe_need_crosstalk_fix(hw)) {\n-\t\tu32 sfp_cage_full;\n-\n-\t\tswitch (hw->mac.type) {\n-\t\tcase ixgbe_mac_82599EB:\n-\t\t\tsfp_cage_full = IXGBE_READ_REG(hw, IXGBE_ESDP) &\n-\t\t\t\t\tIXGBE_ESDP_SDP2;\n-\t\t\tbreak;\n-\t\tcase ixgbe_mac_X550EM_x:\n-\t\tcase ixgbe_mac_X550EM_a:\n-\t\t\tsfp_cage_full = IXGBE_READ_REG(hw, IXGBE_ESDP) &\n-\t\t\t\t\tIXGBE_ESDP_SDP0;\n-\t\t\tbreak;\n-\t\tdefault:\n-\t\t\t/* sanity check - No SFP+ devices here */\n-\t\t\tsfp_cage_full = false;\n-\t\t\tbreak;\n-\t\t}\n+\t\tenum ixgbe_sfp_cage_status sfp_cage_status;\n \n-\t\tif (!sfp_cage_full) {\n+\t\tsfp_cage_status = ixgbe_check_sfp_cage(hw);\n+\t\tif (sfp_cage_status != IXGBE_SFP_CAGE_FULL) {\n \t\t\t*link_up = false;\n \t\t\t*speed = IXGBE_LINK_SPEED_UNKNOWN;\n \t\t\treturn IXGBE_SUCCESS;\ndiff --git a/drivers/net/ixgbe/base/ixgbe_common.h b/drivers/net/ixgbe/base/ixgbe_common.h\nindex 5bdb484407..30db9a08c4 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.h\n+++ b/drivers/net/ixgbe/base/ixgbe_common.h\n@@ -112,6 +112,14 @@ s32 ixgbe_set_vlvf_generic(struct ixgbe_hw *hw, u32 vlan, u32 vind,\n s32 ixgbe_clear_vfta_generic(struct ixgbe_hw *hw);\n s32 ixgbe_find_vlvf_slot(struct ixgbe_hw *hw, u32 vlan, bool vlvf_bypass);\n \n+enum ixgbe_sfp_cage_status {\n+\tIXGBE_SFP_CAGE_EMPTY = 0,\n+\tIXGBE_SFP_CAGE_FULL,\n+\tIXGBE_SFP_CAGE_UNKNOWN = -1,\n+\tIXGBE_SFP_CAGE_NOCAGE = -2,\n+};\n+enum ixgbe_sfp_cage_status ixgbe_check_sfp_cage(struct ixgbe_hw *hw);\n+\n s32 ixgbe_check_mac_link_generic(struct ixgbe_hw *hw,\n \t\t\t ixgbe_link_speed *speed,\n \t\t\t bool *link_up, bool link_up_wait_to_complete);\ndiff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex 8d4d9bbfef..d8d51d2c3f 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -1228,9 +1228,17 @@ s32 ixgbe_reset_phy_nl(struct ixgbe_hw *hw)\n s32 ixgbe_identify_module_generic(struct ixgbe_hw *hw)\n {\n \ts32 status = IXGBE_ERR_SFP_NOT_PRESENT;\n+\tenum ixgbe_sfp_cage_status sfp_cage_status;\n \n \tDEBUGFUNC(\"ixgbe_identify_module_generic\");\n \n+\tsfp_cage_status = ixgbe_check_sfp_cage(hw);\n+\tif (sfp_cage_status == IXGBE_SFP_CAGE_EMPTY ||\n+\t sfp_cage_status == IXGBE_SFP_CAGE_NOCAGE) {\n+\t\thw->phy.sfp_type = ixgbe_sfp_type_not_present;\n+\t\treturn status;\n+\t}\n+\n \tswitch (hw->mac.ops.get_media_type(hw)) {\n \tcase ixgbe_media_type_fiber:\n \t\tstatus = ixgbe_identify_sfp_module_generic(hw);\n", "prefixes": [ "2/7" ] }