Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104861/?format=api
{ "id": 104861, "url": "http://patchwork.dpdk.org/api/patches/104861/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-4-stephend@silicom-usa.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211203225516.571368-4-stephend@silicom-usa.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211203225516.571368-4-stephend@silicom-usa.com", "date": "2021-12-03T22:55:12", "name": "[3/7] net/ixgbe: Check that SFF-8472 soft rate select is supported before write", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9bd623c21deae43131196c228054b1eb09c73d60", "submitter": { "id": 2437, "url": "http://patchwork.dpdk.org/api/people/2437/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-4-stephend@silicom-usa.com/mbox/", "series": [ { "id": 20852, "url": "http://patchwork.dpdk.org/api/series/20852/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20852", "date": "2021-12-03T22:55:09", "name": "ixgbe SFP handling fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20852/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104861/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104861/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C3C59A0C41;\n\tFri, 3 Dec 2021 23:56:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2658942737;\n\tFri, 3 Dec 2021 23:56:04 +0100 (CET)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2111.outbound.protection.outlook.com [40.107.21.111])\n by mails.dpdk.org (Postfix) with ESMTP id 605024067B;\n Fri, 3 Dec 2021 23:55:59 +0100 (CET)", "from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29)\n by AM0PR04MB6404.eurprd04.prod.outlook.com (2603:10a6:208:178::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec\n 2021 22:55:56 +0000", "from AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.019; Fri, 3 Dec 2021\n 22:55:56 +0000", "from lappy.adi.eng (173.14.114.227) by\n BL1PR13CA0431.namprd13.prod.outlook.com (2603:10b6:208:2c3::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.10 via Frontend\n Transport; Fri, 3 Dec 2021 22:55:55 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=QXElkBu0Buwv5KihT4/rp9gBQVv3S4P7GHCiuKLTaA3sRbaQHZqT0zxofdz0BxJvtiOrVDIsFCOMUFSMZCgVI7/aEfVMrFtytF4g+sGqI5tL37uFgqO1NuIsLa5cxmaNqLbRaUBC42qbE5OB/IZLCks2ldLCd/l0mpTo8qhcNwtjfxXGyFmXAAy7tr+m0c2Wu91HCCUc131cNBsQVX8ZWTUSE4kiUQgMraeF1365EgKo8/V51a4odY0iWZk8yUajwyQxk/Zl0W1Sya5PSgAc9fSBfrdT5pt5pMGU87P5lcSa3OROMzQtifBgb4wxCiaMANWN/1WjLXi8AFha5qAJlg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=kbGwrfkhiXYs+8DaWVgwsi/F4ize67M8nbNxe8cu5tk=;\n b=FMGvAV4/YnM4/iP39zMNB/mMjmvKLOKquBwNsIHuKdDrzZ5tTa1ldAMdReIJgNWLOOoBE8VVIgHP+06Rd8syECWoO5baJXBqyrNuvgyoh7PcSu9DR6Bd2XMbc3NdZArd6/uYuHMKb6Fr0uxhKUofQlkIV7deXXMYzByQJ0v6vATJWdBU8k/N/bqYo10DcfJ8r/Zcbh7IWSCGiTBlaMWwN6ERJi0gfv+B35Wr14WcbnZ10VDHIQAfHwpDA+ataT5dZsobk3Ga3+2quDLQ4hVk3B3NitfPcRIAAj67BzS6CKW3+hnWjuzhCQpRbKhbl6bnH1JlJOwMT8yoIs2QWuJqpg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom-usa.com; dmarc=pass action=none\n header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kbGwrfkhiXYs+8DaWVgwsi/F4ize67M8nbNxe8cu5tk=;\n b=yAUNR5PFtM8ZsE2D1VUFB70UGK9UCp1fPmZWw5AvHL0/6Yf6i7X89/FKuVM9Z3KcHrPG9hnrHTC3BLi9DCzwRp10XSU4dybgciD75nmBeHCStmecKsZveZzMtEzkm2FV+kFUEPNY2Sd3MXclbXAAQWcORL3A7Se5wnBM3f1Ggmk=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=silicom-usa.com;", "From": "Stephen Douthit <stephend@silicom-usa.com>", "To": "dev@dpdk.org", "Cc": "wenw@silicom-usa.com, Stephen Douthit <stephend@silicom-usa.com>,\n stable@dpdk.org, Haiyue Wang <haiyue.wang@intel.com>,\n Helin Zhang <helin.zhang@intel.com>,\n Changchun Ouyang <changchun.ouyang@intel.com>,\n Wenzhuo Lu <wenzhuo.lu@intel.com>", "Subject": "[PATCH 3/7] net/ixgbe: Check that SFF-8472 soft rate select is\n supported before write", "Date": "Fri, 3 Dec 2021 17:55:12 -0500", "Message-Id": "<20211203225516.571368-4-stephend@silicom-usa.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211203225516.571368-1-stephend@silicom-usa.com>", "References": "<20211203225516.571368-1-stephend@silicom-usa.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BL1PR13CA0431.namprd13.prod.outlook.com\n (2603:10b6:208:2c3::16) To AM0PR04MB4083.eurprd04.prod.outlook.com\n (2603:10a6:208:64::29)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "e3241785-1d6c-4dfb-d78f-08d9b6b010bf", "X-MS-TrafficTypeDiagnostic": "AM0PR04MB6404:", "X-Microsoft-Antispam-PRVS": "\n <AM0PR04MB64047C0B4A8A7F81FB2B9D69946A9@AM0PR04MB6404.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7691;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n g7Vl7fMRdN0ygG+4C7mxnouLViow/p6AYhv8P2uq9ATC5pGZl/ij2PCshFICbNzghap3Nx/1Q5phSntG1vVRGKStJFJCqML6IOMW62wzbWfxL2u2S62IBqfB/5IoMJl3m1h1ILAP6GIkMDXskNXjusFLSrwmWJmgtatBnBCXB6IqiNetU521sXgX/FlqvL2UlEIZ2F5LKcNmVAVish4Oo4aYEDl9goV1KQVEffMv76DBU1y3nFDU1aCZfKj5ORfDp0/F8ci+24wygp1IYHLd69S6xTeX49k1E2J/Jak5IkFhSHL6yVXpg75j9v1gtZrWywHGL/6UVHeDBJrCIKdKj+mxfbYgJIWoQGPBMv3Ph/ehJIWVrY/A53z/FtWqoVCDtwhamnWBxby/gcnqGxZCcQZaUHGYoTHGeSbt3XmL6xO37vNrUMlRljvKczRMD8167JU5CnDwInC0SoxdoOm+pZHp0tc7F1taTFI74oc4l7uhxaQqLdLktZGe2MeLr6VhrCTA36GKxOEokiq6ikkCrWj/9av1T1cZ1T4r8sicvx8O0TeTRv2sLkocrFYlfMpMhhJuCBop0yBiF7I63imDunF7rbdG3/HC/q3LnXKapwyTXDc21TvbFP7bP/6LM8mVOCTa9EwjOkJ+3Kkz2yv54DaHHonw9qlTCQpQXYAk4zV5agPkGIDM8FM1wq5hgIe4Yc4E1AcWW5C7dG+nVyYzQA==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(8936002)(2906002)(508600001)(6916009)(8676002)(6486002)(26005)(956004)(83380400001)(316002)(1076003)(36756003)(5660300002)(86362001)(186003)(4326008)(66946007)(2616005)(38100700002)(38350700002)(6506007)(66556008)(52116002)(66476007)(6666004)(6512007)(54906003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 1EwauOOgGi3mZQ+pPc5Jh20g1CREk2rCNtRho4tnYHfST5Uuf8dY3ZDUNhRAogjByOeJWcT2H8YN9LanGVPdvleGqgTyxFEONV2KrzZtDxxPH4P08B8EtxAsAOWSD0liLIQgJxEIFyWTYcOSJjmQWr2VRpPA0VfIC7Y37xJOZMqXUfWn2DGfXU+y9slVq8hhMkLlnAvdC/QlVEey21vwnrtLehMClJvhj/NglfR42Ob4mpWFNsvuMnXLu13zlgJUn+v/CvPAS7XP9FCseVM8FeyDFsKDhUfVRoodma467xg+p0ULm8okUMYXetkpA0x4urozchT3FUCN+aaBgn6KuoKr83ufo5zcLFhiibHQsTERYosCNKiJR/nSC+inhC0GmSvMIKJCEW/LOGs3ePYNg1ydPKdvjybhDYn6F838fUBrVuoWEP55tQ2SL7O8WKoBepQCcW/y4yPSxa0fG+c0eYLS5leCkL1gf3KkVxp8XCMNiZChVwSuJ21KOBYE+04Iu71NqXhEBVBTCKe4uuxpAql9MwyJsXvObU3YCg5V4Klxhi4+Hw3W3q/qIN/pYYNbWHnp1T2DOj2bfK1OI9YMsdA5k0TghKjn36ndRK7mBB8X1NPM7O3iqAixoV0fm5fRK9didaZlTSdGUA1BLJ+jyF2UwAoKUtCwvYdIXIhymodbpvFoznoIeFwXNBDoeOHULw4Ok/BCTMAXI/eaAi0u9B9bRWtDLJ1GS8xqPyKyXNppMt5I+Ljsb0VDakT+ui1hEvQLvYhLK6PZDhb5A2XEr8ui3Xo0K6WJXhDHu4yq7V6HcA2l+CJhFkKRLrLpzB42aH97Wsa0nocDztKcMAPLft/ZitqoOoTN7+6e6RhSxtkKsTLJ1txd07KiXufVIea3c8l7D5Qrd/j5w2EdUvN/swP6P0b7bqHWVcgLKhu1onUf639Y2jaAexU5KzYj01HQ6HPy6VV9jN5YFeq8/tIsHFzgF91pTz3S5XqEM0HnbcCp+e5VbEHPG04D8pGuTqz2KGhGR/g+aRgmkiuuXy5TXjoaMwY5aO4q5mq22IE1CE9hBAgIkYxBp8MRbhd7GaL9vHiWb1ZYjWqqPKcVDRJMyUMA30c3Tdt8NzHgqYeQGpaToH0W/eeNe0P/XQUpvlB+DB4tFceETgRVqDIVYn0gcmpH7I3k3LSLMGFv+toJ+ghr2UMWKSbqhp0pdJUvHGjQ+/tnNBAAb0IaVhjsUACJvBRNSkiS1eh6C7+/3hnVbpmrITANhqu6V5dYma8m6x03hQhSaeCyrv+or+2purSgmUyjmKgJvSPzRcZAz4g5dSQRFUqczAEyXBucNSX03VTXJFWoOyzHDhBZKWmdKsVhbJdA0hbbkjwo/M8giTasy8PdTw52pn+Droy+olbBKea6t9Y1qTEL6HFeayJuOCVFs4PqYYc52aK2JBahXTAFkCqQkoTnSdmuiPK9ntltlGn77BsNQMUhKERI+IKOTDw31h6xqhylO64EwpT+QmKKCjGwZTb4dAXQhZ073kub36XuqkEzx5RRPhI/eBaW1MqgxG8yCJyHne+XxV7D3eSLyy1K27Ok6T23NU94GgXbWL2Ph3RekY8TKVtAcctFOzwb+CINj7LQWKW7Ch5w2uFeP+a1YRHRJGb6I+GPe3apUSnP+WoUxHptYOvohhIbdFWmz/1DuBeaYv+YbFoMKj5FnnA=", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n e3241785-1d6c-4dfb-d78f-08d9b6b010bf", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR04MB4083.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Dec 2021 22:55:56.1892 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 7N7+W3352Ix+SbpM3jpoZROP1gYumJMfdYBFnhdBO6NexYdEoqOpdvxjTlTZDxOfYfuLPlXJ/zJp9OF9/JbIFJliH5fjciHLORXBQAPUcEE=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6404", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Make sure an SFP is really a SFF-8472 device that supports the optional\nsoft rate select feature before just blindly poking those I2C registers.\n\nSkip all I2C traffic if we know there's no SFP.\n\nFixes: f3430431aba (\"ixgbe/base: add SFP+ dual-speed support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ixgbe/base/ixgbe_common.c | 46 +++++++++++++++++++++++++++\n drivers/net/ixgbe/base/ixgbe_phy.h | 3 ++\n 2 files changed, 49 insertions(+)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c\nindex 2764cf7cf1..3be1cc7fa2 100644\n--- a/drivers/net/ixgbe/base/ixgbe_common.c\n+++ b/drivers/net/ixgbe/base/ixgbe_common.c\n@@ -5371,6 +5371,7 @@ s32 ixgbe_setup_mac_link_multispeed_fiber(struct ixgbe_hw *hw,\n void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,\n \t\t\t\t\tixgbe_link_speed speed)\n {\n+\tenum ixgbe_sfp_cage_status sfp_cage_status;\n \ts32 status;\n \tu8 rs, eeprom_data;\n \n@@ -5387,6 +5388,51 @@ void ixgbe_set_soft_rate_select_speed(struct ixgbe_hw *hw,\n \t\treturn;\n \t}\n \n+\t/* Can't set rate on missing devices, skip all I2C access */\n+\tsfp_cage_status = ixgbe_check_sfp_cage(hw);\n+\tif (sfp_cage_status == IXGBE_SFP_CAGE_EMPTY ||\n+\t sfp_cage_status == IXGBE_SFP_CAGE_NOCAGE) {\n+\t\tDEBUGOUT(\"No SFP\\n\");\n+\t\treturn;\n+\t}\n+\n+\t/* This only applies to SFF-8472 devices, so check that this device has\n+\t * a non-zero SFF8472 compliance code @ device 0xA0 byte 94\n+\t */\n+\tstatus = hw->phy.ops.read_i2c_eeprom(hw,\n+\t\t\t\t\t IXGBE_SFF_SFF_8472_COMP,\n+\t\t\t\t\t &eeprom_data);\n+\tif (status || !eeprom_data) {\n+\t\tDEBUGOUT(\"Not a SFF-8472 device\\n\");\n+\t\tgoto out;\n+\t}\n+\n+\t/* (read|write)_i2c_byte() don't support the address change mechanism\n+\t * outlined in section 8.9 \"Addressing Modes\" of SFF_8472, so if that\n+\t * is a requirement give up\n+\t */\n+\tstatus = hw->phy.ops.read_i2c_eeprom(hw,\n+\t\t\t\t\t IXGBE_SFF_SFF_8472_SWAP,\n+\t\t\t\t\t &eeprom_data);\n+\tif (status || (eeprom_data & IXGBE_SFF_ADDRESSING_MODE)) {\n+\t\tDEBUGOUT(\"Address change not supported\\n\");\n+\t\tgoto out;\n+\t}\n+\t/* Digital diagnostic monitoring must be supported for rate select */\n+\tif (!(eeprom_data & IXGBE_SFF_DDM_IMPLEMENTED)) {\n+\t\tDEBUGOUT(\"DDM not implemented\\n\");\n+\t\tgoto out;\n+\t}\n+\n+\t/* Finally check if the optional rate select feature is implemented */\n+\tstatus = hw->phy.ops.read_i2c_eeprom(hw,\n+\t\t\t\t\t IXGBE_SFF_SFF_8472_EOPT,\n+\t\t\t\t\t &eeprom_data);\n+\tif (status || !(eeprom_data & IXGBE_SFF_HAVE_RS)) {\n+\t\tDEBUGOUT(\"Rate select not supported\");\n+\t\tgoto out;\n+\t}\n+\n \t/* Set RS0 */\n \tstatus = hw->phy.ops.read_i2c_byte(hw, IXGBE_SFF_SFF_8472_OSCB,\n \t\t\t\t\t IXGBE_I2C_EEPROM_DEV_ADDR2,\ndiff --git a/drivers/net/ixgbe/base/ixgbe_phy.h b/drivers/net/ixgbe/base/ixgbe_phy.h\nindex ceefbb3e68..cd57ce040f 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.h\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.h\n@@ -21,6 +21,7 @@\n #define IXGBE_SFF_CABLE_TECHNOLOGY\t0x8\n #define IXGBE_SFF_CABLE_SPEC_COMP\t0x3C\n #define IXGBE_SFF_SFF_8472_SWAP\t\t0x5C\n+#define IXGBE_SFF_SFF_8472_EOPT\t\t0x5D\n #define IXGBE_SFF_SFF_8472_COMP\t\t0x5E\n #define IXGBE_SFF_SFF_8472_OSCB\t\t0x6E\n #define IXGBE_SFF_SFF_8472_ESCB\t\t0x76\n@@ -48,6 +49,8 @@\n #define IXGBE_SFF_SOFT_RS_SELECT_10G\t0x8\n #define IXGBE_SFF_SOFT_RS_SELECT_1G\t0x0\n #define IXGBE_SFF_ADDRESSING_MODE\t0x4\n+#define IXGBE_SFF_DDM_IMPLEMENTED\t0x40\n+#define IXGBE_SFF_HAVE_RS\t\t0x2\n #define IXGBE_SFF_QSFP_DA_ACTIVE_CABLE\t0x1\n #define IXGBE_SFF_QSFP_DA_PASSIVE_CABLE\t0x8\n #define IXGBE_SFF_QSFP_CONNECTOR_NOT_SEPARABLE\t0x23\n", "prefixes": [ "3/7" ] }