Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104862/?format=api
{ "id": 104862, "url": "http://patchwork.dpdk.org/api/patches/104862/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-5-stephend@silicom-usa.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211203225516.571368-5-stephend@silicom-usa.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211203225516.571368-5-stephend@silicom-usa.com", "date": "2021-12-03T22:55:13", "name": "[4/7] net/ixgbe: Run 82599 link status workaround only on affected devices", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "cc844333fb1b56f181c3400c8756fca35073846a", "submitter": { "id": 2437, "url": "http://patchwork.dpdk.org/api/people/2437/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211203225516.571368-5-stephend@silicom-usa.com/mbox/", "series": [ { "id": 20852, "url": "http://patchwork.dpdk.org/api/series/20852/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20852", "date": "2021-12-03T22:55:09", "name": "ixgbe SFP handling fixes", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20852/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104862/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104862/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DB6A8A0C41;\n\tFri, 3 Dec 2021 23:56:25 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 403E54271F;\n\tFri, 3 Dec 2021 23:56:05 +0100 (CET)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2111.outbound.protection.outlook.com [40.107.21.111])\n by mails.dpdk.org (Postfix) with ESMTP id 7BCBD40041;\n Fri, 3 Dec 2021 23:55:59 +0100 (CET)", "from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29)\n by AM0PR04MB6404.eurprd04.prod.outlook.com (2603:10a6:208:178::23)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4734.23; Fri, 3 Dec\n 2021 22:55:57 +0000", "from AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.019; Fri, 3 Dec 2021\n 22:55:57 +0000", "from lappy.adi.eng (173.14.114.227) by\n BL1PR13CA0431.namprd13.prod.outlook.com (2603:10b6:208:2c3::16) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.10 via Frontend\n Transport; Fri, 3 Dec 2021 22:55:56 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=oQ89CbGDOfZfQ46zrpSfZ0A7JqX0beDQjr+q7xnkw+nhvxoz8Rdy42+QO6+qlEpb9d3BumU0GNX8OaP6Nqkop8pO6Y8UoXtmtCW1vO1YzVu+cmUCZJI6ngY8y9MaxWtoBTbhx3c5RgGvaDpB+0g3POeB9yvpqfp1B2HMhUQC6ncfxBXoebll0xU933rF+Gw4ps3CtIiET1zP7I9Zv2ozOVPGJJyoBcdVc+A+H9Ik8Bbq7f3cyLyS0GCDcKQbxxNkrwwxQlsVe1I8m0qEeb0H+NRw0EZ7bemA9Ma4CNAFzkEqeKwhwSXDpoy1sPPldRROaYelfkGJh/WpnjYhNmsmUQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=S+qvJ7TWGEzjPB2KcQX9exVWsDjyIT61sB1oY5i874c=;\n b=nJrMMeFd2eHhUSAVk2rp65pGOarga1AEuraB5fbNBqxx+x9DOHc+A1qaOcJpMksELsoUbGjJIhBd74MBQmSK1k9O2O9VgYDRZEj3wHI1dAygOXDdrg4Kj85HdZpq+XacQ41aoORQ+UTOURP3W30KLKeRgaxkcexD9hotMItmvKPC5BzMfWsmgkTnv/JWMpIOXIsEAapWeLrgn+V8q4pVWl9cslY70TKfBubp5rhNgL0GmxMhWfHtlSKhtY5RbbX/SKLWwFOoLdqKzIie4ymO0jB1yFjFASuJ9nMQc73eLIpPOVk0aYLQPRCjl7yVcq/ezST8o3pIqcNIjQxsPPpMRQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom-usa.com; dmarc=pass action=none\n header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=S+qvJ7TWGEzjPB2KcQX9exVWsDjyIT61sB1oY5i874c=;\n b=FNKHfOpJcEoQtpwZlWB/xCrMN/AHpAxx7M9zhw3wTyogXQwj1fGR9sVKDyoJTvSW18dFLsydmvEL97m/Z30v5fw4GF0vyGHV+GprhrlMEi1yFKjG6ZeIxjhRWsskV3qv9BgplMep9o6whlKxhdYTOHMMuj0cI/m/JOprc8qBIJM=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=silicom-usa.com;", "From": "Stephen Douthit <stephend@silicom-usa.com>", "To": "dev@dpdk.org", "Cc": "wenw@silicom-usa.com, Stephen Douthit <stephend@silicom-usa.com>,\n stable@dpdk.org, Haiyue Wang <haiyue.wang@intel.com>,\n Xiaolong Ye <xiaolong.ye@intel.com>, Xiao Zhang <xiao.zhang@intel.com>,\n Wei Zhao <wei.zhao1@intel.com>, Lunyuan Cui <lunyuanx.cui@intel.com>", "Subject": "[PATCH 4/7] net/ixgbe: Run 82599 link status workaround only on\n affected devices", "Date": "Fri, 3 Dec 2021 17:55:13 -0500", "Message-Id": "<20211203225516.571368-5-stephend@silicom-usa.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211203225516.571368-1-stephend@silicom-usa.com>", "References": "<20211203225516.571368-1-stephend@silicom-usa.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "BL1PR13CA0431.namprd13.prod.outlook.com\n (2603:10b6:208:2c3::16) To AM0PR04MB4083.eurprd04.prod.outlook.com\n (2603:10a6:208:64::29)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "1725f558-a36b-456e-1fbc-08d9b6b01194", "X-MS-TrafficTypeDiagnostic": "AM0PR04MB6404:", "X-Microsoft-Antispam-PRVS": "\n <AM0PR04MB64045191DDBF291993765B0F946A9@AM0PR04MB6404.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:7691;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n X8binozqhSj7CEM8woQZXdmGpJ92TLZ6iXsVVDUFiKXIZQ6Wj6l5Kll0+bE9ii3TSjMBkB9ObJQR2W+rC0pu/hNqOyYJW0r0Egy3XjNVKgb8o0QhCEmPw/dY7IZD1JZQAcnTOmvl4hwx0FRjMRKNSEmbU1KZfmyEWPdGjx04gQETHS7BfTyiEEZWwTJhixpp90mWqGmPAIU9i0E7lxON0ZtgXzYAtnzbB8u3oWVvi1lQB3FtTB9t0HllwsltukLWni8C6G2E0Q3EPAfmZgqPffrl5/mFKiuaACjWZvGhJy542lko4mab5PsY0DJay9i8k1+QEfwWGMbBvpILnSdRcH3TwjXtTbClJxTg1IRnNq71RUYqSOxCtDUnE56HVUAij1fNM0UJgO7V+lpqpohmscPhSDVX2gaBBGai9m0mgD5HiskQ6Cz2R5pDt2oJQqe1rQPmat4571rqZ2flXgR30YpaOVl1MLFBZZHe5DnFlWzzPnjOzrE7doyge8q58HkOJ0wEzWCAuYcNSf0R63QuXJeV2SWhygJLic9y26jx8CgzFNz9rZ/jP7nrzz3KqwLUP5lPXWBVnx7xagxdpR9KSEojcImC4xddKE+ch2ZV3Tqxkzs4ZanzLm4Es6i3jj0fqnNpim/U5y0qDhNF4wB8q/Y0MRiCW3JWLHlQqbtV9GYl1aDAzqKfzrJh7CIbNfZZyxFTeFOQbGM51fx3UP4KBg==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(8936002)(2906002)(508600001)(6916009)(8676002)(6486002)(26005)(956004)(83380400001)(316002)(1076003)(36756003)(5660300002)(86362001)(186003)(4326008)(66946007)(2616005)(38100700002)(38350700002)(6506007)(66556008)(52116002)(66476007)(6666004)(6512007)(54906003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n 1xdyy/HRTFwl86fRKVFupSpcLFrvj+ub5QZV9gIIZqDQXogPhOFuywmJzTwy/cg8sPMEbSpBtnudBZcPRX/9ExqWaJsD0wUaGLD8Ll4VVzpmfv3Xu4wD/ZOtMA4BXl57dIiAK7clQsmAWg+G8Y7gH9NswL6jDzmItFfIlA2Up34J3FgjfZ+ycFdjrbhY/qMIaydxldpeQSy8COWHBEkHj9YtZVb8CvCymMELoh9V1J6YSTxv04ghHP49AiKXEhsIa80wre/ld7H2FOTE5YjcNoNklKjC3H/jcfc1GH7Va+Qq+qyEOgNz8RneGKpb7ySKe5vGkFdwymNF6aoLoprfWguxEaQivUcfRZfMr/kpLOYTaO0DXnWIYaAIaesxGMstcftBurYviRxtyRjbkXM+njC7jC9XP5AzohkjJ+PygQA9773ThKuoy++OnQZ7ExuYW2njdBCbdJhxpuxA6xoVBMYtrlxhv1Nuv5HUxgnwuBc+B3421Ln6JxSJ5QtZ6A3I2CW1yd77mBNJLBiEQsHuTThqAd9CcBT47Xx34CqmTmu8ISjGl1+3T0TUr1Rti77HmJfeRaRKYxxJfHBoS4niHY/GwL9Cnib3501dXnOn18QR10tNQiXz/OXioGzbr2HZnuul3w0uMyZcUoaiJ5pqZMKDkzoiYlL7zMPCN/9IQYavHCPHVnC0hfke+2jNP/jIQqfYUEJYBiVk4H3spXjsa9Dy/kRpIbZjfBVzMihLcduMClxBd9KpulSesISnR3nf69bW5RB+HAX34zCwrNApXjaArXKMFEja0w6kRw5DvCnvT45O6MSHZXJA7xJM6MOw7fg8VdZjvqYZFFYoBqtSbJgFy9P9jBQ9YXOD4ADymtgdfGHOOA4OWJtjrFNQJnG/GhwMt0E6JFGvBgt1q7hf+o8XsQHq3TIALrZaRMSiZu5OTRakgqNj1kVJK4CakH4Y0+WPpJdiiwlwchNmJZAfIi3AEa+/4QIUCzHa9ZJOA/oaxY232h0NCYkl0hyBwnbIU1NNF9gC/ckzXrf7z3reH1oYoGdXB1S+I7U1v6m8+pbmqqSYMXEg+smrG+oDVNXmbmlIQi21IrD2WubefoyMFHRulVai0Wd56akICal5USfTA2UtrcDpAxGWDKQz5fdV3CZXYCj7N1g9fHGGJMEYvV+h04bo50pvc78OifGmZzjGtsJHrJyGCHlBIjejkOzvee6dWARrJHtSa8tvvEG9Ix9sd4Dhsr6tl0BZFkdOanK/4liuF8WuexKSr1oWVKBCmARChuWZC9aUh4cW/HFm+kRcJz0ZTFy14w+nocqIGIqPao9B1xsVv+tCNnvGA7hho0OLzzoIp0C/fvK2lXpIE8kZOQRUFuKU4w/xF4/+IzvttZItXLZTyJDVbAoIwaOZpbDnfdE7dFPCmzBxENEK+BfjhEGwXuwDGcerM2rC7GIo18O5sscapdgPq7pZwpXgrfK/FzDVv+fpgvQqhURbI6ftnX7sbkM/BrhVwLbuX1qvbmvUW1f6FEKF+0v4J39d8i1ARqPoLHvVLHRlN11Lt2DqVrys0pR0JeYt/Ibo3pA+tzd5iWUX33JYooRYCtUlTURs+FaEfcMoI1NJqFArZXGf4Re6Zf40JDeeXPMBhNY90tdEX4BLPLt5FY+K1J0ky1OnvrgYHe6YLXu7Qgfc9MrxLJ7jAsfRFriS9Ki+628=", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 1725f558-a36b-456e-1fbc-08d9b6b01194", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR04MB4083.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Dec 2021 22:55:57.5864 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n ehC/ZrczuM4mi95eD/G0IOpNCvhQv7NCnc3HNN1tyyqDznnJYJfcjJWWkB65pRW7oVRGzefqwYhJC73Zvmhk77RiI/0L5miTA+B00JtBnfc=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6404", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1ca05831b9b added a check that SDP3 (used as a TX_DISABLE output to the\nSFP cage on these cards) is not asserted to avoid incorrectly reporting\nlink up when the SFP's laser is turned off.\n\nff8162cb957 limited this workaround to fiber ports\n\nRefactor this so it's:\n\n* Not open coded in ixgbe_dev_link_update_share()\n* Runs only on fiber 82599 devices, not all fiber ixgbe devs (which don't\n all use SDP3 as TX_DISABLE)\n\nFixes: 1ca05831b9b (\"net/ixgbe: fix link status\")\nFixes: ff8162cb957 (\"net/ixgbe: fix link status\")\nCc: stable@dpdk.org\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ixgbe/base/ixgbe_82599.c | 41 ++++++++++++++++++++++++++++\n drivers/net/ixgbe/ixgbe_ethdev.c | 7 -----\n 2 files changed, 41 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_82599.c b/drivers/net/ixgbe/base/ixgbe_82599.c\nindex 69fd4cd3fb..5786114b0a 100644\n--- a/drivers/net/ixgbe/base/ixgbe_82599.c\n+++ b/drivers/net/ixgbe/base/ixgbe_82599.c\n@@ -28,6 +28,39 @@ STATIC s32 ixgbe_read_i2c_byte_82599(struct ixgbe_hw *hw, u8 byte_offset,\n STATIC s32 ixgbe_write_i2c_byte_82599(struct ixgbe_hw *hw, u8 byte_offset,\n \t\t\t\t\tu8 dev_addr, u8 data);\n \n+/**\n+ * ixgbe_check_mac_link_82599_fiber - Determine link and speed status\n+ *\n+ * @hw: pointer to hardware structure\n+ * @speed: pointer to link speed\n+ * @link_up: true when link is up\n+ * @link_up_wait_to_complete: bool used to wait for link up or not\n+ *\n+ * Call the generic MAC check_link function, but also take into account the\n+ * state of SDP3, which is a GPIO configured as an output driving the TX_DISABLE\n+ * pin on the SFP cage. This prevents reporting a false positive link up in the\n+ * case where the link partner is transmitting, but we are not.\n+ **/\n+STATIC s32 ixgbe_check_mac_link_82599_fiber(struct ixgbe_hw *hw,\n+\t\t\t\t\t ixgbe_link_speed *speed,\n+\t\t\t\t\t bool *link_up,\n+\t\t\t\t\t bool link_up_wait_to_complete)\n+{\n+\tu32 esdp_reg;\n+\ts32 err;\n+\n+\tDEBUGFUNC(\"ixgbe_check_mac_link_82599_fiber\");\n+\n+\terr = ixgbe_check_mac_link_generic(hw, speed, link_up,\n+\t\t\t\t\t link_up_wait_to_complete);\n+\n+\tesdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);\n+\tif ((esdp_reg & IXGBE_ESDP_SDP3))\n+\t\t*link_up = 0;\n+\n+\treturn err;\n+}\n+\n void ixgbe_init_mac_link_ops_82599(struct ixgbe_hw *hw)\n {\n \tstruct ixgbe_mac_info *mac = &hw->mac;\n@@ -52,6 +85,14 @@ void ixgbe_init_mac_link_ops_82599(struct ixgbe_hw *hw)\n \t\tmac->ops.flap_tx_laser = NULL;\n \t}\n \n+\t/*\n+\t * For 82599 SFP+ fiber, make sure that SDP3 (TX_DISABLE to SFP cage)\n+\t * isn't asserted. Either by mac->ops.disable_tx_laser(), or possibly\n+\t * management firmware\n+\t */\n+\tif (mac->ops.get_media_type(hw) == ixgbe_media_type_fiber)\n+\t\tmac->ops.check_link = ixgbe_check_mac_link_82599_fiber;\n+\n \tif (hw->phy.multispeed_fiber) {\n \t\t/* Set up dual speed SFP+ support */\n \t\tmac->ops.setup_link = ixgbe_setup_mac_link_multispeed_fiber;\ndiff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex 66f7af95de..34b7cb2d4e 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -4216,7 +4216,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \tbool link_up;\n \tint diag;\n \tint wait = 1;\n-\tu32 esdp_reg;\n \n \tmemset(&link, 0, sizeof(link));\n \tlink.link_status = RTE_ETH_LINK_DOWN;\n@@ -4250,12 +4249,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev,\n \t\treturn rte_eth_linkstatus_set(dev, &link);\n \t}\n \n-\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n-\t\tesdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP);\n-\t\tif ((esdp_reg & IXGBE_ESDP_SDP3))\n-\t\t\tlink_up = 0;\n-\t}\n-\n \tif (link_up == 0) {\n \t\tif (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) {\n \t\t\tixgbe_dev_wait_setup_link_complete(dev, 0);\n", "prefixes": [ "4/7" ] }