Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104866/?format=api
{ "id": 104866, "url": "http://patchwork.dpdk.org/api/patches/104866/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/d286500b98bab0dca653d124209b7e1028f0e0d1.1638613012.git.wangyunjian@huawei.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<d286500b98bab0dca653d124209b7e1028f0e0d1.1638613012.git.wangyunjian@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/d286500b98bab0dca653d124209b7e1028f0e0d1.1638613012.git.wangyunjian@huawei.com", "date": "2021-12-04T10:23:36", "name": "net/ixgbe: check ixgbe filter init failure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "78043468fb3d7605778c7567f0f935da5370dc0c", "submitter": { "id": 551, "url": "http://patchwork.dpdk.org/api/people/551/?format=api", "name": "Yunjian Wang", "email": "wangyunjian@huawei.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/d286500b98bab0dca653d124209b7e1028f0e0d1.1638613012.git.wangyunjian@huawei.com/mbox/", "series": [ { "id": 20853, "url": "http://patchwork.dpdk.org/api/series/20853/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20853", "date": "2021-12-04T10:23:36", "name": "net/ixgbe: check ixgbe filter init failure", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20853/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104866/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104866/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7D0FFA0C4C;\n\tSat, 4 Dec 2021 11:23:59 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 26D764013F;\n\tSat, 4 Dec 2021 11:23:58 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id 4FF6440041;\n Sat, 4 Dec 2021 11:23:56 +0100 (CET)", "from dggpemm500021.china.huawei.com (unknown [172.30.72.56])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4J5m1c0lnyz1DJ0t;\n Sat, 4 Dec 2021 18:21:08 +0800 (CST)", "from dggpemm500008.china.huawei.com (7.185.36.136) by\n dggpemm500021.china.huawei.com (7.185.36.109) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2308.20; Sat, 4 Dec 2021 18:23:53 +0800", "from localhost (10.174.242.157) by dggpemm500008.china.huawei.com\n (7.185.36.136) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sat, 4 Dec\n 2021 18:23:53 +0800" ], "From": "Yunjian Wang <wangyunjian@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<haiyue.wang@intel.com>, <dingxiaoxiong@huawei.com>,\n <xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,\n <stable@dpdk.org>", "Subject": "[dpdk-dev] [PATCH] net/ixgbe: check ixgbe filter init failure", "Date": "Sat, 4 Dec 2021 18:23:36 +0800", "Message-ID": "\n <d286500b98bab0dca653d124209b7e1028f0e0d1.1638613012.git.wangyunjian@huawei.com>", "X-Mailer": "git-send-email 1.9.5.msysgit.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.174.242.157]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpemm500008.china.huawei.com (7.185.36.136)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function ixgbe_fdir_filter_init() and ixgbe_l2_tn_filter_init()\ncould return errors, the return value need to be checked and returned.\n\nFixes: 080e3c0ee989 (\"net/ixgbe: store flow director filter\")\nFixes: d0c0c416ef1f (\"net/ixgbe: store L2 tunnel filter\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yunjian Wang <wangyunjian@huawei.com>\n---\n drivers/net/ixgbe/ixgbe_ethdev.c | 30 +++++++++++++++++++++---------\n 1 file changed, 21 insertions(+), 9 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c\nindex fe61dba81d..25d6de7709 100644\n--- a/drivers/net/ixgbe/ixgbe_ethdev.c\n+++ b/drivers/net/ixgbe/ixgbe_ethdev.c\n@@ -1223,13 +1223,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \n \t/* initialize PF if max_vfs not zero */\n \tret = ixgbe_pf_host_init(eth_dev);\n-\tif (ret) {\n-\t\trte_free(eth_dev->data->mac_addrs);\n-\t\teth_dev->data->mac_addrs = NULL;\n-\t\trte_free(eth_dev->data->hash_mac_addrs);\n-\t\teth_dev->data->hash_mac_addrs = NULL;\n-\t\treturn ret;\n-\t}\n+\tif (ret)\n+\t\tgoto err_pf_host_init;\n \n \tctrl_ext = IXGBE_READ_REG(hw, IXGBE_CTRL_EXT);\n \t/* let hardware know driver is loaded */\n@@ -1268,10 +1263,14 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \tTAILQ_INIT(&filter_info->fivetuple_list);\n \n \t/* initialize flow director filter list & hash */\n-\tixgbe_fdir_filter_init(eth_dev);\n+\tret = ixgbe_fdir_filter_init(eth_dev);\n+\tif (ret)\n+\t\tgoto err_fdir_filter_init;\n \n \t/* initialize l2 tunnel filter list & hash */\n-\tixgbe_l2_tn_filter_init(eth_dev);\n+\tret = ixgbe_l2_tn_filter_init(eth_dev);\n+\tif (ret)\n+\t\tgoto err_l2_tn_filter_init;\n \n \t/* initialize flow filter lists */\n \tixgbe_filterlist_init();\n@@ -1283,6 +1282,19 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)\n \tixgbe_tm_conf_init(eth_dev);\n \n \treturn 0;\n+\n+err_l2_tn_filter_init:\n+\tixgbe_fdir_filter_uninit(eth_dev);\n+err_fdir_filter_init:\n+\tixgbe_pf_host_uninit(eth_dev);\n+\trte_intr_callback_unregister(intr_handle,\n+\t\tixgbe_dev_interrupt_handler, eth_dev);\n+err_pf_host_init:\n+\trte_free(eth_dev->data->mac_addrs);\n+\teth_dev->data->mac_addrs = NULL;\n+\trte_free(eth_dev->data->hash_mac_addrs);\n+\teth_dev->data->hash_mac_addrs = NULL;\n+\treturn ret;\n }\n \n static int\n", "prefixes": [] }