Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104867/?format=api
{ "id": 104867, "url": "http://patchwork.dpdk.org/api/patches/104867/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211204103046.3353646-1-asekhar@marvell.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211204103046.3353646-1-asekhar@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211204103046.3353646-1-asekhar@marvell.com", "date": "2021-12-04T10:30:46", "name": "common/cnxk: enable lmtst burst for batch free", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "84d95c6062bdc6649ee976440ad62d920601532a", "submitter": { "id": 2125, "url": "http://patchwork.dpdk.org/api/people/2125/?format=api", "name": "Ashwin Sekhar T K", "email": "asekhar@marvell.com" }, "delegate": { "id": 310, "url": "http://patchwork.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211204103046.3353646-1-asekhar@marvell.com/mbox/", "series": [ { "id": 20854, "url": "http://patchwork.dpdk.org/api/series/20854/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20854", "date": "2021-12-04T10:30:46", "name": "common/cnxk: enable lmtst burst for batch free", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20854/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104867/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104867/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B0FE8A0C4C;\n\tSat, 4 Dec 2021 11:32:47 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 26E0F4013F;\n\tSat, 4 Dec 2021 11:32:47 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id A339440041\n for <dev@dpdk.org>; Sat, 4 Dec 2021 11:32:45 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.16.1.2/8.16.1.2) with ESMTP id\n 1B4APvbB011977\n for <dev@dpdk.org>; Sat, 4 Dec 2021 02:32:43 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3cr6jrg0fa-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Sat, 04 Dec 2021 02:32:43 -0800", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2;\n Sat, 4 Dec 2021 02:32:41 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.18 via Frontend\n Transport; Sat, 4 Dec 2021 02:32:41 -0800", "from lab-ci-142.marvell.com (unknown [10.28.36.142])\n by maili.marvell.com (Postfix) with ESMTP id AA4123F7088;\n Sat, 4 Dec 2021 02:32:38 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=pOpSR9yG1//DH/YOUVt0XJH/VMxevoscwdoZi2cm0Bk=;\n b=b6TpaaIQYU6vFZpjHVmYDztqoyjZPQgegu0bmKOd04EQBsfTbC+du6VLjBPL8V/coZsT\n aY9xfQF/bl+d+JSGanO9K3B7LQYvFmZcGIzDP1ya4aTHF4erH+56c7eUBiE5vB4iFTSD\n MFZt6qXtBH7fLbk+2LFY/f5TWwywO5/modt6/RdojzVQW4kSM2y4htbqK7F75o2WQMqy\n JJQicYz0N2nUBJ4bnaxgV/i4podAP6mjsvBbJ1fpb4JokRHHJfPBGiAKUtcSXdXpzgMu\n iPA/cbspLE3N+ElAzw1W3KskmaMzHFnADhtaCDbQ71F6G+1rQg1mmMv3j/Msteo3FXgC vQ==", "From": "Ashwin Sekhar T K <asekhar@marvell.com>", "To": "<dev@dpdk.org>", "CC": "<ndabilpuram@marvell.com>, <jerinj@marvell.com>, <skori@marvell.com>,\n <skoteshwar@marvell.com>, <pbhagavatula@marvell.com>,\n <kirankumark@marvell.com>, <psatheesh@marvell.com>,\n <asekhar@marvell.com>, <anoobj@marvell.com>, <gakhil@marvell.com>", "Subject": "[PATCH] common/cnxk: enable lmtst burst for batch free", "Date": "Sat, 4 Dec 2021 16:00:46 +0530", "Message-ID": "<20211204103046.3353646-1-asekhar@marvell.com>", "X-Mailer": "git-send-email 2.32.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "T-pQ6kL1qWLwf7e72JWihJKx90-Cvail", "X-Proofpoint-ORIG-GUID": "T-pQ6kL1qWLwf7e72JWihJKx90-Cvail", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513\n definitions=2021-12-04_02,2021-12-02_01,2021-12-02_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use lmtst burst when more than 15 pointers is requested\nto be freed.\n\nSigned-off-by: Ashwin Sekhar T K <asekhar@marvell.com>\n---\n drivers/common/cnxk/roc_npa.h | 86 +++++++++++++++++++++++++++--------\n 1 file changed, 68 insertions(+), 18 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_npa.h b/drivers/common/cnxk/roc_npa.h\nindex 46350fdb48..dfe6e5318f 100644\n--- a/drivers/common/cnxk/roc_npa.h\n+++ b/drivers/common/cnxk/roc_npa.h\n@@ -10,7 +10,8 @@\n \n #define ROC_NPA_MAX_BLOCK_SZ\t\t (128 * 1024)\n #define ROC_CN10K_NPA_BATCH_ALLOC_MAX_PTRS 512\n-#define ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS 15\n+#define ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS 15U\n+#define ROC_CN10K_NPA_BATCH_FREE_BURST_MAX 16U\n \n /* This value controls how much of the present average resource level is used to\n * calculate the new resource level.\n@@ -362,9 +363,6 @@ roc_npa_aura_batch_free(uint64_t aura_handle, uint64_t const *buf,\n \tvolatile uint64_t *lmt_data;\n \tunsigned int i;\n \n-\tif (num > ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS)\n-\t\treturn;\n-\n \tlmt_data = (uint64_t *)lmt_addr;\n \n \taddr = roc_npa_aura_handle_to_base(aura_handle) +\n@@ -379,10 +377,8 @@ roc_npa_aura_batch_free(uint64_t aura_handle, uint64_t const *buf,\n \t * -----------------------------------------\n \t */\n \tfree0 = roc_npa_aura_handle_to_aura(aura_handle);\n-\tif (fabs)\n-\t\tfree0 |= (0x1UL << 63);\n-\tif (num & 0x1)\n-\t\tfree0 |= (0x1UL << 32);\n+\tfree0 |= ((uint64_t)!!fabs << 63);\n+\tfree0 |= ((uint64_t)(num & 0x1) << 32);\n \n \t/* tar_addr[4:6] is LMTST size-1 in units of 128b */\n \ttar_addr = addr | ((num >> 1) << 4);\n@@ -396,23 +392,77 @@ roc_npa_aura_batch_free(uint64_t aura_handle, uint64_t const *buf,\n }\n \n static inline void\n-roc_npa_aura_op_batch_free(uint64_t aura_handle, uint64_t const *buf,\n-\t\t\t unsigned int num, const int fabs, uint64_t lmt_addr,\n-\t\t\t uint64_t lmt_id)\n+roc_npa_aura_batch_free_burst(uint64_t aura_handle, uint64_t const *buf,\n+\t\t\t unsigned int num, const int fabs,\n+\t\t\t uint64_t lmt_addr, uint64_t lmt_id)\n {\n-\tunsigned int chunk;\n+\tuint64_t addr, tar_addr, free0, send_data, lmtline;\n+\tuint64_t *lmt_data;\n+\n+\t/* 63 52 51 20 19 7 6 4 3 0\n+\t * ----------------------------------------\n+\t * | RSVD | ADDR | RSVD | LMTST SZ(0) | 0 |\n+\t * ----------------------------------------\n+\t */\n+\taddr = roc_npa_aura_handle_to_base(aura_handle) +\n+\t NPA_LF_AURA_BATCH_FREE0;\n+\ttar_addr = addr | (0x7 << 4);\n+\n+\t/* 63 63 62 33 32 32 31 20 19 0\n+\t * -----------------------------------------\n+\t * | FABS | Rsvd | COUNT_EOT | Rsvd | AURA |\n+\t * -----------------------------------------\n+\t */\n+\tfree0 = roc_npa_aura_handle_to_aura(aura_handle);\n+\tfree0 |= ((uint64_t)!!fabs << 63);\n+\tfree0 |= (0x1UL << 32);\n \n+\t/* Fill the lmt lines */\n+\tlmt_data = (uint64_t *)lmt_addr;\n+\tlmtline = 0;\n \twhile (num) {\n-\t\tchunk = (num >= ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS) ?\n-\t\t\t\t ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS :\n-\t\t\t\t num;\n+\t\tlmt_data[lmtline * 16] = free0;\n+\t\tmemcpy(&lmt_data[(lmtline * 16) + 1], buf,\n+\t\t ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS * sizeof(uint64_t));\n+\t\tlmtline++;\n+\t\tnum -= ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS;\n+\t\tbuf += ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS;\n+\t}\n \n-\t\troc_npa_aura_batch_free(aura_handle, buf, chunk, fabs, lmt_addr,\n-\t\t\t\t\tlmt_id);\n+\t/* 63 19 18 16 15 12 11 11 10 0\n+\t * ---------------------------------------------------------------\n+\t * | LMTST SZ(15) ... LMTST SZ(1) | Rsvd | CNTM1 | Rsvd | LMT_ID |\n+\t * ---------------------------------------------------------------\n+\t */\n+\tsend_data = lmt_id | ((lmtline - 1) << 12) | (0x1FFFFFFFFFFFUL << 19);\n+\troc_lmt_submit_steorl(send_data, tar_addr);\n+\tplt_io_wmb();\n+}\n \n+static inline void\n+roc_npa_aura_op_batch_free(uint64_t aura_handle, uint64_t const *buf,\n+\t\t\t unsigned int num, const int fabs, uint64_t lmt_addr,\n+\t\t\t uint64_t lmt_id)\n+{\n+\tunsigned int max_burst, chunk, bnum;\n+\n+\tmax_burst = ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS *\n+\t\t ROC_CN10K_NPA_BATCH_FREE_BURST_MAX;\n+\tbnum = num / ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS;\n+\tbnum *= ROC_CN10K_NPA_BATCH_FREE_MAX_PTRS;\n+\tnum -= bnum;\n+\n+\twhile (bnum) {\n+\t\tchunk = (bnum >= max_burst) ? max_burst : bnum;\n+\t\troc_npa_aura_batch_free_burst(aura_handle, buf, chunk, fabs,\n+\t\t\t\t\t lmt_addr, lmt_id);\n \t\tbuf += chunk;\n-\t\tnum -= chunk;\n+\t\tbnum -= chunk;\n \t}\n+\n+\tif (num)\n+\t\troc_npa_aura_batch_free(aura_handle, buf, num, fabs, lmt_addr,\n+\t\t\t\t\tlmt_id);\n }\n \n static inline unsigned int\n", "prefixes": [] }