Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104869/?format=api
{ "id": 104869, "url": "http://patchwork.dpdk.org/api/patches/104869/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211205034450.7888-1-rzidane@nvidia.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211205034450.7888-1-rzidane@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211205034450.7888-1-rzidane@nvidia.com", "date": "2021-12-05T03:44:50", "name": "app/testpmd: fix GENEVE parsing in csum forward mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "94cfbe2ad69ccbb5cd02f4bd550ef78dde811911", "submitter": { "id": 2300, "url": "http://patchwork.dpdk.org/api/people/2300/?format=api", "name": "Raja Zidane", "email": "rzidane@nvidia.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211205034450.7888-1-rzidane@nvidia.com/mbox/", "series": [ { "id": 20856, "url": "http://patchwork.dpdk.org/api/series/20856/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20856", "date": "2021-12-05T03:44:50", "name": "app/testpmd: fix GENEVE parsing in csum forward mode", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20856/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104869/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104869/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B1B44A0C4E;\n\tSun, 5 Dec 2021 04:45:09 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4D7CE4013F;\n\tSun, 5 Dec 2021 04:45:09 +0100 (CET)", "from NAM12-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam12on2048.outbound.protection.outlook.com [40.107.237.48])\n by mails.dpdk.org (Postfix) with ESMTP id 8FAA440040;\n Sun, 5 Dec 2021 04:45:08 +0100 (CET)", "from BN6PR1201CA0021.namprd12.prod.outlook.com\n (2603:10b6:405:4c::31) by BN7PR12MB2770.namprd12.prod.outlook.com\n (2603:10b6:408:32::14) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.14; Sun, 5 Dec\n 2021 03:45:07 +0000", "from BN8NAM11FT020.eop-nam11.prod.protection.outlook.com\n (2603:10b6:405:4c:cafe::30) by BN6PR1201CA0021.outlook.office365.com\n (2603:10b6:405:4c::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.11 via Frontend\n Transport; Sun, 5 Dec 2021 03:45:07 +0000", "from mail.nvidia.com (216.228.112.32) by\n BN8NAM11FT020.mail.protection.outlook.com (10.13.176.223) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id\n 15.20.4755.13 via Frontend Transport; Sun, 5 Dec 2021 03:45:07 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by HQMAIL109.nvidia.com\n (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1497.18; Sat, 4 Dec\n 2021 19:45:05 -0800", "from nvidia.com (172.20.187.5) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.9; Sat, 4 Dec 2021\n 19:45:04 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=WXMs3ff9jyHst/QgvL+PKdxEnjj/bdwGfQdf2VchY0QNlitE9CurIIQ1DKrUiNPubiIuMX02JfTRObomXYbNuDZSaUmYpH8AbJC1oqKY9+TK1dKxtAXFGrAlPfmQK0t9I3WAULstv1aTaJCWHYx6oeQqBlETy2+EyhBbhBkHlsObCcWT10NABTkXBg4TTSR4c96QeSQpml5XEULUkW/XkZOnGMVCstHp3w+zhxspfzOMK1kETb7rHXTJg6S9QrcVyaAAbSsKmOmnmhGPqHQ1i5gkaiTvPiq195jsJEIOq8aK5ngE6UzeqTto8VNPNgOOY/08qu4zqQqsfXJY1dKzGQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=IncgGbrGM1cZyaRQqeeSIk9Ku/PMebWCF8CxOOmodqg=;\n b=igjKrgGx3TAIoTBCUBIPeuSSBHQKi5l4LHh94NXLCuLT3nQmGMHwN+cgYacQiZPVC5Jsm5uijqib1C8AxBpz2o/Yk+CynH1LpS0lmPWFNQorVvyhoKc+nsF4ftt/H2efhnBk0+/C7Beu6DPbSHRWxkmQOWDhZus2a7y94Rb8jyvB18EHcjqzi1u7utHnf+1tUXxI/Ga3EeAekQNnDt/xTMmz7t1eH3CLs1iHgYvFttgrBdPmg7q9gmMzEWLDdg3Qp3Nok80lFAqPBBXgffPYEONRq+Cyznn5oudhJd9nMZAK1rDZu3wirkUp29riI93Onn4lwBPHzNubkiskK+fViw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.112.32) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=quarantine sp=quarantine pct=100) action=none\n header.from=nvidia.com; dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=IncgGbrGM1cZyaRQqeeSIk9Ku/PMebWCF8CxOOmodqg=;\n b=qwDleI6yeFJtewTkduIRMB0p3yw28J94V4qpmLlueFG5luOuTKODP6r9i/S8dDt+1qYjeUJ+cvnt7Kp2oWgAj/z2Kcn7IezoWGl64Eb5TrQbqsMj74Cc8xK8VW8h++lR7ZzmcEYvZ5rkJuCRWuOQi/u0yKByrpOCT0h7dAI/DsazggV+YrMGe44OgC8JApQkI/xAf+WkGAIGUtGj8Ms+0VZqkOL2XcO94N0QLCjIYmfficmpeFH17G+n18NhrU271WFq+tFaF6hVI1BUDt1Yuz/QK0V4W1LgmNF0eVwvsui5NPrYYhJyq2Fkgnr+6mN2T9PIFdq4Iw+L6gjZbfViYA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.112.32)\n smtp.mailfrom=nvidia.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.112.32 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.112.32; helo=mail.nvidia.com;", "From": "Raja Zidane <rzidane@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH] app/testpmd: fix GENEVE parsing in csum forward mode", "Date": "Sun, 5 Dec 2021 03:44:50 +0000", "Message-ID": "<20211205034450.7888-1-rzidane@nvidia.com>", "X-Mailer": "git-send-email 2.17.1", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[172.20.187.5]", "X-ClientProxiedBy": "HQMAIL107.nvidia.com (172.20.187.13) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "25e4e80c-9989-439f-216b-08d9b7a1a147", "X-MS-TrafficTypeDiagnostic": "BN7PR12MB2770:", "X-Microsoft-Antispam-PRVS": "\n <BN7PR12MB27708218EA966DB65B6008B8C76C9@BN7PR12MB2770.namprd12.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n kwbupYXXpzSY+Dwu7G32+HcFjkBozhdpQvOu71WufBh4rkYXMwQlrNwBTMc77UNcosGdPadpegaimqg0HmR6TzU+UhDZf72hOqsDxUH52TrEAF9t+PxICxSSENojCmA4TqjGBnXBUv5ozUezpRGEmm/NAsVXcCUKc24cEBWjzWdmuaVG7T2Bk/yaVsmylXAn6b5rZcbfGkptiTi7cTK+GgyU0wfbvegnBS5zhefSVhV1iYfAcT4MWPyacx3V9PjWvLOgkbayV7l9PY1kAFM+85uPOP6vfbcSbcXWRz3qzcFnyl616OwquC1IMSeZctsVkVDvoeA6rNDXZ1KZpuEesY1A1/yUTQf9B2iyL9WnFciz3iaLuqER09GW2kY3DDAXtdiDJ9FQgw4xawQIs3rZoDgwF9oHTcnJdZrmCCILkKDeHFD/O/2VAapgpZgWWbOZFgZrNQqquJafbwfjjGlWmdXtUWgVeAUXu69crHpjUjxjszENlB2uYOHGgJTb92e+Qvi5upsjvpBJJTI+8vi2FvrY/RQO2Eqyw34Oph9nzueSTy+pJCldjwlkkRKEWUhczyLCuRpPe8o6fGQjZ1/nEFJZHY6NgG1KUSXfKZVIBgPmmyZ4cZlUsR/N7qYw2274OplfT5cs2iO+ooTDCEnPIWG59tZobeVV777XPbzegDTn+bkJCziBoQfUrqZ/1MCb/XkWkOOypnXg/X79q6obw1V7xcIGbfF5jVNcGLUgRjZswbaiqhkn+82asjaicl058XtW1V/OmozoAG/m6J9ecA==", "X-Forefront-Antispam-Report": "CIP:216.228.112.32; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid01.nvidia.com; CAT:NONE;\n SFS:(4636009)(36840700001)(46966006)(40470700001)(5660300002)(186003)(4326008)(6666004)(16526019)(36860700001)(2906002)(83380400001)(40460700001)(6916009)(2616005)(8936002)(1076003)(6286002)(7696005)(316002)(8676002)(426003)(70586007)(450100002)(54906003)(70206006)(356005)(86362001)(36756003)(336012)(55016003)(82310400004)(7636003)(26005)(47076005)(508600001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "05 Dec 2021 03:45:07.1328 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 25e4e80c-9989-439f-216b-08d9b7a1a147", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.32];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n BN8NAM11FT020.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN7PR12MB2770", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The csum FWD mode parses any received packet to set mbuf offloads for the\ntransmitting burst, mainly in the checksum/TSO areas.\nIn the case of a tunnel header, the csum FWD tries to detect known tunnels\nby the standard definition using the header'sdata and fallback to check the\npacket type in the mbuf to see if the Rx port driver already sign the\npacket as a tunnel.\nIn the fallback case, the csum assumes the tunnel is VXLAN and parses the\ntunnel as VXLAN.\nWhen the GENEVE tunnel was added to the known tunnels in csum, its parsing\ntrial was wrongly located after the pkt type detection, causing the csum to\nparse the GENEVE header as VXLAN when the Rx port set the tunnel packet\ntype.\n\nLocate the GENEVE parsing trial before the packet type detection.\n\nFixes: ea0e711b8ae0 (\"app/testpmd: add GENEVE parsing\")\nCc: stable@dpdk.org\n\nSigned-off-by: Raja Zidane <rzidane@nvidia.com>\n---\nAcked-by: Matan Azrad <matan@nvidia.com>\n app/test-pmd/csumonly.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/app/test-pmd/csumonly.c b/app/test-pmd/csumonly.c\nindex 2aeea243b6..fe810fecdd 100644\n--- a/app/test-pmd/csumonly.c\n+++ b/app/test-pmd/csumonly.c\n@@ -254,7 +254,10 @@ parse_gtp(struct rte_udp_hdr *udp_hdr,\n \tinfo->l2_len += RTE_ETHER_GTP_HLEN;\n }\n \n-/* Parse a vxlan header */\n+/*\n+ * Parse a vxlan header.\n+ * If a tunnel is detected in 'pkt_type' it will be parsed by default as vxlan.\n+ */\n static void\n parse_vxlan(struct rte_udp_hdr *udp_hdr,\n \t struct testpmd_offload_info *info,\n@@ -912,17 +915,18 @@ pkt_burst_checksum_forward(struct fwd_stream *fs)\n \t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_VXLAN_GPE;\n \t\t\t\t\tgoto tunnel_update;\n \t\t\t\t}\n-\t\t\t\tparse_vxlan(udp_hdr, &info,\n-\t\t\t\t\t m->packet_type);\n+\t\t\t\tparse_geneve(udp_hdr, &info);\n \t\t\t\tif (info.is_tunnel) {\n \t\t\t\t\ttx_ol_flags |=\n-\t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_VXLAN;\n+\t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_GENEVE;\n \t\t\t\t\tgoto tunnel_update;\n \t\t\t\t}\n-\t\t\t\tparse_geneve(udp_hdr, &info);\n+\t\t\t\t/* Always keep last. */\n+\t\t\t\tparse_vxlan(udp_hdr, &info,\n+\t\t\t\t\t m->packet_type);\n \t\t\t\tif (info.is_tunnel) {\n \t\t\t\t\ttx_ol_flags |=\n-\t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_GENEVE;\n+\t\t\t\t\t\tRTE_MBUF_F_TX_TUNNEL_VXLAN;\n \t\t\t\t\tgoto tunnel_update;\n \t\t\t\t}\n \t\t\t} else if (info.l4_proto == IPPROTO_GRE) {\n", "prefixes": [] }