Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 104870,
    "url": "http://patchwork.dpdk.org/api/patches/104870/?format=api",
    "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211205044230.2146683-1-baymaxhuang@gmail.com/",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20211205044230.2146683-1-baymaxhuang@gmail.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20211205044230.2146683-1-baymaxhuang@gmail.com",
    "date": "2021-12-05T04:42:30",
    "name": "[v2] net/kni: reset rte_kni_conf struct before initialization",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "4a544209d21c195df84fe92ef0246290bd6dd235",
    "submitter": {
        "id": 2435,
        "url": "http://patchwork.dpdk.org/api/people/2435/?format=api",
        "name": "Harold Huang",
        "email": "baymaxhuang@gmail.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211205044230.2146683-1-baymaxhuang@gmail.com/mbox/",
    "series": [
        {
            "id": 20857,
            "url": "http://patchwork.dpdk.org/api/series/20857/?format=api",
            "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20857",
            "date": "2021-12-05T04:42:30",
            "name": "[v2] net/kni: reset rte_kni_conf struct before initialization",
            "version": 2,
            "mbox": "http://patchwork.dpdk.org/series/20857/mbox/"
        }
    ],
    "comments": "http://patchwork.dpdk.org/api/patches/104870/comments/",
    "check": "warning",
    "checks": "http://patchwork.dpdk.org/api/patches/104870/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1538DA0C4E;\n\tSun,  5 Dec 2021 05:42:47 +0100 (CET)",
            "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 988BA40040;\n\tSun,  5 Dec 2021 05:42:46 +0100 (CET)",
            "from mail-pj1-f48.google.com (mail-pj1-f48.google.com\n [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id EFA3D4003C\n for <dev@dpdk.org>; Sun,  5 Dec 2021 05:42:45 +0100 (CET)",
            "by mail-pj1-f48.google.com with SMTP id\n w33-20020a17090a6ba400b001a722a06212so7471083pjj.0\n for <dev@dpdk.org>; Sat, 04 Dec 2021 20:42:45 -0800 (PST)",
            "from localhost.localdomain ([157.255.44.216])\n by smtp.gmail.com with ESMTPSA id t13sm7741462pfl.214.2021.12.04.20.42.43\n for <dev@dpdk.org>\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 04 Dec 2021 20:42:44 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;\n h=from:to:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=LveDOJlThs8HrpAohuHdLFJiIcFJVWA0bucfIgjfm7o=;\n b=UFfF5/y/qVNSwvFqVVCw5BQRIAdwzVNpTCcdNZi/NLpr6MgJjiMq66JjmjIdogSJaU\n lIS3T1aCpkApKVTFJmyxc/Vf+94w0YGI+1P2QRmBdd69qKz6Lofe7DnNHWhHMdCsnGrB\n kVrJd7tlOCQmo9yV6rYq/GDAz8TQIo+rXzaI/NHM7GKoABkeU4K4z7dN6acYAI7Y0XF5\n 8rEmQorDGjFsQNFriAzG7Puwdni4CxCsuPSYZ2tCzrqmxrl8gS8laPK8hVMB1k9sYeSF\n 9Xk4WRwFROq1nxAaz5ggXoJ2VedsoRrcHAJFH164Ik0pcA/14VVctUXHHnUwBfSGSv/t\n aeNA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112;\n h=x-gm-message-state:from:to:subject:date:message-id:mime-version\n :content-transfer-encoding;\n bh=LveDOJlThs8HrpAohuHdLFJiIcFJVWA0bucfIgjfm7o=;\n b=NabNa9LhJ2nyhesaYh01dOW/Ngw/zdrOXCv+V8UVIvhnZKxEpImvrYlt+qjPQ8UZJy\n KhzlEXuGz5kSXqYclfrSvfDjXuws9D78pwm1UN+qAwfTtUmIeGYZh1hZoco+YjZWBfii\n UQlVhXwW1SPv3ZzDOaeEIfKzxySEHxS6iYpYuAX+6m/B/NHDZ2aZhH+Gpnj7nN7HneYo\n kCc9OFmsl8NN84POjdRx/H0nmlxoJ8o2rh4ugIlfF77yoQcg37zYZ6QJaStxqt948xHT\n HX+dEHGbDlK4Thed+dImaKfmi4WacG9SNRJsJRbyQJhCH2msfSdNwNMYo0ny3WAiCpGI\n UeBw==",
        "X-Gm-Message-State": "AOAM530xBhC4FXcCzkahrMyW9Kt2d9055IjLjuOlao0BDcIbRlLyjEni\n QWdBXOrHMNhWMS6nNVOaLNpGNFXF47c=",
        "X-Google-Smtp-Source": "\n ABdhPJz9hK7cEH+6aZPGfIs/otSm5P+aLoPZb4WeCHiPe4kjOs4VqhcU0IoKzxxLq1Lrqcx8uXgD4g==",
        "X-Received": "by 2002:a17:903:246:b0:143:c007:7d41 with SMTP id\n j6-20020a170903024600b00143c0077d41mr34378822plh.59.1638679364803;\n Sat, 04 Dec 2021 20:42:44 -0800 (PST)",
        "From": "Harold Huang <baymaxhuang@gmail.com>",
        "To": "dev@dpdk.org",
        "Subject": "[PATCH v2] net/kni: reset rte_kni_conf struct before initialization",
        "Date": "Sun,  5 Dec 2021 12:42:30 +0800",
        "Message-Id": "<20211205044230.2146683-1-baymaxhuang@gmail.com>",
        "X-Mailer": "git-send-email 2.27.0",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and in some time we could not change the kni device mtu with ip link command.\n\nFixes: ff1e35fb5f8 (\"kni: calculate MTU from mbuf size\")\nSigned-off-by: Harold Huang <baymaxhuang@gmail.com>\n---\n drivers/net/kni/rte_eth_kni.c | 1 +\n 1 file changed, 1 insertion(+)",
    "diff": "diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c\nindex c428caf441..23b15edfac 100644\n--- a/drivers/net/kni/rte_eth_kni.c\n+++ b/drivers/net/kni/rte_eth_kni.c\n@@ -128,6 +128,7 @@ eth_kni_start(struct rte_eth_dev *dev)\n \tconst char *name = dev->device->name + 4; /* remove net_ */\n \n \tmb_pool = internals->rx_queues[0].mb_pool;\n+\tmemset(&conf, 0, sizeof(conf));\n \tstrlcpy(conf.name, name, RTE_KNI_NAMESIZE);\n \tconf.force_bind = 0;\n \tconf.group_id = port_id;\n",
    "prefixes": [
        "v2"
    ]
}