Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104924/?format=api
{ "id": 104924, "url": "http://patchwork.dpdk.org/api/patches/104924/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/patch/1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech/", "project": { "id": 3, "url": "http://patchwork.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech>", "list_archive_url": "https://inbox.dpdk.org/dts/1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech", "date": "2021-12-06T12:14:37", "name": "[v1] framework/dut: fix pylama errors", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "d1463ee20931adea9d0852c8373f69ddede56f81", "submitter": { "id": 1626, "url": "http://patchwork.dpdk.org/api/people/1626/?format=api", "name": "Juraj Linkeš", "email": "juraj.linkes@pantheon.tech" }, "delegate": null, "mbox": "http://patchwork.dpdk.org/project/dts/patch/1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech/mbox/", "series": [ { "id": 20871, "url": "http://patchwork.dpdk.org/api/series/20871/?format=api", "web_url": "http://patchwork.dpdk.org/project/dts/list/?series=20871", "date": "2021-12-06T12:14:37", "name": "[v1] framework/dut: fix pylama errors", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20871/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104924/comments/", "check": "fail", "checks": "http://patchwork.dpdk.org/api/patches/104924/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 830FEA034F;\n\tMon, 6 Dec 2021 13:14:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7AAB541171;\n\tMon, 6 Dec 2021 13:14:41 +0100 (CET)", "from lb.pantheon.sk (lb.pantheon.sk [46.229.239.20])\n by mails.dpdk.org (Postfix) with ESMTP id B612441169\n for <dts@dpdk.org>; Mon, 6 Dec 2021 13:14:39 +0100 (CET)", "from localhost (localhost [127.0.0.1])\n by lb.pantheon.sk (Postfix) with ESMTP id 3745C134296;\n Mon, 6 Dec 2021 13:14:39 +0100 (CET)", "from lb.pantheon.sk ([127.0.0.1])\n by localhost (lb.pantheon.sk [127.0.0.1]) (amavisd-new, port 10024)\n with ESMTP id kVffT36DtKKs; Mon, 6 Dec 2021 13:14:38 +0100 (CET)", "from service-node1.lab.pantheon.local (unknown [46.229.239.141])\n by lb.pantheon.sk (Postfix) with ESMTP id F31DD130F7E;\n Mon, 6 Dec 2021 13:14:37 +0100 (CET)" ], "X-Virus-Scanned": "amavisd-new at siecit.sk", "From": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "To": "lijuan.tu@intel.com,\n\tohilyard@iol.unh.edu", "Cc": "dts@dpdk.org, =?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>", "Subject": "[PATCH v1] framework/dut: fix pylama errors", "Date": "Mon, 6 Dec 2021 13:14:37 +0100", "Message-Id": "<1638792877-2000-1-git-send-email-juraj.linkes@pantheon.tech>", "X-Mailer": "git-send-email 2.7.4", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "Pylama found the following errors:\nframework/dut.py:273: [E] E0602 Undefined variable 'threading' [pylint]\nframework/dut.py:591: [E] E1101 Instance of 'Dut' has no 'get_def_rte_config' member [pylint]\n- move the method from child class\nframework/dut.py:631: [E] E0602 Undefined variable 'crbs' [pylint]\nframework/dut.py:840: [E] E0602 Undefined variable 'ResultTable' [pylint]\nframework/dut.py:846: [E] E0602 Undefined variable 'ResultTable' [pylint]\nframework/dut.py:929: [E] E0602 Undefined variable 'pci_bus' [pylint]\nframework/dut.py:1173: [E] E0602 Undefined variable 'VMCORELIST' [pylint]\n- remove unused method\n\nSigned-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>\n---\nLijuan, please add additional people to review if needed.\n---\n framework/dut.py | 27 ++++++++++++++++++++-------\n framework/project_dpdk.py | 13 -------------\n 2 files changed, 20 insertions(+), 20 deletions(-)", "diff": "diff --git a/framework/dut.py b/framework/dut.py\nindex dc3fc874..0d3447fe 100644\n--- a/framework/dut.py\n+++ b/framework/dut.py\n@@ -31,6 +31,7 @@\n \n import os\n import re\n+import threading\n import time\n from uuid import uuid4\n \n@@ -41,6 +42,7 @@ from .config import AppNameConf, PortConf\n from .crb import Crb\n from .settings import LOG_NAME_SEP, NICS\n from .ssh_connection import SSHConnection\n+from .test_result import ResultTable\n from .utils import RED, remove_old_rsa_key\n from .virt_resource import VirtResource\n \n@@ -540,6 +542,19 @@ class Dut(Crb):\n except AttributeError:\n self.logger.error(\"%s is not implemented\" % function_name)\n \n+ def get_def_rte_config(self, config):\n+ \"\"\"\n+ Get RTE configuration from config/defconfig_*.\n+ \"\"\"\n+ out = self.send_expect(\"cat config/defconfig_%s | sed '/^#/d' | sed '/^\\s*$/d'\"\n+ % self.target, \"# \")\n+\n+ def_rte_config = re.findall(config+'=(\\S+)', out)\n+ if def_rte_config:\n+ return def_rte_config[0]\n+ else:\n+ return None\n+\n def setup_memory_linux(self, hugepages=-1):\n \"\"\"\n Setup Linux hugepages.\n@@ -582,7 +597,7 @@ class Dut(Crb):\n self.set_huge_pages(arch_huge_pages)\n else:\n # before all hugepage average distribution by all socket,\n- # but sometimes create mbuf pool on socket 0 failed when \n+ # but sometimes create mbuf pool on socket 0 failed when\n # setup testpmd, so set all huge page on first socket\n if force_socket:\n self.set_huge_pages(arch_huge_pages, numa_nodes[0])\n@@ -628,7 +643,7 @@ class Dut(Crb):\n if pci_bus == port_info['pci']:\n port = port_info['port']\n break\n- if port and port.get_ipv4_addr() == crbs['IP'].strip():\n+ if port and port.get_ipv4_addr() == self.crb['IP'].strip():\n return True\n else:\n return False\n@@ -926,7 +941,8 @@ class Dut(Crb):\n port = port_info['port']\n intf = port.get_interface_name()\n if \"No such file\" in intf:\n- self.logger.info(\"DUT: [%s] %s\" % (pci_bus, unknow_interface))\n+ self.logger.info(\"DUT: [%s] %s\" % (port_info['pci'],\n+ unknow_interface))\n continue\n self.send_expect(\"ifconfig %s up\" % intf, \"# \")\n time.sleep(5)\n@@ -1056,7 +1072,7 @@ class Dut(Crb):\n self.ports_info = []\n \n skipped = RED('Skipped: Unknown/not selected')\n- \n+\n for (pci_bus, pci_id) in self.pci_devices_info:\n \n if not settings.accepted_nic(pci_id):\n@@ -1169,9 +1185,6 @@ class Dut(Crb):\n for port_id in range(len(self.ports_info)):\n self.destroy_sriov_vfs_by_port(port_id)\n \n- def get_vm_core_list(self):\n- return VMCORELIST[self.crb['VM CoreList']]\n-\n def load_portconf(self):\n \"\"\"\n Load port configurations for ports_info. If manually configured info\ndiff --git a/framework/project_dpdk.py b/framework/project_dpdk.py\nindex 9927bcc1..bc60f1ad 100644\n--- a/framework/project_dpdk.py\n+++ b/framework/project_dpdk.py\n@@ -649,19 +649,6 @@ class DPDKdut(Dut):\n # No blocklist option in FreeBSD\n return blocklist\n \n- def get_def_rte_config(self, config):\n- \"\"\"\n- Get RTE configuration from config/defconfig_*.\n- \"\"\"\n- out = self.send_expect(\"cat config/defconfig_%s | sed '/^#/d' | sed '/^\\s*$/d'\"\n- % self.target, \"# \")\n-\n- def_rte_config = re.findall(config+'=(\\S+)', out)\n- if def_rte_config:\n- return def_rte_config[0]\n- else:\n- return None\n-\n def set_driver_specific_configurations(self, drivername):\n \"\"\"\n Set configurations required for specific drivers before compilation.\n", "prefixes": [ "v1" ] }