Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104929/?format=api
{ "id": 104929, "url": "http://patchwork.dpdk.org/api/patches/104929/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-4-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211206121824.3493-4-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211206121824.3493-4-nipun.gupta@nxp.com", "date": "2021-12-06T12:18:10", "name": "[03/17] net/dpaa2: warn user in case of high nb desc", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ed730a8429dd01054bd59663b2b2f8d641b92ffe", "submitter": { "id": 471, "url": "http://patchwork.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-4-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 20873, "url": "http://patchwork.dpdk.org/api/series/20873/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20873", "date": "2021-12-06T12:18:07", "name": "features and fixes on NXP eth devices", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20873/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104929/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104929/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E4D33A034F;\n\tMon, 6 Dec 2021 13:18:47 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3B888411B6;\n\tMon, 6 Dec 2021 13:18:33 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by mails.dpdk.org (Postfix) with ESMTP id 9AC5E41171\n for <dev@dpdk.org>; Mon, 6 Dec 2021 13:18:28 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 743FB1A06EF;\n Mon, 6 Dec 2021 13:18:28 +0100 (CET)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3D5121A133E;\n Mon, 6 Dec 2021 13:18:28 +0100 (CET)", "from lsv03274.swis.in-blr01.nxp.com (lsv03274.swis.in-blr01.nxp.com\n [92.120.147.114])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 4FC53183AD05;\n Mon, 6 Dec 2021 20:18:27 +0800 (+08)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n Rohit Raj <rohit.raj@nxp.com>", "Subject": "[PATCH 03/17] net/dpaa2: warn user in case of high nb desc", "Date": "Mon, 6 Dec 2021 17:48:10 +0530", "Message-Id": "<20211206121824.3493-4-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "References": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Rohit Raj <rohit.raj@nxp.com>\n\nAdded warning message if application is configuring nb_desc\nmore than supported by PEB memory suggesting user to configure\nHW descriptors in normal memory rather than in faster PEB\nmemory.\n\nSigned-off-by: Rohit Raj <rohit.raj@nxp.com>\n---\n drivers/net/dpaa2/dpaa2_ethdev.c | 13 +++++++++++++\n 1 file changed, 13 insertions(+)", "diff": "diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex a3706439d5..f5cac8f9d9 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -74,6 +74,9 @@ int dpaa2_timestamp_dynfield_offset = -1;\n /* Enable error queue */\n bool dpaa2_enable_err_queue;\n \n+#define MAX_NB_RX_DESC\t\t11264\n+int total_nb_rx_desc;\n+\n struct rte_dpaa2_xstats_name_off {\n \tchar name[RTE_ETH_XSTATS_NAME_SIZE];\n \tuint8_t page_id; /* dpni statistics page id */\n@@ -694,6 +697,13 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \tDPAA2_PMD_DEBUG(\"dev =%p, queue =%d, pool = %p, conf =%p\",\n \t\t\tdev, rx_queue_id, mb_pool, rx_conf);\n \n+\ttotal_nb_rx_desc += nb_rx_desc;\n+\tif (total_nb_rx_desc > MAX_NB_RX_DESC) {\n+\t\tDPAA2_PMD_WARN(\"\\nTotal nb_rx_desc exceeds %d limit. Please use Normal buffers\",\n+\t\t\t MAX_NB_RX_DESC);\n+\t\tDPAA2_PMD_WARN(\"To use Normal buffers, run 'export DPNI_NORMAL_BUF=1' before running dynamic_dpl.sh script\");\n+\t}\n+\n \t/* Rx deferred start is not supported */\n \tif (rx_conf->rx_deferred_start) {\n \t\tDPAA2_PMD_ERR(\"%p:Rx deferred start not supported\",\n@@ -984,6 +994,9 @@ dpaa2_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n \n \tmemset(&cfg, 0, sizeof(struct dpni_queue));\n \tPMD_INIT_FUNC_TRACE();\n+\n+\ttotal_nb_rx_desc -= dpaa2_q->nb_desc;\n+\n \tif (dpaa2_q->cgid != 0xff) {\n \t\toptions = DPNI_QUEUE_OPT_CLEAR_CGID;\n \t\tcfg.cgid = dpaa2_q->cgid;\n", "prefixes": [ "03/17" ] }