Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104936/?format=api
{ "id": 104936, "url": "http://patchwork.dpdk.org/api/patches/104936/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-9-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211206121824.3493-9-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211206121824.3493-9-nipun.gupta@nxp.com", "date": "2021-12-06T12:18:15", "name": "[08/17] net/dpaa2: secondary process handling for dpni", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "80174362bbea4dc626066fa77d27b74cbdefb4b8", "submitter": { "id": 471, "url": "http://patchwork.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-9-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 20873, "url": "http://patchwork.dpdk.org/api/series/20873/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20873", "date": "2021-12-06T12:18:07", "name": "features and fixes on NXP eth devices", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20873/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104936/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104936/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A591DA034F;\n\tMon, 6 Dec 2021 13:19:20 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2C5D342745;\n\tMon, 6 Dec 2021 13:18:39 +0100 (CET)", "from inva021.nxp.com (inva021.nxp.com [92.121.34.21])\n by mails.dpdk.org (Postfix) with ESMTP id A8A37411B2\n for <dev@dpdk.org>; Mon, 6 Dec 2021 13:18:30 +0100 (CET)", "from inva021.nxp.com (localhost [127.0.0.1])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 772D6201AC6;\n Mon, 6 Dec 2021 13:18:30 +0100 (CET)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 14730201295;\n Mon, 6 Dec 2021 13:18:30 +0100 (CET)", "from lsv03274.swis.in-blr01.nxp.com (lsv03274.swis.in-blr01.nxp.com\n [92.120.147.114])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id 7ADB8183AC96;\n Mon, 6 Dec 2021 20:18:29 +0800 (+08)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n Jun Yang <jun.yang@nxp.com>", "Subject": "[PATCH 08/17] net/dpaa2: secondary process handling for dpni", "Date": "Mon, 6 Dec 2021 17:48:15 +0530", "Message-Id": "<20211206121824.3493-9-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "References": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jun Yang <jun.yang@nxp.com>\n\nThis change uses 'dev->process_private' instead of 'priv->hw'\nto get dpmcp per process while setting flow distribution,\nas priv->hw is only valid for primary process.\nIt also initialize rte_dpaa2_bpid_info in secondary process.\n\nSigned-off-by: Jun Yang <jun.yang@nxp.com>\n---\n drivers/mempool/dpaa2/dpaa2_hw_mempool.c | 23 +++++++++++++++++++++++\n drivers/mempool/dpaa2/rte_dpaa2_mempool.h | 15 +++++++++++++++\n drivers/mempool/dpaa2/version.map | 1 +\n drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 5 ++---\n drivers/net/dpaa2/dpaa2_ethdev.c | 10 ++++++++--\n drivers/net/dpaa2/dpaa2_ethdev.h | 3 ++-\n 6 files changed, 51 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\nindex 39c6252a63..56c629c681 100644\n--- a/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n+++ b/drivers/mempool/dpaa2/dpaa2_hw_mempool.c\n@@ -263,6 +263,29 @@ rte_dpaa2_mbuf_release(struct rte_mempool *pool __rte_unused,\n \t}\n }\n \n+int rte_dpaa2_bpid_info_init(struct rte_mempool *mp)\n+{\n+\tstruct dpaa2_bp_info *bp_info = mempool_to_bpinfo(mp);\n+\tuint32_t bpid = bp_info->bpid;\n+\n+\tif (!rte_dpaa2_bpid_info) {\n+\t\trte_dpaa2_bpid_info = (struct dpaa2_bp_info *)rte_malloc(NULL,\n+\t\t\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID,\n+\t\t\t\t RTE_CACHE_LINE_SIZE);\n+\t\tif (rte_dpaa2_bpid_info == NULL)\n+\t\t\treturn -ENOMEM;\n+\t\tmemset(rte_dpaa2_bpid_info, 0,\n+\t\t sizeof(struct dpaa2_bp_info) * MAX_BPID);\n+\t}\n+\n+\trte_dpaa2_bpid_info[bpid].meta_data_size = sizeof(struct rte_mbuf)\n+\t\t\t\t+ rte_pktmbuf_priv_size(mp);\n+\trte_dpaa2_bpid_info[bpid].bp_list = bp_info->bp_list;\n+\trte_dpaa2_bpid_info[bpid].bpid = bpid;\n+\n+\treturn 0;\n+}\n+\n uint16_t\n rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp)\n {\ndiff --git a/drivers/mempool/dpaa2/rte_dpaa2_mempool.h b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h\nindex 4a22b7c42e..28dea74326 100644\n--- a/drivers/mempool/dpaa2/rte_dpaa2_mempool.h\n+++ b/drivers/mempool/dpaa2/rte_dpaa2_mempool.h\n@@ -46,6 +46,21 @@ rte_dpaa2_mbuf_pool_bpid(struct rte_mempool *mp);\n struct rte_mbuf *\n rte_dpaa2_mbuf_from_buf_addr(struct rte_mempool *mp, void *buf_addr);\n \n+/**\n+ * Initialize the rte_dpaa2_bpid_info\n+ * In generial, it is called in the secondary process and\n+ * mp has been created in the primary process.\n+ *\n+ * @param mp\n+ * memory pool\n+ *\n+ * @return\n+ * - 0 on success.\n+ * - (<0) on failure.\n+ */\n+__rte_internal\n+int rte_dpaa2_bpid_info_init(struct rte_mempool *mp);\n+\n #ifdef __cplusplus\n }\n #endif\ndiff --git a/drivers/mempool/dpaa2/version.map b/drivers/mempool/dpaa2/version.map\nindex 49c460ec54..cfd4ae617a 100644\n--- a/drivers/mempool/dpaa2/version.map\n+++ b/drivers/mempool/dpaa2/version.map\n@@ -11,5 +11,6 @@ INTERNAL {\n \tglobal:\n \n \trte_dpaa2_bpid_info;\n+\trte_dpaa2_bpid_info_init;\n \trte_dpaa2_mbuf_alloc_bulk;\n };\ndiff --git a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\nindex 3170694841..9509f6e8a3 100644\n--- a/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n+++ b/drivers/net/dpaa2/base/dpaa2_hw_dpni.c\n@@ -95,7 +95,7 @@ dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev,\n \tuint64_t req_dist_set, int tc_index)\n {\n \tstruct dpaa2_dev_priv *priv = eth_dev->data->dev_private;\n-\tstruct fsl_mc_io *dpni = priv->hw;\n+\tstruct fsl_mc_io *dpni = eth_dev->process_private;\n \tstruct dpni_rx_dist_cfg tc_cfg;\n \tstruct dpkg_profile_cfg kg_cfg;\n \tvoid *p_params;\n@@ -457,13 +457,12 @@ dpaa2_distset_to_dpkg_profile_cfg(\n \n int\n dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv,\n-\t\t void *blist)\n+\tstruct fsl_mc_io *dpni, void *blist)\n {\n \t/* Function to attach a DPNI with a buffer pool list. Buffer pool list\n \t * handle is passed in blist.\n \t */\n \tint32_t retcode;\n-\tstruct fsl_mc_io *dpni = priv->hw;\n \tstruct dpni_pools_cfg bpool_cfg;\n \tstruct dpaa2_bp_list *bp_list = (struct dpaa2_bp_list *)blist;\n \tstruct dpni_buffer_layout layout;\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex b91e773605..a45beed75f 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -18,6 +18,7 @@\n #include <rte_dev.h>\n #include <rte_fslmc.h>\n #include <rte_flow_driver.h>\n+#include \"rte_dpaa2_mempool.h\"\n \n #include \"dpaa2_pmd_logs.h\"\n #include <fslmc_vfio.h>\n@@ -712,9 +713,14 @@ dpaa2_dev_rx_queue_setup(struct rte_eth_dev *dev,\n \t}\n \n \tif (!priv->bp_list || priv->bp_list->mp != mb_pool) {\n+\t\tif (rte_eal_process_type() != RTE_PROC_PRIMARY) {\n+\t\t\tret = rte_dpaa2_bpid_info_init(mb_pool);\n+\t\t\tif (ret)\n+\t\t\t\treturn ret;\n+\t\t}\n \t\tbpid = mempool_to_bpid(mb_pool);\n-\t\tret = dpaa2_attach_bp_list(priv,\n-\t\t\t\t\t rte_dpaa2_bpid_info[bpid].bp_list);\n+\t\tret = dpaa2_attach_bp_list(priv, dpni,\n+\t\t\t\trte_dpaa2_bpid_info[bpid].bp_list);\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.h b/drivers/net/dpaa2/dpaa2_ethdev.h\nindex 1fc2fc367e..bd33a22a8e 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.h\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.h\n@@ -208,7 +208,8 @@ int dpaa2_setup_flow_dist(struct rte_eth_dev *eth_dev,\n int dpaa2_remove_flow_dist(struct rte_eth_dev *eth_dev,\n \t\t\t uint8_t tc_index);\n \n-int dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv, void *blist);\n+int dpaa2_attach_bp_list(struct dpaa2_dev_priv *priv,\n+\tstruct fsl_mc_io *dpni, void *blist);\n \n __rte_internal\n int dpaa2_eth_eventq_attach(const struct rte_eth_dev *dev,\n", "prefixes": [ "08/17" ] }