Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104939/?format=api
{ "id": 104939, "url": "http://patchwork.dpdk.org/api/patches/104939/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-12-nipun.gupta@nxp.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211206121824.3493-12-nipun.gupta@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211206121824.3493-12-nipun.gupta@nxp.com", "date": "2021-12-06T12:18:18", "name": "[11/17] net/dpaa: check status before configuring shared MAC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4945b579262700fea542a7062206a52ea108a72d", "submitter": { "id": 471, "url": "http://patchwork.dpdk.org/api/people/471/?format=api", "name": "Nipun Gupta", "email": "nipun.gupta@nxp.com" }, "delegate": { "id": 319, "url": "http://patchwork.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211206121824.3493-12-nipun.gupta@nxp.com/mbox/", "series": [ { "id": 20873, "url": "http://patchwork.dpdk.org/api/series/20873/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20873", "date": "2021-12-06T12:18:07", "name": "features and fixes on NXP eth devices", "version": 1, "mbox": "http://patchwork.dpdk.org/series/20873/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104939/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104939/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 35102A034F;\n\tMon, 6 Dec 2021 13:19:42 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DB8D24275A;\n\tMon, 6 Dec 2021 13:18:42 +0100 (CET)", "from inva020.nxp.com (inva020.nxp.com [92.121.34.13])\n by mails.dpdk.org (Postfix) with ESMTP id CD97F41186\n for <dev@dpdk.org>; Mon, 6 Dec 2021 13:18:31 +0100 (CET)", "from inva020.nxp.com (localhost [127.0.0.1])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id AFCCC1A133E;\n Mon, 6 Dec 2021 13:18:31 +0100 (CET)", "from aprdc01srsp001v.ap-rdc01.nxp.com\n (aprdc01srsp001v.ap-rdc01.nxp.com [165.114.16.16])\n by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 4EEF21A0E16;\n Mon, 6 Dec 2021 13:18:31 +0100 (CET)", "from lsv03274.swis.in-blr01.nxp.com (lsv03274.swis.in-blr01.nxp.com\n [92.120.147.114])\n by aprdc01srsp001v.ap-rdc01.nxp.com (Postfix) with ESMTP id B6A2F183ACDD;\n Mon, 6 Dec 2021 20:18:30 +0800 (+08)" ], "From": "nipun.gupta@nxp.com", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@intel.com, hemant.agrawal@nxp.com,\n Nipun Gupta <nipun.gupta@nxp.com>", "Subject": "[PATCH 11/17] net/dpaa: check status before configuring shared MAC", "Date": "Mon, 6 Dec 2021 17:48:18 +0530", "Message-Id": "<20211206121824.3493-12-nipun.gupta@nxp.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "References": "<20211206121824.3493-1-nipun.gupta@nxp.com>", "X-Virus-Scanned": "ClamAV using ClamSMTP", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Nipun Gupta <nipun.gupta@nxp.com>\n\nFor shared MAC interface, it is a prerequisite to enable the\ninterface in the kernel, before using it in user-space. This\npatch makes sure that device is not getting configured in\ncase shared MAC interface is not enabled in the kernel.\n\nSigned-off-by: Nipun Gupta <nipun.gupta@nxp.com>\n---\n drivers/bus/dpaa/base/fman/fman_hw.c | 11 +++++++++++\n drivers/bus/dpaa/include/fsl_fman.h | 2 ++\n drivers/bus/dpaa/version.map | 1 +\n drivers/net/dpaa/dpaa_ethdev.c | 13 ++++++++++++-\n 4 files changed, 26 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/bus/dpaa/base/fman/fman_hw.c b/drivers/bus/dpaa/base/fman/fman_hw.c\nindex af9bac76c2..24a99f7235 100644\n--- a/drivers/bus/dpaa/base/fman/fman_hw.c\n+++ b/drivers/bus/dpaa/base/fman/fman_hw.c\n@@ -314,6 +314,17 @@ fman_if_disable_rx(struct fman_if *p)\n \tout_be32(__if->ccsr_map + 8, in_be32(__if->ccsr_map + 8) & ~(u32)2);\n }\n \n+int\n+fman_if_get_rx_status(struct fman_if *p)\n+{\n+\tstruct __fman_if *__if = container_of(p, struct __fman_if, __if);\n+\n+\tassert(fman_ccsr_map_fd != -1);\n+\n+\t/* return true if RX bit is set */\n+\treturn !!(in_be32(__if->ccsr_map + 8) & (u32)2);\n+}\n+\n void\n fman_if_loopback_enable(struct fman_if *p)\n {\ndiff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h\nindex f3a5d05970..acb344584f 100644\n--- a/drivers/bus/dpaa/include/fsl_fman.h\n+++ b/drivers/bus/dpaa/include/fsl_fman.h\n@@ -81,6 +81,8 @@ __rte_internal\n void fman_if_enable_rx(struct fman_if *p);\n __rte_internal\n void fman_if_disable_rx(struct fman_if *p);\n+__rte_internal\n+int fman_if_get_rx_status(struct fman_if *p);\n \n /* Enable/disable loopback on specific interfaces */\n __rte_internal\ndiff --git a/drivers/bus/dpaa/version.map b/drivers/bus/dpaa/version.map\nindex 900635b210..1a840fd1a5 100644\n--- a/drivers/bus/dpaa/version.map\n+++ b/drivers/bus/dpaa/version.map\n@@ -33,6 +33,7 @@ INTERNAL {\n \tfman_if_get_fdoff;\n \tfman_if_get_maxfrm;\n \tfman_if_get_sg_enable;\n+\tfman_if_get_rx_status;\n \tfman_if_loopback_disable;\n \tfman_if_loopback_enable;\n \tfman_if_promiscuous_disable;\ndiff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex e49f765434..3972ecaed8 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -195,6 +195,7 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)\n \tstruct rte_eth_conf *eth_conf = &dev->data->dev_conf;\n \tuint64_t rx_offloads = eth_conf->rxmode.offloads;\n \tuint64_t tx_offloads = eth_conf->txmode.offloads;\n+\tstruct dpaa_if *dpaa_intf = dev->data->dev_private;\n \tstruct rte_device *rdev = dev->device;\n \tstruct rte_eth_link *link = &dev->data->dev_link;\n \tstruct rte_dpaa_device *dpaa_dev;\n@@ -203,7 +204,7 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)\n \tstruct rte_intr_handle *intr_handle;\n \tuint32_t max_rx_pktlen;\n \tint speed, duplex;\n-\tint ret;\n+\tint ret, rx_status;\n \n \tPMD_INIT_FUNC_TRACE();\n \n@@ -211,6 +212,16 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)\n \tintr_handle = dpaa_dev->intr_handle;\n \t__fif = container_of(fif, struct __fman_if, __if);\n \n+\t/* Check if interface is enabled in case of shared MAC */\n+\tif (fif->is_shared_mac) {\n+\t\trx_status = fman_if_get_rx_status(fif);\n+\t\tif (!rx_status) {\n+\t\t\tDPAA_PMD_ERR(\"%s Interface not enabled in kernel!\",\n+\t\t\t\t dpaa_intf->name);\n+\t\t\treturn -EHOSTDOWN;\n+\t\t}\n+\t}\n+\n \t/* Rx offloads which are enabled by default */\n \tif (dev_rx_offloads_nodis & ~rx_offloads) {\n \t\tDPAA_PMD_INFO(\n", "prefixes": [ "11/17" ] }