Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/104956/?format=api
{ "id": 104956, "url": "http://patchwork.dpdk.org/api/patches/104956/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/patch/20211206221922.644187-7-stephend@silicom-usa.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20211206221922.644187-7-stephend@silicom-usa.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20211206221922.644187-7-stephend@silicom-usa.com", "date": "2021-12-06T22:19:20", "name": "[v2,6/7] net/ixgbe: Retry SFP ID read field to handle misbehaving SFPs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ddf6579e444f7b20b4d146bcc8872c147414ef35", "submitter": { "id": 2437, "url": "http://patchwork.dpdk.org/api/people/2437/?format=api", "name": "Stephen Douthit", "email": "stephend@silicom-usa.com" }, "delegate": { "id": 1540, "url": "http://patchwork.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20211206221922.644187-7-stephend@silicom-usa.com/mbox/", "series": [ { "id": 20881, "url": "http://patchwork.dpdk.org/api/series/20881/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=20881", "date": "2021-12-06T22:19:14", "name": "ixgbe SFP handling fixes", "version": 2, "mbox": "http://patchwork.dpdk.org/series/20881/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/patches/104956/comments/", "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/104956/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2EC49A034F;\n\tMon, 6 Dec 2021 23:20:21 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1664426E4;\n\tMon, 6 Dec 2021 23:19:57 +0100 (CET)", "from EUR05-DB8-obe.outbound.protection.outlook.com\n (mail-db8eur05on2095.outbound.protection.outlook.com [40.107.20.95])\n by mails.dpdk.org (Postfix) with ESMTP id 79DAD40040\n for <dev@dpdk.org>; Mon, 6 Dec 2021 23:19:56 +0100 (CET)", "from AM0PR04MB4083.eurprd04.prod.outlook.com (2603:10a6:208:64::29)\n by AM0PR04MB6596.eurprd04.prod.outlook.com (2603:10a6:208:173::13)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4755.21; Mon, 6 Dec\n 2021 22:19:55 +0000", "from AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc]) by AM0PR04MB4083.eurprd04.prod.outlook.com\n ([fe80::f4db:d40d:a746:7bfc%7]) with mapi id 15.20.4755.022; Mon, 6 Dec 2021\n 22:19:55 +0000", "from lappy.adi.eng (173.14.114.227) by\n MN2PR20CA0031.namprd20.prod.outlook.com (2603:10b6:208:e8::44) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.4755.19 via Frontend Transport; Mon, 6 Dec 2021 22:19:54 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=bCod5+Tkm58syvnJ0VkfgQRdvj/3/TcCLk1QHGSGwntUcMbVSMzqNCgsDeKU/j3PkdiIPS4qa/Aw/4WB5f6jUtaL0M8ZTRJJhfRXWj238Jjn0ZLAohyya/Vu0CoBTaCJd6N4OZ4goJt9mshFrjJwKhEbm6MmM/PXl7DwpVUFoD+hShnjk1+wCzn9ynOrOoEHzb1NAVHSuyDs1n3R2VcUzWtri8O6ZlTG8XjTfuvWa66xJLHHzCcs/YFee0U/QAvGyrs54shmDADnkqsEKwNOAgc/+Ug/OGf6ogcRwBqrzxEwvEWfERg4byVgPU1/S280iFUdYsbWAV9l8c612yn0hQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=TLWJ/N3uy81luT2AJZRD2PrZ4DdBQfcOmmb5f39fGyo=;\n b=Tlh+V8Z4AFy8R+sElGFsEC4ocQljeJAIcd0eMFX4MxdxlBf0LTBHFCvi7NH2OfFKTZKInwBVwKsOTDheIZaa3r4hGW727NJPV8IxuRkx3TvRoHbzJqbwP16j3HM8nVuKfCDO8U8IuZSEd1ROUIghYRicex1msw0+feoeDuti2Sy3XXeGB3PdOwjTT3ZbqrvbpyJiMFE5My44yaXd1RCahZPWdE9i+Gpyt+QRhEifm/LJNs0471C3CVKcFP5JQvhpthgT0kGSnqLJguQNI4msaZ1nz5s+dmb4GufsfOqmEYhk5OntpZjpSwt6My9feb2nYWEBdgKtYje07dshJQIEeQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=silicom-usa.com; dmarc=pass action=none\n header.from=silicom-usa.com; dkim=pass header.d=silicom-usa.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=SILICOMLTD.onmicrosoft.com; s=selector2-SILICOMLTD-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=TLWJ/N3uy81luT2AJZRD2PrZ4DdBQfcOmmb5f39fGyo=;\n b=yJK66eX0Le3sCqYAiLErrkO0lH8elqoQ/RWNV+u0F0pJD/bvIsLrddC2cY6r1tFh421QMue7b4nvZelAfmXah6bKFQxgKDcQMc+0S6nAs8C3a0y5Ab90iP3qD2ejmXC3bemGSw46oRCAnYZbQ3NUhZUYDDYx5NG9dI7RFgGUTRs=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=silicom-usa.com;", "From": "Stephen Douthit <stephend@silicom-usa.com>", "To": "Haiyue Wang <haiyue.wang@intel.com>", "Cc": "dev@dpdk.org, wenw@silicom-usa.com,\n Stephen Douthit <stephend@silicom-usa.com>", "Subject": "[PATCH v2 6/7] net/ixgbe: Retry SFP ID read field to handle\n misbehaving SFPs", "Date": "Mon, 6 Dec 2021 17:19:20 -0500", "Message-Id": "<20211206221922.644187-7-stephend@silicom-usa.com>", "X-Mailer": "git-send-email 2.31.1", "In-Reply-To": "<20211206221922.644187-1-stephend@silicom-usa.com>", "References": "<20211206221922.644187-1-stephend@silicom-usa.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "MN2PR20CA0031.namprd20.prod.outlook.com\n (2603:10b6:208:e8::44) To AM0PR04MB4083.eurprd04.prod.outlook.com\n (2603:10a6:208:64::29)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-Correlation-Id": "9954f17d-76d0-45a1-99e6-08d9b90687d1", "X-MS-TrafficTypeDiagnostic": "AM0PR04MB6596:EE_", "X-Microsoft-Antispam-PRVS": "\n <AM0PR04MB6596436F5626E394DB47D55F946D9@AM0PR04MB6596.eurprd04.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:8273;", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n G3A/V9IJJQVERVlSYjuUVjaWxpuxUI67y+lxZrHV+9AoS055cWymRKMqPbF5ZXRDSN9DkKKq70O5zocXm1TX3f1w7N+Kd5W4X/ZFvZkb3Xjtk18QlfrBakXTY17VdQi/Js8wQwd242PCVMg5W8Ak0RpBFMKNOMHnndZU5NhsUX3o5dgy+WcxzU9eRm0qon12qb3bHf7hCn3maHP5kPXJ+hgAnWHgZ81Piw5NnnIyapaKEKTyITJ7UexOs7qm0d/94hdA1DhrPBnLROLNTvcq80GFcpaVnMlVUYvGy0uEUwYSYByl20PWxOl8zGrSEBUDHXUH67aHc2m+9xNnymQukOmJyq1hT5t0wOD3d3w5RAmtSNHhxDFDC1yS5zk+esCs399133xttdy9Z5+uJ1rDY8mm9uoV7eJ3npYwhqDv/HotONs8uIz1lcwfO0LHvsQFwq0UfZBz9Nf7iASKmTwZa5spbO6xckDgxxjU/tQdsgMC/7eu3LKUySsnqpDkz4EE8e1teNYB6dv4400qX1kwRSMdoKYgd6YQDQmTJTxEg4a1WiPbk0nPa7gAEkayqZmq0I1iB9UU9f6e+M+MkOhnwElzPCo4p6BuB3XBDzPqmjGpCQ4jBYwkeMXNhK1nNouw/m+46Knj83LoSMFTrryetxD8KUPJkvPkWNYe1oCLwlKqeHJHEy4oz4+6HxH6+CIfkBtcsWsZcTDBJbTav5ZVZw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR04MB4083.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(4636009)(366004)(8676002)(4326008)(66946007)(6506007)(8936002)(6666004)(2616005)(52116002)(66476007)(66556008)(86362001)(956004)(107886003)(6486002)(6512007)(2906002)(316002)(83380400001)(1076003)(36756003)(38100700002)(38350700002)(26005)(5660300002)(186003)(508600001)(6916009);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n g+KOOvp9ssse8ONtBYiiq1Reqm2ruKPCv6cs4gJmfoCJDLnfbAdqlPqB/Npom5YluwH0DmIFMUh1SWBpyBoHuUMoIs7RVHpS36RyTLaIs9XyQ3DzCFAc14Shfe2SVuTHdPa8X+gLyl8q5h26dVDGhPXkD3RQwznb1O094AEbuNNHmE/vfF3rzhEW+rP8sWKpJyuUrFnGVBkrWDzS3a14ratSqmOKlc5citd8bR5RvbRM6/kbpXIqDTOGQ2gdh0IwhTBtt7hhiCLPjColHzdGE9tci2YK8i1cld3oqazzm5VYpxyYXOdeYcEq4g8G+2h+OPEXbNH0bxU57JFkl8qJ5kBlOm3gK5e57gAuCvwKVWzhEhIu5GZsIM+EfSc71nb551sFURzg7XY3JTCeyH3J+QRVBuPxCui8zI+x9ZnPTJyl3/yQ21egdl8/bicjoM/SjGRL9J8MRoEcDbkw41WPPyDOqbUw9WF2Xre+TS7nPCVZvM0GeCkUCbDU6BjCdfV7C9WQ/uyf57Qxd4Cnk/6kpH10ah/1IcjHUuz/uh6lFYACUv4izwcT2oG3Z6m8tkQ/pmOLQBFWd1mIxOD1TiAVRvJpLxJOVDTDikcWkJf18tV26lUBp74XV6D/Il57pMiJWLoBgLC5QsR2cvU79a4njXYO/WHzlsiEaBjoEHbbkGnDN4wKy6w387rG6it2LlORz6JAhRQ/3vxkpA3/fPzJTcmqFCLGAYVQ6UQdkqI7QzMx6rHRmUtmWfpegU6iBvJ/0T0dEnztpDgztaQmRZ8O7nFSbB6dhLNzZsD+wNeYCZ9yt+C6mcf0Z/9Ghq3MAiY8uiOwQPU0BNOST6Zcs0lAGnXHwKSSwuHpYofvk8faA3wK7AoMre5j5XC7AIF39X/nUwPmCIsLzdBk22l483hCKi0yGwqylnTyV++P1fLZS3LrxqtGOjECTBSyzagjvpzHF/ItuAHRxHnmokP150xiMzTVa7Yc2zC9worLpoCALV9vwUBUrcRimHcWlLBZzljA3yMOO+37I4TseQNeke8tQvnp717qYztK5eAB9Z1ls/sSWyUCQMN278TkHHqPC0/qjUGmJ7UfLZX0xNczX1/6TzvInwhAsUNacBjxafDJ4Imqf9+qzZsBb2rppXVLNLoM5Z0jyZJ6tK24Hc0HaTYLj5dusGO9FNV5Z6gtbIjLdj+R6rKpJsVJZo/VhPXnqO8yMb2o32jSBSC7f5GyiU6mSKzyQ18b7TernThfFY75kkQ4z1acf6XJPflb29xDm4fohmb1r2GlaXJkABMNjesPZ5VJy3rxb6Vmx/cZ3xuWwgfhVVfCiAyMU3bAlNFsbcp5FjIEyI2vjZ9g3oBXCbpF386cwAvQ6FP6eZvRf/C7HzgryPCtdWGd80M8l7/gau/vv6b2CgaGHePcaQrkGWB+JjZ0/eeQDgJyBnv1p6yvMlfpM5IPn/CbOgP1YaDU8KEkcb4LO3oRvY3WwCv4my4BjJYuMGAO7tGWCVV1gnHWSD6rcnQe3OV6/iKed6t+eMKJKrdlP5qkC5wmx2PEIMz7Y7gnfKqU1IPzcPwpITLbM4UGmpL4GbDHeaSzMqiF2ICB2//4d0kp0OeEp69XGiiTn2vCM5xYq3JB5Nk1b1ff0lgR5gN78cZhC/neRwVJj8XkeWRjnNuQyrUfY7X6fQr22w==", "X-OriginatorOrg": "silicom-usa.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 9954f17d-76d0-45a1-99e6-08d9b90687d1", "X-MS-Exchange-CrossTenant-AuthSource": "AM0PR04MB4083.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "06 Dec 2021 22:19:55.1167 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "c9e326d8-ce47-4930-8612-cc99d3c87ad1", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n RabHp0hpllU6tZWr1hh1DvaemTwTeu5h0jeQrq64ULjwYzQcOcWzaGKE/ub7lUX80jf2Xu6ic6+rvgusWXZEOzwNBpnYlr4c1q+z85lRH30=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0PR04MB6596", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Some XGS-PON SFPs have been observed ACKing I2C reads and returning\nuninitialized garbage while their uC boots. This can lead to the SFP ID\ncode marking an otherwise working SFP module as unsupported if a bogus\nID value is read while its internal PHY/microcontroller is still\nbooting.\n\nRetry the ID read several times looking not just for NAK, but also for a\nvalid ID field.\n\nSince the device isn't NAKing the trasanction the existing longer retry\ncode in ixgbe_read_i2c_byte_generic_int() doesn't apply here.\n\nSigned-off-by: Stephen Douthit <stephend@silicom-usa.com>\n---\n drivers/net/ixgbe/base/ixgbe_phy.c | 31 ++++++++++++++++++++++++++----\n 1 file changed, 27 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c\nindex d8d51d2c3f..27bce066a1 100644\n--- a/drivers/net/ixgbe/base/ixgbe_phy.c\n+++ b/drivers/net/ixgbe/base/ixgbe_phy.c\n@@ -1275,6 +1275,7 @@ s32 ixgbe_identify_sfp_module_generic(struct ixgbe_hw *hw)\n \tu8 cable_tech = 0;\n \tu8 cable_spec = 0;\n \tu16 enforce_sfp = 0;\n+\tu8 id_reads;\n \n \tDEBUGFUNC(\"ixgbe_identify_sfp_module_generic\");\n \n@@ -1287,12 +1288,34 @@ s32 ixgbe_identify_sfp_module_generic(struct ixgbe_hw *hw)\n \t/* LAN ID is needed for I2C access */\n \thw->mac.ops.set_lan_id(hw);\n \n-\tstatus = hw->phy.ops.read_i2c_eeprom(hw,\n-\t\t\t\t\t IXGBE_SFF_IDENTIFIER,\n-\t\t\t\t\t &identifier);\n+\t/* Need to check this a couple of times for a sane value.\n+\t *\n+\t * SFPs that have a uC slaved to the I2C bus (vs. a dumb EEPROM) can be\n+\t * poorly designed such that they will ACK I2C reads and return\n+\t * whatever bogus data is in the SRAM (or whatever is backing the target\n+\t * device) before things are truly initialized.\n+\t *\n+\t * In a perfect world devices would NAK I2C requests until they were\n+\t * sane, but here we are.\n+\t *\n+\t * Give such devices a couple tries to get their act together before\n+\t * marking the device as unsupported.\n+\t */\n+\tfor (id_reads = 0; id_reads < 5; id_reads++) {\n+\t\tstatus = hw->phy.ops.read_i2c_eeprom(hw,\n+\t\t\t\t\t\t IXGBE_SFF_IDENTIFIER,\n+\t\t\t\t\t\t &identifier);\n \n-\tif (status != IXGBE_SUCCESS)\n+\t\tDEBUGOUT(\"status %d, id %d\\n\", status, identifier);\n+\t\tif (!status &&\n+\t\t identifier == IXGBE_SFF_IDENTIFIER_SFP)\n+\t\t\tbreak;\n+\t}\n+\n+\tif (status != IXGBE_SUCCESS) {\n+\t\tDEBUGOUT(\"Failed SFF ID read (%d attempts)\\n\", id_reads);\n \t\tgoto err_read_i2c_eeprom;\n+\t}\n \n \tif (identifier != IXGBE_SFF_IDENTIFIER_SFP) {\n \t\thw->phy.type = ixgbe_phy_sfp_unsupported;\n", "prefixes": [ "v2", "6/7" ] }